| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:fc1b4aee-897b-e11f-23c2-4f34734c924f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8328:31B434:13D4F10:19E1B71:6B0006C0 |
| html-safe-nonce | 70c2cc12ca364e441270ee8acb73c0563e025646fef73d96e66ccfe355d837be |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MzI4OjMxQjQzNDoxM0Q0RjEwOjE5RTFCNzE6NkIwMDA2QzAiLCJ2aXNpdG9yX2lkIjoiODQxNjQ5MjMxNjc1NTIzMjQ0OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | c9fd6e9a8fe5c3b4db3f17d9f6645b7d78380c6c02634989dfaf3040c5f4eaee |
| hovercard-subject-tag | pull_request:88596087 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/typing/295/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/7f87dc5ab41af9b96847f19a7bac99af414a085073858738fb4ad584772aa8fa/python/typing/pull/295 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/7f87dc5ab41af9b96847f19a7bac99af414a085073858738fb4ad584772aa8fa/python/typing/pull/295 |
| og:image:alt | @gvanrossum
This PR actually fixes #250
The main idea here is optimizing generics for cases where a type information is added to existing code.
Now:
Node[int] and Node have identical __bases__ and... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ilevkivskyi |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/typing git https://github.com/python/typing.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 24604008 |
| octolytics-dimension-repository_nwo | python/typing |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24604008 |
| octolytics-dimension-repository_network_root_nwo | python/typing |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 16a11879678aaf97e2a42c33ee70830aa084fa37 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/typing/pull/295#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftyping%2Fpull%2F295 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftyping%2Fpull%2F295 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Ftyping |
| Reload | https://github.com/python/typing/pull/295 |
| Reload | https://github.com/python/typing/pull/295 |
| Reload | https://github.com/python/typing/pull/295 |
| python | https://github.com/python |
| typing | https://github.com/python/typing |
| Code | https://github.com/python/typing |
| Issues206 (206) | https://github.com/python/typing/issues |
| Pull requests27 (27) | https://github.com/python/typing/pulls |
| Discussions | https://github.com/python/typing/discussions |
| Actions | https://github.com/python/typing/actions |
| Security and quality | https://github.com/python/typing/security |
| Insights | https://github.com/python/typing/insights |
| https://github.com/python/typing |
| gvanrossum | https://github.com/gvanrossum |
| python:master | https://github.com/python/typing/tree/master |
| ilevkivskyi:master | https://github.com/ilevkivskyi/typehinting/tree/master |
| Conversation | https://github.com/python/typing/pull/295 |
| Commits6 (6) | https://github.com/python/typing/pull/295/commits |
| Checks | https://github.com/python/typing/pull/295/checks |
| Files changed | https://github.com/python/typing/pull/295/files |
| A real fix for issue #250 (failure with mock) | https://github.com/python/typing/pull/295#top |
| gvanrossum | https://github.com/gvanrossum |
| python:master | https://github.com/python/typing/tree/master |
| ilevkivskyi:master | https://github.com/ilevkivskyi/typehinting/tree/master |
|
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Oct 9, 2016 | https://github.com/python/typing/pull/295#issue-181914307 |
| @gvanrossum | https://github.com/gvanrossum |
| #250 | https://github.com/python/typing/issues/250 |
| Please reload this page | https://github.com/python/typing/pull/295 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| October 9, 2016 23:20 | https://github.com/python/typing/pull/295#commits-pushed-b07b8ea |
|
| https://github.com/ilevkivskyi |
| A real fix for | https://github.com/python/typing/pull/295/commits/b07b8eab3429a802f44ea7ebf09f614c6efc9642 |
| python#250 | https://github.com/python/typing/issues/250 |
| b07b8ea | https://github.com/python/typing/pull/295/commits/b07b8eab3429a802f44ea7ebf09f614c6efc9642 |
|
| https://github.com/ilevkivskyi |
| Use _gorg for the case of multiply parameterized generics | https://github.com/python/typing/pull/295/commits/eb7801bb3d96643ffa0f943cb6f685795eb27946 |
| eb7801b | https://github.com/python/typing/pull/295/commits/eb7801bb3d96643ffa0f943cb6f685795eb27946 |
|
| https://github.com/ilevkivskyi |
| Formatting | https://github.com/python/typing/pull/295/commits/be5d7ed51aebe7ad5e65f985ffe835c868a7611c |
| be5d7ed | https://github.com/python/typing/pull/295/commits/be5d7ed51aebe7ad5e65f985ffe835c868a7611c |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
|
Oct 10, 2016
| https://github.com/python/typing/pull/295#pullrequestreview-3525020 |
|
View reviewed changes
| https://github.com/python/typing/pull/295/files/be5d7ed51aebe7ad5e65f985ffe835c868a7611c |
| gvanrossum | https://github.com/gvanrossum |
| https://github.com/python/typing/pull/295#pullrequestreview-3525020 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/typing/pull/295 |
| python2/typing.py | https://github.com/python/typing/pull/295/files/be5d7ed51aebe7ad5e65f985ffe835c868a7611c#diff-cbea31cd6366bdaf7805202979325ba4b14a29613bb7aeaecf9a18e94ea93619 |
| gvanrossum | https://github.com/gvanrossum |
| Oct 10, 2016 | https://github.com/python/typing/pull/295#discussion_r82630943 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/typing/pull/295 |
| https://github.com/markshannon |
| markshannon | https://github.com/markshannon |
| Oct 10, 2016 | https://github.com/python/typing/pull/295#issuecomment-252668864 |
| Please reload this page | https://github.com/python/typing/pull/295 |
|
| https://github.com/ilevkivskyi |
| Response to comments + some tests | https://github.com/python/typing/pull/295/commits/63482faf6775d68f6de073a3a2d7e506949e809e |
| 63482fa | https://github.com/python/typing/pull/295/commits/63482faf6775d68f6de073a3a2d7e506949e809e |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Oct 10, 2016 | https://github.com/python/typing/pull/295#issuecomment-252762838 |
| Please reload this page | https://github.com/python/typing/pull/295 |
| @gvanrossum | https://github.com/gvanrossum |
| Please reload this page | https://github.com/python/typing/pull/295 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
| Oct 10, 2016 | https://github.com/python/typing/pull/295#issuecomment-252770761 |
| #250 | https://github.com/python/typing/issues/250 |
| Please reload this page | https://github.com/python/typing/pull/295 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Oct 11, 2016 | https://github.com/python/typing/pull/295#issuecomment-252843617 |
| @gvanrossum | https://github.com/gvanrossum |
| #250 | https://github.com/python/typing/issues/250 |
| #289 | https://github.com/python/typing/pull/289 |
| #250 | https://github.com/python/typing/issues/250 |
| #250 | https://github.com/python/typing/issues/250 |
| #289 | https://github.com/python/typing/pull/289 |
| Please reload this page | https://github.com/python/typing/pull/295 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
|
Oct 11, 2016
| https://github.com/python/typing/pull/295#ref-pullrequest-181980139 |
|
Alternative (simpler) repr for generics
#296
| https://github.com/python/typing/pull/296 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
| Oct 11, 2016 | https://github.com/python/typing/pull/295#issuecomment-252978298 |
| Please reload this page | https://github.com/python/typing/pull/295 |
| #250 | https://github.com/python/typing/issues/250 |
| Please reload this page | https://github.com/python/typing/pull/295 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
|
Oct 12, 2016
| https://github.com/python/typing/pull/295#ref-issue-182582839 |
|
isinstance + class indirectly deriving from SupportsInt results in "TypeError: Protocols cannot be used with isinstance()"
#297
| https://github.com/python/typing/issues/297 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
|
Oct 14, 2016
| https://github.com/python/typing/pull/295#pullrequestreview-4356800 |
|
View reviewed changes
| https://github.com/python/typing/pull/295/files/63482faf6775d68f6de073a3a2d7e506949e809e |
| gvanrossum | https://github.com/gvanrossum |
| https://github.com/python/typing/pull/295#pullrequestreview-4356800 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/typing/pull/295 |
| src/typing.py | https://github.com/python/typing/pull/295/files/63482faf6775d68f6de073a3a2d7e506949e809e#diff-ad6da8dfad5c336100410e57073641a0266b69e1801476d2b1e593b2c04f81f5 |
| gvanrossum | https://github.com/gvanrossum |
| Oct 14, 2016 | https://github.com/python/typing/pull/295#discussion_r83514358 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/typing/pull/295 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Oct 16, 2016 | https://github.com/python/typing/pull/295#discussion_r83554181 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/typing/pull/295 |
| src/test_typing.py | https://github.com/python/typing/pull/295/files/63482faf6775d68f6de073a3a2d7e506949e809e#diff-e618ee6a4894a62d9269e41c4dc836e31e8224cfb66b5be3b325f4798ec245e3 |
| gvanrossum | https://github.com/gvanrossum |
| Oct 14, 2016 | https://github.com/python/typing/pull/295#discussion_r83515174 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/typing/pull/295 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Oct 16, 2016 | https://github.com/python/typing/pull/295#discussion_r83554183 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/typing/pull/295 |
| src/test_typing.py | https://github.com/python/typing/pull/295/files/63482faf6775d68f6de073a3a2d7e506949e809e#diff-e618ee6a4894a62d9269e41c4dc836e31e8224cfb66b5be3b325f4798ec245e3 |
| gvanrossum | https://github.com/gvanrossum |
| Oct 14, 2016 | https://github.com/python/typing/pull/295#discussion_r83515461 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/typing/pull/295 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Oct 16, 2016 | https://github.com/python/typing/pull/295#discussion_r83554287 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/typing/pull/295 |
|
| https://github.com/ilevkivskyi |
| Add tests illustrating new dunder attributes; preserve initial class … | https://github.com/python/typing/pull/295/commits/307bf649e54a72842f59dfa6b3b62aa49c28450d |
| 307bf64 | https://github.com/python/typing/pull/295/commits/307bf649e54a72842f59dfa6b3b62aa49c28450d |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Oct 16, 2016 | https://github.com/python/typing/pull/295#issuecomment-254056340 |
| @gvanrossum | https://github.com/gvanrossum |
| Please reload this page | https://github.com/python/typing/pull/295 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
|
Oct 20, 2016
| https://github.com/python/typing/pull/295#pullrequestreview-5173899 |
|
View reviewed changes
| https://github.com/python/typing/pull/295/files/307bf649e54a72842f59dfa6b3b62aa49c28450d |
| gvanrossum | https://github.com/gvanrossum |
| https://github.com/python/typing/pull/295#pullrequestreview-5173899 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/typing/pull/295 |
| python2/test_typing.py | https://github.com/python/typing/pull/295/files/63482faf6775d68f6de073a3a2d7e506949e809e..307bf649e54a72842f59dfa6b3b62aa49c28450d#diff-f23c53e6fa002cdeac74b9499d744b9492bfd34a58ce281c2b5076e628d0083a |
| gvanrossum | https://github.com/gvanrossum |
| Oct 20, 2016 | https://github.com/python/typing/pull/295#discussion_r84391857 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/typing/pull/295 |
| src/typing.py | https://github.com/python/typing/pull/295/files/63482faf6775d68f6de073a3a2d7e506949e809e..307bf649e54a72842f59dfa6b3b62aa49c28450d#diff-ad6da8dfad5c336100410e57073641a0266b69e1801476d2b1e593b2c04f81f5 |
| gvanrossum | https://github.com/gvanrossum |
| Oct 20, 2016 | https://github.com/python/typing/pull/295#discussion_r84392668 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/typing/pull/295 |
|
| https://github.com/ilevkivskyi |
| Response to comments | https://github.com/python/typing/pull/295/commits/f4932bb33887448615bcb27098341b74786b0b4d |
| f4932bb | https://github.com/python/typing/pull/295/commits/f4932bb33887448615bcb27098341b74786b0b4d |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Oct 20, 2016 | https://github.com/python/typing/pull/295#issuecomment-255253731 |
| @gvanrossum | https://github.com/gvanrossum |
| Please reload this page | https://github.com/python/typing/pull/295 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
| a38bdac | https://github.com/python/typing/commit/a38bdac6e474ce61fc2f410b588c441dad1f6ddb |
| Oct 21, 2016 | https://github.com/python/typing/pull/295#event-831506929 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
| Oct 21, 2016 | https://github.com/python/typing/pull/295#issuecomment-255281981 |
| Please reload this page | https://github.com/python/typing/pull/295 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
| Oct 21, 2016 | https://github.com/python/typing/pull/295#issuecomment-255282047 |
| Please reload this page | https://github.com/python/typing/pull/295 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Oct 21, 2016 | https://github.com/python/typing/pull/295#issuecomment-255485070 |
| @gvanrossum | https://github.com/gvanrossum |
| #298 | https://github.com/python/typing/issues/298 |
| #299 | https://github.com/python/typing/issues/299 |
| #301 | https://github.com/python/typing/issues/301 |
| Please reload this page | https://github.com/python/typing/pull/295 |
| https://github.com/gvanrossum |
| gvanrossum | https://github.com/gvanrossum |
| Oct 25, 2016 | https://github.com/python/typing/pull/295#issuecomment-256122947 |
| Please reload this page | https://github.com/python/typing/pull/295 |
| https://github.co/hiddenchars |
| https://github.com/python/typing/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftyping%2Fpull%2F295 |
|
| https://github.com/gvanrossum |
|
gvanrossum
| https://github.com/gvanrossum |
|
| https://github.com/python/typing/pull/295/files/307bf649e54a72842f59dfa6b3b62aa49c28450d |
| Please reload this page | https://github.com/python/typing/pull/295 |
|
Inheriting from instantiated generic class causes mocking to fail
| https://github.com/python/typing/issues/250 |
| Please reload this page | https://github.com/python/typing/pull/295 |
|
| https://github.com/ilevkivskyi |
|
| https://github.com/markshannon |
|
| https://github.com/gvanrossum |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |