| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:ae42c188-6206-624b-1537-cbb25d2525d6 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C0B0:A0638:123D150:171A870:6AFF93DC |
| html-safe-nonce | 0e5dba2c7a99f1bfb3c350d768d520c63c7270ae62e012b73e618df36f42fa13 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMEIwOkEwNjM4OjEyM0QxNTA6MTcxQTg3MDo2QUZGOTNEQyIsInZpc2l0b3JfaWQiOiI1ODg4NzgxODMyNTg0OTI2MTcyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 54bf6c8d050f4b88f8aa070a9289f17744b689eafaffd2a185212b994822f2d8 |
| hovercard-subject-tag | pull_request:4941519721 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/typing/pull/2373/files |
| twitter:image | https://avatars.githubusercontent.com/u/906600?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/906600?s=400&v=4 |
| og:image:alt | And remove the test case in the ClassVar file; it's redundant as qualifiers_final_annotation
already tests it in a more isolated way.
Fixes #2371. |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 2c75d045e8c84b51e2ac680086a6dd1eeaf2bc15b82137d22ee5106835d6256c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/typing git https://github.com/python/typing.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 24604008 |
| octolytics-dimension-repository_nwo | python/typing |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24604008 |
| octolytics-dimension-repository_network_root_nwo | python/typing |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | aa486b0389431f870c0adf9d4758aaff807c2d97 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/typing/pull/2373/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftyping%2Fpull%2F2373%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftyping%2Fpull%2F2373%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Ftyping |
| Reload | https://github.com/python/typing/pull/2373/files |
| Reload | https://github.com/python/typing/pull/2373/files |
| Reload | https://github.com/python/typing/pull/2373/files |
| python | https://github.com/python |
| typing | https://github.com/python/typing |
| Code | https://github.com/python/typing |
| Issues206 (206) | https://github.com/python/typing/issues |
| Pull requests27 (27) | https://github.com/python/typing/pulls |
| Discussions | https://github.com/python/typing/discussions |
| Actions | https://github.com/python/typing/actions |
| Security and quality | https://github.com/python/typing/security |
| Insights | https://github.com/python/typing/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Ftyping%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Ftyping%2Fissues%2Fnew%2Fchoose |
| JelleZijlstra | https://github.com/JelleZijlstra |
| python:main | https://github.com/python/typing/tree/main |
| JelleZijlstra:classvar-final | https://github.com/JelleZijlstra/typing/tree/classvar-final |
|
Conversation
7
| https://github.com/python/typing/pull/2373 |
|
Commits
3
| https://github.com/python/typing/pull/2373/commits |
|
Checks
3
| https://github.com/python/typing/pull/2373/checks |
|
Files changed
14
| https://github.com/python/typing/pull/2373/files |
|
conformance: do not require error for Final + ClassVar
| https://github.com/python/typing/pull/2373/files#top |
|
Show all changes
3 commits
| https://github.com/python/typing/pull/2373/files |
|
ae7fbdf
conformance: do not require error for Final + ClassVar
JelleZijlstra Oct 20, 2026
| https://github.com/python/typing/pull/2373/commits/ae7fbdfa60ae28c142b6a8a2669d966a41b22f02 |
|
6d3595a
feedback
JelleZijlstra Oct 20, 2026
| https://github.com/python/typing/pull/2373/commits/6d3595a2793d6b1782825d965e918fe45a6744e8 |
|
bc8250a
regen
JelleZijlstra Oct 20, 2026
| https://github.com/python/typing/pull/2373/commits/bc8250ad3f09eff695e01609ecaae178e95f51b5 |
|
Clear filters
| https://github.com/python/typing/pull/2373/files |
| Please reload this page | https://github.com/python/typing/pull/2373/files |
| Please reload this page | https://github.com/python/typing/pull/2373/files |
|
classes_classvar.toml
| https://github.com/python/typing/pull/2373/files#diff-8313fe61299bfaf601a330afa9df1d5b8f359e35bd77cd80252538f9887b50d9 |
|
qualifiers_final_annotation.toml
| https://github.com/python/typing/pull/2373/files#diff-3e3a446434b9675cf920233ec1006bbe87da57dd61fbf24028bb166e908a52b0 |
|
classes_classvar.toml
| https://github.com/python/typing/pull/2373/files#diff-47a2fd8c61b2f137f2197e6aa058305b5934871000a813fd92161bb656abe800 |
|
qualifiers_final_annotation.toml
| https://github.com/python/typing/pull/2373/files#diff-81c5d20592ab9fb0b9e333e4bb28aa2a1a839e33a91432021988bb8f371b8207 |
|
classes_classvar.toml
| https://github.com/python/typing/pull/2373/files#diff-412479af467aaf8cb0a04702e59cfa9e177b217575668b077625dd446a17ff5e |
|
qualifiers_final_annotation.toml
| https://github.com/python/typing/pull/2373/files#diff-1da1a7b00d6fd5aedb4b683870999735942232d636e7d78a26e3830c1affafdc |
|
classes_classvar.toml
| https://github.com/python/typing/pull/2373/files#diff-992f4b54b7760d35414d1dfd75fc717b764f9a82378d580eb458b4933d3a2b7f |
|
qualifiers_final_annotation.toml
| https://github.com/python/typing/pull/2373/files#diff-a472ef3847b332ccbbde49334f3badab9156dad74aa4f3f4193481afb298fc6d |
|
classes_classvar.toml
| https://github.com/python/typing/pull/2373/files#diff-782000ef7a2cd727320587ccfd715ec968b695397a6aa4e36c523cdbda74d014 |
|
qualifiers_final_annotation.toml
| https://github.com/python/typing/pull/2373/files#diff-67847d42e3183722270f248099a3684c17e599781084595f3a024156d2d79ac9 |
|
classes_classvar.toml
| https://github.com/python/typing/pull/2373/files#diff-5f32585229071c69b4d1e9730ce12583cc1c2f1281edb21c9e85dba67095b3f5 |
|
qualifiers_final_annotation.toml
| https://github.com/python/typing/pull/2373/files#diff-299e369ba0864a87462f8cd78d38fa7ae3b14beba8b6d4eb04b49b62494ffa8a |
|
classes_classvar.py
| https://github.com/python/typing/pull/2373/files#diff-141f5bd9a2e129736b9c064b24f7cf398ee96d79292ee8e75aae1bed9ba184d0 |
|
qualifiers_final_annotation.py
| https://github.com/python/typing/pull/2373/files#diff-7890c25bd5fec9cfecd619efabd6a81245f5ffbbe03b964aa456f2b81a28aa63 |
| conformance/results/mypy/classes_classvar.toml | https://github.com/python/typing/pull/2373/files#diff-8313fe61299bfaf601a330afa9df1d5b8f359e35bd77cd80252538f9887b50d9 |
|
View file
| https://github.com/python/typing/blob/bc8250ad3f09eff695e01609ecaae178e95f51b5/conformance/results/mypy/classes_classvar.toml |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/typing/pull/2373/{{ revealButtonHref }} |
|
| https://github.com/python/typing/pull/2373/files#diff-8313fe61299bfaf601a330afa9df1d5b8f359e35bd77cd80252538f9887b50d9 |
| conformance/results/mypy/qualifiers_final_annotation.toml | https://github.com/python/typing/pull/2373/files#diff-3e3a446434b9675cf920233ec1006bbe87da57dd61fbf24028bb166e908a52b0 |
|
View file
| https://github.com/python/typing/blob/bc8250ad3f09eff695e01609ecaae178e95f51b5/conformance/results/mypy/qualifiers_final_annotation.toml |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/typing/pull/2373/{{ revealButtonHref }} |
|
| https://github.com/python/typing/pull/2373/files#diff-3e3a446434b9675cf920233ec1006bbe87da57dd61fbf24028bb166e908a52b0 |
| conformance/results/pycroscope/classes_classvar.toml | https://github.com/python/typing/pull/2373/files#diff-47a2fd8c61b2f137f2197e6aa058305b5934871000a813fd92161bb656abe800 |
|
View file
| https://github.com/python/typing/blob/bc8250ad3f09eff695e01609ecaae178e95f51b5/conformance/results/pycroscope/classes_classvar.toml |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/typing/pull/2373/{{ revealButtonHref }} |
|
| https://github.com/python/typing/pull/2373/files#diff-47a2fd8c61b2f137f2197e6aa058305b5934871000a813fd92161bb656abe800 |
| conformance/results/pycroscope/qualifiers_final_annotation.toml | https://github.com/python/typing/pull/2373/files#diff-81c5d20592ab9fb0b9e333e4bb28aa2a1a839e33a91432021988bb8f371b8207 |
|
View file
| https://github.com/python/typing/blob/bc8250ad3f09eff695e01609ecaae178e95f51b5/conformance/results/pycroscope/qualifiers_final_annotation.toml |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/typing/pull/2373/{{ revealButtonHref }} |
|
| https://github.com/python/typing/pull/2373/files#diff-81c5d20592ab9fb0b9e333e4bb28aa2a1a839e33a91432021988bb8f371b8207 |
| Please reload this page | https://github.com/python/typing/pull/2373/files |
| Please reload this page | https://github.com/python/typing/pull/2373/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |