René's URL Explorer Experiment


Title: conformance: do not require error for Final + ClassVar by JelleZijlstra · Pull Request #2373 · python/typing · GitHub

Open Graph Title: conformance: do not require error for Final + ClassVar by JelleZijlstra · Pull Request #2373 · python/typing

X Title: conformance: do not require error for Final + ClassVar by JelleZijlstra · Pull Request #2373 · python/typing

Description: And remove the test case in the ClassVar file; it's redundant as qualifiers_final_annotation already tests it in a more isolated way. Fixes #2371.

Open Graph Description: And remove the test case in the ClassVar file; it's redundant as qualifiers_final_annotation already tests it in a more isolated way. Fixes #2371.

X Description: And remove the test case in the ClassVar file; it's redundant as qualifiers_final_annotation already tests it in a more isolated way. Fixes #2371.

Opengraph URL: https://github.com/python/typing/pull/2373

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ae42c188-6206-624b-1537-cbb25d2525d6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC0B0:A0638:123D150:171A870:6AFF93DC
html-safe-nonce0e5dba2c7a99f1bfb3c350d768d520c63c7270ae62e012b73e618df36f42fa13
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMEIwOkEwNjM4OjEyM0QxNTA6MTcxQTg3MDo2QUZGOTNEQyIsInZpc2l0b3JfaWQiOiI1ODg4NzgxODMyNTg0OTI2MTcyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac54bf6c8d050f4b88f8aa070a9289f17744b689eafaffd2a185212b994822f2d8
hovercard-subject-tagpull_request:4941519721
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/typing/pull/2373/files
twitter:imagehttps://avatars.githubusercontent.com/u/906600?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/906600?s=400&v=4
og:image:altAnd remove the test case in the ClassVar file; it's redundant as qualifiers_final_annotation already tests it in a more isolated way. Fixes #2371.
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None2c75d045e8c84b51e2ac680086a6dd1eeaf2bc15b82137d22ee5106835d6256c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/typing git https://github.com/python/typing.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id24604008
octolytics-dimension-repository_nwopython/typing
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24604008
octolytics-dimension-repository_network_root_nwopython/typing
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseaa486b0389431f870c0adf9d4758aaff807c2d97
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/typing/pull/2373/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftyping%2Fpull%2F2373%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftyping%2Fpull%2F2373%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Ftyping
Reloadhttps://github.com/python/typing/pull/2373/files
Reloadhttps://github.com/python/typing/pull/2373/files
Reloadhttps://github.com/python/typing/pull/2373/files
pythonhttps://github.com/python
typinghttps://github.com/python/typing
Codehttps://github.com/python/typing
Issues206 (206)https://github.com/python/typing/issues
Pull requests27 (27)https://github.com/python/typing/pulls
Discussionshttps://github.com/python/typing/discussions
Actionshttps://github.com/python/typing/actions
Security and qualityhttps://github.com/python/typing/security
Insightshttps://github.com/python/typing/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Ftyping%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Ftyping%2Fissues%2Fnew%2Fchoose
JelleZijlstrahttps://github.com/JelleZijlstra
python:mainhttps://github.com/python/typing/tree/main
JelleZijlstra:classvar-finalhttps://github.com/JelleZijlstra/typing/tree/classvar-final
Conversation 7 https://github.com/python/typing/pull/2373
Commits 3 https://github.com/python/typing/pull/2373/commits
Checks 3 https://github.com/python/typing/pull/2373/checks
Files changed 14 https://github.com/python/typing/pull/2373/files
conformance: do not require error for Final + ClassVar https://github.com/python/typing/pull/2373/files#top
Show all changes 3 commits https://github.com/python/typing/pull/2373/files
ae7fbdf conformance: do not require error for Final + ClassVar JelleZijlstra Oct 20, 2026 https://github.com/python/typing/pull/2373/commits/ae7fbdfa60ae28c142b6a8a2669d966a41b22f02
6d3595a feedback JelleZijlstra Oct 20, 2026 https://github.com/python/typing/pull/2373/commits/6d3595a2793d6b1782825d965e918fe45a6744e8
bc8250a regen JelleZijlstra Oct 20, 2026 https://github.com/python/typing/pull/2373/commits/bc8250ad3f09eff695e01609ecaae178e95f51b5
Clear filters https://github.com/python/typing/pull/2373/files
Please reload this pagehttps://github.com/python/typing/pull/2373/files
Please reload this pagehttps://github.com/python/typing/pull/2373/files
classes_classvar.toml https://github.com/python/typing/pull/2373/files#diff-8313fe61299bfaf601a330afa9df1d5b8f359e35bd77cd80252538f9887b50d9
qualifiers_final_annotation.toml https://github.com/python/typing/pull/2373/files#diff-3e3a446434b9675cf920233ec1006bbe87da57dd61fbf24028bb166e908a52b0
classes_classvar.toml https://github.com/python/typing/pull/2373/files#diff-47a2fd8c61b2f137f2197e6aa058305b5934871000a813fd92161bb656abe800
qualifiers_final_annotation.toml https://github.com/python/typing/pull/2373/files#diff-81c5d20592ab9fb0b9e333e4bb28aa2a1a839e33a91432021988bb8f371b8207
classes_classvar.toml https://github.com/python/typing/pull/2373/files#diff-412479af467aaf8cb0a04702e59cfa9e177b217575668b077625dd446a17ff5e
qualifiers_final_annotation.toml https://github.com/python/typing/pull/2373/files#diff-1da1a7b00d6fd5aedb4b683870999735942232d636e7d78a26e3830c1affafdc
classes_classvar.toml https://github.com/python/typing/pull/2373/files#diff-992f4b54b7760d35414d1dfd75fc717b764f9a82378d580eb458b4933d3a2b7f
qualifiers_final_annotation.toml https://github.com/python/typing/pull/2373/files#diff-a472ef3847b332ccbbde49334f3badab9156dad74aa4f3f4193481afb298fc6d
classes_classvar.toml https://github.com/python/typing/pull/2373/files#diff-782000ef7a2cd727320587ccfd715ec968b695397a6aa4e36c523cdbda74d014
qualifiers_final_annotation.toml https://github.com/python/typing/pull/2373/files#diff-67847d42e3183722270f248099a3684c17e599781084595f3a024156d2d79ac9
classes_classvar.toml https://github.com/python/typing/pull/2373/files#diff-5f32585229071c69b4d1e9730ce12583cc1c2f1281edb21c9e85dba67095b3f5
qualifiers_final_annotation.toml https://github.com/python/typing/pull/2373/files#diff-299e369ba0864a87462f8cd78d38fa7ae3b14beba8b6d4eb04b49b62494ffa8a
classes_classvar.py https://github.com/python/typing/pull/2373/files#diff-141f5bd9a2e129736b9c064b24f7cf398ee96d79292ee8e75aae1bed9ba184d0
qualifiers_final_annotation.py https://github.com/python/typing/pull/2373/files#diff-7890c25bd5fec9cfecd619efabd6a81245f5ffbbe03b964aa456f2b81a28aa63
conformance/results/mypy/classes_classvar.tomlhttps://github.com/python/typing/pull/2373/files#diff-8313fe61299bfaf601a330afa9df1d5b8f359e35bd77cd80252538f9887b50d9
View file https://github.com/python/typing/blob/bc8250ad3f09eff695e01609ecaae178e95f51b5/conformance/results/mypy/classes_classvar.toml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typing/pull/2373/{{ revealButtonHref }}
https://github.com/python/typing/pull/2373/files#diff-8313fe61299bfaf601a330afa9df1d5b8f359e35bd77cd80252538f9887b50d9
conformance/results/mypy/qualifiers_final_annotation.tomlhttps://github.com/python/typing/pull/2373/files#diff-3e3a446434b9675cf920233ec1006bbe87da57dd61fbf24028bb166e908a52b0
View file https://github.com/python/typing/blob/bc8250ad3f09eff695e01609ecaae178e95f51b5/conformance/results/mypy/qualifiers_final_annotation.toml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typing/pull/2373/{{ revealButtonHref }}
https://github.com/python/typing/pull/2373/files#diff-3e3a446434b9675cf920233ec1006bbe87da57dd61fbf24028bb166e908a52b0
conformance/results/pycroscope/classes_classvar.tomlhttps://github.com/python/typing/pull/2373/files#diff-47a2fd8c61b2f137f2197e6aa058305b5934871000a813fd92161bb656abe800
View file https://github.com/python/typing/blob/bc8250ad3f09eff695e01609ecaae178e95f51b5/conformance/results/pycroscope/classes_classvar.toml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typing/pull/2373/{{ revealButtonHref }}
https://github.com/python/typing/pull/2373/files#diff-47a2fd8c61b2f137f2197e6aa058305b5934871000a813fd92161bb656abe800
conformance/results/pycroscope/qualifiers_final_annotation.tomlhttps://github.com/python/typing/pull/2373/files#diff-81c5d20592ab9fb0b9e333e4bb28aa2a1a839e33a91432021988bb8f371b8207
View file https://github.com/python/typing/blob/bc8250ad3f09eff695e01609ecaae178e95f51b5/conformance/results/pycroscope/qualifiers_final_annotation.toml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typing/pull/2373/{{ revealButtonHref }}
https://github.com/python/typing/pull/2373/files#diff-81c5d20592ab9fb0b9e333e4bb28aa2a1a839e33a91432021988bb8f371b8207
Please reload this pagehttps://github.com/python/typing/pull/2373/files
Please reload this pagehttps://github.com/python/typing/pull/2373/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.