| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:c64bc189-61ab-74f2-f41d-e6443dce8630 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C5B8:3E1195:1D76FC:25A3D5:6AFF9382 |
| html-safe-nonce | 2728b50ef0429c460ae04b18b6ada7a147ae5f1d383b054b18834c09da13446a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNUI4OjNFMTE5NToxRDc2RkM6MjVBM0Q1OjZBRkY5MzgyIiwidmlzaXRvcl9pZCI6Ijc2NDcyNzM4OTYwNjM3Njc0MjciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | edeb6a4636a7e92a88ff0167d5af4e7442201428fae19819f4884de6109cd85d |
| hovercard-subject-tag | pull_request:3779138939 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/typing/pull/2299/files |
| twitter:image | https://avatars.githubusercontent.com/u/3095771?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/3095771?s=400&v=4 |
| og:image:alt | Closes #2259.
dataclasses_descriptors.py keeps coverage for the non-data descriptor (Desc2, only __get__) used as a dataclass field, but aligns the expected behavior with runtime descriptor lookup:... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 2c75d045e8c84b51e2ac680086a6dd1eeaf2bc15b82137d22ee5106835d6256c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/typing git https://github.com/python/typing.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 24604008 |
| octolytics-dimension-repository_nwo | python/typing |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24604008 |
| octolytics-dimension-repository_network_root_nwo | python/typing |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | aa486b0389431f870c0adf9d4758aaff807c2d97 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/typing/pull/2299/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftyping%2Fpull%2F2299%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftyping%2Fpull%2F2299%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Ftyping |
| Reload | https://github.com/python/typing/pull/2299/files |
| Reload | https://github.com/python/typing/pull/2299/files |
| Reload | https://github.com/python/typing/pull/2299/files |
| python | https://github.com/python |
| typing | https://github.com/python/typing |
| Code | https://github.com/python/typing |
| Issues206 (206) | https://github.com/python/typing/issues |
| Pull requests27 (27) | https://github.com/python/typing/pulls |
| Discussions | https://github.com/python/typing/discussions |
| Actions | https://github.com/python/typing/actions |
| Security and quality | https://github.com/python/typing/security |
| Insights | https://github.com/python/typing/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Ftyping%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Ftyping%2Fissues%2Fnew%2Fchoose |
| ashishpatel26 | https://github.com/ashishpatel26 |
| python:main | https://github.com/python/typing/tree/main |
| ashishpatel26:conformance-dataclass-descriptor-2259 | https://github.com/ashishpatel26/typing/tree/conformance-dataclass-descriptor-2259 |
|
Conversation
14
| https://github.com/python/typing/pull/2299 |
|
Commits
4
| https://github.com/python/typing/pull/2299/commits |
|
Checks
3
| https://github.com/python/typing/pull/2299/checks |
|
Files changed
| https://github.com/python/typing/pull/2299/files |
| Please reload this page | https://github.com/python/typing/pull/2299/files |
|
Conformance: align dataclass descriptor tests with runtime
| https://github.com/python/typing/pull/2299/files#top |
|
Show all changes
4 commits
| https://github.com/python/typing/pull/2299/files |
|
ce4ec15
Conformance: align dataclass descriptor tests with runtime
ashishpatel26 Jun 1, 2026
| https://github.com/python/typing/pull/2299/commits/ce4ec155e75b4a40f6619be3ebb36010a17f42ef |
|
dea18ca
Fix Windows path separators in pycroscope TOML results
ashishpatel26 Jun 22, 2026
| https://github.com/python/typing/pull/2299/commits/dea18cae652bfc68a24d184a04509eec4ed5a28b |
|
436ccfd
Merge upstream/main: resolve TOML notes conflicts, regenerate results…
ashishpatel26 Jun 22, 2026
| https://github.com/python/typing/pull/2299/commits/436ccfd19009cacac2dd0d82fd02b7936685081b |
|
e439275
conformance: fix pyrefly dataclasses_descriptors TOML with missing er…
ashishpatel26 Jun 22, 2026
| https://github.com/python/typing/pull/2299/commits/e4392758459b6e8d3e9181afeaf34a8252a12cf5 |
|
Clear filters
| https://github.com/python/typing/pull/2299/files |
| Please reload this page | https://github.com/python/typing/pull/2299/files |
| Please reload this page | https://github.com/python/typing/pull/2299/files |
|
dataclasses_descriptors.toml
| https://github.com/python/typing/pull/2299/files#diff-1a6e6cd1fb4604108f94df00851180cda7f477a85794baf1e8655dee7dd25dee |
|
dataclasses_descriptors.toml
| https://github.com/python/typing/pull/2299/files#diff-f2dec672c4764628e0b252644be77dc570464de6d9bd043668c5fd95d91ce369 |
|
dataclasses_descriptors.toml
| https://github.com/python/typing/pull/2299/files#diff-a53794c16754144be18cc0f78dc801b097b3786784aa7cc6733db63d8948549e |
|
dataclasses_descriptors.toml
| https://github.com/python/typing/pull/2299/files#diff-c990334e3316a9464b1bd1f68590cda8388a4b9b1bd7ee33e3a8bde59f3cc2e9 |
|
results.html
| https://github.com/python/typing/pull/2299/files#diff-1026e9a5ffcc2a9a0af3bc5b250ce31a9562dc874f49390536bb28e2e129c381 |
|
dataclasses_descriptors.toml
| https://github.com/python/typing/pull/2299/files#diff-4fbcea01baf406de3506aaa2c7a9aee3b0037c8b9dcc99520925d59a872848cf |
|
dataclasses_descriptors.toml
| https://github.com/python/typing/pull/2299/files#diff-57fe6e824ae0e0785417da73cff6f5c74b3386657451879da88ee611b952dcd4 |
|
dataclasses_descriptors.py
| https://github.com/python/typing/pull/2299/files#diff-4389a11c3db67967f4049da6f8e69c782e9b554977795139f978c8fffaf997fe |
| conformance/results/mypy/dataclasses_descriptors.toml | https://github.com/python/typing/pull/2299/files#diff-1a6e6cd1fb4604108f94df00851180cda7f477a85794baf1e8655dee7dd25dee |
|
View file
| https://github.com/python/typing/blob/e4392758459b6e8d3e9181afeaf34a8252a12cf5/conformance/results/mypy/dataclasses_descriptors.toml |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/typing/pull/2299/{{ revealButtonHref }} |
| conformance/results/pycroscope/dataclasses_descriptors.toml | https://github.com/python/typing/pull/2299/files#diff-f2dec672c4764628e0b252644be77dc570464de6d9bd043668c5fd95d91ce369 |
|
View file
| https://github.com/python/typing/blob/e4392758459b6e8d3e9181afeaf34a8252a12cf5/conformance/results/pycroscope/dataclasses_descriptors.toml |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/typing/pull/2299/{{ revealButtonHref }} |
| conformance/results/pyrefly/dataclasses_descriptors.toml | https://github.com/python/typing/pull/2299/files#diff-a53794c16754144be18cc0f78dc801b097b3786784aa7cc6733db63d8948549e |
|
View file
| https://github.com/python/typing/blob/e4392758459b6e8d3e9181afeaf34a8252a12cf5/conformance/results/pyrefly/dataclasses_descriptors.toml |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/typing/pull/2299/{{ revealButtonHref }} |
| conformance/results/pyright/dataclasses_descriptors.toml | https://github.com/python/typing/pull/2299/files#diff-c990334e3316a9464b1bd1f68590cda8388a4b9b1bd7ee33e3a8bde59f3cc2e9 |
|
View file
| https://github.com/python/typing/blob/e4392758459b6e8d3e9181afeaf34a8252a12cf5/conformance/results/pyright/dataclasses_descriptors.toml |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/typing/pull/2299/{{ revealButtonHref }} |
| conformance/results/results.html | https://github.com/python/typing/pull/2299/files#diff-1026e9a5ffcc2a9a0af3bc5b250ce31a9562dc874f49390536bb28e2e129c381 |
|
View file
| https://github.com/python/typing/blob/e4392758459b6e8d3e9181afeaf34a8252a12cf5/conformance/results/results.html |
|
Open in desktop
| https://desktop.github.com |
| how customized files appear on GitHub | https://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github |
| Please reload this page | https://github.com/python/typing/pull/2299/files |
| conformance/results/ty/dataclasses_descriptors.toml | https://github.com/python/typing/pull/2299/files#diff-4fbcea01baf406de3506aaa2c7a9aee3b0037c8b9dcc99520925d59a872848cf |
|
View file
| https://github.com/python/typing/blob/e4392758459b6e8d3e9181afeaf34a8252a12cf5/conformance/results/ty/dataclasses_descriptors.toml |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/typing/pull/2299/{{ revealButtonHref }} |
| conformance/results/zuban/dataclasses_descriptors.toml | https://github.com/python/typing/pull/2299/files#diff-57fe6e824ae0e0785417da73cff6f5c74b3386657451879da88ee611b952dcd4 |
|
View file
| https://github.com/python/typing/blob/e4392758459b6e8d3e9181afeaf34a8252a12cf5/conformance/results/zuban/dataclasses_descriptors.toml |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/typing/pull/2299/{{ revealButtonHref }} |
| conformance/tests/dataclasses_descriptors.py | https://github.com/python/typing/pull/2299/files#diff-4389a11c3db67967f4049da6f8e69c782e9b554977795139f978c8fffaf997fe |
|
View file
| https://github.com/python/typing/blob/e4392758459b6e8d3e9181afeaf34a8252a12cf5/conformance/tests/dataclasses_descriptors.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/typing/pull/2299/{{ revealButtonHref }} |
|
| https://github.com/python/typing/pull/2299/files#diff-4389a11c3db67967f4049da6f8e69c782e9b554977795139f978c8fffaf997fe |
|
| https://github.com/python/typing/pull/2299/files#diff-4389a11c3db67967f4049da6f8e69c782e9b554977795139f978c8fffaf997fe |
|
| https://github.com/python/typing/pull/2299/files#diff-4389a11c3db67967f4049da6f8e69c782e9b554977795139f978c8fffaf997fe |
|
| https://github.com/python/typing/pull/2299/files#diff-4389a11c3db67967f4049da6f8e69c782e9b554977795139f978c8fffaf997fe |
| JelleZijlstra | https://github.com/JelleZijlstra |
| Jun 23, 2026 | https://github.com/python/typing/pull/2299/files#r3456692217 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/typing/pull/2299/files |
| davidhalter | https://github.com/davidhalter |
| Jun 23, 2026 | https://github.com/python/typing/pull/2299/files#r3457822752 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/typing/pull/2299/files |
| carljm | https://github.com/carljm |
| Jun 24, 2026 | https://github.com/python/typing/pull/2299/files#r3463801506 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/typing/pull/2299/files |
| carljm | https://github.com/carljm |
| Jun 24, 2026 | https://github.com/python/typing/pull/2299/files#r3463861300 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/typing/pull/2299/files |
| JelleZijlstra | https://github.com/JelleZijlstra |
| Jun 24, 2026 | https://github.com/python/typing/pull/2299/files#r3464180474 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/typing/pull/2299/files |
| davidhalter | https://github.com/davidhalter |
| Jun 24, 2026 | https://github.com/python/typing/pull/2299/files#r3465607566 |
| Please reload this page | https://github.com/python/typing/pull/2299/files |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/typing/pull/2299/files |
| rchen152 | https://github.com/rchen152 |
| Aug 7, 2026 | https://github.com/python/typing/pull/2299/files#r3734169234 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/typing/pull/2299/files |
| carljm | https://github.com/carljm |
| Jun 24, 2026 | https://github.com/python/typing/pull/2299/files#r3463891408 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/typing/pull/2299/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |