| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:fca4ad53-8dea-9deb-6197-3e9045353fe1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DF76:8FAC9:10E621:163AED:6AFF7F14 |
| html-safe-nonce | 576d20e805371ebf98a707448ef73807cad199be8755de96b68713923865278b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERjc2OjhGQUM5OjEwRTYyMToxNjNBRUQ6NkFGRjdGMTQiLCJ2aXNpdG9yX2lkIjoiMzE2ODcwMTI0OTI4NTQ4ODQwNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 2160b9a8ed68eb1e9e4c286b17dd84f0fa53cf8ff40d29b467c20bcf1e0fdff2 |
| hovercard-subject-tag | pull_request:3779138939 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/typing/2299/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/17ae88f50dd189dbbd9a74e5b9084c70d3c9d602cb4697c41ff839d8abb38fd3/python/typing/pull/2299 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/17ae88f50dd189dbbd9a74e5b9084c70d3c9d602cb4697c41ff839d8abb38fd3/python/typing/pull/2299 |
| og:image:alt | Closes #2259.
dataclasses_descriptors.py keeps coverage for the non-data descriptor (Desc2, only __get__) used as a dataclass field, but aligns the expected behavior with runtime descriptor lookup:... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ashishpatel26 |
| hostname | github.com |
| expected-hostname | github.com |
| None | b5a2047dbbde77e0ba2f8dfd78621e8a7313a105f7437ca693fcccd16cd137ee |
| turbo-cache-control | no-cache |
| go-import | github.com/python/typing git https://github.com/python/typing.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 24604008 |
| octolytics-dimension-repository_nwo | python/typing |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24604008 |
| octolytics-dimension-repository_network_root_nwo | python/typing |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 83e3dfa4de364d61589204ed35e53b2b7f77fba2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/typing/pull/2299#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftyping%2Fpull%2F2299 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftyping%2Fpull%2F2299 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Ftyping |
| Reload | https://github.com/python/typing/pull/2299 |
| Reload | https://github.com/python/typing/pull/2299 |
| Reload | https://github.com/python/typing/pull/2299 |
| python | https://github.com/python |
| typing | https://github.com/python/typing |
| Code | https://github.com/python/typing |
| Issues206 (206) | https://github.com/python/typing/issues |
| Pull requests27 (27) | https://github.com/python/typing/pulls |
| Discussions | https://github.com/python/typing/discussions |
| Actions | https://github.com/python/typing/actions |
| Security and quality | https://github.com/python/typing/security |
| Insights | https://github.com/python/typing/insights |
| https://github.com/python/typing |
| ashishpatel26 | https://github.com/ashishpatel26 |
| python:main | https://github.com/python/typing/tree/main |
| ashishpatel26:conformance-dataclass-descriptor-2259 | https://github.com/ashishpatel26/typing/tree/conformance-dataclass-descriptor-2259 |
| Conversation | https://github.com/python/typing/pull/2299 |
| Commits4 (4) | https://github.com/python/typing/pull/2299/commits |
| Checks | https://github.com/python/typing/pull/2299/checks |
| Files changed | https://github.com/python/typing/pull/2299/files |
| Conformance: align dataclass descriptor tests with runtime | https://github.com/python/typing/pull/2299#top |
| ashishpatel26 | https://github.com/ashishpatel26 |
| python:main | https://github.com/python/typing/tree/main |
| ashishpatel26:conformance-dataclass-descriptor-2259 | https://github.com/ashishpatel26/typing/tree/conformance-dataclass-descriptor-2259 |
|
| https://github.com/ashishpatel26 |
| ashishpatel26 | https://github.com/ashishpatel26 |
| Jun 1, 2026 | https://github.com/python/typing/pull/2299#issue-4560997032 |
| Please reload this page | https://github.com/python/typing/pull/2299 |
| #2259 | https://github.com/python/typing/issues/2259 |
| Please reload this page | https://github.com/python/typing/pull/2299 |
| https://github.com/davidhalter |
| davidhalter | https://github.com/davidhalter |
| Jun 1, 2026 | https://github.com/python/typing/pull/2299#issuecomment-4590336818 |
| Please reload this page | https://github.com/python/typing/pull/2299 |
| Please reload this page | https://github.com/python/typing/pull/2299 |
| https://github.com/JelleZijlstra |
| JelleZijlstra | https://github.com/JelleZijlstra |
| Jun 1, 2026 | https://github.com/python/typing/pull/2299#issuecomment-4592881772 |
| Please reload this page | https://github.com/python/typing/pull/2299 |
| https://github.com/davidhalter |
| davidhalter | https://github.com/davidhalter |
| Jun 1, 2026 | https://github.com/python/typing/pull/2299#issuecomment-4593691061 |
| Please reload this page | https://github.com/python/typing/pull/2299 |
| Please reload this page | https://github.com/python/typing/pull/2299 |
| https://github.com/ashishpatel26 |
| ashishpatel26 | https://github.com/ashishpatel26 |
| force-pushed | https://github.com/python/typing/compare/c6b7cd926f05dec6aee5db55903c7c7e7d04b267..d49e4a1ba43c6a84f98f1de4e9fdba391591d104 |
| c6b7cd9 | https://github.com/python/typing/commit/c6b7cd926f05dec6aee5db55903c7c7e7d04b267 |
| d49e4a1 | https://github.com/python/typing/commit/d49e4a1ba43c6a84f98f1de4e9fdba391591d104 |
|
Compare
| https://github.com/python/typing/compare/c6b7cd926f05dec6aee5db55903c7c7e7d04b267..d49e4a1ba43c6a84f98f1de4e9fdba391591d104 |
| June 5, 2026 07:06 | https://github.com/python/typing/pull/2299#event-26373198303 |
| https://github.com/ashishpatel26 |
| ashishpatel26 | https://github.com/ashishpatel26 |
| Jun 5, 2026 | https://github.com/python/typing/pull/2299#issuecomment-4629056659 |
| Please reload this page | https://github.com/python/typing/pull/2299 |
| https://github.com/ashishpatel26 |
| ashishpatel26 | https://github.com/ashishpatel26 |
| Jun 5, 2026 | https://github.com/python/typing/pull/2299#event-26373253670 |
| ashishpatel26 | https://github.com/ashishpatel26 |
| June 22, 2026 16:12 | https://github.com/python/typing/pull/2299#commits-pushed-ce4ec15 |
|
| https://github.com/ashishpatel26 |
| Conformance: align dataclass descriptor tests with runtime | https://github.com/python/typing/pull/2299/commits/ce4ec155e75b4a40f6619be3ebb36010a17f42ef |
| ce4ec15 | https://github.com/python/typing/pull/2299/commits/ce4ec155e75b4a40f6619be3ebb36010a17f42ef |
|
| https://github.com/ashishpatel26 |
| Fix Windows path separators in pycroscope TOML results | https://github.com/python/typing/pull/2299/commits/dea18cae652bfc68a24d184a04509eec4ed5a28b |
| dea18ca | https://github.com/python/typing/pull/2299/commits/dea18cae652bfc68a24d184a04509eec4ed5a28b |
| https://github.com/ashishpatel26 |
| ashishpatel26 | https://github.com/ashishpatel26 |
| force-pushed | https://github.com/python/typing/compare/4c6b2f9d86fd1211b0c0a16de52956adab19764d..dea18cae652bfc68a24d184a04509eec4ed5a28b |
| 4c6b2f9 | https://github.com/python/typing/commit/4c6b2f9d86fd1211b0c0a16de52956adab19764d |
| dea18ca | https://github.com/python/typing/commit/dea18cae652bfc68a24d184a04509eec4ed5a28b |
|
Compare
| https://github.com/python/typing/compare/4c6b2f9d86fd1211b0c0a16de52956adab19764d..dea18cae652bfc68a24d184a04509eec4ed5a28b |
| June 22, 2026 10:43 | https://github.com/python/typing/pull/2299#event-27036589523 |
| https://github.com/srittau |
| srittau | https://github.com/srittau |
|
topic: conformance tests
| https://github.com/python/typing/issues?q=state%3Aopen%20label%3A%22topic%3A%20conformance%20tests%22 |
| Jun 22, 2026 | https://github.com/python/typing/pull/2299#event-27040292745 |
| ashishpatel26 | https://github.com/ashishpatel26 |
| June 22, 2026 19:50 | https://github.com/python/typing/pull/2299#commits-pushed-436ccfd |
|
| https://github.com/ashishpatel26 |
| Merge upstream/main: resolve TOML notes conflicts, regenerate results… | https://github.com/python/typing/pull/2299/commits/436ccfd19009cacac2dd0d82fd02b7936685081b |
| 436ccfd | https://github.com/python/typing/pull/2299/commits/436ccfd19009cacac2dd0d82fd02b7936685081b |
|
| https://github.com/ashishpatel26 |
| conformance: fix pyrefly dataclasses_descriptors TOML with missing er… | https://github.com/python/typing/pull/2299/commits/e4392758459b6e8d3e9181afeaf34a8252a12cf5 |
| e439275 | https://github.com/python/typing/pull/2299/commits/e4392758459b6e8d3e9181afeaf34a8252a12cf5 |
| https://github.com/JelleZijlstra |
| JelleZijlstra | https://github.com/JelleZijlstra |
|
Jun 23, 2026
| https://github.com/python/typing/pull/2299#pullrequestreview-4549610361 |
|
View reviewed changes
| https://github.com/python/typing/pull/2299/files/e4392758459b6e8d3e9181afeaf34a8252a12cf5 |
| conformance/tests/dataclasses_descriptors.py | https://github.com/python/typing/pull/2299/files/e4392758459b6e8d3e9181afeaf34a8252a12cf5#diff-4389a11c3db67967f4049da6f8e69c782e9b554977795139f978c8fffaf997fe |
| JelleZijlstra | https://github.com/JelleZijlstra |
| Jun 23, 2026 | https://github.com/python/typing/pull/2299#discussion_r3456692217 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/typing/pull/2299 |
| davidhalter | https://github.com/davidhalter |
| Jun 23, 2026 | https://github.com/python/typing/pull/2299#discussion_r3457822752 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/typing/pull/2299 |
| carljm | https://github.com/carljm |
| Jun 24, 2026 | https://github.com/python/typing/pull/2299#discussion_r3463801506 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/typing/pull/2299 |
| carljm | https://github.com/carljm |
| Jun 24, 2026 | https://github.com/python/typing/pull/2299#discussion_r3463861300 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/typing/pull/2299 |
| JelleZijlstra | https://github.com/JelleZijlstra |
| Jun 24, 2026 | https://github.com/python/typing/pull/2299#discussion_r3464180474 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/typing/pull/2299 |
| davidhalter | https://github.com/davidhalter |
| Jun 24, 2026 | https://github.com/python/typing/pull/2299#discussion_r3465607566 |
| Please reload this page | https://github.com/python/typing/pull/2299 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/typing/pull/2299 |
| rchen152 | https://github.com/rchen152 |
| Aug 7, 2026 | https://github.com/python/typing/pull/2299#discussion_r3734169234 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/typing/pull/2299 |
| https://github.com/JelleZijlstra |
| JelleZijlstra | https://github.com/JelleZijlstra |
| Jun 23, 2026 | https://github.com/python/typing/pull/2299#issuecomment-4775182635 |
| Please reload this page | https://github.com/python/typing/pull/2299 |
| https://github.com/davidhalter |
| davidhalter | https://github.com/davidhalter |
|
Jun 23, 2026
| https://github.com/python/typing/pull/2299#pullrequestreview-4550957387 |
|
View reviewed changes
| https://github.com/python/typing/pull/2299/files/e4392758459b6e8d3e9181afeaf34a8252a12cf5 |
| davidhalter | https://github.com/davidhalter |
| https://github.com/python/typing/pull/2299#pullrequestreview-4550957387 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/typing/pull/2299 |
| conformance/tests/dataclasses_descriptors.py | https://github.com/python/typing/pull/2299/files/e4392758459b6e8d3e9181afeaf34a8252a12cf5#diff-4389a11c3db67967f4049da6f8e69c782e9b554977795139f978c8fffaf997fe |
| davidhalter | https://github.com/davidhalter |
| Jun 23, 2026 | https://github.com/python/typing/pull/2299#discussion_r3457822752 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/typing/pull/2299 |
| https://github.com/carljm |
| carljm | https://github.com/carljm |
|
Jun 24, 2026
| https://github.com/python/typing/pull/2299#pullrequestreview-4558249120 |
|
View reviewed changes
| https://github.com/python/typing/pull/2299/files/e4392758459b6e8d3e9181afeaf34a8252a12cf5 |
| conformance/tests/dataclasses_descriptors.py | https://github.com/python/typing/pull/2299/files/e4392758459b6e8d3e9181afeaf34a8252a12cf5#diff-4389a11c3db67967f4049da6f8e69c782e9b554977795139f978c8fffaf997fe |
| carljm | https://github.com/carljm |
| Jun 24, 2026 | https://github.com/python/typing/pull/2299#discussion_r3463891408 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/typing/pull/2299 |
|
Conformance: remove non-data-descriptor tests in dataclasses_descriptors.py
#2319
| https://github.com/python/typing/pull/2319 |
|
Remove questionable dataclass descriptor conformance assertions
#2296
| https://github.com/python/typing/pull/2296 |
| https://github.com/yangdanny97 |
| yangdanny97 | https://github.com/yangdanny97 |
|
Aug 5, 2026
| https://github.com/python/typing/pull/2299#ref-issue-3801820968 |
|
Dataclass descriptors + conformance test problems
pyrefly-org/pyrefly#2065
| https://github.com/pyrefly-org/pyrefly/issues/2065 |
| https://github.com/rchen152 |
| rchen152 | https://github.com/rchen152 |
|
Nov 13, 2026
| https://github.com/python/typing/pull/2299#ref-pullrequest-6369780737 |
|
conformance: delete questionable portions of dataclasses_descriptors test
#2388
| https://github.com/python/typing/pull/2388 |
| https://github.co/hiddenchars |
| https://github.com/python/typing/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftyping%2Fpull%2F2299 |
|
| https://github.com/carljm |
|
carljm
| https://github.com/carljm |
|
| https://github.com/python/typing/pull/2299/files/e4392758459b6e8d3e9181afeaf34a8252a12cf5 |
|
| https://github.com/davidhalter |
|
davidhalter
| https://github.com/davidhalter |
|
| https://github.com/python/typing/pull/2299/files/e4392758459b6e8d3e9181afeaf34a8252a12cf5 |
|
| https://github.com/JelleZijlstra |
|
JelleZijlstra
| https://github.com/JelleZijlstra |
|
| https://github.com/python/typing/pull/2299/files/e4392758459b6e8d3e9181afeaf34a8252a12cf5 |
|
| https://github.com/rchen152 |
|
rchen152
| https://github.com/rchen152 |
|
| https://github.com/python/typing/pull/2299/files/e4392758459b6e8d3e9181afeaf34a8252a12cf5 |
| Please reload this page | https://github.com/python/typing/pull/2299 |
|
topic: conformance tests
| https://github.com/python/typing/issues?q=state%3Aopen%20label%3A%22topic%3A%20conformance%20tests%22 |
|
Conformance suite: Questionable tests in dataclasses_descriptors.py
| https://github.com/python/typing/issues/2259 |
| Please reload this page | https://github.com/python/typing/pull/2299 |
|
| https://github.com/ashishpatel26 |
|
| https://github.com/davidhalter |
|
| https://github.com/JelleZijlstra |
|
| https://github.com/carljm |
|
| https://github.com/rchen152 |
|
| https://github.com/srittau |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |