Title: Fix generics inheritance and drop __subclasscheck__ by bintoro · Pull Request #207 · python/typing · GitHub
Open Graph Title: Fix generics inheritance and drop __subclasscheck__ by bintoro · Pull Request #207 · python/typing
X Title: Fix generics inheritance and drop __subclasscheck__ by bintoro · Pull Request #207 · python/typing
Description: I don't expect this to be reviewed anytime soon, but the effort is now fairly complete, so might as well put it out there for comments. Resolves #136 Resolves #202 Resolves #203 At the heart of #136 is a conflation between type compatibility and subtype relationships. Even though Sequence[Manager] is compatible with Sequence[Employee], it's not a subclass of it. Rather, both derive from Sequence[+T_co]. To address this, the PR introduces a new helper is_compatible(), which implements the "is consistent with or a subtype of" relation. In short, it does what issubclass() has been doing until now. The practical end result is that issubclass() is no longer applicable to the special types Any, Union, etc. is_compatible() always works — if neither argument is a special type, is_compatible(T1, T2) reduces to issubclass(T1, T2) issubclass() acquires its normal semantics w.r.t. generics: >>> issubclass(Sequence[Manager], Sequence[Employee]) False >>> issubclass(Sequence[Manager], Sequence) True whereas: >>> is_compatible(Sequence[Manager], Sequence[Employee]) True Commit summary There are three commits: The first simply stops the __extra__ linkage from leaking down to generics' subclasses. This fixes the bug where issubclass(dict, CustomMapping) == True. [Diff] The second adds the __extra__ ABCs as actual base classes of their typing twins. It also refactors GenericMeta.__subclasscheck__ into a compatibility check and a __subclasshook__ dedicated to handling the __extra__ connection. [Diff] This achieves a few things: User-defined generics become recognized as subclasses of the associated collections ABCs. Abstract and mixin methods from collections.abc become available. issubclass(list, Iterable[X]) no longer returns true for arbitrary X (#136). The final commit is largely a mechanical change: the special types are made to raise a TypeError in response to issubclass(). Every type metaclass gets a method named __is_compatible__ to host the prior __subclasscheck__ logic. [Diff] Notes Full parity is preserved in using unparameterized types in place of the corresponding collections.abc classes in isinstance() and issubclass() calls: issubclass(type, typing.Callable) == issubclass(type, collections.Callable) == True issubclass(list, typing.Iterable) == issubclass(list, collections.Iterable) == True ... The intent has been not to mess with the types' behavior. That said, the introduction of is_compatible() yields a couple of automatic improvements regarding Any: The relation evaluates to true when either argument is Any; previously issubclass(Any, C) would return false for some arbitrary class C but true for a typing type. is_compatible(Iterable[Any], Iterable[int]) correctly returns true. The merging of #205 caused a huge conflict in the tests. I will look into it eventually if there's interest in merging this. The proposal is compatible with the plan to convert some of the collection types to protocols, if that's still on the table.
Open Graph Description: I don't expect this to be reviewed anytime soon, but the effort is now fairly complete, so might as well put it out there for comments. Resolves #136 Resolves #202 Resolves #203 At the heart of...
X Description: I don't expect this to be reviewed anytime soon, but the effort is now fairly complete, so might as well put it out there for comments. Resolves #136 Resolves #202 Resolves #203 At the hear...
Opengraph URL: https://github.com/python/typing/pull/207
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:23e6d670-0969-7006-6359-30b0ec781844 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 885E:2148FB:2031085:2BAE476:6B001C08 |
| html-safe-nonce | 51d75fbdf7c2dc5c2486a05298e74b8bc5fc3e8c89d86fd8c948963fba3c57b5 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4ODVFOjIxNDhGQjoyMDMxMDg1OjJCQUU0NzY6NkIwMDFDMDgiLCJ2aXNpdG9yX2lkIjoiOTExMDY3MzQ5Njk2MjI0MzU5MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | e26b62059c93d387ee8c2d5060920ce37972e070e38273d5df3cd059e07322eb |
| hovercard-subject-tag | pull_request:67126579 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/typing/pull/207/files |
| twitter:image | https://avatars.githubusercontent.com/u/7081785?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/7081785?s=400&v=4 |
| og:image:alt | I don't expect this to be reviewed anytime soon, but the effort is now fairly complete, so might as well put it out there for comments. Resolves #136 Resolves #202 Resolves #203 At the heart of... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/typing git https://github.com/python/typing.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 24604008 |
| octolytics-dimension-repository_nwo | python/typing |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24604008 |
| octolytics-dimension-repository_network_root_nwo | python/typing |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 44c658b24abf00491fb7ae5f56d42c9f38cbeab2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width