René's URL Explorer Experiment


Title: Fix generics inheritance and drop __subclasscheck__ by bintoro · Pull Request #207 · python/typing · GitHub

Open Graph Title: Fix generics inheritance and drop __subclasscheck__ by bintoro · Pull Request #207 · python/typing

X Title: Fix generics inheritance and drop __subclasscheck__ by bintoro · Pull Request #207 · python/typing

Description: I don't expect this to be reviewed anytime soon, but the effort is now fairly complete, so might as well put it out there for comments. Resolves #136 Resolves #202 Resolves #203 At the heart of #136 is a conflation between type compatibility and subtype relationships. Even though Sequence[Manager] is compatible with Sequence[Employee], it's not a subclass of it. Rather, both derive from Sequence[+T_co]. To address this, the PR introduces a new helper is_compatible(), which implements the "is consistent with or a subtype of" relation. In short, it does what issubclass() has been doing until now. The practical end result is that issubclass() is no longer applicable to the special types Any, Union, etc. is_compatible() always works — if neither argument is a special type, is_compatible(T1, T2) reduces to issubclass(T1, T2) issubclass() acquires its normal semantics w.r.t. generics: >>> issubclass(Sequence[Manager], Sequence[Employee]) False >>> issubclass(Sequence[Manager], Sequence) True whereas: >>> is_compatible(Sequence[Manager], Sequence[Employee]) True Commit summary There are three commits: The first simply stops the __extra__ linkage from leaking down to generics' subclasses. This fixes the bug where issubclass(dict, CustomMapping) == True. [Diff] The second adds the __extra__ ABCs as actual base classes of their typing twins. It also refactors GenericMeta.__subclasscheck__ into a compatibility check and a __subclasshook__ dedicated to handling the __extra__ connection. [Diff] This achieves a few things: User-defined generics become recognized as subclasses of the associated collections ABCs. Abstract and mixin methods from collections.abc become available. issubclass(list, Iterable[X]) no longer returns true for arbitrary X (#136). The final commit is largely a mechanical change: the special types are made to raise a TypeError in response to issubclass(). Every type metaclass gets a method named __is_compatible__ to host the prior __subclasscheck__ logic. [Diff] Notes Full parity is preserved in using unparameterized types in place of the corresponding collections.abc classes in isinstance() and issubclass() calls: issubclass(type, typing.Callable) == issubclass(type, collections.Callable) == True issubclass(list, typing.Iterable) == issubclass(list, collections.Iterable) == True ... The intent has been not to mess with the types' behavior. That said, the introduction of is_compatible() yields a couple of automatic improvements regarding Any: The relation evaluates to true when either argument is Any; previously issubclass(Any, C) would return false for some arbitrary class C but true for a typing type. is_compatible(Iterable[Any], Iterable[int]) correctly returns true. The merging of #205 caused a huge conflict in the tests. I will look into it eventually if there's interest in merging this. The proposal is compatible with the plan to convert some of the collection types to protocols, if that's still on the table.

Open Graph Description: I don't expect this to be reviewed anytime soon, but the effort is now fairly complete, so might as well put it out there for comments. Resolves #136 Resolves #202 Resolves #203 At the heart of...

X Description: I don't expect this to be reviewed anytime soon, but the effort is now fairly complete, so might as well put it out there for comments. Resolves #136 Resolves #202 Resolves #203 At the hear...

Opengraph URL: https://github.com/python/typing/pull/207

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:23e6d670-0969-7006-6359-30b0ec781844
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id885E:2148FB:2031085:2BAE476:6B001C08
html-safe-nonce51d75fbdf7c2dc5c2486a05298e74b8bc5fc3e8c89d86fd8c948963fba3c57b5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4ODVFOjIxNDhGQjoyMDMxMDg1OjJCQUU0NzY6NkIwMDFDMDgiLCJ2aXNpdG9yX2lkIjoiOTExMDY3MzQ5Njk2MjI0MzU5MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmace26b62059c93d387ee8c2d5060920ce37972e070e38273d5df3cd059e07322eb
hovercard-subject-tagpull_request:67126579
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/typing/pull/207/files
twitter:imagehttps://avatars.githubusercontent.com/u/7081785?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/7081785?s=400&v=4
og:image:altI don't expect this to be reviewed anytime soon, but the effort is now fairly complete, so might as well put it out there for comments. Resolves #136 Resolves #202 Resolves #203 At the heart of...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/typing git https://github.com/python/typing.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id24604008
octolytics-dimension-repository_nwopython/typing
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24604008
octolytics-dimension-repository_network_root_nwopython/typing
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release44c658b24abf00491fb7ae5f56d42c9f38cbeab2
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/typing/pull/207/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftyping%2Fpull%2F207%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftyping%2Fpull%2F207%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Ftyping
Reloadhttps://github.com/python/typing/pull/207/files
Reloadhttps://github.com/python/typing/pull/207/files
Reloadhttps://github.com/python/typing/pull/207/files
pythonhttps://github.com/python
typinghttps://github.com/python/typing
Codehttps://github.com/python/typing
Issues206 (206)https://github.com/python/typing/issues
Pull requests27 (27)https://github.com/python/typing/pulls
Discussionshttps://github.com/python/typing/discussions
Actionshttps://github.com/python/typing/actions
Security and qualityhttps://github.com/python/typing/security
Insightshttps://github.com/python/typing/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Ftyping%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Ftyping%2Fissues%2Fnew%2Fchoose
bintorohttps://github.com/bintoro
python:masterhttps://github.com/python/typing/tree/master
bintoro:extra-as-basehttps://github.com/bintoro/typing/tree/extra-as-base
Conversation 3 https://github.com/python/typing/pull/207
Commits 3 https://github.com/python/typing/pull/207/commits
Checks 0 https://github.com/python/typing/pull/207/checks
Files changed https://github.com/python/typing/pull/207/files
Please reload this pagehttps://github.com/python/typing/pull/207/files
Fix generics inheritance and drop __subclasscheck__ https://github.com/python/typing/pull/207/files#top
Show all changes 3 commits https://github.com/python/typing/pull/207/files
2ef2a50 Prevent generic subclasses from inheriting __extra__ bintoro Apr 15, 2016 https://github.com/python/typing/pull/207/commits/2ef2a504304636ee7939c8b23c2f822e0331fabe
0ec4dd2 Insert extras as bases, remove GenericMeta.__subclasscheck__ bintoro Apr 17, 2016 https://github.com/python/typing/pull/207/commits/0ec4dd2e1d3fef533a59a08cb8a0212ff4877c99
fd4a1b0 Drop issubclass() support from special types bintoro Apr 19, 2016 https://github.com/python/typing/pull/207/commits/fd4a1b0790dcabc18d3e3c94e81ee3774ac0d9b5
Clear filters https://github.com/python/typing/pull/207/files
Please reload this pagehttps://github.com/python/typing/pull/207/files
Please reload this pagehttps://github.com/python/typing/pull/207/files
test_typing.py https://github.com/python/typing/pull/207/files#diff-e618ee6a4894a62d9269e41c4dc836e31e8224cfb66b5be3b325f4798ec245e3
typing.py https://github.com/python/typing/pull/207/files#diff-ad6da8dfad5c336100410e57073641a0266b69e1801476d2b1e593b2c04f81f5
Please reload this pagehttps://github.com/python/typing/pull/207/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.