| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:5bd22503-606d-74f1-c81b-55d404cabb80 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B774:385F9F:E2782C:1390436:696A90DD |
| html-safe-nonce | bf17b493a0490ecc7c96bfe5e379badd7fd773c421ec757319b1437d39ef324d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNzc0OjM4NUY5RjpFMjc4MkM6MTM5MDQzNjo2OTZBOTBERCIsInZpc2l0b3JfaWQiOiIyODI2ODQyNzgxODcyOTg0Mjg1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | d15b33733de34f2e33af75e5d96c0642802029854dd60e3b29d72998f15f88e8 |
| hovercard-subject-tag | pull_request:2308308038 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/typing/1916/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/965e3ab553ab09e892a4cf8bf9fc955890c836af69206320aaa8ae343f574fc2/python/typing/pull/1916 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/965e3ab553ab09e892a4cf8bf9fc955890c836af69206320aaa8ae343f574fc2/python/typing/pull/1916 |
| og:image:alt | The language of the typing spec indicates that the @final decorator may be used with properties:
The method decorator version may be used with all of instance methods, class methods, static method... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | samwgoldman |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4dd496afc954da9c207b2d9fbe86e3074619f565754aa1d9274aec30d9e5b8d7 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/typing git https://github.com/python/typing.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 24604008 |
| octolytics-dimension-repository_nwo | python/typing |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24604008 |
| octolytics-dimension-repository_network_root_nwo | python/typing |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 31496a13b80a2f6ad77d6c617ee2255a3545b539 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/typing/pull/1916#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftyping%2Fpull%2F1916 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftyping%2Fpull%2F1916 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Ftyping |
| Reload | https://github.com/python/typing/pull/1916 |
| Reload | https://github.com/python/typing/pull/1916 |
| Reload | https://github.com/python/typing/pull/1916 |
|
python
| https://github.com/python |
| typing | https://github.com/python/typing |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Ftyping |
|
Fork
283
| https://github.com/login?return_to=%2Fpython%2Ftyping |
|
Star
1.7k
| https://github.com/login?return_to=%2Fpython%2Ftyping |
|
Code
| https://github.com/python/typing |
|
Issues
187
| https://github.com/python/typing/issues |
|
Pull requests
12
| https://github.com/python/typing/pulls |
|
Discussions
| https://github.com/python/typing/discussions |
|
Actions
| https://github.com/python/typing/actions |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/typing/security |
| Please reload this page | https://github.com/python/typing/pull/1916 |
|
Insights
| https://github.com/python/typing/pulse |
|
Code
| https://github.com/python/typing |
|
Issues
| https://github.com/python/typing/issues |
|
Pull requests
| https://github.com/python/typing/pulls |
|
Discussions
| https://github.com/python/typing/discussions |
|
Actions
| https://github.com/python/typing/actions |
|
Security
| https://github.com/python/typing/security |
|
Insights
| https://github.com/python/typing/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Ftyping%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Ftyping%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/python/typing/pull/1916#issue-comment-box |
| samwgoldman | https://github.com/samwgoldman |
| python:main | https://github.com/python/typing/tree/main |
| samwgoldman:final-property | https://github.com/samwgoldman/python-typing/tree/final-property |
|
Add conformance test for @final combined with @property
| https://github.com/python/typing/pull/1916#top |
| samwgoldman | https://github.com/samwgoldman |
| python:main | https://github.com/python/typing/tree/main |
| samwgoldman:final-property | https://github.com/samwgoldman/python-typing/tree/final-property |
|
Conversation
10
| https://github.com/python/typing/pull/1916 |
|
Commits
3
| https://github.com/python/typing/pull/1916/commits |
|
Checks
2
| https://github.com/python/typing/pull/1916/checks |
|
Files changed
| https://github.com/python/typing/pull/1916/files |
| Please reload this page | https://github.com/python/typing/pull/1916 |
| https://github.co/hiddenchars |
| https://github.com/python/typing/pull/{{ revealButtonHref }} |
|
| https://github.com/samwgoldman |
| samwgoldman | https://github.com/samwgoldman |
| Jan 31, 2025 | https://github.com/python/typing/pull/1916#issue-2822481868 |
| https://discuss.python.org/t/proposal-allow-chaining-final-decorator-when-previous-decorators-return-a-non-function/78918 | https://discuss.python.org/t/proposal-allow-chaining-final-decorator-when-previous-decorators-return-a-non-function/78918 |
| Please reload this page | https://github.com/python/typing/pull/1916 |
| samwgoldman | https://github.com/samwgoldman |
| January 30, 2025 21:15 | https://github.com/python/typing/pull/1916#commits-pushed-52aad76 |
|
| https://github.com/samwgoldman |
| Add conformance test for @final-decorated | https://github.com/python/typing/pull/1916/commits/52aad76a5a606562d28d404ee7c113fc42c390b4 |
| @Property | https://github.com/Property |
| 52aad76 | https://github.com/python/typing/pull/1916/commits/52aad76a5a606562d28d404ee7c113fc42c390b4 |
| @Final | https://github.com/Final |
| https://discuss.python.org/t/proposal-allow-chaining-final-decorator-when-previous-decorators-return-a-non-function/78918 | https://discuss.python.org/t/proposal-allow-chaining-final-decorator-when-previous-decorators-return-a-non-function/78918 |
|
| https://github.com/samwgoldman |
| Add example of | https://github.com/python/typing/pull/1916/commits/06ce4ccf766a20d6bde2618ed644539a04077958 |
| @Final | https://github.com/Final |
| with | https://github.com/python/typing/pull/1916/commits/06ce4ccf766a20d6bde2618ed644539a04077958 |
| @Property | https://github.com/Property |
| to the typing spec | https://github.com/python/typing/pull/1916/commits/06ce4ccf766a20d6bde2618ed644539a04077958 |
| 06ce4cc | https://github.com/python/typing/pull/1916/commits/06ce4ccf766a20d6bde2618ed644539a04077958 |
| @Final | https://github.com/Final |
| @Property | https://github.com/Property |
| https://github.com/ghost |
| ghost | https://github.com/ghost |
| Jan 31, 2025 | https://github.com/python/typing/pull/1916#issuecomment-2626337274 |
| Please reload this page | https://github.com/python/typing/pull/1916 |
| https://cpython-clabot.herokuapp.com/signed-contributor-license-agreement?version=96a49432-b8b1-11ec-9bf5-bfe9ad6c72c4 |
| Please reload this page | https://github.com/python/typing/pull/1916 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
|
Jan 31, 2025
| https://github.com/python/typing/pull/1916#pullrequestreview-2585709229 |
|
View reviewed changes
| https://github.com/python/typing/pull/1916/files/06ce4ccf766a20d6bde2618ed644539a04077958 |
| hauntsaninja | https://github.com/hauntsaninja |
| https://github.com/python/typing/pull/1916#pullrequestreview-2585709229 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/typing/pull/1916 |
| https://github.com/erictraut |
| erictraut | https://github.com/erictraut |
|
Jan 31, 2025
| https://github.com/python/typing/pull/1916#pullrequestreview-2585722743 |
|
View reviewed changes
| https://github.com/python/typing/pull/1916/files |
| conformance/results/pyright/qualifiers_final_decorator.toml | https://github.com/python/typing/pull/1916/files#diff-8d10867583fbd9eafa5cd2ee7c726f0cb2ec3eebcf6752416b5ab541c02afe6a |
| erictraut | https://github.com/erictraut |
| Jan 31, 2025 | https://github.com/python/typing/pull/1916#discussion_r1936716555 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/typing/pull/1916 |
| https://github.com/erictraut |
| erictraut | https://github.com/erictraut |
| Jan 31, 2025 | https://github.com/python/typing/pull/1916#issuecomment-2626365533 |
| microsoft/pyright#9795 | https://github.com/microsoft/pyright/issues/9795 |
| Please reload this page | https://github.com/python/typing/pull/1916 |
|
| https://github.com/samwgoldman |
| Update conformance result for pyright/qualifiers_final_decorator.toml | https://github.com/python/typing/pull/1916/commits/f4d1db668efaf156dee0cd9f13009d4b29838faf |
| f4d1db6 | https://github.com/python/typing/pull/1916/commits/f4d1db668efaf156dee0cd9f13009d4b29838faf |
| https://github.com/samwgoldman |
| samwgoldman | https://github.com/samwgoldman |
| force-pushed | https://github.com/python/typing/compare/aa381ae1e4987b3bbe9fbf1a10611df5b591d1eb..f4d1db668efaf156dee0cd9f13009d4b29838faf |
| aa381ae | https://github.com/python/typing/commit/aa381ae1e4987b3bbe9fbf1a10611df5b591d1eb |
| f4d1db6 | https://github.com/python/typing/commit/f4d1db668efaf156dee0cd9f13009d4b29838faf |
|
Compare
| https://github.com/python/typing/compare/aa381ae1e4987b3bbe9fbf1a10611df5b591d1eb..f4d1db668efaf156dee0cd9f13009d4b29838faf |
| January 31, 2025 06:08 | https://github.com/python/typing/pull/1916#event-16134465353 |
| https://github.com/samwgoldman |
| samwgoldman | https://github.com/samwgoldman |
| Jan 31, 2025 | https://github.com/python/typing/pull/1916#issuecomment-2626384954 |
| Please reload this page | https://github.com/python/typing/pull/1916 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
| Jan 31, 2025 | https://github.com/python/typing/pull/1916#issuecomment-2626635854 |
| Please reload this page | https://github.com/python/typing/pull/1916 |
| https://github.com/JelleZijlstra |
| JelleZijlstra | https://github.com/JelleZijlstra |
|
Jan 31, 2025
| https://github.com/python/typing/pull/1916#pullrequestreview-2587083303 |
|
View reviewed changes
| https://github.com/python/typing/pull/1916/files/f4d1db668efaf156dee0cd9f13009d4b29838faf |
| docs/spec/qualifiers.rst | https://github.com/python/typing/pull/1916/files/f4d1db668efaf156dee0cd9f13009d4b29838faf#diff-d63169ac083634a818bd58f3c0d305cc19ad8200a2a0363d5010e0dc998033ff |
| JelleZijlstra | https://github.com/JelleZijlstra |
| Jan 31, 2025 | https://github.com/python/typing/pull/1916#discussion_r1937491640 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| mypy | https://mypy-play.net/?mypy=latest&python=3.12&gist=b97323c411bc7615c2f3fd2307ee2c21 |
| pyright | https://pyright-play.net/?code=GYJw9gtgBALgngBwJYDsDmUkQWEMrCoCGANgFBkDGJRAzrVAIIBcZU7UAAoSqWx52p1aEAKYwAFmAAm-dtNHACxEgH1CIWjAAU1WgEooAWgB8mFDGZQQ4gK4gUUAIxyorwTXpjJM9zz4cUApK-mq0opRgKNK6JAbGZqiW1nYOUABMrlSeDABC2oz6rIEewt5SsoHByrxqGlqx8abmyTYw9o4AzBQlQl7iFa7VoarhkdGNhs1JVm0dUAAsQA |
| Please reload this page | https://github.com/python/typing/pull/1916 |
| erictraut | https://github.com/erictraut |
| Jan 31, 2025 | https://github.com/python/typing/pull/1916#discussion_r1937625876 |
| Please reload this page | https://github.com/python/typing/pull/1916 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/typing/pull/1916 |
| samwgoldman | https://github.com/samwgoldman |
| Jan 31, 2025 | https://github.com/python/typing/pull/1916#discussion_r1937630859 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/typing/pull/1916 |
| samwgoldman | https://github.com/samwgoldman |
| Jan 31, 2025 | https://github.com/python/typing/pull/1916#discussion_r1937639169 |
| Please reload this page | https://github.com/python/typing/pull/1916 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/typing/pull/1916 |
| https://github.com/erictraut |
| erictraut | https://github.com/erictraut |
|
Feb 4, 2025
| https://github.com/python/typing/pull/1916#ref-issue-2822507544 |
|
False negative: override of @final property
microsoft/pyright#9795
| https://github.com/microsoft/pyright/issues/9795 |
| https://github.com/srittau |
| srittau | https://github.com/srittau |
|
topic: typing spec
| https://github.com/python/typing/issues?q=state%3Aopen%20label%3A%22topic%3A%20typing%20spec%22 |
| Mar 17, 2025 | https://github.com/python/typing/pull/1916#event-16799646013 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftyping%2Fpull%2F1916 |
|
| https://github.com/JelleZijlstra |
|
JelleZijlstra
| https://github.com/JelleZijlstra |
|
| https://github.com/python/typing/pull/1916/files/f4d1db668efaf156dee0cd9f13009d4b29838faf |
|
| https://github.com/erictraut |
|
erictraut
| https://github.com/erictraut |
|
| https://github.com/python/typing/pull/1916/files/f4d1db668efaf156dee0cd9f13009d4b29838faf |
|
| https://github.com/hauntsaninja |
|
hauntsaninja
| https://github.com/hauntsaninja |
|
| https://github.com/python/typing/pull/1916/files/06ce4ccf766a20d6bde2618ed644539a04077958 |
|
topic: typing spec
| https://github.com/python/typing/issues?q=state%3Aopen%20label%3A%22topic%3A%20typing%20spec%22 |
| Please reload this page | https://github.com/python/typing/pull/1916 |
|
| https://github.com/samwgoldman |
|
| https://github.com/erictraut |
|
| https://github.com/hauntsaninja |
|
| https://github.com/JelleZijlstra |
|
| https://github.com/srittau |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |