| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:ceb2f8bd-5a0a-f3f1-7229-48a9daa4964b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BED0:1D5C28:767A15:9ABA82:6AFFCF2D |
| html-safe-nonce | 479df16730c50de8a8817afa1f9d0e9c40e6d56c37f35f92288f48f3f909261b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRUQwOjFENUMyODo3NjdBMTU6OUFCQTgyOjZBRkZDRjJEIiwidmlzaXRvcl9pZCI6IjIxMTUyODAzNjI5NjY4NjM2NjIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | f1a98aec3ab8423720061c115fa35404f1d60f705d82a30c1a659fbf51bf99ab |
| hovercard-subject-tag | pull_request:1877394460 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/typing/pull/1741/files |
| twitter:image | https://avatars.githubusercontent.com/u/61586?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/61586?s=400&v=4 |
| og:image:alt | Add conformance tests for the spec changes merged in #1669
None of the tested type checkers support nesting Final within ClassVar in dataclasses yet, so they all fail the automated conformance chec... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/typing git https://github.com/python/typing.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 24604008 |
| octolytics-dimension-repository_nwo | python/typing |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24604008 |
| octolytics-dimension-repository_network_root_nwo | python/typing |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 16a11879678aaf97e2a42c33ee70830aa084fa37 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/typing/pull/1741/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftyping%2Fpull%2F1741%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftyping%2Fpull%2F1741%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Ftyping |
| Reload | https://github.com/python/typing/pull/1741/files |
| Reload | https://github.com/python/typing/pull/1741/files |
| Reload | https://github.com/python/typing/pull/1741/files |
| python | https://github.com/python |
| typing | https://github.com/python/typing |
| Code | https://github.com/python/typing |
| Issues206 (206) | https://github.com/python/typing/issues |
| Pull requests27 (27) | https://github.com/python/typing/pulls |
| Discussions | https://github.com/python/typing/discussions |
| Actions | https://github.com/python/typing/actions |
| Security and quality | https://github.com/python/typing/security |
| Insights | https://github.com/python/typing/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Ftyping%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Ftyping%2Fissues%2Fnew%2Fchoose |
| JelleZijlstra | https://github.com/JelleZijlstra |
| python:main | https://github.com/python/typing/tree/main |
| carljm:dcfinaltests | https://github.com/carljm/typing/tree/dcfinaltests |
|
Conversation
5
| https://github.com/python/typing/pull/1741 |
|
Commits
2
| https://github.com/python/typing/pull/1741/commits |
|
Checks
0
| https://github.com/python/typing/pull/1741/checks |
|
Files changed
| https://github.com/python/typing/pull/1741/files |
| Please reload this page | https://github.com/python/typing/pull/1741/files |
|
Add conformance tests for Final dataclass fields
| https://github.com/python/typing/pull/1741/files#top |
|
Show all changes
2 commits
| https://github.com/python/typing/pull/1741/files |
|
d32d58c
Conformance tests for Final dataclass fields
carljm May 20, 2024
| https://github.com/python/typing/pull/1741/commits/d32d58c42c92a575ac7805dea165a8f4a4ae7897 |
|
95fce46
fix mypy conformance result
carljm May 20, 2024
| https://github.com/python/typing/pull/1741/commits/95fce46273ca409c649712aad7ac85aba1db8066 |
|
Clear filters
| https://github.com/python/typing/pull/1741/files |
| Please reload this page | https://github.com/python/typing/pull/1741/files |
| Please reload this page | https://github.com/python/typing/pull/1741/files |
|
dataclasses_final.toml
| https://github.com/python/typing/pull/1741/files#diff-11630524b56f597a1f7564e5ac2fec895234772b8ea3a5dd8042104d68709600 |
|
version.toml
| https://github.com/python/typing/pull/1741/files#diff-e4d38c0bb619c9628e04996dade77803d27cd462b19336f47fa42e8b991e5045 |
|
dataclasses_final.toml
| https://github.com/python/typing/pull/1741/files#diff-a9c6f7034ba09d17ea89577b60a640b07b3311f13e5ab56a9609cc8c6012d3b3 |
|
version.toml
| https://github.com/python/typing/pull/1741/files#diff-7821102017faa6d7e47f494787d6884cbaef605a05556990b5f2b3d857e5ad7d |
|
dataclasses_final.toml
| https://github.com/python/typing/pull/1741/files#diff-72c1890baa7043a97916ddf154fc17748d520cc8ecc26fdf76fa6debf038e1a3 |
|
version.toml
| https://github.com/python/typing/pull/1741/files#diff-02f6ca22bcd17c2c0e46477de7dd3f96c22653672d501465f37eafdbae110ce8 |
|
dataclasses_final.toml
| https://github.com/python/typing/pull/1741/files#diff-af6d0e1be9a8609be10c07b34c9d6794b77bf4557409aa5fc77fdfd4bd3b086f |
|
version.toml
| https://github.com/python/typing/pull/1741/files#diff-07743847060ac908fdc3625920c8983c38650880a0c22a98090c814ca3313ac1 |
|
results.html
| https://github.com/python/typing/pull/1741/files#diff-1026e9a5ffcc2a9a0af3bc5b250ce31a9562dc874f49390536bb28e2e129c381 |
|
dataclasses_final.py
| https://github.com/python/typing/pull/1741/files#diff-68ea08e63ab4c42993ddb181e9da1338bc4a52a7948885434c96bb282ca088cd |
|
qualifiers_final_annotation.py
| https://github.com/python/typing/pull/1741/files#diff-7890c25bd5fec9cfecd619efabd6a81245f5ffbbe03b964aa456f2b81a28aa63 |
| conformance/results/mypy/dataclasses_final.toml | https://github.com/python/typing/pull/1741/files#diff-11630524b56f597a1f7564e5ac2fec895234772b8ea3a5dd8042104d68709600 |
|
View file
| https://github.com/carljm/typing/blob/95fce46273ca409c649712aad7ac85aba1db8066/conformance/results/mypy/dataclasses_final.toml |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/typing/pull/1741/{{ revealButtonHref }} |
| conformance/results/mypy/version.toml | https://github.com/python/typing/pull/1741/files#diff-e4d38c0bb619c9628e04996dade77803d27cd462b19336f47fa42e8b991e5045 |
|
View file
| https://github.com/carljm/typing/blob/95fce46273ca409c649712aad7ac85aba1db8066/conformance/results/mypy/version.toml |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/typing/pull/1741/{{ revealButtonHref }} |
| conformance/results/pyre/dataclasses_final.toml | https://github.com/python/typing/pull/1741/files#diff-a9c6f7034ba09d17ea89577b60a640b07b3311f13e5ab56a9609cc8c6012d3b3 |
|
View file
| https://github.com/carljm/typing/blob/95fce46273ca409c649712aad7ac85aba1db8066/conformance/results/pyre/dataclasses_final.toml |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/typing/pull/1741/{{ revealButtonHref }} |
| conformance/results/pyre/version.toml | https://github.com/python/typing/pull/1741/files#diff-7821102017faa6d7e47f494787d6884cbaef605a05556990b5f2b3d857e5ad7d |
|
View file
| https://github.com/carljm/typing/blob/95fce46273ca409c649712aad7ac85aba1db8066/conformance/results/pyre/version.toml |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/typing/pull/1741/{{ revealButtonHref }} |
| conformance/results/pyright/dataclasses_final.toml | https://github.com/python/typing/pull/1741/files#diff-72c1890baa7043a97916ddf154fc17748d520cc8ecc26fdf76fa6debf038e1a3 |
|
View file
| https://github.com/carljm/typing/blob/95fce46273ca409c649712aad7ac85aba1db8066/conformance/results/pyright/dataclasses_final.toml |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/typing/pull/1741/{{ revealButtonHref }} |
| conformance/results/pyright/version.toml | https://github.com/python/typing/pull/1741/files#diff-02f6ca22bcd17c2c0e46477de7dd3f96c22653672d501465f37eafdbae110ce8 |
|
View file
| https://github.com/carljm/typing/blob/95fce46273ca409c649712aad7ac85aba1db8066/conformance/results/pyright/version.toml |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/typing/pull/1741/{{ revealButtonHref }} |
| conformance/results/pytype/dataclasses_final.toml | https://github.com/python/typing/pull/1741/files#diff-af6d0e1be9a8609be10c07b34c9d6794b77bf4557409aa5fc77fdfd4bd3b086f |
|
View file
| https://github.com/carljm/typing/blob/95fce46273ca409c649712aad7ac85aba1db8066/conformance/results/pytype/dataclasses_final.toml |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/typing/pull/1741/{{ revealButtonHref }} |
| conformance/results/pytype/version.toml | https://github.com/python/typing/pull/1741/files#diff-07743847060ac908fdc3625920c8983c38650880a0c22a98090c814ca3313ac1 |
|
View file
| https://github.com/carljm/typing/blob/95fce46273ca409c649712aad7ac85aba1db8066/conformance/results/pytype/version.toml |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/typing/pull/1741/{{ revealButtonHref }} |
| conformance/results/results.html | https://github.com/python/typing/pull/1741/files#diff-1026e9a5ffcc2a9a0af3bc5b250ce31a9562dc874f49390536bb28e2e129c381 |
|
View file
| https://github.com/carljm/typing/blob/95fce46273ca409c649712aad7ac85aba1db8066/conformance/results/results.html |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/typing/pull/1741/{{ revealButtonHref }} |
|
| https://github.com/python/typing/pull/1741/files#diff-1026e9a5ffcc2a9a0af3bc5b250ce31a9562dc874f49390536bb28e2e129c381 |
|
| https://github.com/python/typing/pull/1741/files#diff-1026e9a5ffcc2a9a0af3bc5b250ce31a9562dc874f49390536bb28e2e129c381 |
|
| https://github.com/python/typing/pull/1741/files#diff-1026e9a5ffcc2a9a0af3bc5b250ce31a9562dc874f49390536bb28e2e129c381 |
|
| https://github.com/python/typing/pull/1741/files#diff-1026e9a5ffcc2a9a0af3bc5b250ce31a9562dc874f49390536bb28e2e129c381 |
| conformance/tests/dataclasses_final.py | https://github.com/python/typing/pull/1741/files#diff-68ea08e63ab4c42993ddb181e9da1338bc4a52a7948885434c96bb282ca088cd |
|
View file
| https://github.com/carljm/typing/blob/95fce46273ca409c649712aad7ac85aba1db8066/conformance/tests/dataclasses_final.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/typing/pull/1741/{{ revealButtonHref }} |
| conformance/tests/qualifiers_final_annotation.py | https://github.com/python/typing/pull/1741/files#diff-7890c25bd5fec9cfecd619efabd6a81245f5ffbbe03b964aa456f2b81a28aa63 |
|
View file
| https://github.com/carljm/typing/blob/95fce46273ca409c649712aad7ac85aba1db8066/conformance/tests/qualifiers_final_annotation.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/typing/pull/1741/{{ revealButtonHref }} |
|
| https://github.com/python/typing/pull/1741/files#diff-7890c25bd5fec9cfecd619efabd6a81245f5ffbbe03b964aa456f2b81a28aa63 |
|
| https://github.com/python/typing/pull/1741/files#diff-7890c25bd5fec9cfecd619efabd6a81245f5ffbbe03b964aa456f2b81a28aa63 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |