René's URL Explorer Experiment


Title: Add conformance tests for Final dataclass fields by carljm · Pull Request #1741 · python/typing · GitHub

Open Graph Title: Add conformance tests for Final dataclass fields by carljm · Pull Request #1741 · python/typing

X Title: Add conformance tests for Final dataclass fields by carljm · Pull Request #1741 · python/typing

Description: Add conformance tests for the spec changes merged in #1669 None of the tested type checkers support nesting Final within ClassVar in dataclasses yet, so they all fail the automated conformance check. Mypy also requires a Final assignment in a dataclass body to be "initialized" (thus effectively requiring final dataclass fields to have a default). But all support the core behavior of defining a final dataclass field, so I marked them all as Partial.

Open Graph Description: Add conformance tests for the spec changes merged in #1669 None of the tested type checkers support nesting Final within ClassVar in dataclasses yet, so they all fail the automated conformance chec...

X Description: Add conformance tests for the spec changes merged in #1669 None of the tested type checkers support nesting Final within ClassVar in dataclasses yet, so they all fail the automated conformance chec...

Opengraph URL: https://github.com/python/typing/pull/1741

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ceb2f8bd-5a0a-f3f1-7229-48a9daa4964b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBED0:1D5C28:767A15:9ABA82:6AFFCF2D
html-safe-nonce479df16730c50de8a8817afa1f9d0e9c40e6d56c37f35f92288f48f3f909261b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRUQwOjFENUMyODo3NjdBMTU6OUFCQTgyOjZBRkZDRjJEIiwidmlzaXRvcl9pZCI6IjIxMTUyODAzNjI5NjY4NjM2NjIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf1a98aec3ab8423720061c115fa35404f1d60f705d82a30c1a659fbf51bf99ab
hovercard-subject-tagpull_request:1877394460
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/typing/pull/1741/files
twitter:imagehttps://avatars.githubusercontent.com/u/61586?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/61586?s=400&v=4
og:image:altAdd conformance tests for the spec changes merged in #1669 None of the tested type checkers support nesting Final within ClassVar in dataclasses yet, so they all fail the automated conformance chec...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/typing git https://github.com/python/typing.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id24604008
octolytics-dimension-repository_nwopython/typing
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24604008
octolytics-dimension-repository_network_root_nwopython/typing
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release16a11879678aaf97e2a42c33ee70830aa084fa37
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/typing/pull/1741/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftyping%2Fpull%2F1741%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftyping%2Fpull%2F1741%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Ftyping
Reloadhttps://github.com/python/typing/pull/1741/files
Reloadhttps://github.com/python/typing/pull/1741/files
Reloadhttps://github.com/python/typing/pull/1741/files
pythonhttps://github.com/python
typinghttps://github.com/python/typing
Codehttps://github.com/python/typing
Issues206 (206)https://github.com/python/typing/issues
Pull requests27 (27)https://github.com/python/typing/pulls
Discussionshttps://github.com/python/typing/discussions
Actionshttps://github.com/python/typing/actions
Security and qualityhttps://github.com/python/typing/security
Insightshttps://github.com/python/typing/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Ftyping%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Ftyping%2Fissues%2Fnew%2Fchoose
JelleZijlstrahttps://github.com/JelleZijlstra
python:mainhttps://github.com/python/typing/tree/main
carljm:dcfinaltestshttps://github.com/carljm/typing/tree/dcfinaltests
Conversation 5 https://github.com/python/typing/pull/1741
Commits 2 https://github.com/python/typing/pull/1741/commits
Checks 0 https://github.com/python/typing/pull/1741/checks
Files changed https://github.com/python/typing/pull/1741/files
Please reload this pagehttps://github.com/python/typing/pull/1741/files
Add conformance tests for Final dataclass fields https://github.com/python/typing/pull/1741/files#top
Show all changes 2 commits https://github.com/python/typing/pull/1741/files
d32d58c Conformance tests for Final dataclass fields carljm May 20, 2024 https://github.com/python/typing/pull/1741/commits/d32d58c42c92a575ac7805dea165a8f4a4ae7897
95fce46 fix mypy conformance result carljm May 20, 2024 https://github.com/python/typing/pull/1741/commits/95fce46273ca409c649712aad7ac85aba1db8066
Clear filters https://github.com/python/typing/pull/1741/files
Please reload this pagehttps://github.com/python/typing/pull/1741/files
Please reload this pagehttps://github.com/python/typing/pull/1741/files
dataclasses_final.toml https://github.com/python/typing/pull/1741/files#diff-11630524b56f597a1f7564e5ac2fec895234772b8ea3a5dd8042104d68709600
version.toml https://github.com/python/typing/pull/1741/files#diff-e4d38c0bb619c9628e04996dade77803d27cd462b19336f47fa42e8b991e5045
dataclasses_final.toml https://github.com/python/typing/pull/1741/files#diff-a9c6f7034ba09d17ea89577b60a640b07b3311f13e5ab56a9609cc8c6012d3b3
version.toml https://github.com/python/typing/pull/1741/files#diff-7821102017faa6d7e47f494787d6884cbaef605a05556990b5f2b3d857e5ad7d
dataclasses_final.toml https://github.com/python/typing/pull/1741/files#diff-72c1890baa7043a97916ddf154fc17748d520cc8ecc26fdf76fa6debf038e1a3
version.toml https://github.com/python/typing/pull/1741/files#diff-02f6ca22bcd17c2c0e46477de7dd3f96c22653672d501465f37eafdbae110ce8
dataclasses_final.toml https://github.com/python/typing/pull/1741/files#diff-af6d0e1be9a8609be10c07b34c9d6794b77bf4557409aa5fc77fdfd4bd3b086f
version.toml https://github.com/python/typing/pull/1741/files#diff-07743847060ac908fdc3625920c8983c38650880a0c22a98090c814ca3313ac1
results.html https://github.com/python/typing/pull/1741/files#diff-1026e9a5ffcc2a9a0af3bc5b250ce31a9562dc874f49390536bb28e2e129c381
dataclasses_final.py https://github.com/python/typing/pull/1741/files#diff-68ea08e63ab4c42993ddb181e9da1338bc4a52a7948885434c96bb282ca088cd
qualifiers_final_annotation.py https://github.com/python/typing/pull/1741/files#diff-7890c25bd5fec9cfecd619efabd6a81245f5ffbbe03b964aa456f2b81a28aa63
conformance/results/mypy/dataclasses_final.tomlhttps://github.com/python/typing/pull/1741/files#diff-11630524b56f597a1f7564e5ac2fec895234772b8ea3a5dd8042104d68709600
View file https://github.com/carljm/typing/blob/95fce46273ca409c649712aad7ac85aba1db8066/conformance/results/mypy/dataclasses_final.toml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typing/pull/1741/{{ revealButtonHref }}
conformance/results/mypy/version.tomlhttps://github.com/python/typing/pull/1741/files#diff-e4d38c0bb619c9628e04996dade77803d27cd462b19336f47fa42e8b991e5045
View file https://github.com/carljm/typing/blob/95fce46273ca409c649712aad7ac85aba1db8066/conformance/results/mypy/version.toml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typing/pull/1741/{{ revealButtonHref }}
conformance/results/pyre/dataclasses_final.tomlhttps://github.com/python/typing/pull/1741/files#diff-a9c6f7034ba09d17ea89577b60a640b07b3311f13e5ab56a9609cc8c6012d3b3
View file https://github.com/carljm/typing/blob/95fce46273ca409c649712aad7ac85aba1db8066/conformance/results/pyre/dataclasses_final.toml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typing/pull/1741/{{ revealButtonHref }}
conformance/results/pyre/version.tomlhttps://github.com/python/typing/pull/1741/files#diff-7821102017faa6d7e47f494787d6884cbaef605a05556990b5f2b3d857e5ad7d
View file https://github.com/carljm/typing/blob/95fce46273ca409c649712aad7ac85aba1db8066/conformance/results/pyre/version.toml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typing/pull/1741/{{ revealButtonHref }}
conformance/results/pyright/dataclasses_final.tomlhttps://github.com/python/typing/pull/1741/files#diff-72c1890baa7043a97916ddf154fc17748d520cc8ecc26fdf76fa6debf038e1a3
View file https://github.com/carljm/typing/blob/95fce46273ca409c649712aad7ac85aba1db8066/conformance/results/pyright/dataclasses_final.toml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typing/pull/1741/{{ revealButtonHref }}
conformance/results/pyright/version.tomlhttps://github.com/python/typing/pull/1741/files#diff-02f6ca22bcd17c2c0e46477de7dd3f96c22653672d501465f37eafdbae110ce8
View file https://github.com/carljm/typing/blob/95fce46273ca409c649712aad7ac85aba1db8066/conformance/results/pyright/version.toml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typing/pull/1741/{{ revealButtonHref }}
conformance/results/pytype/dataclasses_final.tomlhttps://github.com/python/typing/pull/1741/files#diff-af6d0e1be9a8609be10c07b34c9d6794b77bf4557409aa5fc77fdfd4bd3b086f
View file https://github.com/carljm/typing/blob/95fce46273ca409c649712aad7ac85aba1db8066/conformance/results/pytype/dataclasses_final.toml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typing/pull/1741/{{ revealButtonHref }}
conformance/results/pytype/version.tomlhttps://github.com/python/typing/pull/1741/files#diff-07743847060ac908fdc3625920c8983c38650880a0c22a98090c814ca3313ac1
View file https://github.com/carljm/typing/blob/95fce46273ca409c649712aad7ac85aba1db8066/conformance/results/pytype/version.toml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typing/pull/1741/{{ revealButtonHref }}
conformance/results/results.htmlhttps://github.com/python/typing/pull/1741/files#diff-1026e9a5ffcc2a9a0af3bc5b250ce31a9562dc874f49390536bb28e2e129c381
View file https://github.com/carljm/typing/blob/95fce46273ca409c649712aad7ac85aba1db8066/conformance/results/results.html
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typing/pull/1741/{{ revealButtonHref }}
https://github.com/python/typing/pull/1741/files#diff-1026e9a5ffcc2a9a0af3bc5b250ce31a9562dc874f49390536bb28e2e129c381
https://github.com/python/typing/pull/1741/files#diff-1026e9a5ffcc2a9a0af3bc5b250ce31a9562dc874f49390536bb28e2e129c381
https://github.com/python/typing/pull/1741/files#diff-1026e9a5ffcc2a9a0af3bc5b250ce31a9562dc874f49390536bb28e2e129c381
https://github.com/python/typing/pull/1741/files#diff-1026e9a5ffcc2a9a0af3bc5b250ce31a9562dc874f49390536bb28e2e129c381
conformance/tests/dataclasses_final.pyhttps://github.com/python/typing/pull/1741/files#diff-68ea08e63ab4c42993ddb181e9da1338bc4a52a7948885434c96bb282ca088cd
View file https://github.com/carljm/typing/blob/95fce46273ca409c649712aad7ac85aba1db8066/conformance/tests/dataclasses_final.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typing/pull/1741/{{ revealButtonHref }}
conformance/tests/qualifiers_final_annotation.pyhttps://github.com/python/typing/pull/1741/files#diff-7890c25bd5fec9cfecd619efabd6a81245f5ffbbe03b964aa456f2b81a28aa63
View file https://github.com/carljm/typing/blob/95fce46273ca409c649712aad7ac85aba1db8066/conformance/tests/qualifiers_final_annotation.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typing/pull/1741/{{ revealButtonHref }}
https://github.com/python/typing/pull/1741/files#diff-7890c25bd5fec9cfecd619efabd6a81245f5ffbbe03b964aa456f2b81a28aa63
https://github.com/python/typing/pull/1741/files#diff-7890c25bd5fec9cfecd619efabd6a81245f5ffbbe03b964aa456f2b81a28aa63
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.