| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:bf2d4a1e-66e7-99e7-ac3d-8d96872f4cd5 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9936:C814F:109A30B:14D9BD1:6AFF89F3 |
| html-safe-nonce | f4b67d49014866c1bf6aa54cb9acdf55b3673c94db4442fa0981b802fb2241be |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OTM2OkM4MTRGOjEwOUEzMEI6MTREOUJEMTo2QUZGODlGMyIsInZpc2l0b3JfaWQiOiI2MzIxNDY5OTkzNDY4NzkxMjgzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | aa528b3ad319a5a20688cc9d6ecaf66e8b37220b3a8c825d1788d577ccdd91dc |
| hovercard-subject-tag | pull_request:1877394460 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/typing/1741/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/5a1cf60a403af9903b57c64c7ec2fdd521972a091c6c0bf8180a947795881f70/python/typing/pull/1741 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/5a1cf60a403af9903b57c64c7ec2fdd521972a091c6c0bf8180a947795881f70/python/typing/pull/1741 |
| og:image:alt | Add conformance tests for the spec changes merged in #1669
None of the tested type checkers support nesting Final within ClassVar in dataclasses yet, so they all fail the automated conformance chec... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | carljm |
| hostname | github.com |
| expected-hostname | github.com |
| None | 587ad99a3e443b2e1cb0d3df059ec49ab54389861f13310766dfdeb615fed90d |
| turbo-cache-control | no-cache |
| go-import | github.com/python/typing git https://github.com/python/typing.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 24604008 |
| octolytics-dimension-repository_nwo | python/typing |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24604008 |
| octolytics-dimension-repository_network_root_nwo | python/typing |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 5bb0fb68d64881d1344f5863d809515d496801e5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/typing/pull/1741#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftyping%2Fpull%2F1741 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftyping%2Fpull%2F1741 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Ftyping |
| Reload | https://github.com/python/typing/pull/1741 |
| Reload | https://github.com/python/typing/pull/1741 |
| Reload | https://github.com/python/typing/pull/1741 |
| python | https://github.com/python |
| typing | https://github.com/python/typing |
| Code | https://github.com/python/typing |
| Issues206 (206) | https://github.com/python/typing/issues |
| Pull requests27 (27) | https://github.com/python/typing/pulls |
| Discussions | https://github.com/python/typing/discussions |
| Actions | https://github.com/python/typing/actions |
| Security and quality | https://github.com/python/typing/security |
| Insights | https://github.com/python/typing/insights |
| https://github.com/python/typing |
| JelleZijlstra | https://github.com/JelleZijlstra |
| python:main | https://github.com/python/typing/tree/main |
| carljm:dcfinaltests | https://github.com/carljm/typing/tree/dcfinaltests |
| Conversation | https://github.com/python/typing/pull/1741 |
| Commits2 (2) | https://github.com/python/typing/pull/1741/commits |
| Checks | https://github.com/python/typing/pull/1741/checks |
| Files changed | https://github.com/python/typing/pull/1741/files |
| Add conformance tests for Final dataclass fields | https://github.com/python/typing/pull/1741#top |
| JelleZijlstra | https://github.com/JelleZijlstra |
| python:main | https://github.com/python/typing/tree/main |
| carljm:dcfinaltests | https://github.com/carljm/typing/tree/dcfinaltests |
|
| https://github.com/carljm |
| carljm | https://github.com/carljm |
| May 20, 2024 | https://github.com/python/typing/pull/1741#issue-2304902834 |
| Please reload this page | https://github.com/python/typing/pull/1741 |
| #1669 | https://github.com/python/typing/pull/1669 |
| Please reload this page | https://github.com/python/typing/pull/1741 |
|
| https://github.com/carljm |
| Conformance tests for Final dataclass fields | https://github.com/python/typing/pull/1741/commits/d32d58c42c92a575ac7805dea165a8f4a4ae7897 |
| d32d58c | https://github.com/python/typing/pull/1741/commits/d32d58c42c92a575ac7805dea165a8f4a4ae7897 |
| https://github.com/erictraut |
| erictraut | https://github.com/erictraut |
|
May 20, 2024
| https://github.com/python/typing/pull/1741#pullrequestreview-2065283693 |
|
View reviewed changes
| https://github.com/python/typing/pull/1741/files/d32d58c42c92a575ac7805dea165a8f4a4ae7897 |
| erictraut | https://github.com/erictraut |
| https://github.com/python/typing/pull/1741#pullrequestreview-2065283693 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/typing/pull/1741 |
| conformance/results/mypy/dataclasses_final.toml | https://github.com/python/typing/pull/1741/files/d32d58c42c92a575ac7805dea165a8f4a4ae7897#diff-11630524b56f597a1f7564e5ac2fec895234772b8ea3a5dd8042104d68709600 |
| Please reload this page | https://github.com/python/typing/pull/1741 |
|
| https://github.com/carljm |
| fix mypy conformance result | https://github.com/python/typing/pull/1741/commits/95fce46273ca409c649712aad7ac85aba1db8066 |
| 95fce46 | https://github.com/python/typing/pull/1741/commits/95fce46273ca409c649712aad7ac85aba1db8066 |
| https://github.com/JelleZijlstra |
| JelleZijlstra | https://github.com/JelleZijlstra |
| 2d2e8ee | https://github.com/python/typing/commit/2d2e8eea682c3a42c7731d5941d3b41ad79acdca |
| May 20, 2024 | https://github.com/python/typing/pull/1741#event-12869165913 |
| https://github.com/Viicos |
| Viicos | https://github.com/Viicos |
|
Jul 16, 2024
| https://github.com/python/typing/pull/1741#ref-issue-2410783188 |
|
Clarify signification of Annotation
#1805
| https://github.com/python/typing/issues/1805 |
| https://github.co/hiddenchars |
| https://github.com/python/typing/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftyping%2Fpull%2F1741 |
|
| https://github.com/erictraut |
|
erictraut
| https://github.com/erictraut |
|
| https://github.com/python/typing/pull/1741/files/d32d58c42c92a575ac7805dea165a8f4a4ae7897 |
| Please reload this page | https://github.com/python/typing/pull/1741 |
| Please reload this page | https://github.com/python/typing/pull/1741 |
|
| https://github.com/carljm |
|
| https://github.com/erictraut |
|
| https://github.com/JelleZijlstra |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |