| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:8db3869f-2a9d-3d33-9473-96c8f8d3fee3 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D860:144E47:FF4930:14036A4:6AFF8743 |
| html-safe-nonce | 5df1fc5451c544169e842eb78e739cea0afdf4428a2dee55e55294a6a150a03b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEODYwOjE0NEU0NzpGRjQ5MzA6MTQwMzZBNDo2QUZGODc0MyIsInZpc2l0b3JfaWQiOiI0MjQxMDI4NzI3NjcwMDE1ODExIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 2367e59ab3727a2f7f6efeea397e2992e8f473ff139a13a3fdfeaf38a5a8a283 |
| hovercard-subject-tag | pull_request:1798213664 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/typing/1669/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/fc1f5a053aad184550be93ad2d251a6b86f5bd2febe0220d2afa352a5e62d510/python/typing/pull/1669 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/fc1f5a053aad184550be93ad2d251a6b86f5bd2febe0220d2afa352a5e62d510/python/typing/pull/1669 |
| og:image:alt | See discussion thread at https://discuss.python.org/t/treatment-of-final-attributes-in-dataclass-likes/47154 and issue at python/cpython#89547
Consider a dataclass with a Final-annotated initialize... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | carljm |
| hostname | github.com |
| expected-hostname | github.com |
| None | 587ad99a3e443b2e1cb0d3df059ec49ab54389861f13310766dfdeb615fed90d |
| turbo-cache-control | no-cache |
| go-import | github.com/python/typing git https://github.com/python/typing.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 24604008 |
| octolytics-dimension-repository_nwo | python/typing |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24604008 |
| octolytics-dimension-repository_network_root_nwo | python/typing |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 5bb0fb68d64881d1344f5863d809515d496801e5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/typing/pull/1669#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftyping%2Fpull%2F1669 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftyping%2Fpull%2F1669 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Ftyping |
| Reload | https://github.com/python/typing/pull/1669 |
| Reload | https://github.com/python/typing/pull/1669 |
| Reload | https://github.com/python/typing/pull/1669 |
| python | https://github.com/python |
| typing | https://github.com/python/typing |
| Code | https://github.com/python/typing |
| Issues206 (206) | https://github.com/python/typing/issues |
| Pull requests27 (27) | https://github.com/python/typing/pulls |
| Discussions | https://github.com/python/typing/discussions |
| Actions | https://github.com/python/typing/actions |
| Security and quality | https://github.com/python/typing/security |
| Insights | https://github.com/python/typing/insights |
| https://github.com/python/typing |
| JelleZijlstra | https://github.com/JelleZijlstra |
| python:main | https://github.com/python/typing/tree/main |
| carljm:dcfinal | https://github.com/carljm/typing/tree/dcfinal |
| Conversation | https://github.com/python/typing/pull/1669 |
| Commits2 (2) | https://github.com/python/typing/pull/1669/commits |
| Checks | https://github.com/python/typing/pull/1669/checks |
| Files changed | https://github.com/python/typing/pull/1669/files |
| spec: clarify interaction of Final and dataclass | https://github.com/python/typing/pull/1669#top |
| JelleZijlstra | https://github.com/JelleZijlstra |
| python:main | https://github.com/python/typing/tree/main |
| carljm:dcfinal | https://github.com/carljm/typing/tree/dcfinal |
|
| https://github.com/carljm |
| carljm | https://github.com/carljm |
| Mar 29, 2024 | https://github.com/python/typing/pull/1669#issue-2215622756 |
| Please reload this page | https://github.com/python/typing/pull/1669 |
| https://discuss.python.org/t/treatment-of-final-attributes-in-dataclass-likes/47154 | https://discuss.python.org/t/treatment-of-final-attributes-in-dataclass-likes/47154 |
| python/cpython#89547 | https://github.com/python/cpython/issues/89547 |
| mypy | https://mypy-play.net/?mypy=latest&python=3.12&gist=f9b653fe9073ca191e990e7d65013734 |
| pyre | https://pyre-check.org/play?input=from%20typing%20import%20assert_type%2C%20Final%0Afrom%20dataclasses%20import%20dataclass%2C%20field%0A%0A%40dataclass%0Aclass%20Item%3A%0A%20%20%20%20x%3A%20Final%5Bint%5D%20%3D%203%0A%20%20%20%20y%3A%20Final%5Bint%5D%20%3D%20field(default%3D4)%0A%20%20%20%20%0Adef%20f()%20-%3E%20None%3A%0A%20%20%20%20item%20%3D%20Item()%0A%20%20%20%20assert_type(item.x%2C%20int)%0A%20%20%20%20item2%20%3D%20Item(x%3D2)%0A%20%20%20%20assert_type(item2.x%2C%20int)%0A%20%20%20%20item2.x%20%3D%204%0A%20%20%20%20reveal_type(Item.x)%0A%20%20%20%20reveal_type(Item.y) |
| pyright | https://pyright-play.net/?strict=true&enableExperimentalFeatures=true&code=GYJw9gtgBALgngBwJYDsDmUkQWEMoCGAzkQKZ4D68CpANFAGKoEA2AUKJFACYEwEBjFsTJFM2XPl78hI%2BsCSkW3NmwAC0wcJJtZJKAEkYpCAC42US1AAepxsxYBtVDAC6UALxQAzBatw7JhRWZxQ3TygFJW4ACm5SYAIAVxYYDwAWAEo-SzZ44EiYzKgAWgA%2BKAA5MBRScytMY2gvIxMinMISchgqRFIYpCaAOmt6F2yGwZMAJgjWiBjrD2mJqxFu3poBpumRsbDVyymIXesI9I6QUgA3UlZN-vmRw6gr2-vqR%2BG4bKA |
| Please reload this page | https://github.com/python/typing/pull/1669 |
|
| https://github.com/carljm |
| clarify interaction of Final and dataclass | https://github.com/python/typing/pull/1669/commits/8a6f51bf268eaf99d587abb2985fb9b944f17444 |
| 8a6f51b | https://github.com/python/typing/pull/1669/commits/8a6f51bf268eaf99d587abb2985fb9b944f17444 |
| https://github.com/carljm |
| carljm | https://github.com/carljm |
|
Mar 29, 2024
| https://github.com/python/typing/pull/1669#ref-issue-1199066444 |
|
Clarify meaning of Final in dataclasses
python/cpython#89547
| https://github.com/python/cpython/issues/89547 |
| https://github.com/carljm |
| carljm | https://github.com/carljm |
| Mar 29, 2024 | https://github.com/python/typing/pull/1669#event-12296610594 |
| https://github.com/Tinche |
| Tinche | https://github.com/Tinche |
| Mar 29, 2024 | https://github.com/python/typing/pull/1669#issuecomment-2027479470 |
| Please reload this page | https://github.com/python/typing/pull/1669 |
| https://github.com/bzoracler |
| bzoracler | https://github.com/bzoracler |
|
Mar 29, 2024
| https://github.com/python/typing/pull/1669#ref-pullrequest-882561425 |
|
Add ability to use Final in a field type annotation
pydantic/pydantic#2768
| https://github.com/pydantic/pydantic/pull/2768 |
| https://github.com/srittau |
| srittau | https://github.com/srittau |
|
Typing Council decision
| https://github.com/python/typing/issues?q=state%3Aopen%20label%3A%22Typing%20Council%20decision%22 |
| Mar 29, 2024 | https://github.com/python/typing/pull/1669#event-12298594730 |
| erictraut | https://github.com/erictraut |
|
Mar 31, 2024
| https://github.com/python/typing/pull/1669#ref-commit-b085a26 |
|
| https://github.com/erictraut |
| Changed the handling of Final variables (that are not explicitly ma… | https://github.com/microsoft/pyright/commit/b085a2669ac8d766722d6e19a0797348143ebfcc |
| b085a26 | https://github.com/microsoft/pyright/commit/b085a2669ac8d766722d6e19a0797348143ebfcc |
| python/typing#1669 | https://github.com/python/typing/pull/1669 |
| https://github.com/erictraut |
| erictraut | https://github.com/erictraut |
| Mar 31, 2024 | https://github.com/python/typing/pull/1669#issuecomment-2028930156 |
| typing council repo | https://github.com/python/typing-council/issues |
| Please reload this page | https://github.com/python/typing/pull/1669 |
| https://github.com/carljm |
| carljm | https://github.com/carljm |
|
Apr 3, 2024
| https://github.com/python/typing/pull/1669#ref-issue-2221711946 |
|
Typing spec update for Final and dataclasses
python/typing-council#24
| https://github.com/python/typing-council/issues/24 |
| https://github.com/JelleZijlstra |
| JelleZijlstra | https://github.com/JelleZijlstra |
|
Apr 3, 2024
| https://github.com/python/typing/pull/1669#pullrequestreview-1977767112 |
|
View reviewed changes
| https://github.com/python/typing/pull/1669/files/8a6f51bf268eaf99d587abb2985fb9b944f17444 |
| docs/spec/qualifiers.rst | https://github.com/python/typing/pull/1669/files/8a6f51bf268eaf99d587abb2985fb9b944f17444#diff-d63169ac083634a818bd58f3c0d305cc19ad8200a2a0363d5010e0dc998033ff |
| Please reload this page | https://github.com/python/typing/pull/1669 |
|
| https://github.com/carljm |
| Jelle comments | https://github.com/python/typing/pull/1669/commits/0e3f3a7f4a2a22e5f69a3fb52f7a173711bf9f69 |
| 0e3f3a7 | https://github.com/python/typing/pull/1669/commits/0e3f3a7f4a2a22e5f69a3fb52f7a173711bf9f69 |
| https://github.com/JelleZijlstra |
| JelleZijlstra | https://github.com/JelleZijlstra |
|
Apr 4, 2024
| https://github.com/python/typing/pull/1669#pullrequestreview-1978566631 |
|
View reviewed changes
| https://github.com/python/typing/pull/1669/files/0e3f3a7f4a2a22e5f69a3fb52f7a173711bf9f69 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
|
Apr 4, 2024
| https://github.com/python/typing/pull/1669#pullrequestreview-1978953269 |
|
View reviewed changes
| https://github.com/python/typing/pull/1669/files/0e3f3a7f4a2a22e5f69a3fb52f7a173711bf9f69 |
| https://github.com/JelleZijlstra |
| JelleZijlstra | https://github.com/JelleZijlstra |
| 7a70cd6 | https://github.com/python/typing/commit/7a70cd6313764e7b6c2c5b4ed439189e5c3e85af |
| Apr 11, 2024 | https://github.com/python/typing/pull/1669#event-12436106638 |
| JelleZijlstra | https://github.com/JelleZijlstra |
|
Apr 11, 2024
| https://github.com/python/typing/pull/1669#ref-commit-4110874 |
|
| https://github.com/carljm |
|
| https://github.com/JelleZijlstra |
| spec: clarify interaction of Final and dataclass ( | https://github.com/JelleZijlstra/typing/commit/411087468884c03ce141fddcb0aee510137ae96a |
| python#1669 | https://github.com/python/typing/pull/1669 |
| ) | https://github.com/JelleZijlstra/typing/commit/411087468884c03ce141fddcb0aee510137ae96a |
| 4110874 | https://github.com/JelleZijlstra/typing/commit/411087468884c03ce141fddcb0aee510137ae96a |
| https://github.com/carljm |
| carljm | https://github.com/carljm |
| Apr 22, 2024 | https://github.com/python/typing/pull/1669#issuecomment-2070976947 |
| Please reload this page | https://github.com/python/typing/pull/1669 |
| https://github.com/carljm |
| carljm | https://github.com/carljm |
| April 22, 2024 21:24 | https://github.com/python/typing/pull/1669#event-12565953027 |
| https://github.com/tmke8 |
| tmke8 | https://github.com/tmke8 |
|
May 13, 2024
| https://github.com/python/typing/pull/1669#ref-issue-359585671 |
|
Allow omitting initializer for Final attributes in dataclasses
python/mypy#5608
| https://github.com/python/mypy/issues/5608 |
| https://github.com/carljm |
| carljm | https://github.com/carljm |
|
May 20, 2024
| https://github.com/python/typing/pull/1669#ref-pullrequest-2304902834 |
|
Add conformance tests for Final dataclass fields
#1741
| https://github.com/python/typing/pull/1741 |
| https://github.com/Viicos |
| Viicos | https://github.com/Viicos |
|
Jul 16, 2024
| https://github.com/python/typing/pull/1669#ref-issue-2410783188 |
|
Clarify signification of Annotation
#1805
| https://github.com/python/typing/issues/1805 |
|
(🐞) false positive mypy error "Only root is allowed as a field of a RootModel"
pydantic/pydantic#10474
| https://github.com/pydantic/pydantic/issues/10474 |
|
Bare Final special form with dataclasses
microsoft/pyright#9468
| https://github.com/microsoft/pyright/issues/9468 |
| https://github.com/ncanceill |
| ncanceill | https://github.com/ncanceill |
|
Dec 3, 2024
| https://github.com/python/typing/pull/1669#ref-issue-2715230333 |
|
Accept nesting Final in ClassVar for dataclasses
python/mypy#18235
| https://github.com/python/mypy/issues/18235 |
| https://github.com/Viicos |
| Viicos | https://github.com/Viicos |
|
Dec 15, 2024
| https://github.com/python/typing/pull/1669#ref-issue-2740800088 |
|
Fields marked as Final with a default value shouldn't be considered as class variables
pydantic/pydantic#11119
| https://github.com/pydantic/pydantic/issues/11119 |
| https://github.com/Viicos |
| Viicos | https://github.com/Viicos |
|
Feb 25, 2025
| https://github.com/python/typing/pull/1669#ref-issue-2410639707 |
|
Order of Final annotation changes behaviour of field
pydantic/pydantic#9904
| https://github.com/pydantic/pydantic/issues/9904 |
| https://github.com/Viicos |
| Viicos | https://github.com/Viicos |
|
May 26, 2025
| https://github.com/python/typing/pull/1669#ref-issue-3088352478 |
|
ClassVar[Final[T]] should be allowed
microsoft/pyright#10500
| https://github.com/microsoft/pyright/issues/10500 |
|
Fix a false positive for class attribute typed with Final
pylint-dev/pylint#10712
| https://github.com/pylint-dev/pylint/pull/10712 |
|
Pylint C0103 (invalid-name) for dataclass Final field
pylint-dev/pylint#10790
| https://github.com/pylint-dev/pylint/issues/10790 |
| https://github.com/davidhalter |
| davidhalter | https://github.com/davidhalter |
|
Oct 21, 2026
| https://github.com/python/typing/pull/1669#ref-issue-5947662596 |
|
ClassVar + Final
#2371
| https://github.com/python/typing/issues/2371 |
| https://github.com/Viicos |
| Viicos | https://github.com/Viicos |
|
Oct 31, 2026
| https://github.com/python/typing/pull/1669#ref-pullrequest-6134448748 |
|
Remove functionality deprecated during the 2.x timeline
pydantic/pydantic#14158
| https://github.com/pydantic/pydantic/pull/14158 |
| https://github.co/hiddenchars |
| https://github.com/python/typing/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftyping%2Fpull%2F1669 |
|
| https://github.com/JelleZijlstra |
|
JelleZijlstra
| https://github.com/JelleZijlstra |
|
| https://github.com/python/typing/pull/1669/files/0e3f3a7f4a2a22e5f69a3fb52f7a173711bf9f69 |
|
| https://github.com/hauntsaninja |
|
hauntsaninja
| https://github.com/hauntsaninja |
|
| https://github.com/python/typing/pull/1669/files/0e3f3a7f4a2a22e5f69a3fb52f7a173711bf9f69 |
| Please reload this page | https://github.com/python/typing/pull/1669 |
|
Typing Council decision
| https://github.com/python/typing/issues?q=state%3Aopen%20label%3A%22Typing%20Council%20decision%22 |
| Please reload this page | https://github.com/python/typing/pull/1669 |
|
| https://github.com/carljm |
|
| https://github.com/Tinche |
|
| https://github.com/erictraut |
|
| https://github.com/JelleZijlstra |
|
| https://github.com/hauntsaninja |
|
| https://github.com/srittau |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |