René's URL Explorer Experiment


Title: Require AsyncGenerator for asynccontextmanager by hauntsaninja · Pull Request #8698 · python/typeshed · GitHub

Open Graph Title: Require AsyncGenerator for asynccontextmanager by hauntsaninja · Pull Request #8698 · python/typeshed

X Title: Require AsyncGenerator for asynccontextmanager by hauntsaninja · Pull Request #8698 · python/typeshed

Description: I'm against merging #7430 because: Generator is not an ergonomic type It's very widely breaking Safety could easily be enforced by a linter that ensures use of yield from x instead of return x in an @contextmanager To expand on that a little: I care about the typing system being accessible. Generator with its three type vars is not a friendly type. I see enough confusion about Iterable, Iterator, Generator as it is. Maintaining a high signal to noise / effort ratio is an important part of making typing accessible. Breaking changes that seem arbitrary to most users reinforce existing negative impressions of typing that hurt the ecosystem as a whole. In all the years of typing, this has come up basically never (reported twice by asottile, none of the outlinks from the issue contain the bug, issue itself is not popular), so I think this is 99.99% noise. Between typeshed and mypy and gitter and discord and work, I've seen a lot of typing issue reports. But I'm willing to admit that the considerations are slightly different for asynccontextmanager: async is less widely used than sync, so this is less widely breaking (let's at least see primer) async is typically used by more experienced Python users, so there's already an accessibility floor here There is no equivalent to yield from in async that a linter could enforce, so this genuinely can only be solved in type checkers The issue that led to #7430 was with asynccontextmanager We've gotten away with some pedantic narrowings of async types before This is just an experiment, I'm not sure whether I'm actually in favour of this change, but I'm a lot more willing to consider it. Note that I'm not open to slippery slope consistency arguments here; if a constraint is that we do both async and sync or neither, then I'm firmly in the neither camp.

Open Graph Description: I'm against merging #7430 because: Generator is not an ergonomic type It's very widely breaking Safety could easily be enforced by a linter that ensures use of yield from x instead of retu...

X Description: I'm against merging #7430 because: Generator is not an ergonomic type It's very widely breaking Safety could easily be enforced by a linter that ensures use of yield from x instead...

Opengraph URL: https://github.com/python/typeshed/pull/8698

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:5426b073-3a5e-bb3d-5fda-a9fc92ba9a82
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id93F6:1DD784:236779:2F931F:6B002302
html-safe-noncec48978ddb37b4f3ef619724286c5737cab2f4f60f4a8cf2db89f330d5f3ba43a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5M0Y2OjFERDc4NDoyMzY3Nzk6MkY5MzFGOjZCMDAyMzAyIiwidmlzaXRvcl9pZCI6IjUzNjkzNDEwMjc0NDg1Mjk2NjYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacc967369992bad28b11402474900e842c49e8bd4a0105fdef583a995587885aa4
hovercard-subject-tagpull_request:1048063492
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/typeshed/pull/8698/files
twitter:imagehttps://avatars.githubusercontent.com/u/12621235?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/12621235?s=400&v=4
og:image:altI'm against merging #7430 because: Generator is not an ergonomic type It's very widely breaking Safety could easily be enforced by a linter that ensures use of yield from x instead of retu...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/typeshed git https://github.com/python/typeshed.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id31696383
octolytics-dimension-repository_nwopython/typeshed
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id31696383
octolytics-dimension-repository_network_root_nwopython/typeshed
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release44c658b24abf00491fb7ae5f56d42c9f38cbeab2
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/typeshed/pull/8698/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fpull%2F8698%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fpull%2F8698%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Ftypeshed
Reloadhttps://github.com/python/typeshed/pull/8698/files
Reloadhttps://github.com/python/typeshed/pull/8698/files
Reloadhttps://github.com/python/typeshed/pull/8698/files
pythonhttps://github.com/python
typeshedhttps://github.com/python/typeshed
Codehttps://github.com/python/typeshed
Issues196 (196)https://github.com/python/typeshed/issues
Pull requests251 (251)https://github.com/python/typeshed/pulls
Actionshttps://github.com/python/typeshed/actions
Security and qualityhttps://github.com/python/typeshed/security
Insightshttps://github.com/python/typeshed/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Ftypeshed%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Ftypeshed%2Fissues%2Fnew%2Fchoose
hauntsaninjahttps://github.com/hauntsaninja
python:masterhttps://github.com/python/typeshed/tree/master
hauntsaninja:asynccontextmanagerhttps://github.com/hauntsaninja/typeshed/tree/asynccontextmanager
Conversation 4 https://github.com/python/typeshed/pull/8698
Commits 1 https://github.com/python/typeshed/pull/8698/commits
Checks 0 https://github.com/python/typeshed/pull/8698/checks
Files changed https://github.com/python/typeshed/pull/8698/files
Please reload this pagehttps://github.com/python/typeshed/pull/8698/files
Require AsyncGenerator for asynccontextmanager https://github.com/python/typeshed/pull/8698/files#top
Show all changes 1 commit https://github.com/python/typeshed/pull/8698/files
cd13dd0 Require AsyncGenerator for asynccontextmanager hauntsaninja Sep 6, 2022 https://github.com/python/typeshed/pull/8698/commits/cd13dd04c57d9af5823b667d754e6292a727031c
Clear filters https://github.com/python/typeshed/pull/8698/files
Please reload this pagehttps://github.com/python/typeshed/pull/8698/files
Please reload this pagehttps://github.com/python/typeshed/pull/8698/files
stdlib/contextlib.pyihttps://github.com/python/typeshed/pull/8698/files#diff-2868ebfb0fa7179f85ba3d6647c7c4a62bbd064479a9d63f6e4ead072c5b4468
View file https://github.com/hauntsaninja/typeshed/blob/cd13dd04c57d9af5823b667d754e6292a727031c/stdlib/contextlib.pyi
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typeshed/pull/8698/{{ revealButtonHref }}
https://github.com/python/typeshed/pull/8698/files#diff-2868ebfb0fa7179f85ba3d6647c7c4a62bbd064479a9d63f6e4ead072c5b4468
https://github.com/python/typeshed/pull/8698/files#diff-2868ebfb0fa7179f85ba3d6647c7c4a62bbd064479a9d63f6e4ead072c5b4468
https://github.com/python/typeshed/pull/8698/files#diff-2868ebfb0fa7179f85ba3d6647c7c4a62bbd064479a9d63f6e4ead072c5b4468
https://github.com/python/typeshed/pull/8698/files#diff-2868ebfb0fa7179f85ba3d6647c7c4a62bbd064479a9d63f6e4ead072c5b4468
https://github.com/python/typeshed/pull/8698/files#diff-2868ebfb0fa7179f85ba3d6647c7c4a62bbd064479a9d63f6e4ead072c5b4468
https://github.com/python/typeshed/pull/8698/files#diff-2868ebfb0fa7179f85ba3d6647c7c4a62bbd064479a9d63f6e4ead072c5b4468
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.