Title: Require AsyncGenerator for asynccontextmanager by hauntsaninja · Pull Request #8698 · python/typeshed · GitHub
Open Graph Title: Require AsyncGenerator for asynccontextmanager by hauntsaninja · Pull Request #8698 · python/typeshed
X Title: Require AsyncGenerator for asynccontextmanager by hauntsaninja · Pull Request #8698 · python/typeshed
Description: I'm against merging #7430 because: Generator is not an ergonomic type It's very widely breaking Safety could easily be enforced by a linter that ensures use of yield from x instead of return x in an @contextmanager To expand on that a little: I care about the typing system being accessible. Generator with its three type vars is not a friendly type. I see enough confusion about Iterable, Iterator, Generator as it is. Maintaining a high signal to noise / effort ratio is an important part of making typing accessible. Breaking changes that seem arbitrary to most users reinforce existing negative impressions of typing that hurt the ecosystem as a whole. In all the years of typing, this has come up basically never (reported twice by asottile, none of the outlinks from the issue contain the bug, issue itself is not popular), so I think this is 99.99% noise. Between typeshed and mypy and gitter and discord and work, I've seen a lot of typing issue reports. But I'm willing to admit that the considerations are slightly different for asynccontextmanager: async is less widely used than sync, so this is less widely breaking (let's at least see primer) async is typically used by more experienced Python users, so there's already an accessibility floor here There is no equivalent to yield from in async that a linter could enforce, so this genuinely can only be solved in type checkers The issue that led to #7430 was with asynccontextmanager We've gotten away with some pedantic narrowings of async types before This is just an experiment, I'm not sure whether I'm actually in favour of this change, but I'm a lot more willing to consider it. Note that I'm not open to slippery slope consistency arguments here; if a constraint is that we do both async and sync or neither, then I'm firmly in the neither camp.
Open Graph Description: I'm against merging #7430 because: Generator is not an ergonomic type It's very widely breaking Safety could easily be enforced by a linter that ensures use of yield from x instead of retu...
X Description: I'm against merging #7430 because: Generator is not an ergonomic type It's very widely breaking Safety could easily be enforced by a linter that ensures use of yield from x instead...
Opengraph URL: https://github.com/python/typeshed/pull/8698
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:5426b073-3a5e-bb3d-5fda-a9fc92ba9a82 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 93F6:1DD784:236779:2F931F:6B002302 |
| html-safe-nonce | c48978ddb37b4f3ef619724286c5737cab2f4f60f4a8cf2db89f330d5f3ba43a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5M0Y2OjFERDc4NDoyMzY3Nzk6MkY5MzFGOjZCMDAyMzAyIiwidmlzaXRvcl9pZCI6IjUzNjkzNDEwMjc0NDg1Mjk2NjYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | c967369992bad28b11402474900e842c49e8bd4a0105fdef583a995587885aa4 |
| hovercard-subject-tag | pull_request:1048063492 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/typeshed/pull/8698/files |
| twitter:image | https://avatars.githubusercontent.com/u/12621235?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/12621235?s=400&v=4 |
| og:image:alt | I'm against merging #7430 because: Generator is not an ergonomic type It's very widely breaking Safety could easily be enforced by a linter that ensures use of yield from x instead of retu... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/typeshed git https://github.com/python/typeshed.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 31696383 |
| octolytics-dimension-repository_nwo | python/typeshed |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 31696383 |
| octolytics-dimension-repository_network_root_nwo | python/typeshed |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 44c658b24abf00491fb7ae5f56d42c9f38cbeab2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width