| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:3b4ce091-79fa-8974-492d-e83c6f29b86e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8734:A3BF2:77441E:A0A70E:6A618757 |
| html-safe-nonce | 822633bcd81295022360561388f96403f3d49fa2d397945c4faacc9adf12336c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NzM0OkEzQkYyOjc3NDQxRTpBMEE3MEU6NkE2MTg3NTciLCJ2aXNpdG9yX2lkIjoiNTU4NjA5NDc1NTQxODMxMDQ4NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 37eab40306cd42109bb73c0618ed6bbd816ef2a74d147f4bf7756e2bbf1f1b89 |
| hovercard-subject-tag | pull_request:1029945069 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/typeshed/8554/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/3b471e5f0db478d499be5d6b80e336c67a20e9405b63c1094601f01e20968f12/python/typeshed/pull/8554 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/3b471e5f0db478d499be5d6b80e336c67a20e9405b63c1094601f01e20968f12/python/typeshed/pull/8554 |
| og:image:alt | fix: #8513
This updates the types of sys.exit and SystemExit with the recommendations of @Akuli. The issue had received 👍 s from three team members, so I wanted to help move this along for the team. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | kkirsche |
| hostname | github.com |
| expected-hostname | github.com |
| None | c28c2f6607f2aacbd934868d997038895c9780d08babfe918550d73773326f4c |
| turbo-cache-control | no-cache |
| go-import | github.com/python/typeshed git https://github.com/python/typeshed.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 31696383 |
| octolytics-dimension-repository_nwo | python/typeshed |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 31696383 |
| octolytics-dimension-repository_network_root_nwo | python/typeshed |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | cd05235d52ffb3318513d883a56c87a121015c8b |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/typeshed/pull/8554#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fpull%2F8554 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| Code QualityEnforce quality at merge | https://github.com/features/code-quality |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fpull%2F8554 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Ftypeshed |
| Reload | https://github.com/python/typeshed/pull/8554 |
| Reload | https://github.com/python/typeshed/pull/8554 |
| Reload | https://github.com/python/typeshed/pull/8554 |
| Please reload this page | https://github.com/python/typeshed/pull/8554 |
|
python
| https://github.com/python |
| typeshed | https://github.com/python/typeshed |
| Please reload this page | https://github.com/python/typeshed/pull/8554 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Ftypeshed |
|
Fork
2.1k
| https://github.com/login?return_to=%2Fpython%2Ftypeshed |
|
Star
5.1k
| https://github.com/login?return_to=%2Fpython%2Ftypeshed |
|
Code
| https://github.com/python/typeshed |
|
Issues
219
| https://github.com/python/typeshed/issues |
|
Pull requests
146
| https://github.com/python/typeshed/pulls |
|
Actions
| https://github.com/python/typeshed/actions |
|
Security and quality
0
| https://github.com/python/typeshed/security |
|
Insights
| https://github.com/python/typeshed/pulse |
|
Code
| https://github.com/python/typeshed |
|
Issues
| https://github.com/python/typeshed/issues |
|
Pull requests
| https://github.com/python/typeshed/pulls |
|
Actions
| https://github.com/python/typeshed/actions |
|
Security and quality
| https://github.com/python/typeshed/security |
|
Insights
| https://github.com/python/typeshed/pulse |
| AlexWaygood | https://github.com/AlexWaygood |
| python:master | https://github.com/python/typeshed/tree/master |
| Conversation | https://github.com/python/typeshed/pull/8554 |
| Commits4 (4) | https://github.com/python/typeshed/pull/8554/commits |
| Checks | https://github.com/python/typeshed/pull/8554/checks |
| Files changed | https://github.com/python/typeshed/pull/8554/files |
| fix: Update sys.exit and SystemExit exception to have the same types | https://github.com/python/typeshed/pull/8554#top |
| AlexWaygood | https://github.com/AlexWaygood |
| python:master | https://github.com/python/typeshed/tree/master |
|
| https://github.com/kkirsche |
| kkirsche | https://github.com/kkirsche |
| Aug 18, 2022 | https://github.com/python/typeshed/pull/8554#issue-1343043047 |
| #8513 | https://github.com/python/typeshed/issues/8513 |
| @Akuli | https://github.com/Akuli |
| Please reload this page | https://github.com/python/typeshed/pull/8554 |
| fix: Update sys.exit and SystemExit exception to have the same types | https://github.com/python/typeshed/pull/8554/commits/d0e66990ce5e8aa357a8af7e9d433fb93ccfef2e |
| d0e6699 | https://github.com/python/typeshed/pull/8554/commits/d0e66990ce5e8aa357a8af7e9d433fb93ccfef2e |
| #8513 | https://github.com/python/typeshed/issues/8513 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fpull%2F8554 |
| https://github.com/AlexWaygood |
| AlexWaygood | https://github.com/AlexWaygood |
|
Aug 18, 2022
| https://github.com/python/typeshed/pull/8554#pullrequestreview-1077648942 |
|
View reviewed changes
| https://github.com/python/typeshed/pull/8554/files/d0e66990ce5e8aa357a8af7e9d433fb93ccfef2e |
| AlexWaygood | https://github.com/AlexWaygood |
| https://github.com/python/typeshed/pull/8554#pullrequestreview-1077648942 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/typeshed/pull/8554 |
| fix: add missing methods and use a type alias for exit code | https://github.com/python/typeshed/pull/8554/commits/dd8fa7b79ef0b6b2339233e978f8e9d4c51b614e |
| dd8fa7b | https://github.com/python/typeshed/pull/8554/commits/dd8fa7b79ef0b6b2339233e978f8e9d4c51b614e |
| https://github.com/kkirsche |
| kkirsche | https://github.com/kkirsche |
| Aug 18, 2022 | https://github.com/python/typeshed/pull/8554#issuecomment-1219687845 |
| Please reload this page | https://github.com/python/typeshed/pull/8554 |
| https://github.com/AlexWaygood |
| AlexWaygood | https://github.com/AlexWaygood |
|
Aug 18, 2022
| https://github.com/python/typeshed/pull/8554#pullrequestreview-1077658715 |
|
View reviewed changes
| https://github.com/python/typeshed/pull/8554/files/dd8fa7b79ef0b6b2339233e978f8e9d4c51b614e |
| stdlib/sys.pyi | https://github.com/python/typeshed/pull/8554/files/dd8fa7b79ef0b6b2339233e978f8e9d4c51b614e#diff-8a26c34ba1794e6179aeb96a6a43b17f39fa3080e4ff97ec20a591145e289cc1 |
| Please reload this page | https://github.com/python/typeshed/pull/8554 |
| August 18, 2022 12:22 | https://github.com/python/typeshed/pull/8554#commits-pushed-c6fc39a |
| fix: delete outdated comment | https://github.com/python/typeshed/pull/8554/commits/c6fc39ae8d46d0e17e4fa5fbe56c72d004780bd6 |
| c6fc39a | https://github.com/python/typeshed/pull/8554/commits/c6fc39ae8d46d0e17e4fa5fbe56c72d004780bd6 |
| fix: add rationale comment | https://github.com/python/typeshed/pull/8554/commits/b7a628202d3fb960ad5d423e195e02c7833dd61a |
| b7a6282 | https://github.com/python/typeshed/pull/8554/commits/b7a628202d3fb960ad5d423e195e02c7833dd61a |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fpull%2F8554 |
| https://github.com/AlexWaygood |
| AlexWaygood | https://github.com/AlexWaygood |
|
Aug 18, 2022
| https://github.com/python/typeshed/pull/8554#pullrequestreview-1077669695 |
|
View reviewed changes
| https://github.com/python/typeshed/pull/8554/files/b7a628202d3fb960ad5d423e195e02c7833dd61a |
| AlexWaygood | https://github.com/AlexWaygood |
| https://github.com/python/typeshed/pull/8554#pullrequestreview-1077669695 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/typeshed/pull/8554 |
| https://github.com/apps/github-actions |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fpull%2F8554 |
| https://github.com/kkirsche |
| kkirsche | https://github.com/kkirsche |
| Aug 18, 2022 | https://github.com/python/typeshed/pull/8554#issuecomment-1219698355 |
| Please reload this page | https://github.com/python/typeshed/pull/8554 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Aug 18, 2022 | https://github.com/python/typeshed/pull/8554#issuecomment-1219702845 |
| mypy_primer | https://github.com/hauntsaninja/mypy_primer |
| Please reload this page | https://github.com/python/typeshed/pull/8554 |
| https://github.com/AlexWaygood |
| AlexWaygood | https://github.com/AlexWaygood |
| b26c31a | https://github.com/python/typeshed/commit/b26c31a23c69fbfb3ef5c49280e392c6d6a8f411 |
| Aug 20, 2022 | https://github.com/python/typeshed/pull/8554#event-7226125009 |
| https://github.com/kkirsche |
| kkirsche | https://github.com/kkirsche |
| August 20, 2022 10:04 | https://github.com/python/typeshed/pull/8554#event-7226129511 |
| https://github.com/hauntsaninja |
| hauntsaninja | https://github.com/hauntsaninja |
|
Sep 26, 2022
| https://github.com/python/typeshed/pull/8554#ref-pullrequest-1386470458 |
|
Sync typeshed
python/mypy#13742
| https://github.com/python/mypy/pull/13742 |
| https://github.co/hiddenchars |
| https://github.com/python/typeshed/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fpull%2F8554 |
|
| https://github.com/AlexWaygood |
|
AlexWaygood
| https://github.com/AlexWaygood |
|
| https://github.com/python/typeshed/pull/8554/files/b7a628202d3fb960ad5d423e195e02c7833dd61a |
|
sys.exit and SystemExit
| https://github.com/python/typeshed/issues/8513 |
| Please reload this page | https://github.com/python/typeshed/pull/8554 |
|
| https://github.com/kkirsche |
|
| https://github.com/AlexWaygood |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |