René's URL Explorer Experiment


Title: ExceptionGroup: make it generic by JelleZijlstra · Pull Request #7626 · python/typeshed · GitHub

Open Graph Title: ExceptionGroup: make it generic by JelleZijlstra · Pull Request #7626 · python/typeshed

X Title: ExceptionGroup: make it generic by JelleZijlstra · Pull Request #7626 · python/typeshed

Description: See motivation in python/cpython#91549. I used the following tests: beg = BaseExceptionGroup("x", [SystemExit()]) assert_type(beg, BaseExceptionGroup[SystemExit]) assert_type(beg.exceptions, tuple[SystemExit | BaseExceptionGroup[SystemExit], ...]) assert_type( beg.subgroup(KeyboardInterrupt), BaseExceptionGroup[KeyboardInterrupt] | None ) assert_type( beg.subgroup((KeyboardInterrupt, SystemExit)), BaseExceptionGroup[KeyboardInterrupt | SystemExit] | None, ) assert_type( beg.split(KeyboardInterrupt), tuple[ BaseExceptionGroup[KeyboardInterrupt] | None, BaseExceptionGroup[SystemExit] | None, ], ) assert_type( beg.split((KeyboardInterrupt, SystemExit)), tuple[ BaseExceptionGroup[KeyboardInterrupt | SystemExit] | None, BaseExceptionGroup[SystemExit] | None, ], ) eg = ExceptionGroup("x", [ValueError(), KeyError()]) assert_type(eg, ExceptionGroup[ValueError | KeyError]) assert_type( eg.exceptions, tuple[ValueError | KeyError | ExceptionGroup[ValueError | KeyError], ...], ) These all pass in pyright, but mypy for some reason fails on a lot of the split and subgroup calls, with errors like samples/exceptiongroup.py:107: error: Expression is of type "Optional[BaseExceptionGroup[Any]]", not "Optional[BaseExceptionGroup[KeyboardInterrupt]]". Seems like a bug. The overloads I added trade precision in the generic argument against precision in the generic type itself. If you have a subclass ChildExceptionGroup(ExceptionGroup) and call .split(SomeException) on it, you get an ExceptionGroup[SomeException] from the type checker, though at runtime you'd get a ChildExceptionGroup[SomeException]. I think that's the right tradeoff because subclassing ExceptionGroup is likely to be rare.

Open Graph Description: See motivation in python/cpython#91549. I used the following tests: beg = BaseExceptionGroup("x", [SystemExit()]) assert_type(beg, BaseExceptionGroup[SystemExit]) assert_type(beg.exceptio...

X Description: See motivation in python/cpython#91549. I used the following tests: beg = BaseExceptionGroup("x", [SystemExit()]) assert_type(beg, BaseExceptionGroup[SystemExit]) assert_type(beg....

Opengraph URL: https://github.com/python/typeshed/pull/7626

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f8d78a61-5b40-28b2-f977-dd61aa88d66e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD970:2463C6:6CFB25:91BA71:6B003868
html-safe-nonce76f57ce8be7db0bdd8f911159c7812906db7aa49fb48cf73232a8ae17b9ec33a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOTcwOjI0NjNDNjo2Q0ZCMjU6OTFCQTcxOjZCMDAzODY4IiwidmlzaXRvcl9pZCI6IjM4OTk0NDIxMDE2NDkxNjAyOTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac43334b1ce614501dd928c95fd551ee5f658bc9e3e583d345b87a45bc6816c70e
hovercard-subject-tagpull_request:910503512
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/typeshed/pull/7626/files
twitter:imagehttps://avatars.githubusercontent.com/u/906600?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/906600?s=400&v=4
og:image:altSee motivation in python/cpython#91549. I used the following tests: beg = BaseExceptionGroup("x", [SystemExit()]) assert_type(beg, BaseExceptionGroup[SystemExit]) assert_type(beg.exceptio...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/typeshed git https://github.com/python/typeshed.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id31696383
octolytics-dimension-repository_nwopython/typeshed
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id31696383
octolytics-dimension-repository_network_root_nwopython/typeshed
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/typeshed/pull/7626/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fpull%2F7626%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fpull%2F7626%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Ftypeshed
Reloadhttps://github.com/python/typeshed/pull/7626/files
Reloadhttps://github.com/python/typeshed/pull/7626/files
Reloadhttps://github.com/python/typeshed/pull/7626/files
pythonhttps://github.com/python
typeshedhttps://github.com/python/typeshed
Codehttps://github.com/python/typeshed
Issues196 (196)https://github.com/python/typeshed/issues
Pull requests252 (252)https://github.com/python/typeshed/pulls
Actionshttps://github.com/python/typeshed/actions
Security and qualityhttps://github.com/python/typeshed/security
Insightshttps://github.com/python/typeshed/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Ftypeshed%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Ftypeshed%2Fissues%2Fnew%2Fchoose
srittauhttps://github.com/srittau
python:masterhttps://github.com/python/typeshed/tree/master
JelleZijlstra:genericeghttps://github.com/JelleZijlstra/typeshed/tree/genericeg
Conversation 10 https://github.com/python/typeshed/pull/7626
Commits 3 https://github.com/python/typeshed/pull/7626/commits
Checks 0 https://github.com/python/typeshed/pull/7626/checks
Files changed https://github.com/python/typeshed/pull/7626/files
Please reload this pagehttps://github.com/python/typeshed/pull/7626/files
ExceptionGroup: make it generic https://github.com/python/typeshed/pull/7626/files#top
Show all changes 3 commits https://github.com/python/typeshed/pull/7626/files
cd608d4 ExceptionGroup: make it generic JelleZijlstra Apr 15, 2022 https://github.com/python/typeshed/pull/7626/commits/cd608d4256cf00b52e4aeaba07b0eaead4193dbb
f07aec0 type ignore JelleZijlstra Apr 15, 2022 https://github.com/python/typeshed/pull/7626/commits/f07aec03162210ba66cb9806b2a594d7c3f5127b
4ce70e3 who needs Union JelleZijlstra Apr 15, 2022 https://github.com/python/typeshed/pull/7626/commits/4ce70e3a27fa178ad722e0d9605293628a5d201c
Clear filters https://github.com/python/typeshed/pull/7626/files
Please reload this pagehttps://github.com/python/typeshed/pull/7626/files
Please reload this pagehttps://github.com/python/typeshed/pull/7626/files
stdlib/builtins.pyihttps://github.com/python/typeshed/pull/7626/files#diff-1580ddf7dc331234b0845ffb953b6f7a5f1e9afa15048ebc0762226a08f194b4
View file https://github.com/JelleZijlstra/typeshed/blob/4ce70e3a27fa178ad722e0d9605293628a5d201c/stdlib/builtins.pyi
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typeshed/pull/7626/{{ revealButtonHref }}
https://github.com/python/typeshed/pull/7626/files#diff-1580ddf7dc331234b0845ffb953b6f7a5f1e9afa15048ebc0762226a08f194b4
https://github.com/python/typeshed/pull/7626/files#diff-1580ddf7dc331234b0845ffb953b6f7a5f1e9afa15048ebc0762226a08f194b4
https://github.com/python/typeshed/pull/7626/files#diff-1580ddf7dc331234b0845ffb953b6f7a5f1e9afa15048ebc0762226a08f194b4
srittauhttps://github.com/srittau
Apr 15, 2022https://github.com/python/typeshed/pull/7626/files#r851193413
Please reload this pagehttps://github.com/python/typeshed/pull/7626/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/typeshed/pull/7626/files
JelleZijlstrahttps://github.com/JelleZijlstra
Apr 15, 2022https://github.com/python/typeshed/pull/7626/files#r851270086
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/typeshed/pull/7626/files
srittauhttps://github.com/srittau
Apr 15, 2022https://github.com/python/typeshed/pull/7626/files#r851195877
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/typeshed/pull/7626/files
AlexWaygoodhttps://github.com/AlexWaygood
Apr 15, 2022https://github.com/python/typeshed/pull/7626/files#r851198023
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
python/typing#548https://github.com/python/typing/issues/548
Please reload this pagehttps://github.com/python/typeshed/pull/7626/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.