René's URL Explorer Experiment


Title: pygments: Correct Formatter generics by not-my-profile · Pull Request #7435 · python/typeshed · GitHub

Open Graph Title: pygments: Correct Formatter generics by not-my-profile · Pull Request #7435 · python/typeshed

X Title: pygments: Correct Formatter generics by not-my-profile · Pull Request #7435 · python/typeshed

Description: 933fec0 made pygments.formatter.Formatter generic to improve the type-safety of pygments.format() and pygments.highlight(). The actual pygments.formatter.Formatter however is not generic, meaning that pygments.formatter.Formatter[str] should not type check (since it leads to a runtime type error). Furthermore the pygments ImageFormatter always expects BinaryIO, no matter which constructor arguments are passed. This commit addresses both problems.

Open Graph Description: 933fec0 made pygments.formatter.Formatter generic to improve the type-safety of pygments.format() and pygments.highlight(). The actual pygments.formatter.Formatter however is not generic, meaning t...

X Description: 933fec0 made pygments.formatter.Formatter generic to improve the type-safety of pygments.format() and pygments.highlight(). The actual pygments.formatter.Formatter however is not generic, meaning t...

Opengraph URL: https://github.com/python/typeshed/pull/7435

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8687b3e7-661f-5647-09ae-70eb735180e6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE468:3A13A0:22BD9C2:2F23C97:6B002958
html-safe-nonceabc3723351431d3b78e6383718670a225dbc2ee39e4e43cd4f007cc17372408c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNDY4OjNBMTNBMDoyMkJEOUMyOjJGMjNDOTc6NkIwMDI5NTgiLCJ2aXNpdG9yX2lkIjoiMjQ0MDE0MDM4MDU4NzQzNjM3NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac98fbe6530e854ff63ccb50ec9b7b33dbddf207a7d276871680ea68ad0f8d840a
hovercard-subject-tagpull_request:871396968
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/typeshed/pull/7435/files
twitter:imagehttps://avatars.githubusercontent.com/u/73739153?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/73739153?s=400&v=4
og:image:alt933fec0 made pygments.formatter.Formatter generic to improve the type-safety of pygments.format() and pygments.highlight(). The actual pygments.formatter.Formatter however is not generic, meaning t...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/typeshed git https://github.com/python/typeshed.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id31696383
octolytics-dimension-repository_nwopython/typeshed
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id31696383
octolytics-dimension-repository_network_root_nwopython/typeshed
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/typeshed/pull/7435/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fpull%2F7435%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fpull%2F7435%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Ftypeshed
Reloadhttps://github.com/python/typeshed/pull/7435/files
Reloadhttps://github.com/python/typeshed/pull/7435/files
Reloadhttps://github.com/python/typeshed/pull/7435/files
pythonhttps://github.com/python
typeshedhttps://github.com/python/typeshed
Codehttps://github.com/python/typeshed
Issues196 (196)https://github.com/python/typeshed/issues
Pull requests251 (251)https://github.com/python/typeshed/pulls
Actionshttps://github.com/python/typeshed/actions
Security and qualityhttps://github.com/python/typeshed/security
Insightshttps://github.com/python/typeshed/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Ftypeshed%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Ftypeshed%2Fissues%2Fnew%2Fchoose
not-my-profilehttps://github.com/not-my-profile
python:masterhttps://github.com/python/typeshed/tree/master
not-my-profile:fix-pygmentshttps://github.com/not-my-profile/typeshed/tree/fix-pygments
Conversation 6 https://github.com/python/typeshed/pull/7435
Commits 1 https://github.com/python/typeshed/pull/7435/commits
Checks 0 https://github.com/python/typeshed/pull/7435/checks
Files changed https://github.com/python/typeshed/pull/7435/files
Please reload this pagehttps://github.com/python/typeshed/pull/7435/files
pygments: Correct Formatter generics https://github.com/python/typeshed/pull/7435/files#top
Show all changes 1 commit https://github.com/python/typeshed/pull/7435/files
d24f07c pygments: Correct Formatter generics not-my-profile Mar 4, 2022 https://github.com/python/typeshed/pull/7435/commits/d24f07c9a620a331c025747ba9f7d5b87a0ddc78
Clear filters https://github.com/python/typeshed/pull/7435/files
Please reload this pagehttps://github.com/python/typeshed/pull/7435/files
Please reload this pagehttps://github.com/python/typeshed/pull/7435/files
__init__.pyi https://github.com/python/typeshed/pull/7435/files#diff-3a9ca18c518f4f4c78317e7546c24741a32180e6054334aee4d7de55b37e1167
formatter.pyi https://github.com/python/typeshed/pull/7435/files#diff-5a70647751feca544eff381f0422f492b96b53924fbf77bc933e88ce9e666268
__init__.pyi https://github.com/python/typeshed/pull/7435/files#diff-f653b35b5b4b560300d90712ae13f2e7d9db96fec2af3082448ee97c32c444cb
bbcode.pyi https://github.com/python/typeshed/pull/7435/files#diff-a4ee6709a0eb70aac4d703bed8877b3e0c0166dd9735f30618ace5e01593a37c
html.pyi https://github.com/python/typeshed/pull/7435/files#diff-3c13f2f0fa80fad101617ece98401fc709c58f1cbf5b7b7d5b358d48c7e445b2
img.pyi https://github.com/python/typeshed/pull/7435/files#diff-c92bac0a3fe2ecc96ef0a2f82a81ad60e10a6a29e81c66c82b498f8d819c09df
irc.pyi https://github.com/python/typeshed/pull/7435/files#diff-acc89e10627ae7e1dbe05a5a40f82da3dcbbb9240dec4f29e814b124e0a188ce
latex.pyi https://github.com/python/typeshed/pull/7435/files#diff-22faaf67ff9de5f489ae891c5cfab0b38bf8257d43d5b717ded902e4cdb9fb54
other.pyi https://github.com/python/typeshed/pull/7435/files#diff-6d8886798d9a906ce70fb49df21261cb7b7160da4fd4d6cc871d6940883d505c
pangomarkup.pyi https://github.com/python/typeshed/pull/7435/files#diff-cbd95ee7378b065e9b0da328ce23cb63b62f6952318cd30788e241940aa53c24
rtf.pyi https://github.com/python/typeshed/pull/7435/files#diff-33bda30dd7cb67490a3b92dfb1ab47b10bf85616d457db50cb35c00ac1703cd9
svg.pyi https://github.com/python/typeshed/pull/7435/files#diff-a5c41e2d3311ac8d0088bee35decf7c0ed5385c78d46905f3bee52fbfef6cb11
terminal.pyi https://github.com/python/typeshed/pull/7435/files#diff-5216ad2f1c242f7dd65944e37a73fe7dc0851b4d72965a496fe080f6e9c84cd1
terminal256.pyi https://github.com/python/typeshed/pull/7435/files#diff-557d3fb5951010f8083111a36efe3cf734ce09547c1cb2a3fafb9b4b0f9eb64c
plugin.pyi https://github.com/python/typeshed/pull/7435/files#diff-215dceecef7810c964882978e7b97f993577f9752d6b127a010d470c73d0d0c0
stubs/Pygments/pygments/__init__.pyihttps://github.com/python/typeshed/pull/7435/files#diff-3a9ca18c518f4f4c78317e7546c24741a32180e6054334aee4d7de55b37e1167
View file https://github.com/not-my-profile/typeshed/blob/d24f07c9a620a331c025747ba9f7d5b87a0ddc78/stubs/Pygments/pygments/__init__.pyi
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typeshed/pull/7435/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/typeshed/pull/7435/files
stubs/Pygments/pygments/formatter.pyihttps://github.com/python/typeshed/pull/7435/files#diff-5a70647751feca544eff381f0422f492b96b53924fbf77bc933e88ce9e666268
View file https://github.com/not-my-profile/typeshed/blob/d24f07c9a620a331c025747ba9f7d5b87a0ddc78/stubs/Pygments/pygments/formatter.pyi
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typeshed/pull/7435/{{ revealButtonHref }}
https://github.com/python/typeshed/pull/7435/files#diff-5a70647751feca544eff381f0422f492b96b53924fbf77bc933e88ce9e666268
stubs/Pygments/pygments/formatters/__init__.pyihttps://github.com/python/typeshed/pull/7435/files#diff-f653b35b5b4b560300d90712ae13f2e7d9db96fec2af3082448ee97c32c444cb
View file https://github.com/not-my-profile/typeshed/blob/d24f07c9a620a331c025747ba9f7d5b87a0ddc78/stubs/Pygments/pygments/formatters/__init__.pyi
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typeshed/pull/7435/{{ revealButtonHref }}
https://github.com/python/typeshed/pull/7435/files#diff-f653b35b5b4b560300d90712ae13f2e7d9db96fec2af3082448ee97c32c444cb
stubs/Pygments/pygments/formatters/bbcode.pyihttps://github.com/python/typeshed/pull/7435/files#diff-a4ee6709a0eb70aac4d703bed8877b3e0c0166dd9735f30618ace5e01593a37c
View file https://github.com/not-my-profile/typeshed/blob/d24f07c9a620a331c025747ba9f7d5b87a0ddc78/stubs/Pygments/pygments/formatters/bbcode.pyi
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typeshed/pull/7435/{{ revealButtonHref }}
https://github.com/python/typeshed/pull/7435/files#diff-a4ee6709a0eb70aac4d703bed8877b3e0c0166dd9735f30618ace5e01593a37c
stubs/Pygments/pygments/formatters/html.pyihttps://github.com/python/typeshed/pull/7435/files#diff-3c13f2f0fa80fad101617ece98401fc709c58f1cbf5b7b7d5b358d48c7e445b2
View file https://github.com/not-my-profile/typeshed/blob/d24f07c9a620a331c025747ba9f7d5b87a0ddc78/stubs/Pygments/pygments/formatters/html.pyi
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typeshed/pull/7435/{{ revealButtonHref }}
https://github.com/python/typeshed/pull/7435/files#diff-3c13f2f0fa80fad101617ece98401fc709c58f1cbf5b7b7d5b358d48c7e445b2
stubs/Pygments/pygments/formatters/img.pyihttps://github.com/python/typeshed/pull/7435/files#diff-c92bac0a3fe2ecc96ef0a2f82a81ad60e10a6a29e81c66c82b498f8d819c09df
View file https://github.com/not-my-profile/typeshed/blob/d24f07c9a620a331c025747ba9f7d5b87a0ddc78/stubs/Pygments/pygments/formatters/img.pyi
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typeshed/pull/7435/{{ revealButtonHref }}
https://github.com/python/typeshed/pull/7435/files#diff-c92bac0a3fe2ecc96ef0a2f82a81ad60e10a6a29e81c66c82b498f8d819c09df
https://github.com/python/typeshed/pull/7435/files#diff-c92bac0a3fe2ecc96ef0a2f82a81ad60e10a6a29e81c66c82b498f8d819c09df
https://github.com/python/typeshed/pull/7435/files#diff-c92bac0a3fe2ecc96ef0a2f82a81ad60e10a6a29e81c66c82b498f8d819c09df
https://github.com/python/typeshed/pull/7435/files#diff-c92bac0a3fe2ecc96ef0a2f82a81ad60e10a6a29e81c66c82b498f8d819c09df
stubs/Pygments/pygments/formatters/irc.pyihttps://github.com/python/typeshed/pull/7435/files#diff-acc89e10627ae7e1dbe05a5a40f82da3dcbbb9240dec4f29e814b124e0a188ce
View file https://github.com/not-my-profile/typeshed/blob/d24f07c9a620a331c025747ba9f7d5b87a0ddc78/stubs/Pygments/pygments/formatters/irc.pyi
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typeshed/pull/7435/{{ revealButtonHref }}
https://github.com/python/typeshed/pull/7435/files#diff-acc89e10627ae7e1dbe05a5a40f82da3dcbbb9240dec4f29e814b124e0a188ce
stubs/Pygments/pygments/formatters/latex.pyihttps://github.com/python/typeshed/pull/7435/files#diff-22faaf67ff9de5f489ae891c5cfab0b38bf8257d43d5b717ded902e4cdb9fb54
View file https://github.com/not-my-profile/typeshed/blob/d24f07c9a620a331c025747ba9f7d5b87a0ddc78/stubs/Pygments/pygments/formatters/latex.pyi
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typeshed/pull/7435/{{ revealButtonHref }}
https://github.com/python/typeshed/pull/7435/files#diff-22faaf67ff9de5f489ae891c5cfab0b38bf8257d43d5b717ded902e4cdb9fb54
stubs/Pygments/pygments/formatters/other.pyihttps://github.com/python/typeshed/pull/7435/files#diff-6d8886798d9a906ce70fb49df21261cb7b7160da4fd4d6cc871d6940883d505c
View file https://github.com/not-my-profile/typeshed/blob/d24f07c9a620a331c025747ba9f7d5b87a0ddc78/stubs/Pygments/pygments/formatters/other.pyi
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typeshed/pull/7435/{{ revealButtonHref }}
https://github.com/python/typeshed/pull/7435/files#diff-6d8886798d9a906ce70fb49df21261cb7b7160da4fd4d6cc871d6940883d505c
stubs/Pygments/pygments/formatters/pangomarkup.pyihttps://github.com/python/typeshed/pull/7435/files#diff-cbd95ee7378b065e9b0da328ce23cb63b62f6952318cd30788e241940aa53c24
View file https://github.com/not-my-profile/typeshed/blob/d24f07c9a620a331c025747ba9f7d5b87a0ddc78/stubs/Pygments/pygments/formatters/pangomarkup.pyi
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typeshed/pull/7435/{{ revealButtonHref }}
https://github.com/python/typeshed/pull/7435/files#diff-cbd95ee7378b065e9b0da328ce23cb63b62f6952318cd30788e241940aa53c24
stubs/Pygments/pygments/formatters/rtf.pyihttps://github.com/python/typeshed/pull/7435/files#diff-33bda30dd7cb67490a3b92dfb1ab47b10bf85616d457db50cb35c00ac1703cd9
View file https://github.com/not-my-profile/typeshed/blob/d24f07c9a620a331c025747ba9f7d5b87a0ddc78/stubs/Pygments/pygments/formatters/rtf.pyi
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typeshed/pull/7435/{{ revealButtonHref }}
https://github.com/python/typeshed/pull/7435/files#diff-33bda30dd7cb67490a3b92dfb1ab47b10bf85616d457db50cb35c00ac1703cd9
stubs/Pygments/pygments/formatters/svg.pyihttps://github.com/python/typeshed/pull/7435/files#diff-a5c41e2d3311ac8d0088bee35decf7c0ed5385c78d46905f3bee52fbfef6cb11
View file https://github.com/not-my-profile/typeshed/blob/d24f07c9a620a331c025747ba9f7d5b87a0ddc78/stubs/Pygments/pygments/formatters/svg.pyi
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typeshed/pull/7435/{{ revealButtonHref }}
https://github.com/python/typeshed/pull/7435/files#diff-a5c41e2d3311ac8d0088bee35decf7c0ed5385c78d46905f3bee52fbfef6cb11
stubs/Pygments/pygments/formatters/terminal.pyihttps://github.com/python/typeshed/pull/7435/files#diff-5216ad2f1c242f7dd65944e37a73fe7dc0851b4d72965a496fe080f6e9c84cd1
View file https://github.com/not-my-profile/typeshed/blob/d24f07c9a620a331c025747ba9f7d5b87a0ddc78/stubs/Pygments/pygments/formatters/terminal.pyi
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typeshed/pull/7435/{{ revealButtonHref }}
https://github.com/python/typeshed/pull/7435/files#diff-5216ad2f1c242f7dd65944e37a73fe7dc0851b4d72965a496fe080f6e9c84cd1
stubs/Pygments/pygments/formatters/terminal256.pyihttps://github.com/python/typeshed/pull/7435/files#diff-557d3fb5951010f8083111a36efe3cf734ce09547c1cb2a3fafb9b4b0f9eb64c
View file https://github.com/not-my-profile/typeshed/blob/d24f07c9a620a331c025747ba9f7d5b87a0ddc78/stubs/Pygments/pygments/formatters/terminal256.pyi
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typeshed/pull/7435/{{ revealButtonHref }}
https://github.com/python/typeshed/pull/7435/files#diff-557d3fb5951010f8083111a36efe3cf734ce09547c1cb2a3fafb9b4b0f9eb64c
https://github.com/python/typeshed/pull/7435/files#diff-557d3fb5951010f8083111a36efe3cf734ce09547c1cb2a3fafb9b4b0f9eb64c
stubs/Pygments/pygments/plugin.pyihttps://github.com/python/typeshed/pull/7435/files#diff-215dceecef7810c964882978e7b97f993577f9752d6b127a010d470c73d0d0c0
View file https://github.com/not-my-profile/typeshed/blob/d24f07c9a620a331c025747ba9f7d5b87a0ddc78/stubs/Pygments/pygments/plugin.pyi
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typeshed/pull/7435/{{ revealButtonHref }}
https://github.com/python/typeshed/pull/7435/files#diff-215dceecef7810c964882978e7b97f993577f9752d6b127a010d470c73d0d0c0
https://github.com/python/typeshed/pull/7435/files#diff-215dceecef7810c964882978e7b97f993577f9752d6b127a010d470c73d0d0c0
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.