René's URL Explorer Experiment


Title: Improve open overloads when mode is a literal union by hauntsaninja · Pull Request #7428 · python/typeshed · GitHub

Open Graph Title: Improve open overloads when mode is a literal union by hauntsaninja · Pull Request #7428 · python/typeshed

X Title: Improve open overloads when mode is a literal union by hauntsaninja · Pull Request #7428 · python/typeshed

Description: As pointed out by @gvanrossum in python/typing#1096 Improves type inference in cases when we know that mode is OpenBinaryMode, but don't know anything more specific: def my_open(name: str, write: bool): mode: Literal['rb', 'wb'] = 'wb' if write else 'rb' with open(name, mode) as f: reveal_type(f) # previously typing.IO[Any], now typing.BinaryIO You may be tempted into thinking this is some limitation of type checkers. mypy does in fact have logic for detecting if we match multiple overloads and union-ing up the return types of matched overloads. The problem is the last overload interferes with this logic. That is, if you remove the fallback overload (prior to this PR), you'd get Union[io.BufferedReader, io.BufferedWriter] in the above example.

Open Graph Description: As pointed out by @gvanrossum in python/typing#1096 Improves type inference in cases when we know that mode is OpenBinaryMode, but don't know anything more specific: def my_open(name: str, writ...

X Description: As pointed out by @gvanrossum in python/typing#1096 Improves type inference in cases when we know that mode is OpenBinaryMode, but don't know anything more specific: def my_open(name: str, ...

Opengraph URL: https://github.com/python/typeshed/pull/7428

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:5a2bf230-69f1-dac8-a6c2-3c6c09785554
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA80A:1AEC58:5141CC:6CD4F0:6B003035
html-safe-noncea86afc9c25a6a61d83168f896f2f5815c7509c9fe4c2b8db6374ba345f6da931
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBODBBOjFBRUM1ODo1MTQxQ0M6NkNENEYwOjZCMDAzMDM1IiwidmlzaXRvcl9pZCI6IjEwNDU2NTM4NDc3ODA4OTY4MjEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaca9e47333f331e70490eaec68913a2a8a0baec37e0e6dcf660681d5aa8a8e8bb7
hovercard-subject-tagpull_request:870060185
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/typeshed/pull/7428/files
twitter:imagehttps://avatars.githubusercontent.com/u/12621235?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/12621235?s=400&v=4
og:image:altAs pointed out by @gvanrossum in python/typing#1096 Improves type inference in cases when we know that mode is OpenBinaryMode, but don't know anything more specific: def my_open(name: str, writ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/typeshed git https://github.com/python/typeshed.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id31696383
octolytics-dimension-repository_nwopython/typeshed
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id31696383
octolytics-dimension-repository_network_root_nwopython/typeshed
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/typeshed/pull/7428/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fpull%2F7428%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fpull%2F7428%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Ftypeshed
Reloadhttps://github.com/python/typeshed/pull/7428/files
Reloadhttps://github.com/python/typeshed/pull/7428/files
Reloadhttps://github.com/python/typeshed/pull/7428/files
pythonhttps://github.com/python
typeshedhttps://github.com/python/typeshed
Codehttps://github.com/python/typeshed
Issues196 (196)https://github.com/python/typeshed/issues
Pull requests251 (251)https://github.com/python/typeshed/pulls
Actionshttps://github.com/python/typeshed/actions
Security and qualityhttps://github.com/python/typeshed/security
Insightshttps://github.com/python/typeshed/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Ftypeshed%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Ftypeshed%2Fissues%2Fnew%2Fchoose
JelleZijlstrahttps://github.com/JelleZijlstra
python:masterhttps://github.com/python/typeshed/tree/master
hauntsaninja:litopenhttps://github.com/hauntsaninja/typeshed/tree/litopen
Conversation 5 https://github.com/python/typeshed/pull/7428
Commits 1 https://github.com/python/typeshed/pull/7428/commits
Checks 0 https://github.com/python/typeshed/pull/7428/checks
Files changed https://github.com/python/typeshed/pull/7428/files
Please reload this pagehttps://github.com/python/typeshed/pull/7428/files
Improve open overloads when mode is a literal union https://github.com/python/typeshed/pull/7428/files#top
Show all changes 1 commit https://github.com/python/typeshed/pull/7428/files
43223af Improve open overloads when mode is a literal union Mar 2, 2022 https://github.com/python/typeshed/pull/7428/commits/43223af702d95a2cdf71cad016f87a05fbcd8c9e
Clear filters https://github.com/python/typeshed/pull/7428/files
Please reload this pagehttps://github.com/python/typeshed/pull/7428/files
Please reload this pagehttps://github.com/python/typeshed/pull/7428/files
builtins.pyi https://github.com/python/typeshed/pull/7428/files#diff-1580ddf7dc331234b0845ffb953b6f7a5f1e9afa15048ebc0762226a08f194b4
abc.pyi https://github.com/python/typeshed/pull/7428/files#diff-775f90ef97a25889ac05563e312b06993a6bdf175d458e5eaa780c9ca6597be2
__init__.pyi https://github.com/python/typeshed/pull/7428/files#diff-91e377a60a2f13de8cb7afa7175f7d39d94e2dbc7cde9990835cc7c41d7ee4a8
pathlib.pyi https://github.com/python/typeshed/pull/7428/files#diff-b5aebc9806d203cfe171e2215b0b4f3106395fc59687382eb9276d7d8976bffd
__init__.pyi https://github.com/python/typeshed/pull/7428/files#diff-e429b5014919df036be5eb384647768f45b555a7d877f2d761e1822c8f2dea3e
stdlib/builtins.pyihttps://github.com/python/typeshed/pull/7428/files#diff-1580ddf7dc331234b0845ffb953b6f7a5f1e9afa15048ebc0762226a08f194b4
View file https://github.com/hauntsaninja/typeshed/blob/43223af702d95a2cdf71cad016f87a05fbcd8c9e/stdlib/builtins.pyi
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typeshed/pull/7428/{{ revealButtonHref }}
https://github.com/python/typeshed/pull/7428/files#diff-1580ddf7dc331234b0845ffb953b6f7a5f1e9afa15048ebc0762226a08f194b4
https://github.com/python/typeshed/pull/7428/files#diff-1580ddf7dc331234b0845ffb953b6f7a5f1e9afa15048ebc0762226a08f194b4
stdlib/importlib/abc.pyihttps://github.com/python/typeshed/pull/7428/files#diff-775f90ef97a25889ac05563e312b06993a6bdf175d458e5eaa780c9ca6597be2
View file https://github.com/hauntsaninja/typeshed/blob/43223af702d95a2cdf71cad016f87a05fbcd8c9e/stdlib/importlib/abc.pyi
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typeshed/pull/7428/{{ revealButtonHref }}
https://github.com/python/typeshed/pull/7428/files#diff-775f90ef97a25889ac05563e312b06993a6bdf175d458e5eaa780c9ca6597be2
https://github.com/python/typeshed/pull/7428/files#diff-775f90ef97a25889ac05563e312b06993a6bdf175d458e5eaa780c9ca6597be2
stdlib/os/__init__.pyihttps://github.com/python/typeshed/pull/7428/files#diff-91e377a60a2f13de8cb7afa7175f7d39d94e2dbc7cde9990835cc7c41d7ee4a8
View file https://github.com/hauntsaninja/typeshed/blob/43223af702d95a2cdf71cad016f87a05fbcd8c9e/stdlib/os/__init__.pyi
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typeshed/pull/7428/{{ revealButtonHref }}
https://github.com/python/typeshed/pull/7428/files#diff-91e377a60a2f13de8cb7afa7175f7d39d94e2dbc7cde9990835cc7c41d7ee4a8
https://github.com/python/typeshed/pull/7428/files#diff-91e377a60a2f13de8cb7afa7175f7d39d94e2dbc7cde9990835cc7c41d7ee4a8
stdlib/pathlib.pyihttps://github.com/python/typeshed/pull/7428/files#diff-b5aebc9806d203cfe171e2215b0b4f3106395fc59687382eb9276d7d8976bffd
View file https://github.com/hauntsaninja/typeshed/blob/43223af702d95a2cdf71cad016f87a05fbcd8c9e/stdlib/pathlib.pyi
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typeshed/pull/7428/{{ revealButtonHref }}
https://github.com/python/typeshed/pull/7428/files#diff-b5aebc9806d203cfe171e2215b0b4f3106395fc59687382eb9276d7d8976bffd
https://github.com/python/typeshed/pull/7428/files#diff-b5aebc9806d203cfe171e2215b0b4f3106395fc59687382eb9276d7d8976bffd
stubs/aiofiles/aiofiles/threadpool/__init__.pyihttps://github.com/python/typeshed/pull/7428/files#diff-e429b5014919df036be5eb384647768f45b555a7d877f2d761e1822c8f2dea3e
View file https://github.com/hauntsaninja/typeshed/blob/43223af702d95a2cdf71cad016f87a05fbcd8c9e/stubs/aiofiles/aiofiles/threadpool/__init__.pyi
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typeshed/pull/7428/{{ revealButtonHref }}
https://github.com/python/typeshed/pull/7428/files#diff-e429b5014919df036be5eb384647768f45b555a7d877f2d761e1822c8f2dea3e
https://github.com/python/typeshed/pull/7428/files#diff-e429b5014919df036be5eb384647768f45b555a7d877f2d761e1822c8f2dea3e
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.