René's URL Explorer Experiment


Title: Bring `_collections_abc` closer to runtime definition by AlexWaygood · Pull Request #6312 · python/typeshed · GitHub

Open Graph Title: Bring `_collections_abc` closer to runtime definition by AlexWaygood · Pull Request #6312 · python/typeshed

X Title: Bring `_collections_abc` closer to runtime definition by AlexWaygood · Pull Request #6312 · python/typeshed

Description: Currently, the following code succeeds at runtime, but fails mypy: from _collections_abc import dict_keys This PR proposes bringing the _collections_abc stub closer to its runtime definition by moving the definitions of dict_keys, dict_values and dict_items from builtins to _collections_abc. I have also added @final to these classes, as they cannot be subclassed at runtime, and added # type: ignore comments to _OrderedDictKeysView/_OrderedDictValuesView/_OrderedDictItemsView. (These are indeed subclasses of dict_keys/dict_values/dict_items, even though the three classes cannot be subclassed at runtime; see #6299.)

Open Graph Description: Currently, the following code succeeds at runtime, but fails mypy: from _collections_abc import dict_keys This PR proposes bringing the _collections_abc stub closer to its runtime definition by mov...

X Description: Currently, the following code succeeds at runtime, but fails mypy: from _collections_abc import dict_keys This PR proposes bringing the _collections_abc stub closer to its runtime definition by mov...

Opengraph URL: https://github.com/python/typeshed/pull/6312

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:47b1a37e-e842-a98b-e9db-5383cf6d0321
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA2D2:142FA7:3E690C:54235A:6B002A9D
html-safe-noncec030a2de51ff90f3307e3e1962096a464b316a6198b6c4de8180935d4680ccee
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMkQyOjE0MkZBNzozRTY5MEM6NTQyMzVBOjZCMDAyQTlEIiwidmlzaXRvcl9pZCI6IjY3OTQ1NjIwOTI4MjIxNzg0NjEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac702565524247d7516a785a015a6539151d427ce52ad2194c2bee0ac5d1278826
hovercard-subject-tagpull_request:781751465
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/typeshed/pull/6312/files
twitter:imagehttps://avatars.githubusercontent.com/u/66076021?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/66076021?s=400&v=4
og:image:altCurrently, the following code succeeds at runtime, but fails mypy: from _collections_abc import dict_keys This PR proposes bringing the _collections_abc stub closer to its runtime definition by mov...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/typeshed git https://github.com/python/typeshed.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id31696383
octolytics-dimension-repository_nwopython/typeshed
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id31696383
octolytics-dimension-repository_network_root_nwopython/typeshed
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/typeshed/pull/6312/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fpull%2F6312%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fpull%2F6312%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Ftypeshed
Reloadhttps://github.com/python/typeshed/pull/6312/files
Reloadhttps://github.com/python/typeshed/pull/6312/files
Reloadhttps://github.com/python/typeshed/pull/6312/files
pythonhttps://github.com/python
typeshedhttps://github.com/python/typeshed
Codehttps://github.com/python/typeshed
Issues196 (196)https://github.com/python/typeshed/issues
Pull requests251 (251)https://github.com/python/typeshed/pulls
Actionshttps://github.com/python/typeshed/actions
Security and qualityhttps://github.com/python/typeshed/security
Insightshttps://github.com/python/typeshed/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Ftypeshed%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Ftypeshed%2Fissues%2Fnew%2Fchoose
JelleZijlstrahttps://github.com/JelleZijlstra
python:masterhttps://github.com/python/typeshed/tree/master
AlexWaygood:dict-iteratorshttps://github.com/AlexWaygood/typeshed/tree/dict-iterators
Conversation 20 https://github.com/python/typeshed/pull/6312
Commits 7 https://github.com/python/typeshed/pull/6312/commits
Checks 0 https://github.com/python/typeshed/pull/6312/checks
Files changed https://github.com/python/typeshed/pull/6312/files
Please reload this pagehttps://github.com/python/typeshed/pull/6312/files
Bring _collections_abc closer to runtime definition https://github.com/python/typeshed/pull/6312/files#top
Show all changes 7 commits https://github.com/python/typeshed/pull/6312/files
188cea2 Bring `_collections_abc` closer to runtime definition AlexWaygood Nov 16, 2021 https://github.com/python/typeshed/pull/6312/commits/188cea2e5fb79b9f5516a0c0375beb8556198468
f08a1f9 Fix CI AlexWaygood Nov 16, 2021 https://github.com/python/typeshed/pull/6312/commits/f08a1f94f40f717bb86537c8bc8a13a87baf3389
a439d4d Remove unused imports AlexWaygood Nov 16, 2021 https://github.com/python/typeshed/pull/6312/commits/a439d4d5900aea357e31eec44bd51777f84db038
1875503 This is what I get for running 3.10 AlexWaygood Nov 16, 2021 https://github.com/python/typeshed/pull/6312/commits/1875503c74d866c7991e2dc34beb3f5c9dbe19f6
0655bef Tweak AlexWaygood Nov 16, 2021 https://github.com/python/typeshed/pull/6312/commits/0655befc977e2de80b44ff09787adf7f12a19401
d7191ba Remove unneeded `TypeVar`s from builtins AlexWaygood Nov 16, 2021 https://github.com/python/typeshed/pull/6312/commits/d7191bafe612224a9d1d35f6002156460ea6b35d
177e4c3 Remove incidental imports AlexWaygood Nov 16, 2021 https://github.com/python/typeshed/pull/6312/commits/177e4c36ccbb9a2e2ed5d080017b7171ae5fac46
Clear filters https://github.com/python/typeshed/pull/6312/files
Please reload this pagehttps://github.com/python/typeshed/pull/6312/files
Please reload this pagehttps://github.com/python/typeshed/pull/6312/files
_collections_abc.pyi https://github.com/python/typeshed/pull/6312/files#diff-87e6c4018e1ab050a25497559a6e2bac9ae9a52d172cf5e579f8d240f94a23b6
builtins.pyi https://github.com/python/typeshed/pull/6312/files#diff-1580ddf7dc331234b0845ffb953b6f7a5f1e9afa15048ebc0762226a08f194b4
__init__.pyi https://github.com/python/typeshed/pull/6312/files#diff-5b7170a7befcf78317eede617006f19d50ab173b9e1b882d791f457741021e70
stdlib/_collections_abc.pyihttps://github.com/python/typeshed/pull/6312/files#diff-87e6c4018e1ab050a25497559a6e2bac9ae9a52d172cf5e579f8d240f94a23b6
View file https://github.com/AlexWaygood/typeshed/blob/177e4c36ccbb9a2e2ed5d080017b7171ae5fac46/stdlib/_collections_abc.pyi
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typeshed/pull/6312/{{ revealButtonHref }}
https://github.com/python/typeshed/pull/6312/files#diff-87e6c4018e1ab050a25497559a6e2bac9ae9a52d172cf5e579f8d240f94a23b6
https://github.com/python/typeshed/pull/6312/files#diff-87e6c4018e1ab050a25497559a6e2bac9ae9a52d172cf5e579f8d240f94a23b6
https://github.com/python/typeshed/pull/6312/files#diff-87e6c4018e1ab050a25497559a6e2bac9ae9a52d172cf5e579f8d240f94a23b6
https://github.com/python/typeshed/pull/6312/files#diff-87e6c4018e1ab050a25497559a6e2bac9ae9a52d172cf5e579f8d240f94a23b6
stdlib/builtins.pyihttps://github.com/python/typeshed/pull/6312/files#diff-1580ddf7dc331234b0845ffb953b6f7a5f1e9afa15048ebc0762226a08f194b4
View file https://github.com/AlexWaygood/typeshed/blob/177e4c36ccbb9a2e2ed5d080017b7171ae5fac46/stdlib/builtins.pyi
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typeshed/pull/6312/{{ revealButtonHref }}
https://github.com/python/typeshed/pull/6312/files#diff-1580ddf7dc331234b0845ffb953b6f7a5f1e9afa15048ebc0762226a08f194b4
https://github.com/python/typeshed/pull/6312/files#diff-1580ddf7dc331234b0845ffb953b6f7a5f1e9afa15048ebc0762226a08f194b4
https://github.com/python/typeshed/pull/6312/files#diff-1580ddf7dc331234b0845ffb953b6f7a5f1e9afa15048ebc0762226a08f194b4
https://github.com/python/typeshed/pull/6312/files#diff-1580ddf7dc331234b0845ffb953b6f7a5f1e9afa15048ebc0762226a08f194b4
https://github.com/python/typeshed/pull/6312/files#diff-1580ddf7dc331234b0845ffb953b6f7a5f1e9afa15048ebc0762226a08f194b4
https://github.com/python/typeshed/pull/6312/files#diff-1580ddf7dc331234b0845ffb953b6f7a5f1e9afa15048ebc0762226a08f194b4
https://github.com/python/typeshed/pull/6312/files#diff-1580ddf7dc331234b0845ffb953b6f7a5f1e9afa15048ebc0762226a08f194b4
https://github.com/python/typeshed/pull/6312/files#diff-1580ddf7dc331234b0845ffb953b6f7a5f1e9afa15048ebc0762226a08f194b4
stdlib/collections/__init__.pyihttps://github.com/python/typeshed/pull/6312/files#diff-5b7170a7befcf78317eede617006f19d50ab173b9e1b882d791f457741021e70
View file https://github.com/AlexWaygood/typeshed/blob/177e4c36ccbb9a2e2ed5d080017b7171ae5fac46/stdlib/collections/__init__.pyi
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typeshed/pull/6312/{{ revealButtonHref }}
https://github.com/python/typeshed/pull/6312/files#diff-5b7170a7befcf78317eede617006f19d50ab173b9e1b882d791f457741021e70
https://github.com/python/typeshed/pull/6312/files#diff-5b7170a7befcf78317eede617006f19d50ab173b9e1b882d791f457741021e70
https://github.com/python/typeshed/pull/6312/files#diff-5b7170a7befcf78317eede617006f19d50ab173b9e1b882d791f457741021e70
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.