René's URL Explorer Experiment


Title: Using dunder parameter name in `builtins._SupportsLessThan` by grievejia · Pull Request #4264 · python/typeshed · GitHub

Open Graph Title: Using dunder parameter name in `builtins._SupportsLessThan` by grievejia · Pull Request #4264 · python/typeshed

X Title: Using dunder parameter name in `builtins._SupportsLessThan` by grievejia · Pull Request #4264 · python/typeshed

Description: PEP 544 intentionally did not specify whether method conformance check in protocol inference should look at parameter names. For example, it's up to the type checker to decide whether a class with method defined as def foo(self, x: int) would implement a protocol with method def foo(self, y: int). Mypy decided to ignore parameter names altogether, but we Pyre team decided to be more strict and refuse to match different parameter names (as it is unsound to do so when those methods are invoked with named parameters). Since Pyre also rely on the typeshed stubs, we want to make sure at least the important stubs on typeshed conform to our standard. This PR changes _SupportsLessThan.__lt__ (introduced in #4192) to use dunder (i.e. positional-only) parameter name specified in PEP484. This change should not affect mypy since it ignores parameter names, but will make Pyre happy when builtin functions like sorted is used. Note there are likely to be other cases where we might want this. We'll submit subsequent PRs in a demand-driven fashion.

Open Graph Description: PEP 544 intentionally did not specify whether method conformance check in protocol inference should look at parameter names. For example, it's up to the type checker to decide whether a class w...

X Description: PEP 544 intentionally did not specify whether method conformance check in protocol inference should look at parameter names. For example, it's up to the type checker to decide whether a cla...

Opengraph URL: https://github.com/python/typeshed/pull/4264

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:bcbe5166-588c-d336-8548-d38c1cb4dd87
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8C42:11BB24:299C18A:38ADE28:6B004984
html-safe-noncea731bb3a017eff9e4869203ae6fdb7cdd1745e525b4e9dce2358edcecd14d2c3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QzQyOjExQkIyNDoyOTlDMThBOjM4QURFMjg6NkIwMDQ5ODQiLCJ2aXNpdG9yX2lkIjoiNDkzMDM4MTg4Nzg5NDk5NzM4MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac86691650a9358ca2b2d2795263206cac40fa41b90441c039bdf3d1451de3e2bd
hovercard-subject-tagpull_request:440185225
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/typeshed/pull/4264/files
twitter:imagehttps://avatars.githubusercontent.com/u/3300714?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/3300714?s=400&v=4
og:image:altPEP 544 intentionally did not specify whether method conformance check in protocol inference should look at parameter names. For example, it's up to the type checker to decide whether a class w...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonef9517bf360d46638a1e5e7daee7158842fe5ef43c9000afa0e127564a7c2f39b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/typeshed git https://github.com/python/typeshed.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id31696383
octolytics-dimension-repository_nwopython/typeshed
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id31696383
octolytics-dimension-repository_network_root_nwopython/typeshed
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb27c5dde30676028abd5c5fc53ce5c9b625f8281
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/typeshed/pull/4264/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fpull%2F4264%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fpull%2F4264%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Ftypeshed
Reloadhttps://github.com/python/typeshed/pull/4264/files
Reloadhttps://github.com/python/typeshed/pull/4264/files
Reloadhttps://github.com/python/typeshed/pull/4264/files
pythonhttps://github.com/python
typeshedhttps://github.com/python/typeshed
Codehttps://github.com/python/typeshed
Issues196 (196)https://github.com/python/typeshed/issues
Pull requests252 (252)https://github.com/python/typeshed/pulls
Actionshttps://github.com/python/typeshed/actions
Security and qualityhttps://github.com/python/typeshed/security
Insightshttps://github.com/python/typeshed/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Ftypeshed%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Ftypeshed%2Fissues%2Fnew%2Fchoose
srittauhttps://github.com/srittau
python:masterhttps://github.com/python/typeshed/tree/master
grievejia:patch-6https://github.com/grievejia/typeshed/tree/patch-6
Conversation 1 https://github.com/python/typeshed/pull/4264
Commits 2 https://github.com/python/typeshed/pull/4264/commits
Checks 0 https://github.com/python/typeshed/pull/4264/checks
Files changed https://github.com/python/typeshed/pull/4264/files
Please reload this pagehttps://github.com/python/typeshed/pull/4264/files
Using dunder parameter name in builtins._SupportsLessThan https://github.com/python/typeshed/pull/4264/files#top
Show all changes 2 commits https://github.com/python/typeshed/pull/4264/files
3a523fb Using dunder parameter name in `builtins._SupportsLessThan` grievejia Jun 25, 2020 https://github.com/python/typeshed/pull/4264/commits/3a523fbc75df594333be7f1b22c70fa6a9704860
ff6e3ab Changes py2 builtins grievejia Jun 25, 2020 https://github.com/python/typeshed/pull/4264/commits/ff6e3ab73912e9545a69f1a902645b20c52d69b7
Clear filters https://github.com/python/typeshed/pull/4264/files
Please reload this pagehttps://github.com/python/typeshed/pull/4264/files
Please reload this pagehttps://github.com/python/typeshed/pull/4264/files
__builtin__.pyi https://github.com/python/typeshed/pull/4264/files#diff-1d779f57c4a031bf6683d708babcda1f1e1bc38fc30e63e87c3451827a870a30
builtins.pyi https://github.com/python/typeshed/pull/4264/files#diff-c430302cd57835815fa7401cd1322c5d1ad57c29ac2850903dff4a1380f202f8
stdlib/2/__builtin__.pyihttps://github.com/python/typeshed/pull/4264/files#diff-1d779f57c4a031bf6683d708babcda1f1e1bc38fc30e63e87c3451827a870a30
View file https://github.com/grievejia/typeshed/blob/ff6e3ab73912e9545a69f1a902645b20c52d69b7/stdlib/2/__builtin__.pyi
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typeshed/pull/4264/{{ revealButtonHref }}
https://github.com/python/typeshed/pull/4264/files#diff-1d779f57c4a031bf6683d708babcda1f1e1bc38fc30e63e87c3451827a870a30
https://github.com/python/typeshed/pull/4264/files#diff-1d779f57c4a031bf6683d708babcda1f1e1bc38fc30e63e87c3451827a870a30
stdlib/2and3/builtins.pyihttps://github.com/python/typeshed/pull/4264/files#diff-c430302cd57835815fa7401cd1322c5d1ad57c29ac2850903dff4a1380f202f8
View file https://github.com/grievejia/typeshed/blob/ff6e3ab73912e9545a69f1a902645b20c52d69b7/stdlib/2and3/builtins.pyi
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typeshed/pull/4264/{{ revealButtonHref }}
https://github.com/python/typeshed/pull/4264/files#diff-c430302cd57835815fa7401cd1322c5d1ad57c29ac2850903dff4a1380f202f8
https://github.com/python/typeshed/pull/4264/files#diff-c430302cd57835815fa7401cd1322c5d1ad57c29ac2850903dff4a1380f202f8
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.