René's URL Explorer Experiment


Title: Use the ReadableBuffer type in more places by bmerry · Pull Request #4245 · python/typeshed · GitHub

Open Graph Title: Use the ReadableBuffer type in more places by bmerry · Pull Request #4245 · python/typeshed

X Title: Use the ReadableBuffer type in more places by bmerry · Pull Request #4245 · python/typeshed

Description: This is a follow-up on #4232. memoryview, hashlib, and hmac are updated to use ReadableBuffer type instead of their own home-spun unions of bytes, bytearray and whatever else each use case used. mmap is being handled in #4244, and I'll leave BinaryIO for another day (or possibly another person) because it's going to require some messy code duplication because the relevant methods are defined in IO[AnyStr]. There's one corner case I'm not quite sure how best to handle: the documentation for hmac.digest claim that the parmaeters have the same meanings as in hmac.new, but in CPython the latter has an explicit check that key is bytes or bytearray while the former works with a memory-view. For now I've matched the documentation. Also, the documentation for HMAC.update says that msg can be any type supported by hashlib from Python 3.4; but I can't see anything in the Python 2.7 implementation that would prevent it also taking bytes-like objects, so I've not tried to treat Python 2 any different to Python 3.

Open Graph Description: This is a follow-up on #4232. memoryview, hashlib, and hmac are updated to use ReadableBuffer type instead of their own home-spun unions of bytes, bytearray and whatever else each use case used. mm...

X Description: This is a follow-up on #4232. memoryview, hashlib, and hmac are updated to use ReadableBuffer type instead of their own home-spun unions of bytes, bytearray and whatever else each use case used. mm...

Opengraph URL: https://github.com/python/typeshed/pull/4245

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:078e8869-5570-e949-ce55-12cadbf53b3e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDF9A:F5AA9:2BBA59A:3BBC8E8:6B0057F1
html-safe-noncefab3fc9ed9025f9149b6609140d1f1840c1d2726c8c600d4730a1743d83a044d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERjlBOkY1QUE5OjJCQkE1OUE6M0JCQzhFODo2QjAwNTdGMSIsInZpc2l0b3JfaWQiOiIyMjc5MzIzNjMyMzYwNTExNDczIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac0eac35eb3c2126cc5341e62030edf06b64103798c347a8d637c43caeca7539b6
hovercard-subject-tagpull_request:437095353
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/typeshed/pull/4245/files
twitter:imagehttps://avatars.githubusercontent.com/u/1963944?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1963944?s=400&v=4
og:image:altThis is a follow-up on #4232. memoryview, hashlib, and hmac are updated to use ReadableBuffer type instead of their own home-spun unions of bytes, bytearray and whatever else each use case used. mm...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonef420f4996e6b1ff1ccd6d7683f8134f4b5f0f8a50124c210dbfe7490e5644abb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/typeshed git https://github.com/python/typeshed.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id31696383
octolytics-dimension-repository_nwopython/typeshed
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id31696383
octolytics-dimension-repository_network_root_nwopython/typeshed
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26e00df917aba0f128135dc073ea0c5e33a70d40
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/typeshed/pull/4245/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fpull%2F4245%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fpull%2F4245%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Ftypeshed
Reloadhttps://github.com/python/typeshed/pull/4245/files
Reloadhttps://github.com/python/typeshed/pull/4245/files
Reloadhttps://github.com/python/typeshed/pull/4245/files
pythonhttps://github.com/python
typeshedhttps://github.com/python/typeshed
Codehttps://github.com/python/typeshed
Issues196 (196)https://github.com/python/typeshed/issues
Pull requests252 (252)https://github.com/python/typeshed/pulls
Actionshttps://github.com/python/typeshed/actions
Security and qualityhttps://github.com/python/typeshed/security
Insightshttps://github.com/python/typeshed/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Ftypeshed%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Ftypeshed%2Fissues%2Fnew%2Fchoose
JelleZijlstrahttps://github.com/JelleZijlstra
python:masterhttps://github.com/python/typeshed/tree/master
bmerry:apply-buffer-aliaseshttps://github.com/bmerry/typeshed/tree/apply-buffer-aliases
Conversation 3 https://github.com/python/typeshed/pull/4245
Commits 2 https://github.com/python/typeshed/pull/4245/commits
Checks 0 https://github.com/python/typeshed/pull/4245/checks
Files changed https://github.com/python/typeshed/pull/4245/files
Please reload this pagehttps://github.com/python/typeshed/pull/4245/files
Use the ReadableBuffer type in more places https://github.com/python/typeshed/pull/4245/files#top
Show all changes 2 commits https://github.com/python/typeshed/pull/4245/files
cf1507d Use the ReadableBuffer type in more places bmerry Jun 19, 2020 https://github.com/python/typeshed/pull/4245/commits/cf1507dd689961d9d795fa6ef46e3576c48a782c
dcafab7 Synchronise `builtins.pyi` to `__builtin__.pyi` bmerry Jun 22, 2020 https://github.com/python/typeshed/pull/4245/commits/dcafab7d555becc2fca162801be26097a3b409db
Clear filters https://github.com/python/typeshed/pull/4245/files
Please reload this pagehttps://github.com/python/typeshed/pull/4245/files
Please reload this pagehttps://github.com/python/typeshed/pull/4245/files
__builtin__.pyi https://github.com/python/typeshed/pull/4245/files#diff-1d779f57c4a031bf6683d708babcda1f1e1bc38fc30e63e87c3451827a870a30
__init__.pyi https://github.com/python/typeshed/pull/4245/files#diff-d88d19d07ffe6d8ae1093f03b378b27a69e98d56779649a70537bdd407d3e6a3
builtins.pyi https://github.com/python/typeshed/pull/4245/files#diff-c430302cd57835815fa7401cd1322c5d1ad57c29ac2850903dff4a1380f202f8
hmac.pyi https://github.com/python/typeshed/pull/4245/files#diff-1809bb01ff4d84f6dbb49fa77677a2baa1310bbc69c74d5ab355694cd50e46ab
hashlib.pyi https://github.com/python/typeshed/pull/4245/files#diff-29fa38b6b896b1665dea7c07ba7467ec93b1a035eed97255e88f040cc77695e8
stdlib/2/__builtin__.pyihttps://github.com/python/typeshed/pull/4245/files#diff-1d779f57c4a031bf6683d708babcda1f1e1bc38fc30e63e87c3451827a870a30
View file https://github.com/bmerry/typeshed/blob/dcafab7d555becc2fca162801be26097a3b409db/stdlib/2/__builtin__.pyi
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typeshed/pull/4245/{{ revealButtonHref }}
https://github.com/python/typeshed/pull/4245/files#diff-1d779f57c4a031bf6683d708babcda1f1e1bc38fc30e63e87c3451827a870a30
https://github.com/python/typeshed/pull/4245/files#diff-1d779f57c4a031bf6683d708babcda1f1e1bc38fc30e63e87c3451827a870a30
https://github.com/python/typeshed/pull/4245/files#diff-1d779f57c4a031bf6683d708babcda1f1e1bc38fc30e63e87c3451827a870a30
https://github.com/python/typeshed/pull/4245/files#diff-1d779f57c4a031bf6683d708babcda1f1e1bc38fc30e63e87c3451827a870a30
stdlib/2and3/_typeshed/__init__.pyihttps://github.com/python/typeshed/pull/4245/files#diff-d88d19d07ffe6d8ae1093f03b378b27a69e98d56779649a70537bdd407d3e6a3
View file https://github.com/bmerry/typeshed/blob/dcafab7d555becc2fca162801be26097a3b409db/stdlib/2and3/_typeshed/__init__.pyi
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typeshed/pull/4245/{{ revealButtonHref }}
https://github.com/python/typeshed/pull/4245/files#diff-d88d19d07ffe6d8ae1093f03b378b27a69e98d56779649a70537bdd407d3e6a3
stdlib/2and3/builtins.pyihttps://github.com/python/typeshed/pull/4245/files#diff-c430302cd57835815fa7401cd1322c5d1ad57c29ac2850903dff4a1380f202f8
View file https://github.com/bmerry/typeshed/blob/dcafab7d555becc2fca162801be26097a3b409db/stdlib/2and3/builtins.pyi
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typeshed/pull/4245/{{ revealButtonHref }}
https://github.com/python/typeshed/pull/4245/files#diff-c430302cd57835815fa7401cd1322c5d1ad57c29ac2850903dff4a1380f202f8
https://github.com/python/typeshed/pull/4245/files#diff-c430302cd57835815fa7401cd1322c5d1ad57c29ac2850903dff4a1380f202f8
https://github.com/python/typeshed/pull/4245/files#diff-c430302cd57835815fa7401cd1322c5d1ad57c29ac2850903dff4a1380f202f8
https://github.com/python/typeshed/pull/4245/files#diff-c430302cd57835815fa7401cd1322c5d1ad57c29ac2850903dff4a1380f202f8
stdlib/2and3/hmac.pyihttps://github.com/python/typeshed/pull/4245/files#diff-1809bb01ff4d84f6dbb49fa77677a2baa1310bbc69c74d5ab355694cd50e46ab
View file https://github.com/bmerry/typeshed/blob/dcafab7d555becc2fca162801be26097a3b409db/stdlib/2and3/hmac.pyi
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typeshed/pull/4245/{{ revealButtonHref }}
https://github.com/python/typeshed/pull/4245/files#diff-1809bb01ff4d84f6dbb49fa77677a2baa1310bbc69c74d5ab355694cd50e46ab
stdlib/3/hashlib.pyihttps://github.com/python/typeshed/pull/4245/files#diff-29fa38b6b896b1665dea7c07ba7467ec93b1a035eed97255e88f040cc77695e8
View file https://github.com/bmerry/typeshed/blob/dcafab7d555becc2fca162801be26097a3b409db/stdlib/3/hashlib.pyi
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typeshed/pull/4245/{{ revealButtonHref }}
https://github.com/python/typeshed/pull/4245/files#diff-29fa38b6b896b1665dea7c07ba7467ec93b1a035eed97255e88f040cc77695e8
https://github.com/python/typeshed/pull/4245/files#diff-29fa38b6b896b1665dea7c07ba7467ec93b1a035eed97255e88f040cc77695e8
https://github.com/python/typeshed/pull/4245/files#diff-29fa38b6b896b1665dea7c07ba7467ec93b1a035eed97255e88f040cc77695e8
https://github.com/python/typeshed/pull/4245/files#diff-29fa38b6b896b1665dea7c07ba7467ec93b1a035eed97255e88f040cc77695e8
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.