René's URL Explorer Experiment


Title: Fix Match.group problems by srittau · Pull Request #3172 · python/typeshed · GitHub

Open Graph Title: Fix Match.group problems by srittau · Pull Request #3172 · python/typeshed

X Title: Fix Match.group problems by srittau · Pull Request #3172 · python/typeshed

Description: group() may return None values group() allows to mix int and str arguments Use concrete return type Merge overloads Fixes #3171 Returning Optional is potentially problematic. It is often obvious from a regexp whether a certain group exists (every time it is non-optional). Many users may rely on group() not returning an Optional. Nevertheless, returning AnyStr is clearly wrong. One alternative is returning Any, but that would lose any type checking ability. Personally, I believe this patch is the best solution, despite the problems it may cause.

Open Graph Description: group() may return None values group() allows to mix int and str arguments Use concrete return type Merge overloads Fixes #3171 Returning Optional is potentially problematic. It is often obvious f...

X Description: group() may return None values group() allows to mix int and str arguments Use concrete return type Merge overloads Fixes #3171 Returning Optional is potentially problematic. It is often obvious f...

Opengraph URL: https://github.com/python/typeshed/pull/3172

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7a261edb-5446-7421-9cd6-d91ee6086276
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC5CE:1F5A:31E3DE:49CABE:6B00386F
html-safe-nonce522b7db159b7b47311fd0abfd30ccc2b81d65f289c18a1e3332f2c91b478893d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNUNFOjFGNUE6MzFFM0RFOjQ5Q0FCRTo2QjAwMzg2RiIsInZpc2l0b3JfaWQiOiIzNzAyMjk3NjIyMzg0NDkwNjA3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac5c0be08358fef146568aa929116f8eef673c873c8c052ba73a40a37ee29e0519
hovercard-subject-tagpull_request:305119456
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/typeshed/pull/3172/files
twitter:imagehttps://avatars.githubusercontent.com/u/52799?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/52799?s=400&v=4
og:image:altgroup() may return None values group() allows to mix int and str arguments Use concrete return type Merge overloads Fixes #3171 Returning Optional is potentially problematic. It is often obvious f...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/typeshed git https://github.com/python/typeshed.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id31696383
octolytics-dimension-repository_nwopython/typeshed
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id31696383
octolytics-dimension-repository_network_root_nwopython/typeshed
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/typeshed/pull/3172/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fpull%2F3172%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fpull%2F3172%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Ftypeshed
Reloadhttps://github.com/python/typeshed/pull/3172/files
Reloadhttps://github.com/python/typeshed/pull/3172/files
Reloadhttps://github.com/python/typeshed/pull/3172/files
pythonhttps://github.com/python
typeshedhttps://github.com/python/typeshed
Codehttps://github.com/python/typeshed
Issues196 (196)https://github.com/python/typeshed/issues
Pull requests252 (252)https://github.com/python/typeshed/pulls
Actionshttps://github.com/python/typeshed/actions
Security and qualityhttps://github.com/python/typeshed/security
Insightshttps://github.com/python/typeshed/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Ftypeshed%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Ftypeshed%2Fissues%2Fnew%2Fchoose
srittauhttps://github.com/srittau
python:masterhttps://github.com/python/typeshed/tree/master
srittau:match-grouphttps://github.com/srittau/typeshed/tree/match-group
Conversation 6 https://github.com/python/typeshed/pull/3172
Commits 5 https://github.com/python/typeshed/pull/3172/commits
Checks 0 https://github.com/python/typeshed/pull/3172/checks
Files changed https://github.com/python/typeshed/pull/3172/files
Please reload this pagehttps://github.com/python/typeshed/pull/3172/files
Fix Match.group problems https://github.com/python/typeshed/pull/3172/files#top
Show all changes 5 commits https://github.com/python/typeshed/pull/3172/files
6379d79 Fix Match.group problems srittau Aug 7, 2019 https://github.com/python/typeshed/pull/3172/commits/6379d799d66cba306833ce9d0a6b70625835bd0f
22fba26 Mark arguments as positional-only srittau Aug 7, 2019 https://github.com/python/typeshed/pull/3172/commits/22fba264c1b85821eed9df176f6f08ee180236e7
692dddb Add overload for group 0 srittau Aug 7, 2019 https://github.com/python/typeshed/pull/3172/commits/692dddb862f3c425b69ee923dcc83b2dba024a91
318605c Add missing @overload srittau Aug 7, 2019 https://github.com/python/typeshed/pull/3172/commits/318605c868f6333f378e5d99ecc2d72cfde2af5a
48bc000 Import Literal on Python < 3.8 srittau Aug 8, 2019 https://github.com/python/typeshed/pull/3172/commits/48bc000279c5c3957005fe18b787ce995d294257
Clear filters https://github.com/python/typeshed/pull/3172/files
Please reload this pagehttps://github.com/python/typeshed/pull/3172/files
Please reload this pagehttps://github.com/python/typeshed/pull/3172/files
stdlib/3/typing.pyihttps://github.com/python/typeshed/pull/3172/files#diff-009a41a8f985ef690b94fb876cfcd4d00fff765eb3f41468a1d816c555bc338b
View file https://github.com/srittau/typeshed/blob/48bc000279c5c3957005fe18b787ce995d294257/stdlib/3/typing.pyi
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typeshed/pull/3172/{{ revealButtonHref }}
https://github.com/python/typeshed/pull/3172/files#diff-009a41a8f985ef690b94fb876cfcd4d00fff765eb3f41468a1d816c555bc338b
https://github.com/python/typeshed/pull/3172/files#diff-009a41a8f985ef690b94fb876cfcd4d00fff765eb3f41468a1d816c555bc338b
https://github.com/python/typeshed/pull/3172/files#diff-009a41a8f985ef690b94fb876cfcd4d00fff765eb3f41468a1d816c555bc338b
JelleZijlstrahttps://github.com/JelleZijlstra
Aug 7, 2019https://github.com/python/typeshed/pull/3172/files#r311662628
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/typeshed/pull/3172/files
https://github.com/python/typeshed/pull/3172/files#diff-009a41a8f985ef690b94fb876cfcd4d00fff765eb3f41468a1d816c555bc338b
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.