René's URL Explorer Experiment


Title: Improve min/max by kaste · Pull Request #2833 · python/typeshed · GitHub

Open Graph Title: Improve min/max by kaste · Pull Request #2833 · python/typeshed

X Title: Improve min/max by kaste · Pull Request #2833 · python/typeshed

Description: Collection of library stubs for Python, with static types - Improve min/max by kaste · Pull Request #2833 · python/typeshed

Open Graph Description: Probably mildly clear if you provide a default value for min/max builtins the return type becomes a 'Union'. I don't know if that's too much but I also added two other commits (you ...

X Description: Probably mildly clear if you provide a default value for min/max builtins the return type becomes a 'Union'. I don't know if that's too much but I also added two oth...

Opengraph URL: https://github.com/python/typeshed/pull/2833

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0d7af892-41d4-1c92-79f7-e1255f2ea002
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC90C:3EE1E4:A8C25F:DA31C5:6A600C47
html-safe-nonce5a99b79d3fb81734ff030a31b8061d1493e08d43b25f9b6cc4a3480a21bff9b9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOTBDOjNFRTFFNDpBOEMyNUY6REEzMUM1OjZBNjAwQzQ3IiwidmlzaXRvcl9pZCI6Ijg0NzgwMTM4NzkyNjQyMTgxODMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac63df87ab81e132ac26329e99f40bf4e1e39da916253af1efaec49936feb64a22
hovercard-subject-tagpull_request:259555233
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/typeshed/2833/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/cba6aa98f0a1184e87dff2db7900076ae524c8d23d5966cd5fceb50e13bae89a/python/typeshed/pull/2833
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/cba6aa98f0a1184e87dff2db7900076ae524c8d23d5966cd5fceb50e13bae89a/python/typeshed/pull/2833
og:image:altProbably mildly clear if you provide a default value for min/max builtins the return type becomes a 'Union'. I don't know if that's too much but I also added two other commits (you ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamekaste
hostnamegithub.com
expected-hostnamegithub.com
None48cb2ed2304f8ae5a4a05d6327faf70466c4c0d9dcbf7b9df76251ca9c669a90
turbo-cache-controlno-cache
go-importgithub.com/python/typeshed git https://github.com/python/typeshed.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id31696383
octolytics-dimension-repository_nwopython/typeshed
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id31696383
octolytics-dimension-repository_network_root_nwopython/typeshed
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecb0f10a384099e0765239a7cc220992cae52bdba
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/typeshed/pull/2833#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fpull%2F2833
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fpull%2F2833
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Ftypeshed
Reloadhttps://github.com/python/typeshed/pull/2833
Reloadhttps://github.com/python/typeshed/pull/2833
Reloadhttps://github.com/python/typeshed/pull/2833
Please reload this pagehttps://github.com/python/typeshed/pull/2833
python https://github.com/python
typeshedhttps://github.com/python/typeshed
Please reload this pagehttps://github.com/python/typeshed/pull/2833
Notifications https://github.com/login?return_to=%2Fpython%2Ftypeshed
Fork 2.1k https://github.com/login?return_to=%2Fpython%2Ftypeshed
Star 5.1k https://github.com/login?return_to=%2Fpython%2Ftypeshed
Code https://github.com/python/typeshed
Issues 224 https://github.com/python/typeshed/issues
Pull requests 140 https://github.com/python/typeshed/pulls
Actions https://github.com/python/typeshed/actions
Security and quality 0 https://github.com/python/typeshed/security
Insights https://github.com/python/typeshed/pulse
Code https://github.com/python/typeshed
Issues https://github.com/python/typeshed/issues
Pull requests https://github.com/python/typeshed/pulls
Actions https://github.com/python/typeshed/actions
Security and quality https://github.com/python/typeshed/security
Insights https://github.com/python/typeshed/pulse
srittauhttps://github.com/srittau
python:masterhttps://github.com/python/typeshed/tree/master
kaste:improve-min-maxhttps://github.com/kaste/typeshed/tree/improve-min-max
Conversationhttps://github.com/python/typeshed/pull/2833
Commits4 (4)https://github.com/python/typeshed/pull/2833/commits
Checkshttps://github.com/python/typeshed/pull/2833/checks
Files changedhttps://github.com/python/typeshed/pull/2833/files
Improve min/maxhttps://github.com/python/typeshed/pull/2833#top
srittauhttps://github.com/srittau
python:masterhttps://github.com/python/typeshed/tree/master
kaste:improve-min-maxhttps://github.com/kaste/typeshed/tree/improve-min-max
https://github.com/kaste
kastehttps://github.com/kaste
Mar 8, 2019https://github.com/python/typeshed/pull/2833#issue-418891134
python/mypy#6460https://github.com/python/mypy/issues/6460
Please reload this pagehttps://github.com/python/typeshed/pull/2833
kastehttps://github.com/kaste
March 8, 2019 18:38https://github.com/python/typeshed/pull/2833#commits-pushed-afb6649
https://github.com/kaste
For min/max return Union type if default givenhttps://github.com/python/typeshed/pull/2833/commits/afb664976d04611ccc3f5587a4c45c8176e4550c
afb6649https://github.com/python/typeshed/pull/2833/commits/afb664976d04611ccc3f5587a4c45c8176e4550c
https://github.com/kaste
For min/max mark keyword only argumentshttps://github.com/python/typeshed/pull/2833/commits/e6f70b6dada503e582b08a76c0b12a27608bb6c4
e6f70b6https://github.com/python/typeshed/pull/2833/commits/e6f70b6dada503e582b08a76c0b12a27608bb6c4
https://github.com/kaste
Also mark positional argumentshttps://github.com/python/typeshed/pull/2833/commits/2f56b1faef4efba04557a36893a6ad40a9104f3a
2f56b1fhttps://github.com/python/typeshed/pull/2833/commits/2f56b1faef4efba04557a36893a6ad40a9104f3a
https://github.com/kaste
kastehttps://github.com/kaste
Mar 8, 2019https://github.com/python/typeshed/pull/2833#event-2190742639
https://github.com/kaste
Copy changes to __builtin__.pyihttps://github.com/python/typeshed/pull/2833/commits/9176b9f8e783eb61ebcb7e4e681237df2a5f9dbc
9176b9fhttps://github.com/python/typeshed/pull/2833/commits/9176b9f8e783eb61ebcb7e4e681237df2a5f9dbc
https://github.com/srittau
srittauhttps://github.com/srittau
Mar 8, 2019 https://github.com/python/typeshed/pull/2833#pullrequestreview-212413607
View reviewed changes https://github.com/python/typeshed/pull/2833/files/9176b9f8e783eb61ebcb7e4e681237df2a5f9dbc
srittauhttps://github.com/srittau
https://github.com/python/typeshed/pull/2833#pullrequestreview-212413607
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/typeshed/pull/2833
https://github.com/srittau
srittauhttps://github.com/srittau
4dcd516https://github.com/python/typeshed/commit/4dcd516caa0c801d4189a4c115a4a6f3f4325869
Mar 8, 2019https://github.com/python/typeshed/pull/2833#event-2190819190
https://github.com/srittau
srittauhttps://github.com/srittau
Mar 8, 2019 https://github.com/python/typeshed/pull/2833#ref-issue-412961845
For min/max functions a default value changes the key function type python/mypy#6460 https://github.com/python/mypy/issues/6460
https://github.com/kaste
kastehttps://github.com/kaste
March 8, 2019 19:12https://github.com/python/typeshed/pull/2833#event-2190926760
msullivanhttps://github.com/msullivan
Mar 25, 2019 https://github.com/python/typeshed/pull/2833#ref-commit-80d4676
https://github.com/msullivan
Add overloads for min/max that don't take defaulthttps://github.com/python/typeshed/commit/80d4676a087ff88d07e5be414eb18044652f358b
80d4676https://github.com/python/typeshed/commit/80d4676a087ff88d07e5be414eb18044652f358b
#2833https://github.com/python/typeshed/pull/2833
https://github.com/msullivan
msullivanhttps://github.com/msullivan
Mar 25, 2019 https://github.com/python/typeshed/pull/2833#ref-pullrequest-425096897
Add overloads for min/max that don't take default #2885 https://github.com/python/typeshed/pull/2885
msullivanhttps://github.com/msullivan
Mar 25, 2019 https://github.com/python/typeshed/pull/2833#ref-commit-c526975
https://github.com/msullivan
Add overloads for min/max that don't take default (https://github.com/python/typeshed/commit/c526975a1bb4ad3f3601ddf2edea22e29ad4ab34
#2885https://github.com/python/typeshed/pull/2885
)https://github.com/python/typeshed/commit/c526975a1bb4ad3f3601ddf2edea22e29ad4ab34
c526975https://github.com/python/typeshed/commit/c526975a1bb4ad3f3601ddf2edea22e29ad4ab34
#2833https://github.com/python/typeshed/pull/2833
https://github.com/pfaion
pfaionhttps://github.com/pfaion
Jul 18, 2024 https://github.com/python/typeshed/pull/2833#ref-issue-2415726847
min()/max() with default value cause issues with key function type python/mypy#17536 https://github.com/python/mypy/issues/17536
https://github.co/hiddenchars
https://github.com/python/typeshed/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fpull%2F2833
https://github.com/srittau
srittau https://github.com/srittau
https://github.com/python/typeshed/pull/2833/files/9176b9f8e783eb61ebcb7e4e681237df2a5f9dbc
Please reload this pagehttps://github.com/python/typeshed/pull/2833
https://github.com/kaste
https://github.com/srittau
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.