| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:e8bf383d-4c23-48f3-ffd3-4327be5284c9 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B118:1BB2D2:6F045:956F7:6B0018E9 |
| html-safe-nonce | 966f5fee6e0f2f52320e8cca1ac97ea68a31d51b314fd4b4ec0df1d70fa48d42 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMTE4OjFCQjJEMjo2RjA0NTo5NTZGNzo2QjAwMThFOSIsInZpc2l0b3JfaWQiOiI2MjQ1NTYxOTk1NjA5Nzc0MzEzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 5b94a827558debe2c2699e2d15b4aba6a255b56de2744a776779cace38cb278e |
| hovercard-subject-tag | pull_request:212793495 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/typeshed/2424/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/db14dae1b43476c48b6ad4a6d9aff2ecf92576b3f5a0dd30cdfb3b2b6fdcca7b/python/typeshed/pull/2424 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/db14dae1b43476c48b6ad4a6d9aff2ecf92576b3f5a0dd30cdfb3b2b6fdcca7b/python/typeshed/pull/2424 |
| og:image:alt | Fixes #2423.
I followed https://github.com/tornadoweb/tornado/blob/master/tornado/httpclient.py and kept the @property where it exists in the implementation and the attribute where it doesn't. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | JelleZijlstra |
| hostname | github.com |
| expected-hostname | github.com |
| None | a2dd2291b1b13cc9c06f27ec92fa3dbaf34116fc24c9347b8539db61884c59f4 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/typeshed git https://github.com/python/typeshed.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 31696383 |
| octolytics-dimension-repository_nwo | python/typeshed |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 31696383 |
| octolytics-dimension-repository_network_root_nwo | python/typeshed |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 70121d4e855ee0bb7b75cf15d061d91f8863c0f8 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/typeshed/pull/2424#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fpull%2F2424 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fpull%2F2424 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Ftypeshed |
| Reload | https://github.com/python/typeshed/pull/2424 |
| Reload | https://github.com/python/typeshed/pull/2424 |
| Reload | https://github.com/python/typeshed/pull/2424 |
| python | https://github.com/python |
| typeshed | https://github.com/python/typeshed |
| Code | https://github.com/python/typeshed |
| Issues196 (196) | https://github.com/python/typeshed/issues |
| Pull requests251 (251) | https://github.com/python/typeshed/pulls |
| Actions | https://github.com/python/typeshed/actions |
| Security and quality | https://github.com/python/typeshed/security |
| Insights | https://github.com/python/typeshed/insights |
| https://github.com/python/typeshed |
| JelleZijlstra | https://github.com/JelleZijlstra |
| master | https://github.com/python/typeshed/tree/master |
| JelleZijlstra-patch-1 | https://github.com/python/typeshed/tree/JelleZijlstra-patch-1 |
| Conversation | https://github.com/python/typeshed/pull/2424 |
| Commits1 (1) | https://github.com/python/typeshed/pull/2424/commits |
| Checks | https://github.com/python/typeshed/pull/2424/checks |
| Files changed | https://github.com/python/typeshed/pull/2424/files |
| fix duplicate definitions in tornado | https://github.com/python/typeshed/pull/2424#top |
| JelleZijlstra | https://github.com/JelleZijlstra |
| master | https://github.com/python/typeshed/tree/master |
| JelleZijlstra-patch-1 | https://github.com/python/typeshed/tree/JelleZijlstra-patch-1 |
|
| https://github.com/JelleZijlstra |
| JelleZijlstra | https://github.com/JelleZijlstra |
| Sep 3, 2018 | https://github.com/python/typeshed/pull/2424#issue-356563557 |
| #2423 | https://github.com/python/typeshed/issues/2423 |
| https://github.com/tornadoweb/tornado/blob/master/tornado/httpclient.py | https://github.com/tornadoweb/tornado/blob/master/tornado/httpclient.py |
| Please reload this page | https://github.com/python/typeshed/pull/2424 |
|
| https://github.com/JelleZijlstra |
| fix duplicate definitions in tornado | https://github.com/python/typeshed/pull/2424/commits/5fc5abafd7c5075d174a35c6d9dcc2a7d87da801 |
| 5fc5aba | https://github.com/python/typeshed/pull/2424/commits/5fc5abafd7c5075d174a35c6d9dcc2a7d87da801 |
| #2423 | https://github.com/python/typeshed/issues/2423 |
| https://github.com/tornadoweb/tornado/blob/master/tornado/httpclient.py | https://github.com/tornadoweb/tornado/blob/master/tornado/httpclient.py |
| https://github.com/JelleZijlstra |
| JelleZijlstra | https://github.com/JelleZijlstra |
|
Sep 3, 2018
| https://github.com/python/typeshed/pull/2424#ref-pullrequest-356538557 |
|
Original node wins in case of a redefinition (especially if it is a class)
python/mypy#5565
| https://github.com/python/mypy/pull/5565 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
|
Sep 3, 2018
| https://github.com/python/typeshed/pull/2424#pullrequestreview-151858257 |
|
View reviewed changes
| https://github.com/python/typeshed/pull/2424/files/5fc5abafd7c5075d174a35c6d9dcc2a7d87da801 |
| ilevkivskyi | https://github.com/ilevkivskyi |
| https://github.com/python/typeshed/pull/2424#pullrequestreview-151858257 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/typeshed/pull/2424 |
| https://github.com/ilevkivskyi |
| ilevkivskyi | https://github.com/ilevkivskyi |
| Sep 3, 2018 | https://github.com/python/typeshed/pull/2424#issuecomment-418181623 |
| Please reload this page | https://github.com/python/typeshed/pull/2424 |
| https://github.com/JelleZijlstra |
| JelleZijlstra | https://github.com/JelleZijlstra |
| 2e1c816 | https://github.com/python/typeshed/commit/2e1c81684e16fe412fbcc12d3ef8b778ccb2c67d |
| Sep 3, 2018 | https://github.com/python/typeshed/pull/2424#event-1824112155 |
| https://github.com/JelleZijlstra |
| JelleZijlstra | https://github.com/JelleZijlstra |
| Sep 3, 2018 | https://github.com/python/typeshed/pull/2424#issuecomment-418205778 |
| Please reload this page | https://github.com/python/typeshed/pull/2424 |
| https://github.com/JelleZijlstra |
| JelleZijlstra | https://github.com/JelleZijlstra |
| September 3, 2018 23:40 | https://github.com/python/typeshed/pull/2424#event-1824112271 |
| cocoatomo | https://github.com/cocoatomo |
|
Sep 8, 2018
| https://github.com/python/typeshed/pull/2424#ref-commit-217550a |
|
| https://github.com/JelleZijlstra |
|
| https://github.com/cocoatomo |
| fix duplicate definitions in tornado ( | https://github.com/cocoatomo/typeshed/commit/217550ab4cf50466846cea8222f418783b3e664f |
| python#2424 | https://github.com/python/typeshed/pull/2424 |
| ) | https://github.com/cocoatomo/typeshed/commit/217550ab4cf50466846cea8222f418783b3e664f |
| 217550a | https://github.com/cocoatomo/typeshed/commit/217550ab4cf50466846cea8222f418783b3e664f |
| python#2423 | https://github.com/python/typeshed/issues/2423 |
| https://github.com/tornadoweb/tornado/blob/master/tornado/httpclient.py | https://github.com/tornadoweb/tornado/blob/master/tornado/httpclient.py |
| yedpodtrzitko | https://github.com/yedpodtrzitko |
|
Jan 23, 2019
| https://github.com/python/typeshed/pull/2424#ref-commit-f2353bb |
|
| https://github.com/JelleZijlstra |
| fix duplicate definitions in tornado ( | https://github.com/yedpodtrzitko/typeshed/commit/f2353bb831879b5b066da3ec6651c9bae118c280 |
| python#2424 | https://github.com/python/typeshed/pull/2424 |
| ) | https://github.com/yedpodtrzitko/typeshed/commit/f2353bb831879b5b066da3ec6651c9bae118c280 |
| f2353bb | https://github.com/yedpodtrzitko/typeshed/commit/f2353bb831879b5b066da3ec6651c9bae118c280 |
| python#2423 | https://github.com/python/typeshed/issues/2423 |
| https://github.com/tornadoweb/tornado/blob/master/tornado/httpclient.py | https://github.com/tornadoweb/tornado/blob/master/tornado/httpclient.py |
| https://github.co/hiddenchars |
| https://github.com/python/typeshed/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fpull%2F2424 |
|
| https://github.com/ilevkivskyi |
|
ilevkivskyi
| https://github.com/ilevkivskyi |
|
| https://github.com/python/typeshed/pull/2424/files/5fc5abafd7c5075d174a35c6d9dcc2a7d87da801 |
| Please reload this page | https://github.com/python/typeshed/pull/2424 |
| Please reload this page | https://github.com/python/typeshed/pull/2424 |
|
| https://github.com/JelleZijlstra |
|
| https://github.com/ilevkivskyi |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |