René's URL Explorer Experiment


Title: add __fspath__ support to os.path by JelleZijlstra · Pull Request #2053 · python/typeshed · GitHub

Open Graph Title: add __fspath__ support to os.path by JelleZijlstra · Pull Request #2053 · python/typeshed

X Title: add __fspath__ support to os.path by JelleZijlstra · Pull Request #2053 · python/typeshed

Description: Fixes #1997, #2068. This is tricky because we need to get the return values right (see #1960 for prior attempts) and we often run into python/mypy#3644. I found that I could express most signatures correctly using a series of overloads. A few other changes in here: Added splitunc, which according to https://docs.python.org/3/library/os.path.html should exist in both Unix and Windows. Made the second argument to os.path.curdir Optional to match the implementation. Fixed os.path.split, whose previous Path-aware signature triggered python/mypy#3644. I couldn't come up with a correct signature for os.path.commonpath, so I am falling back to using Any as its return type. I used the following test program to make sure mypy accepted the signatures used here: import os from os.path import abspath, commonpath, relpath, split, join from typing import Generic, AnyStr, Any class PL(os.PathLike[AnyStr]): def __init__(self, path: AnyStr) -> None: self.path: AnyStr = path def __fspath__(self) -> AnyStr: return self.path bad_path: PL[Any] = PL('') reveal_type(abspath('hello')) # str reveal_type(abspath(b'hello')) # bytes reveal_type(abspath(PL('hello'))) # str reveal_type(abspath(PL(b'hello'))) # bytes reveal_type(commonpath(['hello', PL('hello')])) # Any (couldn't get it work correctly) reveal_type(commonpath([b'hello', PL(b'hello')])) # Any reveal_type(relpath('hello')) # str reveal_type(relpath('hello', PL('hello'))) # str reveal_type(relpath(b'hello', b'hello')) # bytes reveal_type(relpath(PL('hello'))) # str reveal_type(relpath(PL(b'hello'), b'hello')) # bytes reveal_type(relpath(bad_path, 'hello')) # str reveal_type(relpath(bad_path, bad_path)) # Any reveal_type(split('hello')) # (str, str) reveal_type(split(b'hello')) # (bytes, bytes) reveal_type(split(PL('hello'))) # (str, str) reveal_type(split(PL(b'hello'))) # (bytes, bytes) reveal_type(join('hello', PL('hello'))) # str reveal_type(join(PL('hello'), 'hello')) # str reveal_type(join(b'hello', PL(b'hello'))) # bytes reveal_type(join(b'hello', PL('hello'))) # error I made the same changes to the Python 2 stub in order to keep the two consistent.

Open Graph Description: Fixes #1997, #2068. This is tricky because we need to get the return values right (see #1960 for prior attempts) and we often run into python/mypy#3644. I found that I could express most signatures...

X Description: Fixes #1997, #2068. This is tricky because we need to get the return values right (see #1960 for prior attempts) and we often run into python/mypy#3644. I found that I could express most signatures...

Opengraph URL: https://github.com/python/typeshed/pull/2053

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:737e6972-aa36-de1d-15a2-8ff988c64dac
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC0D2:1C3DC0:3EA15F:544263:6B002AA6
html-safe-nonce259c9237a7e9162a24a266492787a0ceab06b8253af5361a547f6d36f742995a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMEQyOjFDM0RDMDozRUExNUY6NTQ0MjYzOjZCMDAyQUE2IiwidmlzaXRvcl9pZCI6IjU0ODEyOTEyOTk5MzM5MjQwMDciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac2737f3a6ea54f3e3a38361578e112abd4a42eafba3be7fa8c4833693174a5a5d
hovercard-subject-tagpull_request:181630773
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/typeshed/pull/2053/files
twitter:imagehttps://avatars.githubusercontent.com/u/906600?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/906600?s=400&v=4
og:image:altFixes #1997, #2068. This is tricky because we need to get the return values right (see #1960 for prior attempts) and we often run into python/mypy#3644. I found that I could express most signatures...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/typeshed git https://github.com/python/typeshed.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id31696383
octolytics-dimension-repository_nwopython/typeshed
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id31696383
octolytics-dimension-repository_network_root_nwopython/typeshed
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/typeshed/pull/2053/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fpull%2F2053%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fpull%2F2053%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Ftypeshed
Reloadhttps://github.com/python/typeshed/pull/2053/files
Reloadhttps://github.com/python/typeshed/pull/2053/files
Reloadhttps://github.com/python/typeshed/pull/2053/files
pythonhttps://github.com/python
typeshedhttps://github.com/python/typeshed
Codehttps://github.com/python/typeshed
Issues196 (196)https://github.com/python/typeshed/issues
Pull requests251 (251)https://github.com/python/typeshed/pulls
Actionshttps://github.com/python/typeshed/actions
Security and qualityhttps://github.com/python/typeshed/security
Insightshttps://github.com/python/typeshed/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Ftypeshed%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Ftypeshed%2Fissues%2Fnew%2Fchoose
JelleZijlstrahttps://github.com/JelleZijlstra
python:masterhttps://github.com/python/typeshed/tree/master
JelleZijlstra:ospathfspathhttps://github.com/JelleZijlstra/typeshed/tree/ospathfspath
Conversation 5 https://github.com/python/typeshed/pull/2053
Commits 2 https://github.com/python/typeshed/pull/2053/commits
Checks 0 https://github.com/python/typeshed/pull/2053/checks
Files changed https://github.com/python/typeshed/pull/2053/files
Please reload this pagehttps://github.com/python/typeshed/pull/2053/files
add __fspath__ support to os.path https://github.com/python/typeshed/pull/2053/files#top
Show all changes 2 commits https://github.com/python/typeshed/pull/2053/files
be69bef add __fspath__ support to os.path JelleZijlstra Apr 14, 2018 https://github.com/python/typeshed/pull/2053/commits/be69befd317c208cee352c90f8199614c1033c44
079f2fc also apply changes to 2 to keep the stubs consistent JelleZijlstra Apr 14, 2018 https://github.com/python/typeshed/pull/2053/commits/079f2fc18f308fecae0518fc5fbbf2d3037f298f
Clear filters https://github.com/python/typeshed/pull/2053/files
Please reload this pagehttps://github.com/python/typeshed/pull/2053/files
Please reload this pagehttps://github.com/python/typeshed/pull/2053/files
path.pyi https://github.com/python/typeshed/pull/2053/files#diff-debcfb6f9f6c4ea9b3e4e832ae7859758eeff67d4c4561fc65813fd78ebd4794
path.pyi https://github.com/python/typeshed/pull/2053/files#diff-b74d1b12d93216ce41890f30eb023664b5df32f9cec620e8b0cfbca733b72120
stdlib/2/os/path.pyihttps://github.com/python/typeshed/pull/2053/files#diff-debcfb6f9f6c4ea9b3e4e832ae7859758eeff67d4c4561fc65813fd78ebd4794
View file https://github.com/JelleZijlstra/typeshed/blob/079f2fc18f308fecae0518fc5fbbf2d3037f298f/stdlib/2/os/path.pyi
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typeshed/pull/2053/{{ revealButtonHref }}
https://github.com/python/typeshed/pull/2053/files#diff-debcfb6f9f6c4ea9b3e4e832ae7859758eeff67d4c4561fc65813fd78ebd4794
https://github.com/python/typeshed/pull/2053/files#diff-debcfb6f9f6c4ea9b3e4e832ae7859758eeff67d4c4561fc65813fd78ebd4794
https://github.com/python/typeshed/pull/2053/files#diff-debcfb6f9f6c4ea9b3e4e832ae7859758eeff67d4c4561fc65813fd78ebd4794
stdlib/3/os/path.pyihttps://github.com/python/typeshed/pull/2053/files#diff-b74d1b12d93216ce41890f30eb023664b5df32f9cec620e8b0cfbca733b72120
View file https://github.com/JelleZijlstra/typeshed/blob/079f2fc18f308fecae0518fc5fbbf2d3037f298f/stdlib/3/os/path.pyi
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typeshed/pull/2053/{{ revealButtonHref }}
https://github.com/python/typeshed/pull/2053/files#diff-b74d1b12d93216ce41890f30eb023664b5df32f9cec620e8b0cfbca733b72120
https://github.com/python/typeshed/pull/2053/files#diff-b74d1b12d93216ce41890f30eb023664b5df32f9cec620e8b0cfbca733b72120
FichteFollhttps://github.com/FichteFoll
Apr 14, 2018https://github.com/python/typeshed/pull/2053/files#r181548652
Please reload this pagehttps://github.com/python/typeshed/pull/2053/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/typeshed/pull/2053/files
JelleZijlstrahttps://github.com/JelleZijlstra
Apr 14, 2018https://github.com/python/typeshed/pull/2053/files#r181554066
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/typeshed/pull/2053/files
JelleZijlstrahttps://github.com/JelleZijlstra
May 14, 2018https://github.com/python/typeshed/pull/2053/files#r187972411
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/typeshed/pull/2053/files
https://github.com/python/typeshed/pull/2053/files#diff-b74d1b12d93216ce41890f30eb023664b5df32f9cec620e8b0cfbca733b72120
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.