René's URL Explorer Experiment


Title: Remove incomplete thrift stubs that cause false positives. by carljm · Pull Request #1827 · python/typeshed · GitHub

Open Graph Title: Remove incomplete thrift stubs that cause false positives. by carljm · Pull Request #1827 · python/typeshed

X Title: Remove incomplete thrift stubs that cause false positives. by carljm · Pull Request #1827 · python/typeshed

Description: Per the precedent set in #1659 and #1664, I am removing the thrift stubs. As noted in 84d0cbf, "These stubs are pure stubgen and might not be much good." In fact, they are not much good, and we saw false positives from them when upgrading mypy (because of their recent move from 2 to 2and3, which made them visible to us for the first time). The false positives we saw are due to classes which are missing entirely from the stubs; comparing the stubs to the actual source of Apache thrift, they are woefully incomplete. IMO these should be in their own project, used via PEP 561.

Open Graph Description: Per the precedent set in #1659 and #1664, I am removing the thrift stubs. As noted in 84d0cbf, "These stubs are pure stubgen and might not be much good." In fact, they are not much good, ...

X Description: Per the precedent set in #1659 and #1664, I am removing the thrift stubs. As noted in 84d0cbf, "These stubs are pure stubgen and might not be much good." In fact, they are not muc...

Opengraph URL: https://github.com/python/typeshed/pull/1827

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:520618a2-7956-24a6-aa7d-48441806fe7f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB636:3E1398:AB2B9:E77AB:6B001C2B
html-safe-nonce536b8eacb9b6da349a5bd65edaa2364cf69427f240c909c543b426b003255d83
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNjM2OjNFMTM5ODpBQjJCOTpFNzdBQjo2QjAwMUMyQiIsInZpc2l0b3JfaWQiOiI0NjU0OTY5MjAxNjg4MDU4OTIzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac2887775297c3a402acbaef0ad8d2e5006f25b7954f2990ba8304dbf7aa08ddff
hovercard-subject-tagpull_request:162759193
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/typeshed/pull/1827/files
twitter:imagehttps://avatars.githubusercontent.com/u/61586?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/61586?s=400&v=4
og:image:altPer the precedent set in #1659 and #1664, I am removing the thrift stubs. As noted in 84d0cbf, "These stubs are pure stubgen and might not be much good." In fact, they are not much good, ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/typeshed git https://github.com/python/typeshed.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id31696383
octolytics-dimension-repository_nwopython/typeshed
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id31696383
octolytics-dimension-repository_network_root_nwopython/typeshed
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release44c658b24abf00491fb7ae5f56d42c9f38cbeab2
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/typeshed/pull/1827/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fpull%2F1827%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fpull%2F1827%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Ftypeshed
Reloadhttps://github.com/python/typeshed/pull/1827/files
Reloadhttps://github.com/python/typeshed/pull/1827/files
Reloadhttps://github.com/python/typeshed/pull/1827/files
pythonhttps://github.com/python
typeshedhttps://github.com/python/typeshed
Codehttps://github.com/python/typeshed
Issues196 (196)https://github.com/python/typeshed/issues
Pull requests251 (251)https://github.com/python/typeshed/pulls
Actionshttps://github.com/python/typeshed/actions
Security and qualityhttps://github.com/python/typeshed/security
Insightshttps://github.com/python/typeshed/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Ftypeshed%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Ftypeshed%2Fissues%2Fnew%2Fchoose
JelleZijlstrahttps://github.com/JelleZijlstra
python:masterhttps://github.com/python/typeshed/tree/master
carljm:remove-thrift-stubhttps://github.com/carljm/typeshed/tree/remove-thrift-stub
Conversation 5 https://github.com/python/typeshed/pull/1827
Commits 1 https://github.com/python/typeshed/pull/1827/commits
Checks 0 https://github.com/python/typeshed/pull/1827/checks
Files changed https://github.com/python/typeshed/pull/1827/files
Please reload this pagehttps://github.com/python/typeshed/pull/1827/files
Remove incomplete thrift stubs that cause false positives. https://github.com/python/typeshed/pull/1827/files#top
Show all changes 1 commit https://github.com/python/typeshed/pull/1827/files
2f712a4 Remove incomplete thrift stubs that cause false positives. carljm Jan 13, 2018 https://github.com/python/typeshed/pull/1827/commits/2f712a410d131fedb8c9947a01a34d3c3e992235
Clear filters https://github.com/python/typeshed/pull/1827/files
Please reload this pagehttps://github.com/python/typeshed/pull/1827/files
Please reload this pagehttps://github.com/python/typeshed/pull/1827/files
Thrift.pyi https://github.com/python/typeshed/pull/1827/files#diff-6f349e4d97f2a649a45c2bbf7e7843cac9851a2ac068ce0d36cc5acf081e4d55
__init__.pyi https://github.com/python/typeshed/pull/1827/files#diff-1493584eb90f0a98512b458521df290c7a216ff57e4303eec1f7feb43af49387
TBinaryProtocol.pyi https://github.com/python/typeshed/pull/1827/files#diff-4a7573eed3d85716aa63b7e99b525c4711d44b194de8661183bb8e904427fc06
TProtocol.pyi https://github.com/python/typeshed/pull/1827/files#diff-cfc47663356c9160431a238e92a9f2e2768b98ef0e20a1efc02bfb021e2b3282
__init__.pyi https://github.com/python/typeshed/pull/1827/files#diff-1ed67483a29bafa7788331d233e977336de0549020e243a8f751e0f57b021db6
TSocket.pyi https://github.com/python/typeshed/pull/1827/files#diff-adb5cbba809602bb7a4cccbc1416d030c72428bea4af31e96bf1487d446417e7
TTransport.pyi https://github.com/python/typeshed/pull/1827/files#diff-cc0da7e5e9f66aad4bf075482a01982c6b645c6dbc79c1a46f2a0c46cad3ca4a
__init__.pyi https://github.com/python/typeshed/pull/1827/files#diff-ac782e832467a5341e8ea188fd8e9d41797236f69f66a1fc30c12f1ff73291d0
third_party/2and3/thrift/Thrift.pyihttps://github.com/python/typeshed/pull/1827/files#diff-6f349e4d97f2a649a45c2bbf7e7843cac9851a2ac068ce0d36cc5acf081e4d55
View file https://github.com/python/typeshed/blob/72052d8338147384bc1e09ba9e313cfb7d0ad16d/third_party/2and3/thrift/Thrift.pyi
Open in desktop https://desktop.github.com
Please reload this pagehttps://github.com/python/typeshed/pull/1827/files
third_party/2and3/thrift/__init__.pyihttps://github.com/python/typeshed/pull/1827/files#diff-1493584eb90f0a98512b458521df290c7a216ff57e4303eec1f7feb43af49387
View file https://github.com/python/typeshed/blob/72052d8338147384bc1e09ba9e313cfb7d0ad16d/third_party/2and3/thrift/__init__.pyi
Open in desktop https://desktop.github.com
third_party/2and3/thrift/protocol/TBinaryProtocol.pyihttps://github.com/python/typeshed/pull/1827/files#diff-4a7573eed3d85716aa63b7e99b525c4711d44b194de8661183bb8e904427fc06
View file https://github.com/python/typeshed/blob/72052d8338147384bc1e09ba9e313cfb7d0ad16d/third_party/2and3/thrift/protocol/TBinaryProtocol.pyi
Open in desktop https://desktop.github.com
Please reload this pagehttps://github.com/python/typeshed/pull/1827/files
third_party/2and3/thrift/protocol/TProtocol.pyihttps://github.com/python/typeshed/pull/1827/files#diff-cfc47663356c9160431a238e92a9f2e2768b98ef0e20a1efc02bfb021e2b3282
View file https://github.com/python/typeshed/blob/72052d8338147384bc1e09ba9e313cfb7d0ad16d/third_party/2and3/thrift/protocol/TProtocol.pyi
Open in desktop https://desktop.github.com
Please reload this pagehttps://github.com/python/typeshed/pull/1827/files
third_party/2and3/thrift/protocol/__init__.pyihttps://github.com/python/typeshed/pull/1827/files#diff-1ed67483a29bafa7788331d233e977336de0549020e243a8f751e0f57b021db6
View file https://github.com/python/typeshed/blob/72052d8338147384bc1e09ba9e313cfb7d0ad16d/third_party/2and3/thrift/protocol/__init__.pyi
Open in desktop https://desktop.github.com
Please reload this pagehttps://github.com/python/typeshed/pull/1827/files
third_party/2and3/thrift/transport/TSocket.pyihttps://github.com/python/typeshed/pull/1827/files#diff-adb5cbba809602bb7a4cccbc1416d030c72428bea4af31e96bf1487d446417e7
View file https://github.com/python/typeshed/blob/72052d8338147384bc1e09ba9e313cfb7d0ad16d/third_party/2and3/thrift/transport/TSocket.pyi
Open in desktop https://desktop.github.com
Please reload this pagehttps://github.com/python/typeshed/pull/1827/files
third_party/2and3/thrift/transport/TTransport.pyihttps://github.com/python/typeshed/pull/1827/files#diff-cc0da7e5e9f66aad4bf075482a01982c6b645c6dbc79c1a46f2a0c46cad3ca4a
View file https://github.com/python/typeshed/blob/72052d8338147384bc1e09ba9e313cfb7d0ad16d/third_party/2and3/thrift/transport/TTransport.pyi
Open in desktop https://desktop.github.com
Please reload this pagehttps://github.com/python/typeshed/pull/1827/files
third_party/2and3/thrift/transport/__init__.pyihttps://github.com/python/typeshed/pull/1827/files#diff-ac782e832467a5341e8ea188fd8e9d41797236f69f66a1fc30c12f1ff73291d0
View file https://github.com/python/typeshed/blob/72052d8338147384bc1e09ba9e313cfb7d0ad16d/third_party/2and3/thrift/transport/__init__.pyi
Open in desktop https://desktop.github.com
Please reload this pagehttps://github.com/python/typeshed/pull/1827/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.