René's URL Explorer Experiment


Title: Fix `missing slot` false positives for `finalize.atexit` & `TarInfo.path` by zyv · Pull Request #16333 · python/typeshed · GitHub

Open Graph Title: Fix `missing slot` false positives for `finalize.atexit` & `TarInfo.path` by zyv · Pull Request #16333 · python/typeshed

X Title: Fix `missing slot` false positives for `finalize.atexit` & `TarInfo.path` by zyv · Pull Request #16333 · python/typeshed

Description: Both are declared as bare instance attributes on classes whose stub also declares __slots__ without them, so type checkers reject every assignment to them even though the runtime allows it. CPython implements both as read-write properties. weakref.finalize (Lib/weakref.py) has __slots__ = () and implements atexit as a property with a setter; the neighbouring alive is already modelled as a property in typeshed. tarfile.TarInfo (Lib/tarfile.py) implements path as a read-write property aliasing name, exactly like linkpath aliases linkname; linkpath is already modelled as a property, path was not, and path is absent from the __slots__ tuple. Reproducer, rejected before and accepted after this patch: import tarfile import weakref class C: ... def f(c: C, ti: tarfile.TarInfo) -> None: weakref.finalize(c, print).atexit = False ti.path = "x" mypy 2.3.1 before: error: Trying to assign name "atexit" that is not in "__slots__" of type "weakref.finalize" [misc] error: Trying to assign name "path" that is not in "__slots__" of type "tarfile.TarInfo" [misc] ty 0.0.77 reports the same two as missing-slot; pyrefly reports missing-attribute. stubtest output is unchanged for both modules. The __slots__ entries came from the automated sweep in #14611 (part of #8832). The attribute declarations predate it, so the contradiction was introduced by adding __slots__ on top of them rather than by the annotations themselves.

Open Graph Description: Both are declared as bare instance attributes on classes whose stub also declares __slots__ without them, so type checkers reject every assignment to them even though the runtime allows it. CPython...

X Description: Both are declared as bare instance attributes on classes whose stub also declares __slots__ without them, so type checkers reject every assignment to them even though the runtime allows it. CPython...

Opengraph URL: https://github.com/python/typeshed/pull/16333

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c46ecbf3-fe7c-d23d-ac8b-e42a9a6abdee
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCB5E:1DD784:3CC2C2:5199DE:6B002A3B
html-safe-nonce1c2b88500d806fcf587bda967b47f92b674891bddf7b13f3004d68c0b1773426
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQjVFOjFERDc4NDozQ0MyQzI6NTE5OURFOjZCMDAyQTNCIiwidmlzaXRvcl9pZCI6IjY4ODA2OTQ5OTM3NDU0NTQ2NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac44fd76f203d4ae05e07b3f13c64fb4de0e5a8818546bbbfc8f47873b5361ab1b
hovercard-subject-tagpull_request:4410205437
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/typeshed/pull/16333/files
twitter:imagehttps://avatars.githubusercontent.com/u/607401?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/607401?s=400&v=4
og:image:altBoth are declared as bare instance attributes on classes whose stub also declares __slots__ without them, so type checkers reject every assignment to them even though the runtime allows it. CPython...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/typeshed git https://github.com/python/typeshed.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id31696383
octolytics-dimension-repository_nwopython/typeshed
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id31696383
octolytics-dimension-repository_network_root_nwopython/typeshed
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/typeshed/pull/16333/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fpull%2F16333%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fpull%2F16333%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Ftypeshed
Reloadhttps://github.com/python/typeshed/pull/16333/files
Reloadhttps://github.com/python/typeshed/pull/16333/files
Reloadhttps://github.com/python/typeshed/pull/16333/files
pythonhttps://github.com/python
typeshedhttps://github.com/python/typeshed
Codehttps://github.com/python/typeshed
Issues196 (196)https://github.com/python/typeshed/issues
Pull requests251 (251)https://github.com/python/typeshed/pulls
Actionshttps://github.com/python/typeshed/actions
Security and qualityhttps://github.com/python/typeshed/security
Insightshttps://github.com/python/typeshed/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Ftypeshed%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Ftypeshed%2Fissues%2Fnew%2Fchoose
srittauhttps://github.com/srittau
python:mainhttps://github.com/python/typeshed/tree/main
zyv:slots-propertieshttps://github.com/zyv/typeshed/tree/slots-properties
Conversation 3 https://github.com/python/typeshed/pull/16333
Commits 1 https://github.com/python/typeshed/pull/16333/commits
Checks 87 https://github.com/python/typeshed/pull/16333/checks
Files changed https://github.com/python/typeshed/pull/16333/files
Please reload this pagehttps://github.com/python/typeshed/pull/16333/files
Fix missing slot false positives for finalize.atexit & TarInfo.path https://github.com/python/typeshed/pull/16333/files#top
Show all changes 1 commit https://github.com/python/typeshed/pull/16333/files
1b6b45e Model `finalize.atexit` and `TarInfo.path` as properties zyv Sep 1, 2026 https://github.com/python/typeshed/pull/16333/commits/1b6b45e20c18269e4ad971f6cd59f23aed09b98f
Clear filters https://github.com/python/typeshed/pull/16333/files
Please reload this pagehttps://github.com/python/typeshed/pull/16333/files
Please reload this pagehttps://github.com/python/typeshed/pull/16333/files
tarfile.pyi https://github.com/python/typeshed/pull/16333/files#diff-27d64f76f95d4a6214902f937984699bb97f313cd6808cfbbe1256eceafaf45e
weakref.pyi https://github.com/python/typeshed/pull/16333/files#diff-629e15983c21d1c7bebf937d70dfd14892c064b999ca0522d62778cff91d2831
stdlib/tarfile.pyihttps://github.com/python/typeshed/pull/16333/files#diff-27d64f76f95d4a6214902f937984699bb97f313cd6808cfbbe1256eceafaf45e
View file https://github.com/zyv/typeshed/blob/1b6b45e20c18269e4ad971f6cd59f23aed09b98f/stdlib/tarfile.pyi
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typeshed/pull/16333/{{ revealButtonHref }}
https://github.com/python/typeshed/pull/16333/files#diff-27d64f76f95d4a6214902f937984699bb97f313cd6808cfbbe1256eceafaf45e
https://github.com/python/typeshed/pull/16333/files#diff-27d64f76f95d4a6214902f937984699bb97f313cd6808cfbbe1256eceafaf45e
https://github.com/python/typeshed/pull/16333/files#diff-27d64f76f95d4a6214902f937984699bb97f313cd6808cfbbe1256eceafaf45e
https://github.com/python/typeshed/pull/16333/files#diff-27d64f76f95d4a6214902f937984699bb97f313cd6808cfbbe1256eceafaf45e
stdlib/weakref.pyihttps://github.com/python/typeshed/pull/16333/files#diff-629e15983c21d1c7bebf937d70dfd14892c064b999ca0522d62778cff91d2831
View file https://github.com/zyv/typeshed/blob/1b6b45e20c18269e4ad971f6cd59f23aed09b98f/stdlib/weakref.pyi
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typeshed/pull/16333/{{ revealButtonHref }}
https://github.com/python/typeshed/pull/16333/files#diff-629e15983c21d1c7bebf937d70dfd14892c064b999ca0522d62778cff91d2831
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.