René's URL Explorer Experiment


Title: Add type signatures to `lru_cache` using descriptor protocol (not ready to merge) by alwaysmpe · Pull Request #13043 · python/typeshed · GitHub

Open Graph Title: Add type signatures to `lru_cache` using descriptor protocol (not ready to merge) by alwaysmpe · Pull Request #13043 · python/typeshed

X Title: Add type signatures to `lru_cache` using descriptor protocol (not ready to merge) by alwaysmpe · Pull Request #13043 · python/typeshed

Description: This is an alternate approach to #13033 (appologies for multiple PRs, tricky problem). That approach tries to solve the problem using multiple overloads but has some limitations, this has different limitations. This changes lru_cache callable signature to use ParamSpec. Also provides descriptor protocol __get__ functions that match the behaviour of methods/classmethods/staticmethods as appropriate to bind the first parameter in the call signature. This is more robust/resistant to false positives because the first parameter should only be bindable as a method if it matches the type of object through which its accessed, likewise binding of classmethods. And a pure member variable should not use descriptor getters. This possibly depends on a very precise interpretation of the typing standard so I may be wrong. So far from what I've found in pyright this works well with a few exceptions. overloads don't behave well with this cache. staticmethods that take as a first argument the type of the enclosing class have the first parameter bound when accessed through both the class and an instance. staticmethods that take as a first argument an instance of the enclosing class have the first parameter bound when accessed through an instance. From what I've found in mypy, if cache is combined with property it causes a type error. Overloads cause problems. Likewise problem with staticmethod taking enclosing type or instance as first parameter. The overload problem may be fixable in type checkers but I believe Eric from pyright has a proposal to clarify the typing spec for overloads, so nothing is likely to change before that. The staticmethod problem isn't very fixable.

Open Graph Description: This is an alternate approach to #13033 (appologies for multiple PRs, tricky problem). That approach tries to solve the problem using multiple overloads but has some limitations, this has different...

X Description: This is an alternate approach to #13033 (appologies for multiple PRs, tricky problem). That approach tries to solve the problem using multiple overloads but has some limitations, this has different...

Opengraph URL: https://github.com/python/typeshed/pull/13043

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f9518643-a5d6-bc8e-fae1-d10562c66d95
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC1A0:196792:2E73045:3D92B45:6B002A2F
html-safe-nonce8abcc5ca3b84d5aae2835cdf27f13cbb0eb7b2f671bce4466428e447fd8bbfd1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMUEwOjE5Njc5MjoyRTczMDQ1OjNEOTJCNDU6NkIwMDJBMkYiLCJ2aXNpdG9yX2lkIjoiODk1MDYxOTM1MDI0MzQ4NjI1NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac76ca69ca9c6cd650891b271583c3184a9b3589e4b08f74b2a6a36e27049d9123
hovercard-subject-tagpull_request:2186310521
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/typeshed/pull/13043/files
twitter:imagehttps://avatars.githubusercontent.com/u/10211004?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/10211004?s=400&v=4
og:image:altThis is an alternate approach to #13033 (appologies for multiple PRs, tricky problem). That approach tries to solve the problem using multiple overloads but has some limitations, this has different...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/typeshed git https://github.com/python/typeshed.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id31696383
octolytics-dimension-repository_nwopython/typeshed
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id31696383
octolytics-dimension-repository_network_root_nwopython/typeshed
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/typeshed/pull/13043/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fpull%2F13043%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fpull%2F13043%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Ftypeshed
Reloadhttps://github.com/python/typeshed/pull/13043/files
Reloadhttps://github.com/python/typeshed/pull/13043/files
Reloadhttps://github.com/python/typeshed/pull/13043/files
pythonhttps://github.com/python
typeshedhttps://github.com/python/typeshed
Codehttps://github.com/python/typeshed
Issues196 (196)https://github.com/python/typeshed/issues
Pull requests251 (251)https://github.com/python/typeshed/pulls
Actionshttps://github.com/python/typeshed/actions
Security and qualityhttps://github.com/python/typeshed/security
Insightshttps://github.com/python/typeshed/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Ftypeshed%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Ftypeshed%2Fissues%2Fnew%2Fchoose
alwaysmpehttps://github.com/alwaysmpe
python:mainhttps://github.com/python/typeshed/tree/main
alwaysmpe:cache-descriptorhttps://github.com/alwaysmpe/typeshed/tree/cache-descriptor
Conversation 9 https://github.com/python/typeshed/pull/13043
Commits 2 https://github.com/python/typeshed/pull/13043/commits
Checks 0 https://github.com/python/typeshed/pull/13043/checks
Files changed https://github.com/python/typeshed/pull/13043/files
Please reload this pagehttps://github.com/python/typeshed/pull/13043/files
Add type signatures to lru_cache using descriptor protocol (not ready to merge) https://github.com/python/typeshed/pull/13043/files#top
Show all changes 2 commits https://github.com/python/typeshed/pull/13043/files
155f837 Add types to `lru_cache` by implementing descriptor protocol alwaysmpe Nov 18, 2024 https://github.com/python/typeshed/pull/13043/commits/155f837d3b07486773d22b1008f00785f0b9a4eb
d309de4 [pre-commit.ci] auto fixes from pre-commit.com hooks pre-commit-ci[bot] Nov 18, 2024 https://github.com/python/typeshed/pull/13043/commits/d309de479ef93869edbfc8ed73a57b1481ed9d82
Clear filters https://github.com/python/typeshed/pull/13043/files
Please reload this pagehttps://github.com/python/typeshed/pull/13043/files
Please reload this pagehttps://github.com/python/typeshed/pull/13043/files
check_lru_cache.py https://github.com/python/typeshed/pull/13043/files#diff-4fa87f761bde3866fd5b6f533adff44652344d886eb9cf496562b500b49b9c92
functools.pyi https://github.com/python/typeshed/pull/13043/files#diff-02c51ed45b741b6765c365fb5d6578c586510bbbd57b10a1dba10aeba37ae157
stdlib/@tests/test_cases/check_lru_cache.pyhttps://github.com/python/typeshed/pull/13043/files#diff-4fa87f761bde3866fd5b6f533adff44652344d886eb9cf496562b500b49b9c92
View file https://github.com/alwaysmpe/typeshed/blob/d309de479ef93869edbfc8ed73a57b1481ed9d82/stdlib/%40tests/test_cases/check_lru_cache.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typeshed/pull/13043/{{ revealButtonHref }}
alwaysmpehttps://github.com/alwaysmpe
Nov 18, 2024https://github.com/python/typeshed/pull/13043/files#r1847414035
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/typeshed/pull/13043/files
alwaysmpehttps://github.com/alwaysmpe
Nov 18, 2024https://github.com/python/typeshed/pull/13043/files#r1847430269
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/typeshed/pull/13043/files
alwaysmpehttps://github.com/alwaysmpe
Nov 18, 2024https://github.com/python/typeshed/pull/13043/files#r1847420524
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/typeshed/pull/13043/files
alwaysmpehttps://github.com/alwaysmpe
Nov 18, 2024https://github.com/python/typeshed/pull/13043/files#r1847423312
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/typeshed/pull/13043/files
stdlib/functools.pyihttps://github.com/python/typeshed/pull/13043/files#diff-02c51ed45b741b6765c365fb5d6578c586510bbbd57b10a1dba10aeba37ae157
View file https://github.com/alwaysmpe/typeshed/blob/d309de479ef93869edbfc8ed73a57b1481ed9d82/stdlib/functools.pyi
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typeshed/pull/13043/{{ revealButtonHref }}
https://github.com/python/typeshed/pull/13043/files#diff-02c51ed45b741b6765c365fb5d6578c586510bbbd57b10a1dba10aeba37ae157
https://github.com/python/typeshed/pull/13043/files#diff-02c51ed45b741b6765c365fb5d6578c586510bbbd57b10a1dba10aeba37ae157
https://github.com/python/typeshed/pull/13043/files#diff-02c51ed45b741b6765c365fb5d6578c586510bbbd57b10a1dba10aeba37ae157
https://github.com/python/typeshed/pull/13043/files#diff-02c51ed45b741b6765c365fb5d6578c586510bbbd57b10a1dba10aeba37ae157
https://github.com/python/typeshed/pull/13043/files#diff-02c51ed45b741b6765c365fb5d6578c586510bbbd57b10a1dba10aeba37ae157
https://github.com/python/typeshed/pull/13043/files#diff-02c51ed45b741b6765c365fb5d6578c586510bbbd57b10a1dba10aeba37ae157
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.