René's URL Explorer Experiment


Title: Add type signatures to `lru_cache` using overloads (not ready to merge) by alwaysmpe · Pull Request #13033 · python/typeshed · GitHub

Open Graph Title: Add type signatures to `lru_cache` using overloads (not ready to merge) by alwaysmpe · Pull Request #13033 · python/typeshed

X Title: Add type signatures to `lru_cache` using overloads (not ready to merge) by alwaysmpe · Pull Request #13033 · python/typeshed

Description: Undecided if this is a good way to go, but marked as for review to see what others say. I've added some notes on output of mypy_primer at the end, there are a couple of unexpected errors but mostly good. Change lru_cache callable signature to use ParamSpec. This has previously been tried unsuccessfully (#11662) due to compatibility with the classmethod decorator. I've attempted to solve that compatibility by using overloads that do/don't include the necessary cls and self parameter when it appearrs that a method/classmethod is being cached. This removes the Hashable constraint on parameters. Instead, this uses the function signatures (almost) correctly (methods and class methods have 2 overloads, one with and without cls and self, but I think this would be less error prone than currently, could possibly be refined). As a trivial example, the below type checks correctly from functools import cache @cache def foo(arg: str): ... foo(1) # correctly raises type error foo("1") foo.cache_clear() There is a more comprehensive example that I've been using to test in #12952 which (with 2 minor exceptions) type checks perfectly.

Open Graph Description: Undecided if this is a good way to go, but marked as for review to see what others say. I've added some notes on output of mypy_primer at the end, there are a couple of unexpected errors but mo...

X Description: Undecided if this is a good way to go, but marked as for review to see what others say. I've added some notes on output of mypy_primer at the end, there are a couple of unexpected errors bu...

Opengraph URL: https://github.com/python/typeshed/pull/13033

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:cc06cb61-0c29-ad83-4970-688ddf987225
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAEAA:1F52F6:2D05C8:3CF158:6B00261D
html-safe-nonce5a325b73d35b9f8ef17cf55899afc163aa1c090a673a8c0601f1d5fe0b6f2936
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRUFBOjFGNTJGNjoyRDA1Qzg6M0NGMTU4OjZCMDAyNjFEIiwidmlzaXRvcl9pZCI6IjE0NTc2MDI3NTQwNTM2Nzg2MjEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac797d97bcdbd61f99f32083d22dcc0acbf4a88e4a506709aac50979556ca48ad8
hovercard-subject-tagpull_request:2184010367
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/typeshed/pull/13033/files
twitter:imagehttps://avatars.githubusercontent.com/u/10211004?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/10211004?s=400&v=4
og:image:altUndecided if this is a good way to go, but marked as for review to see what others say. I've added some notes on output of mypy_primer at the end, there are a couple of unexpected errors but mo...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/typeshed git https://github.com/python/typeshed.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id31696383
octolytics-dimension-repository_nwopython/typeshed
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id31696383
octolytics-dimension-repository_network_root_nwopython/typeshed
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release44c658b24abf00491fb7ae5f56d42c9f38cbeab2
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/typeshed/pull/13033/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fpull%2F13033%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fpull%2F13033%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Ftypeshed
Reloadhttps://github.com/python/typeshed/pull/13033/files
Reloadhttps://github.com/python/typeshed/pull/13033/files
Reloadhttps://github.com/python/typeshed/pull/13033/files
pythonhttps://github.com/python
typeshedhttps://github.com/python/typeshed
Codehttps://github.com/python/typeshed
Issues196 (196)https://github.com/python/typeshed/issues
Pull requests251 (251)https://github.com/python/typeshed/pulls
Actionshttps://github.com/python/typeshed/actions
Security and qualityhttps://github.com/python/typeshed/security
Insightshttps://github.com/python/typeshed/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Ftypeshed%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Ftypeshed%2Fissues%2Fnew%2Fchoose
alwaysmpehttps://github.com/alwaysmpe
python:mainhttps://github.com/python/typeshed/tree/main
alwaysmpe:cache-overloadhttps://github.com/alwaysmpe/typeshed/tree/cache-overload
Conversation 13 https://github.com/python/typeshed/pull/13033
Commits 2 https://github.com/python/typeshed/pull/13033/commits
Checks 0 https://github.com/python/typeshed/pull/13033/checks
Files changed https://github.com/python/typeshed/pull/13033/files
Please reload this pagehttps://github.com/python/typeshed/pull/13033/files
Add type signatures to lru_cache using overloads (not ready to merge) https://github.com/python/typeshed/pull/13033/files#top
Show all changes 2 commits https://github.com/python/typeshed/pull/13033/files
fff1058 Add type signatures to lru_cache alwaysmpe Nov 17, 2024 https://github.com/python/typeshed/pull/13033/commits/fff10587278fef318b44871174c5a9da56eaf684
03e550f [pre-commit.ci] auto fixes from pre-commit.com hooks pre-commit-ci[bot] Nov 18, 2024 https://github.com/python/typeshed/pull/13033/commits/03e550f3ec81544519730fb9804bc58b0535c270
Clear filters https://github.com/python/typeshed/pull/13033/files
Please reload this pagehttps://github.com/python/typeshed/pull/13033/files
Please reload this pagehttps://github.com/python/typeshed/pull/13033/files
stdlib/functools.pyihttps://github.com/python/typeshed/pull/13033/files#diff-02c51ed45b741b6765c365fb5d6578c586510bbbd57b10a1dba10aeba37ae157
View file https://github.com/alwaysmpe/typeshed/blob/03e550f3ec81544519730fb9804bc58b0535c270/stdlib/functools.pyi
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typeshed/pull/13033/{{ revealButtonHref }}
https://github.com/python/typeshed/pull/13033/files#diff-02c51ed45b741b6765c365fb5d6578c586510bbbd57b10a1dba10aeba37ae157
https://github.com/python/typeshed/pull/13033/files#diff-02c51ed45b741b6765c365fb5d6578c586510bbbd57b10a1dba10aeba37ae157
https://github.com/python/typeshed/pull/13033/files#diff-02c51ed45b741b6765c365fb5d6578c586510bbbd57b10a1dba10aeba37ae157
https://github.com/python/typeshed/pull/13033/files#diff-02c51ed45b741b6765c365fb5d6578c586510bbbd57b10a1dba10aeba37ae157
alwaysmpehttps://github.com/alwaysmpe
Nov 18, 2024https://github.com/python/typeshed/pull/13033/files#r1846422533
Please reload this pagehttps://github.com/python/typeshed/pull/13033/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@Daverballhttps://github.com/Daverball
Please reload this pagehttps://github.com/python/typeshed/pull/13033/files
Daverballhttps://github.com/Daverball
Nov 18, 2024https://github.com/python/typeshed/pull/13033/files#r1846451895
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/typeshed/pull/13033/files
https://github.com/python/typeshed/pull/13033/files#diff-02c51ed45b741b6765c365fb5d6578c586510bbbd57b10a1dba10aeba37ae157
https://github.com/python/typeshed/pull/13033/files#diff-02c51ed45b741b6765c365fb5d6578c586510bbbd57b10a1dba10aeba37ae157
https://github.com/python/typeshed/pull/13033/files#diff-02c51ed45b741b6765c365fb5d6578c586510bbbd57b10a1dba10aeba37ae157
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.