René's URL Explorer Experiment


Title: Change `cache`/`lru_cache` typing to retain function signatures by alwaysmpe · Pull Request #12945 · python/typeshed · GitHub

Open Graph Title: Change `cache`/`lru_cache` typing to retain function signatures by alwaysmpe · Pull Request #12945 · python/typeshed

X Title: Change `cache`/`lru_cache` typing to retain function signatures by alwaysmpe · Pull Request #12945 · python/typeshed

Description: My attempt at fixing the cache & lru_cache typing problem. Using the newer generics syntax I get the same result in both mypy and pyright. Using the older typevar syntax (which I'm less familiar with) I get different errors. See my comment for the newer generics approach. Using these type stubs in pyright the below code checks as expected, mypy thinks some of the type invariance should be different (update: I've pushed changes to match mypy's preference) Update: think I've worked it out, converting to draft while making changes. from functools import cache class CFnCls: @cache def fn(self, arg: int) -> int: print("method fn called") return arg @classmethod @cache def cls_fn(cls, arg: int) -> int: print("class fn called") return arg @staticmethod @cache def st_fn(arg: int) -> int: print("static fn called") return arg cfn_inst = CFnCls() cfn_inst.fn(1) CFnCls.st_fn(1) CFnCls.cls_fn(1) cfn_inst.fn(1) CFnCls.st_fn(1) CFnCls.cls_fn(1) assert_type(cfn_inst.fn(1), int) assert_type(CFnCls.st_fn(1), int) assert_type(CFnCls.cls_fn(1), int) CFnCls().fn.cache_clear() CFnCls.fn.cache_clear() CFnCls.st_fn.cache_clear() CFnCls.cls_fn.cache_clear() if TYPE_CHECKING: CFnCls().fn(1, 1) # type error - correct CFnCls.st_fn(1, 1) # type error - correct CFnCls.cls_fn(1, 1) # type error - correct @cache def fn(arg: int) -> int: return arg @cache def df_fn(arg: int, darg: str = "default"): print("default fn called") return darg df_fn(1) fn(1) assert_type(fn(1), int) if TYPE_CHECKING: fn(1, 2) # type error - correct fn.cache_clear() @overload @cache def fn_overload(arg: int) -> int: ... @overload @cache def fn_overload(arg: str) -> str: ... @cache def fn_overload(arg: int | str) -> int | str: return arg fn_overload(1) fn_overload("1") # behaves same as previous cache, merges overloads assert_type(fn_overload(1), int | str) assert_type(fn_overload("1"), int | str) fn_overload.cache_clear() if TYPE_CHECKING: fn_overload({1,2}) # type error - correct class Unhashable: @override def __eq__(self, value: object) -> bool: return False @cache def no_cache(arg: Unhashable, arg2: int) -> None: pass if TYPE_CHECKING: # type error in pyright - correct # no type error in mypy? no_cache(Unhashable(), 2) Define overloads for cache/lru_cache that are constrained by the signature of the function they're called with. This assumes self as a first parameter is a function method, cls is a classmethod and everything else are either static methods or functions. Then direct each overload to a descriptor protocol that mirrors the binding behaviour of methods/functions/classmethods. The returned type is then a union with a callable that takes arbitrary arguments that are hashable. This means that the previous hashable requirement is retained (type checkers don't know which type was returned so calls must satisfy both, the union takes any arguments as long as they're hashable while the descriptor protocol mirrors the cached function's behaviour).

Open Graph Description: My attempt at fixing the cache & lru_cache typing problem. Using the newer generics syntax I get the same result in both mypy and pyright. Using the older typevar syntax (which I'm less fam...

X Description: My attempt at fixing the cache & lru_cache typing problem. Using the newer generics syntax I get the same result in both mypy and pyright. Using the older typevar syntax (which I'm ...

Opengraph URL: https://github.com/python/typeshed/pull/12945

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:2b5c39a2-57d3-1dfe-0000-5563a2c5fd26
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9C6A:4D728:31FE9C1:41FE4B6:6B00303F
html-safe-nonced210faed4b804b2090faa34925b8de895c2a52a8f75436c011a0ce79be1de3ba
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QzZBOjRENzI4OjMxRkU5QzE6NDFGRTRCNjo2QjAwMzAzRiIsInZpc2l0b3JfaWQiOiIyNzE5NTg1NDM5Nzg5ODg3NTUxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac5193525cc9de09b4c355458ac534135121bfa29360317b8f91cc63123fbaa301
hovercard-subject-tagpull_request:2159536749
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/typeshed/pull/12945/files
twitter:imagehttps://avatars.githubusercontent.com/u/10211004?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/10211004?s=400&v=4
og:image:altMy attempt at fixing the cache & lru_cache typing problem. Using the newer generics syntax I get the same result in both mypy and pyright. Using the older typevar syntax (which I'm less fam...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/typeshed git https://github.com/python/typeshed.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id31696383
octolytics-dimension-repository_nwopython/typeshed
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id31696383
octolytics-dimension-repository_network_root_nwopython/typeshed
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/typeshed/pull/12945/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fpull%2F12945%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fpull%2F12945%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Ftypeshed
Reloadhttps://github.com/python/typeshed/pull/12945/files
Reloadhttps://github.com/python/typeshed/pull/12945/files
Reloadhttps://github.com/python/typeshed/pull/12945/files
pythonhttps://github.com/python
typeshedhttps://github.com/python/typeshed
Codehttps://github.com/python/typeshed
Issues196 (196)https://github.com/python/typeshed/issues
Pull requests251 (251)https://github.com/python/typeshed/pulls
Actionshttps://github.com/python/typeshed/actions
Security and qualityhttps://github.com/python/typeshed/security
Insightshttps://github.com/python/typeshed/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Ftypeshed%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Ftypeshed%2Fissues%2Fnew%2Fchoose
alwaysmpehttps://github.com/alwaysmpe
python:mainhttps://github.com/python/typeshed/tree/main
alwaysmpe:mainhttps://github.com/alwaysmpe/typeshed/tree/main
Conversation 16 https://github.com/python/typeshed/pull/12945
Commits 15 https://github.com/python/typeshed/pull/12945/commits
Checks 0 https://github.com/python/typeshed/pull/12945/checks
Files changed https://github.com/python/typeshed/pull/12945/files
Please reload this pagehttps://github.com/python/typeshed/pull/12945/files
Change cache/lru_cache typing to retain function signatures https://github.com/python/typeshed/pull/12945/files#top
Show all changes 15 commits https://github.com/python/typeshed/pull/12945/files
5ca2ed5 Change `cache`/`lru_cache` typing to retain function signatures alwaysmpe Nov 3, 2024 https://github.com/python/typeshed/pull/12945/commits/5ca2ed5863e84d840d8fe2bf5319d3ad960fbc2d
c16b351 [pre-commit.ci] auto fixes from pre-commit.com hooks pre-commit-ci[bot] Nov 3, 2024 https://github.com/python/typeshed/pull/12945/commits/c16b3518810021a6dd2e85013eb335f7ef86bce9
833e40e Fix remove overload implementation alwaysmpe Nov 3, 2024 https://github.com/python/typeshed/pull/12945/commits/833e40efc045c4ec278d5640d3c7d175695dd753
6e22af9 Fix add version gate for `typing.Concatenate` alwaysmpe Nov 3, 2024 https://github.com/python/typeshed/pull/12945/commits/6e22af965672bee00695ed4a45c8395bc4105258
ab29e6d Fix match mypy's expected type invariance alwaysmpe Nov 3, 2024 https://github.com/python/typeshed/pull/12945/commits/ab29e6d28130f5b35624c222a13a3e67567c12fe
3cbb714 [pre-commit.ci] auto fixes from pre-commit.com hooks pre-commit-ci[bot] Nov 3, 2024 https://github.com/python/typeshed/pull/12945/commits/3cbb7141f430843a86ce088866130e1e7e815b10
91f43a2 Fix copy/paste mistake alwaysmpe Nov 3, 2024 https://github.com/python/typeshed/pull/12945/commits/91f43a29151cf46a90e7f9d444de3ca27ac5f259
54e4fe0 [pre-commit.ci] auto fixes from pre-commit.com hooks pre-commit-ci[bot] Nov 3, 2024 https://github.com/python/typeshed/pull/12945/commits/54e4fe01fca651d5a700472fa00b5b1163a7a57c
fd0d180 Fix cache should be positional-only alwaysmpe Nov 3, 2024 https://github.com/python/typeshed/pull/12945/commits/fd0d180e957347fd7280a7e9fa70bbb8ef86c3c2
3aaf0ff [pre-commit.ci] auto fixes from pre-commit.com hooks pre-commit-ci[bot] Nov 3, 2024 https://github.com/python/typeshed/pull/12945/commits/3aaf0ff16186ac7bf8542de8102eb81f122a2c60
8c5c469 Remove what I think are nolonger needed ignores alwaysmpe Nov 3, 2024 https://github.com/python/typeshed/pull/12945/commits/8c5c4698376838954c94ddb710c821713a5ec570
28e87fc Fix final shouldn't have been removed alwaysmpe Nov 3, 2024 https://github.com/python/typeshed/pull/12945/commits/28e87fc73f0f6f5a7b255fde91a51de67ff4e710
1d1c46a [pre-commit.ci] auto fixes from pre-commit.com hooks pre-commit-ci[bot] Nov 3, 2024 https://github.com/python/typeshed/pull/12945/commits/1d1c46a9e3fb2481c95cae5c84b661eaf7edea59
d705819 Use type invariance recommended by pyright (which I think is correct) alwaysmpe Nov 3, 2024 https://github.com/python/typeshed/pull/12945/commits/d705819fbbc74a7b700faf49812a7d5f462a8f2a
6af9214 Various improvements alwaysmpe Nov 3, 2024 https://github.com/python/typeshed/pull/12945/commits/6af921487147f7bee12da2a2b05195db26014cb1
Clear filters https://github.com/python/typeshed/pull/12945/files
Please reload this pagehttps://github.com/python/typeshed/pull/12945/files
Please reload this pagehttps://github.com/python/typeshed/pull/12945/files
stdlib/functools.pyihttps://github.com/python/typeshed/pull/12945/files#diff-02c51ed45b741b6765c365fb5d6578c586510bbbd57b10a1dba10aeba37ae157
View file https://github.com/alwaysmpe/typeshed/blob/6af921487147f7bee12da2a2b05195db26014cb1/stdlib/functools.pyi
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typeshed/pull/12945/{{ revealButtonHref }}
https://github.com/python/typeshed/pull/12945/files#diff-02c51ed45b741b6765c365fb5d6578c586510bbbd57b10a1dba10aeba37ae157
https://github.com/python/typeshed/pull/12945/files#diff-02c51ed45b741b6765c365fb5d6578c586510bbbd57b10a1dba10aeba37ae157
https://github.com/python/typeshed/pull/12945/files#diff-02c51ed45b741b6765c365fb5d6578c586510bbbd57b10a1dba10aeba37ae157
https://github.com/python/typeshed/pull/12945/files#diff-02c51ed45b741b6765c365fb5d6578c586510bbbd57b10a1dba10aeba37ae157
https://github.com/python/typeshed/pull/12945/files#diff-02c51ed45b741b6765c365fb5d6578c586510bbbd57b10a1dba10aeba37ae157
https://github.com/python/typeshed/pull/12945/files#diff-02c51ed45b741b6765c365fb5d6578c586510bbbd57b10a1dba10aeba37ae157
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.