René's URL Explorer Experiment


Title: Add more return types to the `numbers` module by AlexWaygood · Pull Request #11353 · python/typeshed · GitHub

Open Graph Title: Add more return types to the `numbers` module by AlexWaygood · Pull Request #11353 · python/typeshed

X Title: Add more return types to the `numbers` module by AlexWaygood · Pull Request #11353 · python/typeshed

Description: This PR represents a compromise between what the numbers module was supposed to be, and the reality of where we are today with Python's typing system. This module is supposed to provide a framework of ABCs that would allow for third-party implementations of Complex, Rational, Real and Integral numbers. As such, the annotations we should be giving to the Real class should be something like this: class Real: @abstractmethod def __mod__(self, other: Real) -> Real: ... @abstractmethod def __round__(self, ndigits: int) -> Real: ... @abstractmethod def __divmod__(self, other: Real) -> tuple[Real, Real]: ... Unfortunately, that doesn't work! The reason is that fractions.Fraction inherits from numbers.Real, and it overrides these abstract methods to provide concrete implementations. The concrete implementations return concrete types such as int, which type checkers don't recognise as subtypes of Real (because the numbers module has never been supported by static type checkers, and never will be): typeshed/stdlib/fractions.pyi Lines 105 to 106 in 547cbc7 @overload def __divmod__(a, b: int | Fraction) -> tuple[int, Fraction]: ... As such, for every method I tried adding types to according to the above strategy, mypy emitted an error warning me that fractions.Fraction incompatibly overrode numbers.Real. (There were also similar errors for a numbers.Real subclass in our Pillow stubs.) Instead of returning Complex from methods that really should be returning Complex, therefore, this PR annotates those methods as returning SupportsComplex. SupportsComplex works pretty well here: It's a supertype of numbers.Complex, so it's not incorrect It's a good deal more precise than Any It's vague enough that it will permit third-party subclassers to return their own implementations of numbers.Complex from these methods, which is what the module was designed for anyway. In a similar way, I've annotated methods that should be returning numbers.Integral as returning SupportsIndex, and I've annotated methods that should be returning numbers.Real as returning SupportsFloat. I haven't attempted to add any new argument annotations as part of this PR. The return annotations were hard enough.

Open Graph Description: This PR represents a compromise between what the numbers module was supposed to be, and the reality of where we are today with Python's typing system. This module is supposed to provide a frame...

X Description: This PR represents a compromise between what the numbers module was supposed to be, and the reality of where we are today with Python's typing system. This module is supposed to provide a f...

Opengraph URL: https://github.com/python/typeshed/pull/11353

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:06141fac-0a29-320b-bc4d-813a30e4e3ee
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD7D0:3E4AC7:2523865:3265656:6B0032E1
html-safe-noncefdcd88e29b01f5b915396b262c93693ab58eb0682fd546fdaf10799e02cdaca9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEN0QwOjNFNEFDNzoyNTIzODY1OjMyNjU2NTY6NkIwMDMyRTEiLCJ2aXNpdG9yX2lkIjoiNzU3NjYxMTIzNDM4OTE3NzA1NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac18e724657e8518d3c0fa643079e5d081a214885ecd8d3cc6989c8171044d8a91
hovercard-subject-tagpull_request:1706488283
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/typeshed/pull/11353/files
twitter:imagehttps://avatars.githubusercontent.com/u/66076021?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/66076021?s=400&v=4
og:image:altThis PR represents a compromise between what the numbers module was supposed to be, and the reality of where we are today with Python's typing system. This module is supposed to provide a frame...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/typeshed git https://github.com/python/typeshed.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id31696383
octolytics-dimension-repository_nwopython/typeshed
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id31696383
octolytics-dimension-repository_network_root_nwopython/typeshed
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/typeshed/pull/11353/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fpull%2F11353%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fpull%2F11353%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Ftypeshed
Reloadhttps://github.com/python/typeshed/pull/11353/files
Reloadhttps://github.com/python/typeshed/pull/11353/files
Reloadhttps://github.com/python/typeshed/pull/11353/files
pythonhttps://github.com/python
typeshedhttps://github.com/python/typeshed
Codehttps://github.com/python/typeshed
Issues196 (196)https://github.com/python/typeshed/issues
Pull requests251 (251)https://github.com/python/typeshed/pulls
Actionshttps://github.com/python/typeshed/actions
Security and qualityhttps://github.com/python/typeshed/security
Insightshttps://github.com/python/typeshed/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Ftypeshed%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Ftypeshed%2Fissues%2Fnew%2Fchoose
AlexWaygoodhttps://github.com/AlexWaygood
python:mainhttps://github.com/python/typeshed/tree/main
AlexWaygood:numbers-compromisehttps://github.com/AlexWaygood/typeshed/tree/numbers-compromise
Conversation 13 https://github.com/python/typeshed/pull/11353
Commits 5 https://github.com/python/typeshed/pull/11353/commits
Checks 0 https://github.com/python/typeshed/pull/11353/checks
Files changed https://github.com/python/typeshed/pull/11353/files
Please reload this pagehttps://github.com/python/typeshed/pull/11353/files
Add more return types to the numbers module https://github.com/python/typeshed/pull/11353/files#top
Show all changes 5 commits https://github.com/python/typeshed/pull/11353/files
3a63a18 Add more return types to the `numbers` module AlexWaygood Feb 1, 2024 https://github.com/python/typeshed/pull/11353/commits/3a63a18216a00cbff1d5dc9fd39875f8533d5d50
e64f895 py310 compat AlexWaygood Feb 1, 2024 https://github.com/python/typeshed/pull/11353/commits/e64f895d9d569ab0abbb7e44df7f8f0c09f2160e
feb3365 stubtest AlexWaygood Feb 1, 2024 https://github.com/python/typeshed/pull/11353/commits/feb33657377359bc7a15718d10f6f557008b220c
687709c Address review AlexWaygood Feb 1, 2024 https://github.com/python/typeshed/pull/11353/commits/687709c395a594ca9ffb6746c486276eb0dc7b36
cce9ac1 Revert "Address review" AlexWaygood Feb 1, 2024 https://github.com/python/typeshed/pull/11353/commits/cce9ac1fdba6339ea39a3ef57513b23d37cadf78
Clear filters https://github.com/python/typeshed/pull/11353/files
Please reload this pagehttps://github.com/python/typeshed/pull/11353/files
Please reload this pagehttps://github.com/python/typeshed/pull/11353/files
stdlib/numbers.pyihttps://github.com/python/typeshed/pull/11353/files#diff-77519b22b0fdfc5c9e44e19367b24ed16298241ef048cd7bbdff80d4101f8d5b
View file https://github.com/AlexWaygood/typeshed/blob/cce9ac1fdba6339ea39a3ef57513b23d37cadf78/stdlib/numbers.pyi
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typeshed/pull/11353/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/typeshed/pull/11353/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.