René's URL Explorer Experiment


Title: Fix `contextlib.asynccontextmanager` to work with coroutine functions by sobolevn · Pull Request #10753 · python/typeshed · GitHub

Open Graph Title: Fix `contextlib.asynccontextmanager` to work with coroutine functions by sobolevn · Pull Request #10753 · python/typeshed

X Title: Fix `contextlib.asynccontextmanager` to work with coroutine functions by sobolevn · Pull Request #10753 · python/typeshed

Description: Right now a code from the docs: https://docs.python.org/3/library/contextlib.html#contextlib.asynccontextmanager does not type-check. Example: https://mypy-play.net/?mypy=latest&python=3.11&gist=f20e230fa7b1af15064b2828dfd7dfd7 We are also required to have AsyncGenerator annotation here, because .athrow() method is used in this function: https://github.com/python/cpython/blob/e8be0c9c5a7c2327b3dd64009f45ee0682322dcb/Lib/contextlib.py#L226 (since 3.8: https://github.com/python/cpython/blob/3.8/Lib/contextlib.py#L189) Runtime: >>> from typing import AsyncGenerator >>> from contextlib import asynccontextmanager >>> import asyncio >>> @asynccontextmanager ... async def async_context() -> AsyncGenerator[str, None]: ... yield 'example' ... >>> async def main(): ... async with async_context() as ac: ... print(ac) ... >>> asyncio.run(main()) example So, I went with the fix that also has some tests.

Open Graph Description: Right now a code from the docs: https://docs.python.org/3/library/contextlib.html#contextlib.asynccontextmanager does not type-check. Example: https://mypy-play.net/?mypy=latest&python=3.11&...

X Description: Right now a code from the docs: https://docs.python.org/3/library/contextlib.html#contextlib.asynccontextmanager does not type-check. Example: https://mypy-play.net/?mypy=latest&python=3.11...

Opengraph URL: https://github.com/python/typeshed/pull/10753

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b00a24db-c77d-b00a-458d-b73c58605472
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9904:1833B7:24EC1FD:321891D:6B0033EF
html-safe-noncea2edf7010000756739def41c707ef0afecf477880f7b7480b340b22654827dcd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OTA0OjE4MzNCNzoyNEVDMUZEOjMyMTg5MUQ6NkIwMDMzRUYiLCJ2aXNpdG9yX2lkIjoiNTYxMDQ5ODc4ODY0NjA2MTkyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac274a02d984ccb0467616fb9195b20dc9e80608e4d9e264a031c8c9e26a69bdc0
hovercard-subject-tagpull_request:1527389448
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/typeshed/pull/10753/files
twitter:imagehttps://avatars.githubusercontent.com/u/4660275?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4660275?s=400&v=4
og:image:altRight now a code from the docs: https://docs.python.org/3/library/contextlib.html#contextlib.asynccontextmanager does not type-check. Example: https://mypy-play.net/?mypy=latest&python=3.11&...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/typeshed git https://github.com/python/typeshed.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id31696383
octolytics-dimension-repository_nwopython/typeshed
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id31696383
octolytics-dimension-repository_network_root_nwopython/typeshed
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/typeshed/pull/10753/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fpull%2F10753%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fpull%2F10753%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Ftypeshed
Reloadhttps://github.com/python/typeshed/pull/10753/files
Reloadhttps://github.com/python/typeshed/pull/10753/files
Reloadhttps://github.com/python/typeshed/pull/10753/files
pythonhttps://github.com/python
typeshedhttps://github.com/python/typeshed
Codehttps://github.com/python/typeshed
Issues196 (196)https://github.com/python/typeshed/issues
Pull requests251 (251)https://github.com/python/typeshed/pulls
Actionshttps://github.com/python/typeshed/actions
Security and qualityhttps://github.com/python/typeshed/security
Insightshttps://github.com/python/typeshed/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Ftypeshed%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Ftypeshed%2Fissues%2Fnew%2Fchoose
sobolevnhttps://github.com/sobolevn
mainhttps://github.com/python/typeshed/tree/main
fix-asynccontextmanagerhttps://github.com/python/typeshed/tree/fix-asynccontextmanager
Conversation 12 https://github.com/python/typeshed/pull/10753
Commits 6 https://github.com/python/typeshed/pull/10753/commits
Checks 0 https://github.com/python/typeshed/pull/10753/checks
Files changed https://github.com/python/typeshed/pull/10753/files
Please reload this pagehttps://github.com/python/typeshed/pull/10753/files
Fix contextlib.asynccontextmanager to work with coroutine functions https://github.com/python/typeshed/pull/10753/files#top
Show all changes 6 commits https://github.com/python/typeshed/pull/10753/files
bf423b3 Fix `contextlib.asynccontextmanager` to work with coroutine functions sobolevn Sep 23, 2023 https://github.com/python/typeshed/pull/10753/commits/bf423b38704ad93d39a1b4b45625f43d74c62d89
1de2736 [pre-commit.ci] auto fixes from pre-commit.com hooks pre-commit-ci[bot] Sep 23, 2023 https://github.com/python/typeshed/pull/10753/commits/1de2736856176ab3c3ab2b71e366063c3bc65391
14e4576 Fix CI sobolevn Sep 23, 2023 https://github.com/python/typeshed/pull/10753/commits/14e457677447041bfff4a1569af76fe6f0436792
76251b4 Merge branch 'fix-asynccontextmanager' of https://github.com/python/t… sobolevn Sep 23, 2023 https://github.com/python/typeshed/pull/10753/commits/76251b448b8d57a064bebdc233f3d0cb4087406a
205713d Use `AsyncIterator` for now sobolevn Sep 23, 2023 https://github.com/python/typeshed/pull/10753/commits/205713d2c08bd9773d4672d306e978ea30b114da
d7077aa [pre-commit.ci] auto fixes from pre-commit.com hooks pre-commit-ci[bot] Sep 23, 2023 https://github.com/python/typeshed/pull/10753/commits/d7077aad5bf3527f1b104d630845da60cd53d9fe
Clear filters https://github.com/python/typeshed/pull/10753/files
Please reload this pagehttps://github.com/python/typeshed/pull/10753/files
Please reload this pagehttps://github.com/python/typeshed/pull/10753/files
contextlib.pyi https://github.com/python/typeshed/pull/10753/files#diff-2868ebfb0fa7179f85ba3d6647c7c4a62bbd064479a9d63f6e4ead072c5b4468
check_contextlib.py https://github.com/python/typeshed/pull/10753/files#diff-08ff6db9f91e5b144e615c20eb479d6d0d81da7d955652a95c46edcf3a450441
stdlib/contextlib.pyihttps://github.com/python/typeshed/pull/10753/files#diff-2868ebfb0fa7179f85ba3d6647c7c4a62bbd064479a9d63f6e4ead072c5b4468
View file https://github.com/python/typeshed/blob/d7077aad5bf3527f1b104d630845da60cd53d9fe/stdlib/contextlib.pyi
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typeshed/pull/10753/{{ revealButtonHref }}
https://github.com/python/typeshed/pull/10753/files#diff-2868ebfb0fa7179f85ba3d6647c7c4a62bbd064479a9d63f6e4ead072c5b4468
https://github.com/python/typeshed/pull/10753/files#diff-2868ebfb0fa7179f85ba3d6647c7c4a62bbd064479a9d63f6e4ead072c5b4468
https://github.com/python/typeshed/pull/10753/files#diff-2868ebfb0fa7179f85ba3d6647c7c4a62bbd064479a9d63f6e4ead072c5b4468
https://github.com/python/typeshed/pull/10753/files#diff-2868ebfb0fa7179f85ba3d6647c7c4a62bbd064479a9d63f6e4ead072c5b4468
test_cases/stdlib/check_contextlib.pyhttps://github.com/python/typeshed/pull/10753/files#diff-08ff6db9f91e5b144e615c20eb479d6d0d81da7d955652a95c46edcf3a450441
View file https://github.com/python/typeshed/blob/d7077aad5bf3527f1b104d630845da60cd53d9fe/test_cases/stdlib/check_contextlib.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/typeshed/pull/10753/{{ revealButtonHref }}
https://github.com/python/typeshed/pull/10753/files#diff-08ff6db9f91e5b144e615c20eb479d6d0d81da7d955652a95c46edcf3a450441
AlexWaygoodhttps://github.com/AlexWaygood
Sep 23, 2023https://github.com/python/typeshed/pull/10753/files#r1335008929
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/typeshed/pull/10753/files
sobolevnhttps://github.com/sobolevn
Sep 23, 2023https://github.com/python/typeshed/pull/10753/files#r1335010003
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/typeshed/pull/10753/files
AlexWaygoodhttps://github.com/AlexWaygood
Sep 23, 2023https://github.com/python/typeshed/pull/10753/files#r1335011934
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/typeshed/pull/10753/files
sobolevnhttps://github.com/sobolevn
Sep 23, 2023https://github.com/python/typeshed/pull/10753/files#r1335012295
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/typeshed/pull/10753/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.