René's URL Explorer Experiment


Title: Repair is_dataclass definition? · Issue #9723 · python/typeshed · GitHub

Open Graph Title: Repair is_dataclass definition? · Issue #9723 · python/typeshed

X Title: Repair is_dataclass definition? · Issue #9723 · python/typeshed

Description: Consider: from dataclasses import is_dataclass def f(X: type) -> None: if is_dataclass(X): reveal_type(X) # information: Type of "X" is "type" Ideally, X would have type type[DataclassInstance]. It doesn't because is_dataclass is defined...

Open Graph Description: Consider: from dataclasses import is_dataclass def f(X: type) -> None: if is_dataclass(X): reveal_type(X) # information: Type of "X" is "type" Ideally, X would have type type[DataclassInstance]. It...

X Description: Consider: from dataclasses import is_dataclass def f(X: type) -> None: if is_dataclass(X): reveal_type(X) # information: Type of "X" is "type" Ideally, X would have type type...

Opengraph URL: https://github.com/python/typeshed/issues/9723

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Repair is_dataclass definition?","articleBody":"Consider:\r\n```python\r\nfrom dataclasses import is_dataclass\r\n\r\ndef f(X: type) -> None:\r\n    if is_dataclass(X):\r\n        reveal_type(X)  # information: Type of \"X\" is \"type\"\r\n```\r\nIdeally, `X` would have type `type[DataclassInstance]`.  It doesn't because `is_dataclass` is defined:\r\n```python\r\n@overload\r\ndef is_dataclass(obj: DataclassInstance | type[DataclassInstance]) -> Literal[True]: ...\r\n@overload\r\ndef is_dataclass(obj: type) -> TypeGuard[type[DataclassInstance]]: ...\r\n@overload\r\ndef is_dataclass(obj: object) -> TypeGuard[DataclassInstance | type[DataclassInstance]]: ...\r\n```\r\nAnd the argument of type `type` matches the first overload, which does not incorporate a `TypeGuard`.  Eric Traut recommends [erasing the first overload  of `is_dataclass`](https://github.com/microsoft/pyright/issues/4626).","author":{"url":"https://github.com/NeilGirdhar","@type":"Person","name":"NeilGirdhar"},"datePublished":"2023-02-12T18:42:53Z","url":"https://github.com/python/typeshed/issues/9723"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:7fc76ee4-ecbd-1e57-5254-ee88ba83622f
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id87F2:D9951:754C6:A1E35:6B007EF5
html-safe-nonce135c588c8db351b57db974ab6e8c8473802edf9efde2275ab949bbefe733baa3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4N0YyOkQ5OTUxOjc1NEM2OkExRTM1OjZCMDA3RUY1IiwidmlzaXRvcl9pZCI6IjMyNjQxMjY3Mjk1ODg4NjY4MDUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacc58be1d71b4ff9b54941d84c50402915555fe6364b18e0c54e1b0eeda426e13f
hovercard-subject-tagissue:1581366468
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/typeshed/9723/issue_layout
twitter:imagehttps://opengraph.githubassets.com/0cbd8bbf90106d924a2e477d463590225366ab73096e1b8591f22237f967b474/python/typeshed/issues/9723
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0cbd8bbf90106d924a2e477d463590225366ab73096e1b8591f22237f967b474/python/typeshed/issues/9723
og:image:altConsider: from dataclasses import is_dataclass def f(X: type) -> None: if is_dataclass(X): reveal_type(X) # information: Type of "X" is "type" Ideally, X would have type type[DataclassInstance]. It...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameNeilGirdhar
hostnamegithub.com
expected-hostnamegithub.com
None82c186f13e104004ab7bdb779f3195e59dd38bfde531aaa74b76470fc2462b83
turbo-cache-controlno-preview
go-importgithub.com/python/typeshed git https://github.com/python/typeshed.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id31696383
octolytics-dimension-repository_nwopython/typeshed
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id31696383
octolytics-dimension-repository_network_root_nwopython/typeshed
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released1bc2aa1939001689f5ce935982c10a6138f745c
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/typeshed/issues/9723#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fissues%2F9723
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fissues%2F9723
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Ftypeshed
Reloadhttps://github.com/python/typeshed/issues/9723
Reloadhttps://github.com/python/typeshed/issues/9723
Reloadhttps://github.com/python/typeshed/issues/9723
pythonhttps://github.com/python
typeshedhttps://github.com/python/typeshed
Codehttps://github.com/python/typeshed
Issues196 (196)https://github.com/python/typeshed/issues
Pull requests254 (254)https://github.com/python/typeshed/pulls
Actionshttps://github.com/python/typeshed/actions
Security and qualityhttps://github.com/python/typeshed/security
Insightshttps://github.com/python/typeshed/insights
https://github.com/python/typeshed
New issuehttps://github.com/login?return_to=https://github.com/python/typeshed/issues/9723
New issuehttps://github.com/login?return_to=https://github.com/python/typeshed/issues/9723
#11929https://github.com/python/typeshed/pull/11929
#9758https://github.com/python/typeshed/pull/9758
Repair is_dataclass definition?https://github.com/python/typeshed/issues/9723#top
#11929https://github.com/python/typeshed/pull/11929
#9758https://github.com/python/typeshed/pull/9758
https://github.com/NeilGirdhar
NeilGirdharhttps://github.com/NeilGirdhar
on Feb 12, 2023https://github.com/python/typeshed/issues/9723#issue-1581366468
erasing the first overload of is_dataclasshttps://github.com/microsoft/pyright/issues/4626
https://github.com/srittau
srittauhttps://github.com/srittau
on Feb 13, 2023https://github.com/python/typeshed/issues/9723#issuecomment-1427868373
@AlexWaygoodhttps://github.com/AlexWaygood
#9362https://github.com/python/typeshed/pull/9362
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
on Feb 14, 2023https://github.com/python/typeshed/issues/9723#issuecomment-1429972745
https://github.com/python/typeshed/blob/main/test_cases/stdlib/check_dataclasses.pyhttps://github.com/python/typeshed/blob/main/test_cases/stdlib/check_dataclasses.py
https://github.com/sterliakov
sterliakovhttps://github.com/sterliakov
on Feb 18, 2023https://github.com/python/typeshed/issues/9723#issuecomment-1435665519
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
on Feb 18, 2023https://github.com/python/typeshed/issues/9723#issuecomment-1435667428
#9362https://github.com/python/typeshed/pull/9362
https://github.com/sterliakov
sterliakovhttps://github.com/sterliakov
on Feb 18, 2023https://github.com/python/typeshed/issues/9723#issuecomment-1435669438
work as expectedhttps://mypy-play.net/?mypy=master&python=3.10&gist=40f983f4084104c6ee0b17c662cb8d88
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
on Feb 18, 2023https://github.com/python/typeshed/issues/9723#issuecomment-1435670573
https://github.com/sterliakov
sterliakovhttps://github.com/sterliakov
on Feb 18, 2023https://github.com/python/typeshed/issues/9723#issuecomment-1435671677
reported as bughttps://github.com/python/mypy/issues/12301
https://github.com/NeilGirdhar
NeilGirdharhttps://github.com/NeilGirdhar
on Feb 18, 2023https://github.com/python/typeshed/issues/9723#issuecomment-1435732630
python/typing#213https://github.com/python/typing/issues/213
python/typing#1351https://github.com/python/typing/issues/1351
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
on Feb 18, 2023https://github.com/python/typeshed/issues/9723#issuecomment-1435767927
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
on Feb 18, 2023https://github.com/python/typeshed/issues/9723#issuecomment-1435768887
reported as bughttps://github.com/python/mypy/issues/12301
the pyright issue you openedhttps://github.com/microsoft/pyright/issues/4658
https://github.com/NeilGirdhar
NeilGirdharhttps://github.com/NeilGirdhar
on Feb 18, 2023https://github.com/python/typeshed/issues/9723#issuecomment-1435769178
JelleZijlstrahttps://github.com/JelleZijlstra
completedhttps://github.com/python/typeshed/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#9758https://github.com/python/typeshed/pull/9758
on Feb 19, 2023https://github.com/python/typeshed/issues/9723#event-8555325649
https://github.com/sterliakov
sterliakovhttps://github.com/sterliakov
on Feb 19, 2023https://github.com/python/typeshed/issues/9723#issuecomment-1436028704
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
on Feb 19, 2023https://github.com/python/typeshed/issues/9723#issuecomment-1436030173
https://github.com/NeilGirdhar
NeilGirdharhttps://github.com/NeilGirdhar
on May 17, 2024https://github.com/python/typeshed/issues/9723#issuecomment-2116657587
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
on May 17, 2024https://github.com/python/typeshed/issues/9723#issuecomment-2117218280
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/typeshed/issues/9723
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/typeshed/issues/9723
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.