René's URL Explorer Experiment


Title: KeysView is now incompatible dict.keys() return type · Issue #6837 · python/typeshed · GitHub

Open Graph Title: KeysView is now incompatible dict.keys() return type · Issue #6837 · python/typeshed

X Title: KeysView is now incompatible dict.keys() return type · Issue #6837 · python/typeshed

Description: Bug Report When sub-classing a Dict and overloading the keys method the following error occurs when updating from mypy v0.921 to v0.930. Return type "KeysView[_K]" of "keys" incompatible with return type "dict_keys[_K, _V]" in supertype ...

Open Graph Description: Bug Report When sub-classing a Dict and overloading the keys method the following error occurs when updating from mypy v0.921 to v0.930. Return type "KeysView[_K]" of "keys" incompatible with retur...

X Description: Bug Report When sub-classing a Dict and overloading the keys method the following error occurs when updating from mypy v0.921 to v0.930. Return type "KeysView[_K]" of "keys" inc...

Opengraph URL: https://github.com/python/typeshed/issues/6837

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"KeysView is now incompatible dict.keys() return type","articleBody":"**Bug Report**\r\n\r\nWhen sub-classing a Dict and overloading the `keys` method the following error occurs when updating from mypy v0.921 to v0.930.\r\n\r\n`Return type \"KeysView[_K]\" of \"keys\" incompatible with return type \"dict_keys[_K, _V]\" in supertype \"dict\"`\r\n\r\n**To Reproduce**\r\n\r\nWith v0.291 this code is perfectly valid and passes validation.\r\n\r\n```python\r\nfrom typing import TypeVar, Dict\r\nfrom collections.abc import KeysView\r\n\r\n_K = TypeVar(\"_K\")\r\n_V = TypeVar(\"_V\")\r\n\r\nclass A(Dict[_K, _V]):\r\n    def __init__(self):\r\n        self._dict: Dict[_K, _V] = {}\r\n\r\n    def keys(self) -> KeysView[_K]:\r\n        return self._dict.keys()\r\n```\r\n\r\nhttps://mypy-play.net/?mypy=0.921&python=3.10&gist=7159c56ca6010a5aace637383a18b8b1\r\n\r\nPost update to v0.930 the above code fails validation and requires updating to the following.\r\n\r\n```python\r\nfrom typing import TypeVar, Dict\r\nfrom _collections_abc import dict_keys\r\n\r\n_K = TypeVar(\"_K\")\r\n_V = TypeVar(\"_V\")\r\n\r\nclass A(Dict[_K, _V]):\r\n    def __init__(self):\r\n        self._dict: Dict[_K, _V] = {}\r\n\r\n    def keys(self) -> dict_keys[_K, _V]:\r\n        return self._dict.keys()\r\n```\r\n\r\nhttps://mypy-play.net/?mypy=latest&python=3.10&gist=65a7626023630e18d178acd0bd75ec61\r\n\r\n**Expected Behavior**\r\n\r\nThe `dict_keys` class extends the `KeysView` class so I would have expected that the code could have remained the same and mypy would walk the hierarchy to determine that the code is still valid. For instance, this shows that the `KeysView` should work (IMO) on v0.930\r\n\r\n```python\r\nfrom collections.abc import KeysView\r\nreveal_type({}.keys())  # Revealed type is \"_collections_abc.dict_keys[\u003cnothing>, \u003cnothing>]\"\r\nprint(isinstance({}.keys(), KeysView))  # True\r\n```\r\n\r\n**Actual Behavior**\r\n\r\nThe class must be rewritten to use the new `dict_keys` return type which is not available in a \"public\" package.\r\n\r\n**Your Environment**\r\n\r\n- Mypy version used: v0.921 and v0.930\r\n- Mypy command-line flags: N/A\r\n- Mypy configuration options from `mypy.ini` (and other config files): N/A\r\n- Python version used: 3.6, 3.7, 3.8, 3.9, 3.10\r\n- Operating system and version: Playground\r\n","author":{"url":"https://github.com/mattdavis90","@type":"Person","name":"mattdavis90"},"datePublished":"2022-01-05T21:00:05Z","url":"https://github.com/python/typeshed/issues/6837"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:e20141d1-e736-ef58-a3a3-48f562f7b63f
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idAA28:07D0:173A693:1EAC5B4:6B0025F4
html-safe-nonce9d49db0c267667a486526d5cbe4a1bc85a35239fb602f23217aa1721ab0379ed
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQTI4OjA3RDA6MTczQTY5MzoxRUFDNUI0OjZCMDAyNUY0IiwidmlzaXRvcl9pZCI6IjUwNTgxMjM0OTY3MDIzNTQ5MzIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf14c386037b616bbb02811646e002fb60ba258b1f59c0086bc9de34045870085
hovercard-subject-tagissue:1094953591
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/typeshed/6837/issue_layout
twitter:imagehttps://opengraph.githubassets.com/f2dbebaec2a7eb07a374651547d2bd0719885312bc7357c72119393b38fb4863/python/typeshed/issues/6837
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f2dbebaec2a7eb07a374651547d2bd0719885312bc7357c72119393b38fb4863/python/typeshed/issues/6837
og:image:altBug Report When sub-classing a Dict and overloading the keys method the following error occurs when updating from mypy v0.921 to v0.930. Return type "KeysView[_K]" of "keys" incompatible with retur...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemattdavis90
hostnamegithub.com
expected-hostnamegithub.com
None4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0
turbo-cache-controlno-preview
go-importgithub.com/python/typeshed git https://github.com/python/typeshed.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id31696383
octolytics-dimension-repository_nwopython/typeshed
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id31696383
octolytics-dimension-repository_network_root_nwopython/typeshed
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release44c658b24abf00491fb7ae5f56d42c9f38cbeab2
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/typeshed/issues/6837#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fissues%2F6837
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fissues%2F6837
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Ftypeshed
Reloadhttps://github.com/python/typeshed/issues/6837
Reloadhttps://github.com/python/typeshed/issues/6837
Reloadhttps://github.com/python/typeshed/issues/6837
pythonhttps://github.com/python
typeshedhttps://github.com/python/typeshed
Codehttps://github.com/python/typeshed
Issues196 (196)https://github.com/python/typeshed/issues
Pull requests251 (251)https://github.com/python/typeshed/pulls
Actionshttps://github.com/python/typeshed/actions
Security and qualityhttps://github.com/python/typeshed/security
Insightshttps://github.com/python/typeshed/insights
https://github.com/python/typeshed
New issuehttps://github.com/login?return_to=https://github.com/python/typeshed/issues/6837
New issuehttps://github.com/login?return_to=https://github.com/python/typeshed/issues/6837
KeysView is now incompatible dict.keys() return typehttps://github.com/python/typeshed/issues/6837#top
https://github.com/mattdavis90
mattdavis90https://github.com/mattdavis90
on Jan 5, 2022https://github.com/python/typeshed/issues/6837#issue-1094953591
https://mypy-play.net/?mypy=0.921&python=3.10&gist=7159c56ca6010a5aace637383a18b8b1https://mypy-play.net/?mypy=0.921&python=3.10&gist=7159c56ca6010a5aace637383a18b8b1
https://mypy-play.net/?mypy=latest&python=3.10&gist=65a7626023630e18d178acd0bd75ec61https://mypy-play.net/?mypy=latest&python=3.10&gist=65a7626023630e18d178acd0bd75ec61
hauntsaninjahttps://github.com/hauntsaninja
python/mypyhttps://github.com/python/mypy
on Jan 6, 2022https://github.com/python/typeshed/issues/6837#event-5850132476
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
on Jan 6, 2022https://github.com/python/typeshed/issues/6837#issuecomment-1006275563
#6039https://github.com/python/typeshed/pull/6039
https://github.com/mattdavis90
mattdavis90https://github.com/mattdavis90
on Jan 10, 2022https://github.com/python/typeshed/issues/6837#issuecomment-1009410230
@hauntsaninjahttps://github.com/hauntsaninja
#6888https://github.com/python/typeshed/pull/6888
https://github.com/Akuli
Akulihttps://github.com/Akuli
on Jan 20, 2022https://github.com/python/typeshed/issues/6837#issuecomment-1017698505
@mattdavis90https://github.com/mattdavis90
@zzzeekhttps://github.com/zzzeek
https://github.com/zzzeek
zzzeekhttps://github.com/zzzeek
on Jan 20, 2022https://github.com/python/typeshed/issues/6837#issuecomment-1017715308
@Akulihttps://github.com/Akuli
python/typing#1033https://github.com/python/typing/discussions/1033
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
on Jan 20, 2022https://github.com/python/typeshed/issues/6837#issuecomment-1017734528
@zzzeekhttps://github.com/zzzeek
https://github.com/zzzeek
zzzeekhttps://github.com/zzzeek
on Jan 20, 2022https://github.com/python/typeshed/issues/6837#issuecomment-1017754628
WeakValueDictionaryhttps://github.com/python/cpython/blob/main/Lib/weakref.py#L244
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
on Jan 20, 2022https://github.com/python/typeshed/issues/6837#issuecomment-1017758786
herehttps://github.com/python/typeshed/blob/7dd35556c400f912562d2666952c8f98e9114a82/stdlib/typing.pyi#L447
herehttps://github.com/python/typeshed/blob/7dd35556c400f912562d2666952c8f98e9114a82/stdlib/typing.pyi#L462
herehttps://github.com/python/typeshed/blob/7dd35556c400f912562d2666952c8f98e9114a82/stdlib/builtins.pyi#L832
https://github.com/Akuli
Akulihttps://github.com/Akuli
on Jan 20, 2022https://github.com/python/typeshed/issues/6837#issuecomment-1017758815
https://github.com/zzzeek
zzzeekhttps://github.com/zzzeek
on Jan 20, 2022https://github.com/python/typeshed/issues/6837#issuecomment-1017760641
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
on Jan 20, 2022https://github.com/python/typeshed/issues/6837#issuecomment-1017761843
https://github.com/Akuli
Akulihttps://github.com/Akuli
on Jan 20, 2022https://github.com/python/typeshed/issues/6837#issuecomment-1017762382
#5444https://github.com/python/typeshed/issues/5444
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
on Jan 20, 2022https://github.com/python/typeshed/issues/6837#issuecomment-1017768641
WeakValueDictionaryhttps://github.com/python/cpython/blob/main/Lib/weakref.py#L244
https://github.com/zzzeek
zzzeekhttps://github.com/zzzeek
on Jan 20, 2022https://github.com/python/typeshed/issues/6837#issuecomment-1017788540
https://github.com/Akuli
Akulihttps://github.com/Akuli
on Jan 20, 2022https://github.com/python/typeshed/issues/6837#issuecomment-1017795940
https://github.com/KotlinIsland
KotlinIslandhttps://github.com/KotlinIsland
on Mar 5, 2022https://github.com/python/typeshed/issues/6837#issuecomment-1059708720
@mattdavis90https://github.com/mattdavis90
https://github.com/KotlinIsland
KotlinIslandhttps://github.com/KotlinIsland
on Mar 5, 2022https://github.com/python/typeshed/issues/6837#issuecomment-1059719295
@hauntsaninjahttps://github.com/hauntsaninja
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
on Mar 5, 2022https://github.com/python/typeshed/issues/6837#issuecomment-1059721663
#6888 (comment)https://github.com/python/typeshed/pull/6888#issuecomment-1009478038
hauntsaninjahttps://github.com/hauntsaninja
completedhttps://github.com/python/typeshed/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Mar 5, 2022https://github.com/python/typeshed/issues/6837#event-6189086779
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/typeshed/issues/6837
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/typeshed/issues/6837
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.