Title: KeysView is now incompatible dict.keys() return type · Issue #6837 · python/typeshed · GitHub
Open Graph Title: KeysView is now incompatible dict.keys() return type · Issue #6837 · python/typeshed
X Title: KeysView is now incompatible dict.keys() return type · Issue #6837 · python/typeshed
Description: Bug Report When sub-classing a Dict and overloading the keys method the following error occurs when updating from mypy v0.921 to v0.930. Return type "KeysView[_K]" of "keys" incompatible with return type "dict_keys[_K, _V]" in supertype ...
Open Graph Description: Bug Report When sub-classing a Dict and overloading the keys method the following error occurs when updating from mypy v0.921 to v0.930. Return type "KeysView[_K]" of "keys" incompatible with retur...
X Description: Bug Report When sub-classing a Dict and overloading the keys method the following error occurs when updating from mypy v0.921 to v0.930. Return type "KeysView[_K]" of "keys" inc...
Opengraph URL: https://github.com/python/typeshed/issues/6837
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"KeysView is now incompatible dict.keys() return type","articleBody":"**Bug Report**\r\n\r\nWhen sub-classing a Dict and overloading the `keys` method the following error occurs when updating from mypy v0.921 to v0.930.\r\n\r\n`Return type \"KeysView[_K]\" of \"keys\" incompatible with return type \"dict_keys[_K, _V]\" in supertype \"dict\"`\r\n\r\n**To Reproduce**\r\n\r\nWith v0.291 this code is perfectly valid and passes validation.\r\n\r\n```python\r\nfrom typing import TypeVar, Dict\r\nfrom collections.abc import KeysView\r\n\r\n_K = TypeVar(\"_K\")\r\n_V = TypeVar(\"_V\")\r\n\r\nclass A(Dict[_K, _V]):\r\n def __init__(self):\r\n self._dict: Dict[_K, _V] = {}\r\n\r\n def keys(self) -> KeysView[_K]:\r\n return self._dict.keys()\r\n```\r\n\r\nhttps://mypy-play.net/?mypy=0.921&python=3.10&gist=7159c56ca6010a5aace637383a18b8b1\r\n\r\nPost update to v0.930 the above code fails validation and requires updating to the following.\r\n\r\n```python\r\nfrom typing import TypeVar, Dict\r\nfrom _collections_abc import dict_keys\r\n\r\n_K = TypeVar(\"_K\")\r\n_V = TypeVar(\"_V\")\r\n\r\nclass A(Dict[_K, _V]):\r\n def __init__(self):\r\n self._dict: Dict[_K, _V] = {}\r\n\r\n def keys(self) -> dict_keys[_K, _V]:\r\n return self._dict.keys()\r\n```\r\n\r\nhttps://mypy-play.net/?mypy=latest&python=3.10&gist=65a7626023630e18d178acd0bd75ec61\r\n\r\n**Expected Behavior**\r\n\r\nThe `dict_keys` class extends the `KeysView` class so I would have expected that the code could have remained the same and mypy would walk the hierarchy to determine that the code is still valid. For instance, this shows that the `KeysView` should work (IMO) on v0.930\r\n\r\n```python\r\nfrom collections.abc import KeysView\r\nreveal_type({}.keys()) # Revealed type is \"_collections_abc.dict_keys[\u003cnothing>, \u003cnothing>]\"\r\nprint(isinstance({}.keys(), KeysView)) # True\r\n```\r\n\r\n**Actual Behavior**\r\n\r\nThe class must be rewritten to use the new `dict_keys` return type which is not available in a \"public\" package.\r\n\r\n**Your Environment**\r\n\r\n- Mypy version used: v0.921 and v0.930\r\n- Mypy command-line flags: N/A\r\n- Mypy configuration options from `mypy.ini` (and other config files): N/A\r\n- Python version used: 3.6, 3.7, 3.8, 3.9, 3.10\r\n- Operating system and version: Playground\r\n","author":{"url":"https://github.com/mattdavis90","@type":"Person","name":"mattdavis90"},"datePublished":"2022-01-05T21:00:05Z","url":"https://github.com/python/typeshed/issues/6837"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:e20141d1-e736-ef58-a3a3-48f562f7b63f |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | AA28:07D0:173A693:1EAC5B4:6B0025F4 |
| html-safe-nonce | 9d49db0c267667a486526d5cbe4a1bc85a35239fb602f23217aa1721ab0379ed |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQTI4OjA3RDA6MTczQTY5MzoxRUFDNUI0OjZCMDAyNUY0IiwidmlzaXRvcl9pZCI6IjUwNTgxMjM0OTY3MDIzNTQ5MzIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | f14c386037b616bbb02811646e002fb60ba258b1f59c0086bc9de34045870085 |
| hovercard-subject-tag | issue:1094953591 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/typeshed/6837/issue_layout |
| twitter:image | https://opengraph.githubassets.com/f2dbebaec2a7eb07a374651547d2bd0719885312bc7357c72119393b38fb4863/python/typeshed/issues/6837 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/f2dbebaec2a7eb07a374651547d2bd0719885312bc7357c72119393b38fb4863/python/typeshed/issues/6837 |
| og:image:alt | Bug Report When sub-classing a Dict and overloading the keys method the following error occurs when updating from mypy v0.921 to v0.930. Return type "KeysView[_K]" of "keys" incompatible with retur... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mattdavis90 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/typeshed git https://github.com/python/typeshed.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 31696383 |
| octolytics-dimension-repository_nwo | python/typeshed |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 31696383 |
| octolytics-dimension-repository_network_root_nwo | python/typeshed |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 44c658b24abf00491fb7ae5f56d42c9f38cbeab2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width