Title: stubtest: should unused allowlist entries be an error in stdlib? · Issue #6406 · python/typeshed · GitHub
Open Graph Title: stubtest: should unused allowlist entries be an error in stdlib? · Issue #6406 · python/typeshed
X Title: stubtest: should unused allowlist entries be an error in stdlib? · Issue #6406 · python/typeshed
Description: In third-party stubs, unused allowlist entries cause CI to fail, and must be removed in the same pull request that fixes whatever causes it to be unused. Advantage: super simple Advantage: you can be sure you fixed an allowlist entry whe...
Open Graph Description: In third-party stubs, unused allowlist entries cause CI to fail, and must be removed in the same pull request that fixes whatever causes it to be unused. Advantage: super simple Advantage: you can ...
X Description: In third-party stubs, unused allowlist entries cause CI to fail, and must be removed in the same pull request that fixes whatever causes it to be unused. Advantage: super simple Advantage: you can ...
Opengraph URL: https://github.com/python/typeshed/issues/6406
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"stubtest: should unused allowlist entries be an error in stdlib?","articleBody":"In third-party stubs, unused allowlist entries cause CI to fail, and must be removed in the same pull request that fixes whatever causes it to be unused.\r\n- Advantage: super simple\r\n- Advantage: you can be sure you fixed an allowlist entry when you make a pull request\r\n- Disadvantage: can be confusing for new contributors\r\n- Disadvantage: can cause merge conflicts if one pull request removes allowlist entry from line 17 and another removes one from line 18 (I don't think this has ever happened)\r\n\r\nIn stdlib, unused allowlist entries don't cause CI errors, and are removed in a weeky automatically generated pull request.\r\n- Advantage: new contributors don't need to worry about the allowlists (more important for stdlib, because there's many allowlists)\r\n- Advantage: no merge conflicts\r\n- Disadvantage: complicated\r\n- Disadvantage: automatic removal doesn't work in all corner cases\r\n- Disadvantage: automatic removal can fail without anyone noticing it (unlike a CI failure of a pull request)\r\n\r\nI like how this works for third-party stubs. Should we do the same for stdlib too?","author":{"url":"https://github.com/Akuli","@type":"Person","name":"Akuli"},"datePublished":"2021-11-27T23:55:48Z","url":"https://github.com/python/typeshed/issues/6406"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:90b56d24-b3d9-be24-1a6f-031040059547 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 80CC:1DA187:37C0E86:4A1AB94:6B004C1D |
| html-safe-nonce | 58695466fd55b03fcd3adcfdcf542ad4361f50dfab84ca84df2dc705b84e10ff |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MENDOjFEQTE4NzozN0MwRTg2OjRBMUFCOTQ6NkIwMDRDMUQiLCJ2aXNpdG9yX2lkIjoiNDE4MDc5MzAyNjgxOTQxMDk3NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | d04049f3035cfafb27b6f5bce697ca8d2c757956ed4015bf885582e39942cf96 |
| hovercard-subject-tag | issue:1065145228 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/typeshed/6406/issue_layout |
| twitter:image | https://opengraph.githubassets.com/85d6a160dfecb6377e4d8211cf534e177e9833cae8adea37c479e5c120bb79ec/python/typeshed/issues/6406 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/85d6a160dfecb6377e4d8211cf534e177e9833cae8adea37c479e5c120bb79ec/python/typeshed/issues/6406 |
| og:image:alt | In third-party stubs, unused allowlist entries cause CI to fail, and must be removed in the same pull request that fixes whatever causes it to be unused. Advantage: super simple Advantage: you can ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Akuli |
| hostname | github.com |
| expected-hostname | github.com |
| None | f9517bf360d46638a1e5e7daee7158842fe5ef43c9000afa0e127564a7c2f39b |
| turbo-cache-control | no-preview |
| go-import | github.com/python/typeshed git https://github.com/python/typeshed.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 31696383 |
| octolytics-dimension-repository_nwo | python/typeshed |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 31696383 |
| octolytics-dimension-repository_network_root_nwo | python/typeshed |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | b27c5dde30676028abd5c5fc53ce5c9b625f8281 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width