René's URL Explorer Experiment


Title: Annotation for builtin max() function uses wrong comparison operator · Issue #6336 · python/typeshed · GitHub

Open Graph Title: Annotation for builtin max() function uses wrong comparison operator · Issue #6336 · python/typeshed

X Title: Annotation for builtin max() function uses wrong comparison operator · Issue #6336 · python/typeshed

Description: The stubs for max() use SupportsLessThanT but should use SupportsGreaterThanT instead. The CPython source uses Py_GT. Instrumenting calls to max() shows the '>' operator being invoked: class I(int): def __gt__(self, other): print(f'{self...

Open Graph Description: The stubs for max() use SupportsLessThanT but should use SupportsGreaterThanT instead. The CPython source uses Py_GT. Instrumenting calls to max() shows the '>' operator being invoked: class I(int)...

X Description: The stubs for max() use SupportsLessThanT but should use SupportsGreaterThanT instead. The CPython source uses Py_GT. Instrumenting calls to max() shows the '>' operator being invoked: c...

Opengraph URL: https://github.com/python/typeshed/issues/6336

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Annotation for builtin max() function uses wrong comparison operator","articleBody":"The stubs for [max()](https://github.com/python/typeshed/blob/fbb89f9fd54566e292a63b80cb32053bd6eb1bb4/stdlib/builtins.pyi#L1135) use `SupportsLessThanT` but should use `SupportsGreaterThanT` instead.\r\n\r\nThe [CPython source](https://github.com/python/cpython/blob/32959108f9c543e3cb9f2b68bbc782bddded6f42/Python/bltinmodule.c#L1837) uses `Py_GT`.\r\n\r\nInstrumenting calls to *max()* shows the '>' operator being invoked:\r\n\r\n```\r\nclass I(int):\r\n    def __gt__(self, other):\r\n        print(f'{self} > {other}')\r\n        return int.__gt__(self, other)\r\n    def __lt__(self, other):\r\n        print(f'{self} \u003c {other}')\r\n        return int.__Lt__(self, other)\r\n\r\n>>> largest = max(map(I, [10, 40, 20]))\r\n40 > 10\r\n20 > 40\r\n>>> largest\r\n40\r\n```\r\n\r\nA class that supplies only `__gt__` suffices for a call to *max()*:\r\n\r\n```\r\nclass ReverseInt:\r\n    def __init__(self, x):\r\n        self.x = x\r\n    def __gt__(self, other):\r\n        return self.x \u003c other.x\r\n    def __repr__(self):\r\n        return f'{type(self).__name__}({self.x!r})'\r\n  \r\n>>> max(map(ReverseInt, [10, 40, 20]))\r\nReverseInt(10)\r\n```\r\n","author":{"url":"https://github.com/rhettinger","@type":"Person","name":"rhettinger"},"datePublished":"2021-11-18T16:46:35Z","url":"https://github.com/python/typeshed/issues/6336"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:b61cf193-7f53-2548-0d58-6bbb69fc0278
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8C00:14F601:4ED3F:6756F:6B00B817
html-safe-nonce8ed5e53ed81db103cdf15435f043f315a9c7b675d57fd3c2aee4b559619825b2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QzAwOjE0RjYwMTo0RUQzRjo2NzU2Rjo2QjAwQjgxNyIsInZpc2l0b3JfaWQiOiI2MzMxOTk3Nzk1ODI5OTg3MzUxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac54d9fc46b6c752a6195ad377d1bab6cba8699a0a161d22ca89338d37638a043c
hovercard-subject-tagissue:1057571927
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/typeshed/6336/issue_layout
twitter:imagehttps://opengraph.githubassets.com/a192ebaf05205f1e720f4ce48c99e518babd3d3d7c2ea024a176b4071d91c0e8/python/typeshed/issues/6336
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a192ebaf05205f1e720f4ce48c99e518babd3d3d7c2ea024a176b4071d91c0e8/python/typeshed/issues/6336
og:image:altThe stubs for max() use SupportsLessThanT but should use SupportsGreaterThanT instead. The CPython source uses Py_GT. Instrumenting calls to max() shows the '>' operator being invoked: class I(int)...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamerhettinger
hostnamegithub.com
expected-hostnamegithub.com
None1d07c25977adfc5ff6acb0a962a9bc168c07afbda6fef765f9761c350c2ae4a2
turbo-cache-controlno-preview
go-importgithub.com/python/typeshed git https://github.com/python/typeshed.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id31696383
octolytics-dimension-repository_nwopython/typeshed
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id31696383
octolytics-dimension-repository_network_root_nwopython/typeshed
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5429cbfc6aca8c7b9a086a3c8f47400346f38cc9
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/typeshed/issues/6336#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fissues%2F6336
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fissues%2F6336
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Ftypeshed
Reloadhttps://github.com/python/typeshed/issues/6336
Reloadhttps://github.com/python/typeshed/issues/6336
Reloadhttps://github.com/python/typeshed/issues/6336
pythonhttps://github.com/python
typeshedhttps://github.com/python/typeshed
Codehttps://github.com/python/typeshed
Issues196 (196)https://github.com/python/typeshed/issues
Pull requests257 (257)https://github.com/python/typeshed/pulls
Actionshttps://github.com/python/typeshed/actions
Security and qualityhttps://github.com/python/typeshed/security
Insightshttps://github.com/python/typeshed/insights
https://github.com/python/typeshed
New issuehttps://github.com/login?return_to=https://github.com/python/typeshed/issues/6336
New issuehttps://github.com/login?return_to=https://github.com/python/typeshed/issues/6336
#6342https://github.com/python/typeshed/pull/6342
Annotation for builtin max() function uses wrong comparison operatorhttps://github.com/python/typeshed/issues/6336#top
#6342https://github.com/python/typeshed/pull/6342
stubs: false positiveType checkers report false errorshttps://github.com/python/typeshed/issues?q=state%3Aopen%20label%3A%22stubs%3A%20false%20positive%22
https://github.com/rhettinger
rhettingerhttps://github.com/rhettinger
on Nov 18, 2021https://github.com/python/typeshed/issues/6336#issue-1057571927
max()https://github.com/python/typeshed/blob/fbb89f9fd54566e292a63b80cb32053bd6eb1bb4/stdlib/builtins.pyi#L1135
CPython sourcehttps://github.com/python/cpython/blob/32959108f9c543e3cb9f2b68bbc782bddded6f42/Python/bltinmodule.c#L1837
srittauhttps://github.com/srittau
stubs: false positiveType checkers report false errorshttps://github.com/python/typeshed/issues?q=state%3Aopen%20label%3A%22stubs%3A%20false%20positive%22
on Nov 19, 2021https://github.com/python/typeshed/issues/6336#event-5643932694
srittauhttps://github.com/srittau
on Nov 19, 2021https://github.com/python/typeshed/issues/6336#event-5643960788
max() uses SupportsGreaterThanThttps://github.com/srittau/typeshed/commit/1f432f8be3828b07ed2f8494a30ba7403e6942fd
https://docs.github.com/articles/closing-issues-via-commit-messages
1f432f8https://github.com/srittau/typeshed/commit/1f432f8be3828b07ed2f8494a30ba7403e6942fd
max() uses SupportsGreaterThanThttps://github.com/srittau/typeshed/commit/2e1d7d1ffa3127e86adcf822ca834ae3e4231686
https://docs.github.com/articles/closing-issues-via-commit-messages
2e1d7d1https://github.com/srittau/typeshed/commit/2e1d7d1ffa3127e86adcf822ca834ae3e4231686
max() uses SupportsGreaterThanThttps://github.com/srittau/typeshed/commit/c8ae584595d6645a489a19d44a4587b5680fc29e
https://docs.github.com/articles/closing-issues-via-commit-messages
c8ae584https://github.com/srittau/typeshed/commit/c8ae584595d6645a489a19d44a4587b5680fc29e
srittauhttps://github.com/srittau
completedhttps://github.com/python/typeshed/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#6342https://github.com/python/typeshed/pull/6342
on Nov 21, 2021https://github.com/python/typeshed/issues/6336#event-5649958999
srittauhttps://github.com/srittau
on Nov 21, 2021https://github.com/python/typeshed/issues/6336#event-5649959074
max() uses SupportsGreaterThanT (#6342)https://github.com/python/typeshed/commit/a6e369906d013c76d535d9a05466d22c54c832a7
#6342https://github.com/python/typeshed/pull/6342
https://docs.github.com/articles/closing-issues-via-commit-messages
a6e3699https://github.com/python/typeshed/commit/a6e369906d013c76d535d9a05466d22c54c832a7
https://github.com/rhettinger
rhettingerhttps://github.com/rhettinger
on Nov 23, 2021https://github.com/python/typeshed/issues/6336#issuecomment-977295437
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/typeshed/issues/6336
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/typeshed/issues/6336
stubs: false positiveType checkers report false errorshttps://github.com/python/typeshed/issues?q=state%3Aopen%20label%3A%22stubs%3A%20false%20positive%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.