René's URL Explorer Experiment


Title: Fix `__init__` type of `typing.NamedTuple` · Issue #6079 · python/typeshed · GitHub

Open Graph Title: Fix `__init__` type of `typing.NamedTuple` · Issue #6079 · python/typeshed

X Title: Fix `__init__` type of `typing.NamedTuple` · Issue #6079 · python/typeshed

Description: While working on python/mypy#11047 I've noticed that there's an issue with typing.NamedTuple Right now __init__ of typing.NamedTuple has type: def __init__(self, typename: str, fields: Iterable[Tuple[str, Any]] = ..., **kwargs: Any) -> N...

Open Graph Description: While working on python/mypy#11047 I've noticed that there's an issue with typing.NamedTuple Right now __init__ of typing.NamedTuple has type: def __init__(self, typename: str, fields: Iterable[Tup...

X Description: While working on python/mypy#11047 I've noticed that there's an issue with typing.NamedTuple Right now __init__ of typing.NamedTuple has type: def __init__(self, typename: str, fields: Iter...

Opengraph URL: https://github.com/python/typeshed/issues/6079

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Fix `__init__` type of `typing.NamedTuple`","articleBody":"While working on https://github.com/python/mypy/issues/11047 I've noticed that there's an issue with `typing.NamedTuple`\r\n\r\nRight now `__init__` of `typing.NamedTuple` has type: `def __init__(self, typename: str, fields: Iterable[Tuple[str, Any]] = ..., **kwargs: Any) -> None: ...` which is not correct.\r\n\r\nWhy? Let's try to add both `fields` and `kwargs`:\r\n\r\n```python\r\n>>> from typing import NamedTuple\r\n>>> NamedTuple('a', (), f=int)\r\nTraceback (most recent call last):\r\n  File \"\u003cstdin>\", line 1, in \u003cmodule>\r\n  File \"/Users/sobolev/.pyenv/versions/3.9.1/lib/python3.9/typing.py\", line 1864, in NamedTuple\r\n    raise TypeError(\"Either list of fields or keywords\"\r\nTypeError: Either list of fields or keywords can be provided to NamedTuple, not both\r\n```\r\n\r\nSource: https://github.com/python/cpython/blob/f56268a2cd38b3fe2be1e4361d3d8b581e73559b/Lib/typing.py#L2290-L2294\r\n\r\nSo, it should be an overload instead:\r\n\r\n```python\r\n    @overload\r\n    def __init__(self, typename: str, fields: Iterable[Tuple[str, Any]] = ...) -> None: ...\r\n    @overload\r\n    def __init__(self, typename: str, **kwargs: Any) -> None: ...\r\n```\r\n\r\nNotice, that `fields=None` is still allowed:\r\n\r\n```python\r\n>>> NamedTuple('a', fields=None, f=int)\r\n```\r\n\r\nBut, I don't think that we should have `def __init__(self, typename: str, fields: None = ..., **kwargs: Any) -> None: ...` instead.\r\n\r\nOne more thing: is it `Tuple[str, Any]` or `Tuple[str, type]`? It is supposed to be types. But, it is not enforced anywhere (except `mypy`) as far as I know.\r\n\r\nI will send a PR with the fix.","author":{"url":"https://github.com/sobolevn","@type":"Person","name":"sobolevn"},"datePublished":"2021-09-26T18:24:39Z","url":"https://github.com/python/typeshed/issues/6079"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:361c8bbc-60a4-a03a-1bc6-cd4861c948d2
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id9AA8:B438C:11A33A5:1731E64:6B000B3C
html-safe-nonce595874b32c250ff1be3930550b14f53e30e5a9cabb812801db509720650bdb29
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QUE4OkI0MzhDOjExQTMzQTU6MTczMUU2NDo2QjAwMEIzQyIsInZpc2l0b3JfaWQiOiI3MDE0MTkzNjc2NTIzOTMyNDc2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac7de7d45ec920ee342c42d4f511bef1dab7f62b339900b5afade8a6a7ad8196d3
hovercard-subject-tagissue:1007465549
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/typeshed/6079/issue_layout
twitter:imagehttps://opengraph.githubassets.com/f10f4df1c0130dd2958ef5d3a1812cb7a6e5c2468bae53e2e4235843827b982d/python/typeshed/issues/6079
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f10f4df1c0130dd2958ef5d3a1812cb7a6e5c2468bae53e2e4235843827b982d/python/typeshed/issues/6079
og:image:altWhile working on python/mypy#11047 I've noticed that there's an issue with typing.NamedTuple Right now __init__ of typing.NamedTuple has type: def __init__(self, typename: str, fields: Iterable[Tup...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesobolevn
hostnamegithub.com
expected-hostnamegithub.com
None0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729
turbo-cache-controlno-preview
go-importgithub.com/python/typeshed git https://github.com/python/typeshed.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id31696383
octolytics-dimension-repository_nwopython/typeshed
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id31696383
octolytics-dimension-repository_network_root_nwopython/typeshed
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release16a11879678aaf97e2a42c33ee70830aa084fa37
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/typeshed/issues/6079#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fissues%2F6079
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fissues%2F6079
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Ftypeshed
Reloadhttps://github.com/python/typeshed/issues/6079
Reloadhttps://github.com/python/typeshed/issues/6079
Reloadhttps://github.com/python/typeshed/issues/6079
pythonhttps://github.com/python
typeshedhttps://github.com/python/typeshed
Codehttps://github.com/python/typeshed
Issues196 (196)https://github.com/python/typeshed/issues
Pull requests251 (251)https://github.com/python/typeshed/pulls
Actionshttps://github.com/python/typeshed/actions
Security and qualityhttps://github.com/python/typeshed/security
Insightshttps://github.com/python/typeshed/insights
https://github.com/python/typeshed
New issuehttps://github.com/login?return_to=https://github.com/python/typeshed/issues/6079
New issuehttps://github.com/login?return_to=https://github.com/python/typeshed/issues/6079
#6080https://github.com/python/typeshed/pull/6080
Fix __init__ type of typing.NamedTuplehttps://github.com/python/typeshed/issues/6079#top
#6080https://github.com/python/typeshed/pull/6080
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
on Sep 26, 2021https://github.com/python/typeshed/issues/6079#issue-1007465549
python/mypy#11047https://github.com/python/mypy/issues/11047
https://github.com/python/cpython/blob/f56268a2cd38b3fe2be1e4361d3d8b581e73559b/Lib/typing.py#L2290-L2294https://github.com/python/cpython/blob/f56268a2cd38b3fe2be1e4361d3d8b581e73559b/Lib/typing.py#L2290-L2294
JelleZijlstrahttps://github.com/JelleZijlstra
completedhttps://github.com/python/typeshed/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Sep 29, 2021https://github.com/python/typeshed/issues/6079#event-5377811636
hauntsaninjahttps://github.com/hauntsaninja
on Sep 29, 2021https://github.com/python/typeshed/issues/6079#event-5377822627
Fixes `__init__` of `typing.NamedTuple` (#6080)https://github.com/python/typeshed/commit/4ac969ad2cd8ceb4b1b7ff75311fd3abbf5d39fa
#6080https://github.com/python/typeshed/pull/6080
https://docs.github.com/articles/closing-issues-via-commit-messages
4ac969ahttps://github.com/python/typeshed/commit/4ac969ad2cd8ceb4b1b7ff75311fd3abbf5d39fa
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/typeshed/issues/6079
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/typeshed/issues/6079
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.