René's URL Explorer Experiment


Title: Mapping.values() return type is too narrow · Issue #4435 · python/typeshed · GitHub

Open Graph Title: Mapping.values() return type is too narrow · Issue #4435 · python/typeshed

X Title: Mapping.values() return type is too narrow · Issue #4435 · python/typeshed

Description: Currently, the type hint for Mapping.values() requires implementors of the Mapping interface to return a ValuesView: class Mapping(_Collection[_KT], Generic[_KT, _VT_co]): ... def values(self) -> ValuesView[_VT_co]: ... But ValuesView is...

Open Graph Description: Currently, the type hint for Mapping.values() requires implementors of the Mapping interface to return a ValuesView: class Mapping(_Collection[_KT], Generic[_KT, _VT_co]): ... def values(self) -> V...

X Description: Currently, the type hint for Mapping.values() requires implementors of the Mapping interface to return a ValuesView: class Mapping(_Collection[_KT], Generic[_KT, _VT_co]): ... def values(self) ->...

Opengraph URL: https://github.com/python/typeshed/issues/4435

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Mapping.values() return type is too narrow","articleBody":"Currently, the type hint for `Mapping.values()` [requires implementors of the `Mapping` interface to return a `ValuesView`](https://github.com/python/typeshed/blob/f46fb7/stdlib/3/typing.pyi#L425):\r\n```python\r\nclass Mapping(_Collection[_KT], Generic[_KT, _VT_co]):\r\n    ...\r\n    def values(self) -> ValuesView[_VT_co]: ...\r\n```\r\n\r\nBut `ValuesView` is too narrow. For example, an ABC for a `BidirectionalMapping` interface which extends the `Mapping` interface should be able to declare that the `values()` method returns an `AbstractSet` (since the values of a bidirectional mapping actually make up a set), [as I need to do in my `bidict` library](https://github.com/jab/bidict/blob/master/bidict/_abc.py#L81). Note that an `AbstractSet` satisfies the contract of a `ValuesView`. But currently declaring this causes the mypy error, `Return type \"AbstractSet[VT]\" of \"values\" incompatible with return type \"ValuesView[VT]\" in supertype \"Mapping\"`.\r\n\r\n(Notice that the type hints for `Mapping.keys()` and `Mapping.items()` return `AbstractSet` rather than `KeysView` and `ItemsView`, respectively, because even `KeysView` and `ItemsView` would have been too narrow there. In other words, those type hints are abstract enough. Only the type hint for `values()` is not abstract enough.)\r\n\r\nIt looks like one way to fix this would be to declare that `Mapping.values()` must return a `Collection[VT]` rather than a `ValuesView[VT]`. Since `AbstractSet` is a subtype of `Collection`, then `BidirectionalMapping.values()` (and other implementors) could return an `AbstractSet[VT]` (or any other subtype) and still satisfy the contract for `Mapping.values()`.\r\n\r\nDoes that make sense, or would some other fix be better here?","author":{"url":"https://github.com/jab","@type":"Person","name":"jab"},"datePublished":"2020-08-10T22:50:47Z","url":"https://github.com/python/typeshed/issues/4435"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:170e9601-92d3-82e9-dfcf-33b65c5b05f2
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idCC5A:1CF166:2714D4B:3541E0F:6B0042CC
html-safe-nonce5ef0716bfafe1a567671ea02ca76021098cd16eb69f80d9ba44411387f71e76e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQzVBOjFDRjE2NjoyNzE0RDRCOjM1NDFFMEY6NkIwMDQyQ0MiLCJ2aXNpdG9yX2lkIjoiMjgyOTA1Nzk0OTkzNzE4OTU4MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac238f8b35eb59d9400a69319befc779d9be1e4eafe47e0fac49d23682256c2210
hovercard-subject-tagissue:676462764
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/typeshed/4435/issue_layout
twitter:imagehttps://opengraph.githubassets.com/9b0ed38d7f4f8c5b347794d4b4cfda105252b2d380f4ae08eeab1933d529e1cf/python/typeshed/issues/4435
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9b0ed38d7f4f8c5b347794d4b4cfda105252b2d380f4ae08eeab1933d529e1cf/python/typeshed/issues/4435
og:image:altCurrently, the type hint for Mapping.values() requires implementors of the Mapping interface to return a ValuesView: class Mapping(_Collection[_KT], Generic[_KT, _VT_co]): ... def values(self) -> V...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejab
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-preview
go-importgithub.com/python/typeshed git https://github.com/python/typeshed.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id31696383
octolytics-dimension-repository_nwopython/typeshed
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id31696383
octolytics-dimension-repository_network_root_nwopython/typeshed
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/typeshed/issues/4435#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fissues%2F4435
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fissues%2F4435
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Ftypeshed
Reloadhttps://github.com/python/typeshed/issues/4435
Reloadhttps://github.com/python/typeshed/issues/4435
Reloadhttps://github.com/python/typeshed/issues/4435
pythonhttps://github.com/python
typeshedhttps://github.com/python/typeshed
Codehttps://github.com/python/typeshed
Issues196 (196)https://github.com/python/typeshed/issues
Pull requests252 (252)https://github.com/python/typeshed/pulls
Actionshttps://github.com/python/typeshed/actions
Security and qualityhttps://github.com/python/typeshed/security
Insightshttps://github.com/python/typeshed/insights
https://github.com/python/typeshed
New issuehttps://github.com/login?return_to=https://github.com/python/typeshed/issues/4435
New issuehttps://github.com/login?return_to=https://github.com/python/typeshed/issues/4435
Mapping.values() return type is too narrowhttps://github.com/python/typeshed/issues/4435#top
https://github.com/jab
jabhttps://github.com/jab
on Aug 10, 2020https://github.com/python/typeshed/issues/4435#issue-676462764
requires implementors of the Mapping interface to return a ValuesViewhttps://github.com/python/typeshed/blob/f46fb7/stdlib/3/typing.pyi#L425
as I need to do in my bidict libraryhttps://github.com/jab/bidict/blob/master/bidict/_abc.py#L81
https://github.com/srittau
srittauhttps://github.com/srittau
on Aug 11, 2020https://github.com/python/typeshed/issues/4435#issuecomment-671911147
https://github.com/jab
jabhttps://github.com/jab
on Aug 11, 2020https://github.com/python/typeshed/issues/4435#issuecomment-671950648
https://github.com/jab
jabhttps://github.com/jab
on Aug 11, 2020https://github.com/python/typeshed/issues/4435#issuecomment-671959770
@matthiaskrammhttps://github.com/matthiaskramm
337abedhttps://github.com/python/typeshed/commit/337abed05a35f0c5b67c02d42bca0af1e2adc76e
@matthiaskrammhttps://github.com/matthiaskramm
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
on Aug 11, 2020https://github.com/python/typeshed/issues/4435#issuecomment-671963989
https://github.com/srittau
srittauhttps://github.com/srittau
on Aug 11, 2020https://github.com/python/typeshed/issues/4435#issuecomment-671983021
#3576https://github.com/python/typeshed/issues/3576
https://github.com/jab
jabhttps://github.com/jab
on Aug 12, 2020https://github.com/python/typeshed/issues/4435#issuecomment-672894473
@gvanrossumhttps://github.com/gvanrossum
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
on Dec 22, 2021https://github.com/python/typeshed/issues/4435#issuecomment-999303554
JelleZijlstrahttps://github.com/JelleZijlstra
completedhttps://github.com/python/typeshed/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Dec 22, 2021https://github.com/python/typeshed/issues/4435#event-5802734386
https://github.com/jab
jabhttps://github.com/jab
on Dec 22, 2021https://github.com/python/typeshed/issues/4435#issuecomment-999876147
https://github.com/jab
jabhttps://github.com/jab
on Feb 7, 2022https://github.com/python/typeshed/issues/4435#issuecomment-1031963535
@JelleZijlstrahttps://github.com/JelleZijlstra
herehttps://github.com/jab/bidict/blob/87bfd1/bidict/_base.py#L38
resort to typing.cast()https://github.com/jab/bidict/blob/87bfd1/bidict/_base.py#L226
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/typeshed/issues/4435
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/typeshed/issues/4435
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.