Title: attr-defined not working on werkzeug.wrappers.BaseRequest childs · Issue #3913 · python/typeshed · GitHub
Open Graph Title: attr-defined not working on werkzeug.wrappers.BaseRequest childs · Issue #3913 · python/typeshed
X Title: attr-defined not working on werkzeug.wrappers.BaseRequest childs · Issue #3913 · python/typeshed
Description: The PR #2740 added __setattr__ and __getattr__ to the werkzeug.wrappers.BaseRequest definition. typeshed/third_party/2and3/werkzeug/wrappers.pyi Line 92 in 60cdee5 def __setattr__(self, name: str, value: Any): ... I have seen the comment...
Open Graph Description: The PR #2740 added __setattr__ and __getattr__ to the werkzeug.wrappers.BaseRequest definition. typeshed/third_party/2and3/werkzeug/wrappers.pyi Line 92 in 60cdee5 def __setattr__(self, name: str, ...
X Description: The PR #2740 added __setattr__ and __getattr__ to the werkzeug.wrappers.BaseRequest definition. typeshed/third_party/2and3/werkzeug/wrappers.pyi Line 92 in 60cdee5 def __setattr__(self, name: str, ...
Opengraph URL: https://github.com/python/typeshed/issues/3913
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"attr-defined not working on werkzeug.wrappers.BaseRequest childs","articleBody":"The PR #2740 added `__setattr__` and `__getattr__` to the `werkzeug.wrappers.BaseRequest` definition.\r\n\r\nhttps://github.com/python/typeshed/blob/60cdee5b2d2366bf9bd2b50c05f850411ef91eb0/third_party/2and3/werkzeug/wrappers.pyi#L92\r\n\r\nI have seen the comment about the change, but I cannot understand why this is a good way to go. This class is often used as parent class. No attribute checks can be made in any child class.\r\n\r\nCan we please remove these definitions?\r\n","author":{"url":"https://github.com/LarsMichelsen","@type":"Person","name":"LarsMichelsen"},"datePublished":"2020-04-07T15:29:33Z","url":"https://github.com/python/typeshed/issues/3913"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:584e6c8a-14c3-2aae-4722-e51b9cbff839 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | E684:43251:2012B00:2ACDF73:6B0052F6 |
| html-safe-nonce | d6ca8e7c8baa96b99c019de2c3f4fb653d8487c2a27af4b02c99465c8463cd92 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNjg0OjQzMjUxOjIwMTJCMDA6MkFDREY3Mzo2QjAwNTJGNiIsInZpc2l0b3JfaWQiOiIyMDA4NTQ4MDgwNjA5MTUzNzgyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 0cc99af780350191d62f49b47c1a2c84cb24cec246f09dc54873add3d7b3d1ce |
| hovercard-subject-tag | issue:595956427 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/typeshed/3913/issue_layout |
| twitter:image | https://opengraph.githubassets.com/31d5193bfb4e6d2f1d17458b65f8bbb4e3b575d86eb8279e3671e7aca6d3f1f0/python/typeshed/issues/3913 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/31d5193bfb4e6d2f1d17458b65f8bbb4e3b575d86eb8279e3671e7aca6d3f1f0/python/typeshed/issues/3913 |
| og:image:alt | The PR #2740 added __setattr__ and __getattr__ to the werkzeug.wrappers.BaseRequest definition. typeshed/third_party/2and3/werkzeug/wrappers.pyi Line 92 in 60cdee5 def __setattr__(self, name: str, ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | LarsMichelsen |
| hostname | github.com |
| expected-hostname | github.com |
| None | f420f4996e6b1ff1ccd6d7683f8134f4b5f0f8a50124c210dbfe7490e5644abb |
| turbo-cache-control | no-preview |
| go-import | github.com/python/typeshed git https://github.com/python/typeshed.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 31696383 |
| octolytics-dimension-repository_nwo | python/typeshed |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 31696383 |
| octolytics-dimension-repository_network_root_nwo | python/typeshed |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 26e00df917aba0f128135dc073ea0c5e33a70d40 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width