René's URL Explorer Experiment


Title: attr-defined not working on werkzeug.wrappers.BaseRequest childs · Issue #3913 · python/typeshed · GitHub

Open Graph Title: attr-defined not working on werkzeug.wrappers.BaseRequest childs · Issue #3913 · python/typeshed

X Title: attr-defined not working on werkzeug.wrappers.BaseRequest childs · Issue #3913 · python/typeshed

Description: The PR #2740 added __setattr__ and __getattr__ to the werkzeug.wrappers.BaseRequest definition. typeshed/third_party/2and3/werkzeug/wrappers.pyi Line 92 in 60cdee5 def __setattr__(self, name: str, value: Any): ... I have seen the comment...

Open Graph Description: The PR #2740 added __setattr__ and __getattr__ to the werkzeug.wrappers.BaseRequest definition. typeshed/third_party/2and3/werkzeug/wrappers.pyi Line 92 in 60cdee5 def __setattr__(self, name: str, ...

X Description: The PR #2740 added __setattr__ and __getattr__ to the werkzeug.wrappers.BaseRequest definition. typeshed/third_party/2and3/werkzeug/wrappers.pyi Line 92 in 60cdee5 def __setattr__(self, name: str, ...

Opengraph URL: https://github.com/python/typeshed/issues/3913

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"attr-defined not working on werkzeug.wrappers.BaseRequest childs","articleBody":"The PR #2740 added `__setattr__` and `__getattr__` to the `werkzeug.wrappers.BaseRequest` definition.\r\n\r\nhttps://github.com/python/typeshed/blob/60cdee5b2d2366bf9bd2b50c05f850411ef91eb0/third_party/2and3/werkzeug/wrappers.pyi#L92\r\n\r\nI have seen the comment about the change, but I cannot understand why this is a good way to go. This class is often used as parent class. No attribute checks can be made in any child class.\r\n\r\nCan we please remove these definitions?\r\n","author":{"url":"https://github.com/LarsMichelsen","@type":"Person","name":"LarsMichelsen"},"datePublished":"2020-04-07T15:29:33Z","url":"https://github.com/python/typeshed/issues/3913"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:584e6c8a-14c3-2aae-4722-e51b9cbff839
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idE684:43251:2012B00:2ACDF73:6B0052F6
html-safe-nonced6ca8e7c8baa96b99c019de2c3f4fb653d8487c2a27af4b02c99465c8463cd92
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNjg0OjQzMjUxOjIwMTJCMDA6MkFDREY3Mzo2QjAwNTJGNiIsInZpc2l0b3JfaWQiOiIyMDA4NTQ4MDgwNjA5MTUzNzgyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac0cc99af780350191d62f49b47c1a2c84cb24cec246f09dc54873add3d7b3d1ce
hovercard-subject-tagissue:595956427
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/typeshed/3913/issue_layout
twitter:imagehttps://opengraph.githubassets.com/31d5193bfb4e6d2f1d17458b65f8bbb4e3b575d86eb8279e3671e7aca6d3f1f0/python/typeshed/issues/3913
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/31d5193bfb4e6d2f1d17458b65f8bbb4e3b575d86eb8279e3671e7aca6d3f1f0/python/typeshed/issues/3913
og:image:altThe PR #2740 added __setattr__ and __getattr__ to the werkzeug.wrappers.BaseRequest definition. typeshed/third_party/2and3/werkzeug/wrappers.pyi Line 92 in 60cdee5 def __setattr__(self, name: str, ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameLarsMichelsen
hostnamegithub.com
expected-hostnamegithub.com
Nonef420f4996e6b1ff1ccd6d7683f8134f4b5f0f8a50124c210dbfe7490e5644abb
turbo-cache-controlno-preview
go-importgithub.com/python/typeshed git https://github.com/python/typeshed.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id31696383
octolytics-dimension-repository_nwopython/typeshed
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id31696383
octolytics-dimension-repository_network_root_nwopython/typeshed
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26e00df917aba0f128135dc073ea0c5e33a70d40
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/typeshed/issues/3913#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fissues%2F3913
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fissues%2F3913
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Ftypeshed
Reloadhttps://github.com/python/typeshed/issues/3913
Reloadhttps://github.com/python/typeshed/issues/3913
Reloadhttps://github.com/python/typeshed/issues/3913
pythonhttps://github.com/python
typeshedhttps://github.com/python/typeshed
Codehttps://github.com/python/typeshed
Issues196 (196)https://github.com/python/typeshed/issues
Pull requests252 (252)https://github.com/python/typeshed/pulls
Actionshttps://github.com/python/typeshed/actions
Security and qualityhttps://github.com/python/typeshed/security
Insightshttps://github.com/python/typeshed/insights
https://github.com/python/typeshed
New issuehttps://github.com/login?return_to=https://github.com/python/typeshed/issues/3913
New issuehttps://github.com/login?return_to=https://github.com/python/typeshed/issues/3913
attr-defined not working on werkzeug.wrappers.BaseRequest childshttps://github.com/python/typeshed/issues/3913#top
https://github.com/LarsMichelsen
LarsMichelsenhttps://github.com/LarsMichelsen
on Apr 7, 2020https://github.com/python/typeshed/issues/3913#issue-595956427
#2740https://github.com/python/typeshed/pull/2740
typeshed/third_party/2and3/werkzeug/wrappers.pyihttps://github.com/python/typeshed/blob/60cdee5b2d2366bf9bd2b50c05f850411ef91eb0/third_party/2and3/werkzeug/wrappers.pyi#L92
60cdee5https://github.com/python/typeshed/commit/60cdee5b2d2366bf9bd2b50c05f850411ef91eb0
LarsMichelsenhttps://github.com/LarsMichelsen
on Apr 7, 2020https://github.com/python/typeshed/issues/3913#event-3211113804
Second step to fix mypy checks for Requesthttps://github.com/Checkmk/checkmk/commit/e5064fa049024d02f8f37913a567330a6a2c8b63
e5064fahttps://github.com/Checkmk/checkmk/commit/e5064fa049024d02f8f37913a567330a6a2c8b63
Fix attr-defined check for werkzeug.wrappers.BaseRequest (fixes pytho…https://github.com/LarsMichelsen/typeshed/commit/162419c3c402c55dc8a5ed2a986ca9bf4f8f2728
pytho…https://github.com/python/typeshed/issues/3913
162419chttps://github.com/LarsMichelsen/typeshed/commit/162419c3c402c55dc8a5ed2a986ca9bf4f8f2728
srittauhttps://github.com/srittau
completedhttps://github.com/python/typeshed/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
9dab57bhttps://github.com/python/typeshed/commit/9dab57b0e876e276c3fb2988a0258d538525d3d5
on Apr 25, 2020https://github.com/python/typeshed/issues/3913#event-3271825205
vishalkuohttps://github.com/vishalkuo
on Jun 26, 2020https://github.com/python/typeshed/issues/3913#event-3487537722
Fix attr-defined check for werkzeug.wrappers.BaseRequest (fixes pytho…https://github.com/vishalkuo/typeshed/commit/00bd5e862d77d508a6ba8df241a433205d27e1fd
pytho…https://github.com/python/typeshed/issues/3913
https://docs.github.com/articles/closing-issues-via-commit-messages
00bd5e8https://github.com/vishalkuo/typeshed/commit/00bd5e862d77d508a6ba8df241a433205d27e1fd
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/typeshed/issues/3913
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/typeshed/issues/3913
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.