René's URL Explorer Experiment


Title: Review Depth · Issue #3448 · python/typeshed · GitHub

Open Graph Title: Review Depth · Issue #3448 · python/typeshed

X Title: Review Depth · Issue #3448 · python/typeshed

Description: I'd like to add short guidelines to the maintainer's section of CONTRIBUTING about how thorough a PR should be reviewed, but we need to agree on that first. My personal take (not final wording): Auto-generated stubs: just do a brief scan...

Open Graph Description: I'd like to add short guidelines to the maintainer's section of CONTRIBUTING about how thorough a PR should be reviewed, but we need to agree on that first. My personal take (not final wording): Au...

X Description: I'd like to add short guidelines to the maintainer's section of CONTRIBUTING about how thorough a PR should be reviewed, but we need to agree on that first. My personal take (not final word...

Opengraph URL: https://github.com/python/typeshed/issues/3448

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Review Depth","articleBody":"I'd like to add short guidelines to the maintainer's section of CONTRIBUTING about how thorough a PR should be reviewed, but we need to agree on that first. My personal take (not final wording):\r\n\r\n* Auto-generated stubs: just do a brief scan for red flags, ignore possible improvements to keep contribution bar low.\r\n* Large hand-crafted PRs like my recent 3.8 PRs or the cryptography PR: while maintainer's are free to delve into it as deeply as they wish, mostly look for red flags, general issues, and do spot checks.\r\n* Smaller hand-crafted PRs: Do a thorough review.","author":{"url":"https://github.com/srittau","@type":"Person","name":"srittau"},"datePublished":"2019-11-07T08:12:47Z","url":"https://github.com/python/typeshed/issues/3448"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:a3aca511-8e1f-cb54-d437-3e65ff2bfb72
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idCD10:15E5F9:248AAFA:31D0EF2:6B003790
html-safe-nonce56651ddad0556246d313865a2ae217ed30c1ded080b00ea65547d5319b7d18c1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRDEwOjE1RTVGOToyNDhBQUZBOjMxRDBFRjI6NkIwMDM3OTAiLCJ2aXNpdG9yX2lkIjoiNjg1MTE0OTU3MDExODkyMTEyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac68519fcd8f7e3a15e41568730c8176ee6cb49f73436a5487fce960fdc57074a0
hovercard-subject-tagissue:519108126
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/typeshed/3448/issue_layout
twitter:imagehttps://opengraph.githubassets.com/f51249fca59153a57109dd800f9ba1ae32e03fa82f60e98a3b04bd1da4e77a5c/python/typeshed/issues/3448
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f51249fca59153a57109dd800f9ba1ae32e03fa82f60e98a3b04bd1da4e77a5c/python/typeshed/issues/3448
og:image:altI'd like to add short guidelines to the maintainer's section of CONTRIBUTING about how thorough a PR should be reviewed, but we need to agree on that first. My personal take (not final wording): Au...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesrittau
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-preview
go-importgithub.com/python/typeshed git https://github.com/python/typeshed.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id31696383
octolytics-dimension-repository_nwopython/typeshed
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id31696383
octolytics-dimension-repository_network_root_nwopython/typeshed
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/typeshed/issues/3448#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fissues%2F3448
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fissues%2F3448
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Ftypeshed
Reloadhttps://github.com/python/typeshed/issues/3448
Reloadhttps://github.com/python/typeshed/issues/3448
Reloadhttps://github.com/python/typeshed/issues/3448
pythonhttps://github.com/python
typeshedhttps://github.com/python/typeshed
Codehttps://github.com/python/typeshed
Issues196 (196)https://github.com/python/typeshed/issues
Pull requests251 (251)https://github.com/python/typeshed/pulls
Actionshttps://github.com/python/typeshed/actions
Security and qualityhttps://github.com/python/typeshed/security
Insightshttps://github.com/python/typeshed/insights
https://github.com/python/typeshed
New issuehttps://github.com/login?return_to=https://github.com/python/typeshed/issues/3448
New issuehttps://github.com/login?return_to=https://github.com/python/typeshed/issues/3448
#4132https://github.com/python/typeshed/pull/4132
Review Depthhttps://github.com/python/typeshed/issues/3448#top
#4132https://github.com/python/typeshed/pull/4132
project: policyOrganization of the typeshed projecthttps://github.com/python/typeshed/issues?q=state%3Aopen%20label%3A%22project%3A%20policy%22
https://github.com/srittau
srittauhttps://github.com/srittau
on Nov 7, 2019https://github.com/python/typeshed/issues/3448#issue-519108126
srittauhttps://github.com/srittau
project: policyOrganization of the typeshed projecthttps://github.com/python/typeshed/issues?q=state%3Aopen%20label%3A%22project%3A%20policy%22
on Nov 7, 2019https://github.com/python/typeshed/issues/3448#event-2778259717
srittauhttps://github.com/srittau
on May 28, 2020https://github.com/python/typeshed/issues/3448#event-3382527534
Add review guidlineshttps://github.com/srittau/typeshed/commit/8d37ee4fa347a7edbffe56b5ee992388f5035483
https://docs.github.com/articles/closing-issues-via-commit-messages
8d37ee4https://github.com/srittau/typeshed/commit/8d37ee4fa347a7edbffe56b5ee992388f5035483
srittauhttps://github.com/srittau
completedhttps://github.com/python/typeshed/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#4132https://github.com/python/typeshed/pull/4132
on May 28, 2020https://github.com/python/typeshed/issues/3448#event-3382739556
srittauhttps://github.com/srittau
on May 28, 2020https://github.com/python/typeshed/issues/3448#event-3382739659
Add review guidlines (#4132)https://github.com/python/typeshed/commit/adafaf19642f85640d288d89205909ba2b58dadd
#4132https://github.com/python/typeshed/pull/4132
https://docs.github.com/articles/closing-issues-via-commit-messages
adafaf1https://github.com/python/typeshed/commit/adafaf19642f85640d288d89205909ba2b58dadd
vishalkuohttps://github.com/vishalkuo
on Jun 26, 2020https://github.com/python/typeshed/issues/3448#event-3487538906
Add review guidlines (python#4132)https://github.com/vishalkuo/typeshed/commit/f58838bf2a2c0fb1386548ce84371528f3354d74
python#4132https://github.com/python/typeshed/pull/4132
https://docs.github.com/articles/closing-issues-via-commit-messages
f58838bhttps://github.com/vishalkuo/typeshed/commit/f58838bf2a2c0fb1386548ce84371528f3354d74
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/typeshed/issues/3448
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/typeshed/issues/3448
project: policyOrganization of the typeshed projecthttps://github.com/python/typeshed/issues?q=state%3Aopen%20label%3A%22project%3A%20policy%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.