Title: Review Depth · Issue #3448 · python/typeshed · GitHub
Open Graph Title: Review Depth · Issue #3448 · python/typeshed
X Title: Review Depth · Issue #3448 · python/typeshed
Description: I'd like to add short guidelines to the maintainer's section of CONTRIBUTING about how thorough a PR should be reviewed, but we need to agree on that first. My personal take (not final wording): Auto-generated stubs: just do a brief scan...
Open Graph Description: I'd like to add short guidelines to the maintainer's section of CONTRIBUTING about how thorough a PR should be reviewed, but we need to agree on that first. My personal take (not final wording): Au...
X Description: I'd like to add short guidelines to the maintainer's section of CONTRIBUTING about how thorough a PR should be reviewed, but we need to agree on that first. My personal take (not final word...
Opengraph URL: https://github.com/python/typeshed/issues/3448
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Review Depth","articleBody":"I'd like to add short guidelines to the maintainer's section of CONTRIBUTING about how thorough a PR should be reviewed, but we need to agree on that first. My personal take (not final wording):\r\n\r\n* Auto-generated stubs: just do a brief scan for red flags, ignore possible improvements to keep contribution bar low.\r\n* Large hand-crafted PRs like my recent 3.8 PRs or the cryptography PR: while maintainer's are free to delve into it as deeply as they wish, mostly look for red flags, general issues, and do spot checks.\r\n* Smaller hand-crafted PRs: Do a thorough review.","author":{"url":"https://github.com/srittau","@type":"Person","name":"srittau"},"datePublished":"2019-11-07T08:12:47Z","url":"https://github.com/python/typeshed/issues/3448"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:a3aca511-8e1f-cb54-d437-3e65ff2bfb72 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | CD10:15E5F9:248AAFA:31D0EF2:6B003790 |
| html-safe-nonce | 56651ddad0556246d313865a2ae217ed30c1ded080b00ea65547d5319b7d18c1 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRDEwOjE1RTVGOToyNDhBQUZBOjMxRDBFRjI6NkIwMDM3OTAiLCJ2aXNpdG9yX2lkIjoiNjg1MTE0OTU3MDExODkyMTEyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 68519fcd8f7e3a15e41568730c8176ee6cb49f73436a5487fce960fdc57074a0 |
| hovercard-subject-tag | issue:519108126 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/typeshed/3448/issue_layout |
| twitter:image | https://opengraph.githubassets.com/f51249fca59153a57109dd800f9ba1ae32e03fa82f60e98a3b04bd1da4e77a5c/python/typeshed/issues/3448 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/f51249fca59153a57109dd800f9ba1ae32e03fa82f60e98a3b04bd1da4e77a5c/python/typeshed/issues/3448 |
| og:image:alt | I'd like to add short guidelines to the maintainer's section of CONTRIBUTING about how thorough a PR should be reviewed, but we need to agree on that first. My personal take (not final wording): Au... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | srittau |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/typeshed git https://github.com/python/typeshed.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 31696383 |
| octolytics-dimension-repository_nwo | python/typeshed |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 31696383 |
| octolytics-dimension-repository_network_root_nwo | python/typeshed |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f3f3a43ca095cdea3abbb394112e971f9fdb94fa |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width