René's URL Explorer Experiment


Title: Applying more Ruff groups to this repository · Issue #13295 · python/typeshed · GitHub

Open Graph Title: Applying more Ruff groups to this repository · Issue #13295 · python/typeshed

X Title: Applying more Ruff groups to this repository · Issue #13295 · python/typeshed

Description: The current selection of Ruff rules comes as a direct translation from when we were using isort, pyupgrade, pycln, Flake8, and some plugins. It made perfect sense at the time to restrict ourselves to only the most necessary rules, as add...

Open Graph Description: The current selection of Ruff rules comes as a direct translation from when we were using isort, pyupgrade, pycln, Flake8, and some plugins. It made perfect sense at the time to restrict ourselves ...

X Description: The current selection of Ruff rules comes as a direct translation from when we were using isort, pyupgrade, pycln, Flake8, and some plugins. It made perfect sense at the time to restrict ourselves ...

Opengraph URL: https://github.com/python/typeshed/issues/13295

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Applying more Ruff groups to this repository","articleBody":"The current selection of Ruff rules comes as a direct translation from when we were using isort, pyupgrade, pycln, Flake8, and some plugins.\nIt made perfect sense at the time to restrict ourselves to only the most necessary rules, as additional linters and tooling to be installed and run could mean an increase in CI runtime, security risks, upgrade maintenance, and complications between incompatible versions of libraries.\n\nBut with Ruff, the context is completely different. It is so fast than any additional rule group is negligible on the runtime and it's a single dependency. Which means that we could enable more rule groups w/o much concerns to help keep our growing non-stubs code up to the best standards. And explore more lints that could be beneficial to stubs.\n\nAs a side effect, we get to test various Ruff rules on a very 3rd-party type-stubs-driven repository, helping catch edge-cases and rules that don't belong in that context. This, in my opinion, would further bolster the existing collaboration between Ruff and typeshed, as well as indirectly help the Python typing community that also uses Ruff.\n\n---\n\nI'm already ready with an experiment PR to see the width and scale of changes this would entail with nearly all rules enabled.\nhttps://github.com/Avasam/typeshed/pull/39 (not something to be reviewed, just a launching point for me, like a possible \"todo list\")\nOf course I would go incrementally: starting with those that already pass as-is, then those covered by autofixes, individually splitting off the more massive ones, finishing with the manual interventions.\n\n---\n\n\u003cdetails>\n\u003csummary>Checklist\u003c/summary>\n\n- `Flake8`:\n  - `Pyflakes (F)`: https://github.com/python/typeshed/pull/11496\n  - `pycodestyle Error (E)`: https://github.com/python/typeshed/pull/11496\n  - `pycodestyle Warning (W)`: https://github.com/python/typeshed/pull/11496\n  - `mccabe (C90)`: ❌We don't actually mind long and complex tests. This is also very arbitrary, let's make that call on individual reviews\n- `isort (I)`: https://github.com/python/typeshed/pull/10912\n- `pep8-naming (N)`: https://github.com/python/typeshed/pull/13327\n- `pydocstyle (D)`: https://github.com/python/typeshed/pull/13326 & \n- `pyupgrade (UP)`: https://github.com/python/typeshed/pull/11499\n- `flake8-2020 (YTT)`: https://github.com/python/typeshed/pull/13314\n- `flake8-annotations (ANN)`: https://github.com/python/typeshed/pull/13331\n  - ⚠Once https://github.com/python/typeshed/issues/9550 is complete, `ANN401` *could* be considered\n- `flake8-async (ASYNC)`: https://github.com/python/typeshed/pull/13727\n- `flake8-bandit (S)`: https://github.com/Avasam/typeshed/tree/Ruff-S-flake8-bandit\n- `flake8-blind-except (BLE)`: https://github.com/python/typeshed/pull/13728\n- `flake8-boolean-trap (FBT)`: ☑https://github.com/python/typeshed/pull/13751\n- `flake8-bugbear (B)`: https://github.com/python/typeshed/pull/11500 & https://github.com/python/typeshed/pull/13308\n- `flake8-builtins (A)`: https://github.com/python/typeshed/pull/13729\n- `flake8-commas (COM)`: ❌Already taken care of by, or conflict with, Black\n- `flake8-copyright (CPY)`: ❌Not using top-of-file copyright notices\n- `flake8-comprehensions (C4)`: ☑https://github.com/python/typeshed/pull/13751\n- `flake8-datetimez (DTZ)`: ☑https://github.com/python/typeshed/pull/13751\n- `flake8-debugger (T10)`: ☑https://github.com/python/typeshed/pull/13751\n- `flake8-django (DJ)`: ❌Not using Django at runtime\n- `flake8-errmsg (EM)`: https://github.com/python/typeshed/pull/13730\n- `flake8-executable (EXE)`: https://github.com/python/typeshed/pull/13346\n- `flake8-future-annotations (FA)`: https://github.com/python/typeshed/pull/10910\n- `flake8-implicit-str-concat (ISC)`: ❌Mostly taken care of by the formatter. And we allow both implicit and explicit multiline strings (to my dismay 😆)\n- `flake8-import-conventions (ICN)`: https://github.com/python/typeshed/pull/13731\n- `flake8-logging (LOG)`: ❌Not using logging at runtime\n- `flake8-logging-format (G)`: ❌Not using logging at runtime\n- `flake8-no-pep420 (INP)`: ❌Leave the decision at review to use [PEP 420](https://peps.python.org/pep-0420/)\n- `flake8-pie (PIE)`: https://github.com/python/typeshed/pull/13747\n- `flake8-print (T20)`: ❌We use print as a logging mechanism\n- `flake8-pyi (PYI)`: https://github.com/python/typeshed/pull/10458 and ongoing\n- `flake8-pytest-style (PT)`: ❌Not using pytest at runtime / in our test suite\n- `flake8-quotes (Q)`: ❌This should be fully covered by formatters (whether Black or Ruff)\n- `flake8-raise (RSE)`: ☑https://github.com/python/typeshed/pull/13751\n- `flake8-return (RET)`: https://github.com/python/typeshed/pull/13323\n- `flake8-self (SLF)`: ❌Already configured to ignore in stubs and covered by [pyright's `reportprivateusage`](https://github.com/microsoft/pyright/blob/main/docs/configuration.md#reportprivateusage).\n- `flake8-slots (SLOT)`: ☑https://github.com/python/typeshed/pull/13751\n- `flake8-simplify (SIM)`: https://github.com/python/typeshed/pull/13309\n- `flake8-tidy-imports (TID)`: ❌Banned APIs need to be configured to be useful. A mix of stubs use relative imports.\n- `flake8-type-checking (TC)`: https://github.com/python/typeshed/pull/13333\n- `flake8-gettext (INT)`: ❌Not using gettext or translations\n- `flake8-unused-arguments (ARG)`: https://github.com/python/typeshed/pull/13334\n- `flake8-use-pathlib (PTH)`: https://github.com/python/typeshed/pull/13750 & \n- `flake8-todos (TD)`: https://github.com/python/typeshed/pull/13748\n- `flake8-fixme (FIX)`: ❌It doesn't make sense to block the CI on TODOs\n  - ⚠There's a feature request to configure rules as warnings in Ruff: https://github.com/astral-sh/ruff/issues/1256\n- `eradicate (ERA)`: ❌Way too many false-positives\n- `pandas-vet (PD)`: ❌Not using Pandas at runtime\n- `pygrep-hooks (PGH)`: https://github.com/python/typeshed/pull/13304\n- `Pylint (PL)`\n  - `Pylint Convention (PLC)`: https://github.com/python/typeshed/pull/13306\n  - `Pylint Error (PLE)`: https://github.com/python/typeshed/pull/13305\n  - `Pylint Refactor (PLR)`: https://github.com/python/typeshed/pull/13307\n  - `Pylint Warning (PLW)`: https://github.com/python/typeshed/pull/13749\n- `tryceratops (TRY)`: https://github.com/python/typeshed/pull/13359\n- `flynt (FLY)`: ☑https://github.com/python/typeshed/pull/13751\n- `NumPy-specific rules (NPY)`: ❌We may have to reference or support deprecated numpy types at times\n- `FastAPI (FAST)`: ❌Not using FastAPI at runtime\n- `Airflow (AIR)`: ❌Not using Airflow at runtime\n- `Perflint (PERF)`: https://github.com/python/typeshed/pull/13312\n- `refurb (FURB)`: https://github.com/python/typeshed/pull/13310\n- `pydoclint (DOC)`: ⚠(all in preview, enabling this would do nothing atm)\n- `Ruff-specific rules (RUF)`: https://github.com/python/typeshed/pull/11496\n\n☑: We already pass all these (not yet configured) as-is. Can enable together.\n\u003c/details>","author":{"url":"https://github.com/Avasam","@type":"Person","name":"Avasam"},"datePublished":"2024-12-24T20:39:43Z","url":"https://github.com/python/typeshed/issues/13295"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:15d960ba-0366-5360-3c70-fcb3ef9688b6
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idCF08:27E6DD:10072A8:14F3B65:6AFFF7B9
html-safe-nonce3f46c74951f4928a7da6fa925ccfbada683d1b2e9a185dcde57d7c86a6604f5c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRjA4OjI3RTZERDoxMDA3MkE4OjE0RjNCNjU6NkFGRkY3QjkiLCJ2aXNpdG9yX2lkIjoiNjQxMzQyMDA4MDcyNTQ4OTU5MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd838bc11a8a7ef77349b91fa81c6b2f6b9843dcb13058c8aff5d0bee5a7ea833
hovercard-subject-tagissue:2758273712
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/typeshed/13295/issue_layout
twitter:imagehttps://opengraph.githubassets.com/560ac7a61066814e7c8cee5c35cc299eaa413641b55b40080665c87cca6bce6b/python/typeshed/issues/13295
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/560ac7a61066814e7c8cee5c35cc299eaa413641b55b40080665c87cca6bce6b/python/typeshed/issues/13295
og:image:altThe current selection of Ruff rules comes as a direct translation from when we were using isort, pyupgrade, pycln, Flake8, and some plugins. It made perfect sense at the time to restrict ourselves ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameAvasam
hostnamegithub.com
expected-hostnamegithub.com
None0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729
turbo-cache-controlno-preview
go-importgithub.com/python/typeshed git https://github.com/python/typeshed.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id31696383
octolytics-dimension-repository_nwopython/typeshed
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id31696383
octolytics-dimension-repository_network_root_nwopython/typeshed
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release16a11879678aaf97e2a42c33ee70830aa084fa37
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/typeshed/issues/13295#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fissues%2F13295
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fissues%2F13295
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Ftypeshed
Reloadhttps://github.com/python/typeshed/issues/13295
Reloadhttps://github.com/python/typeshed/issues/13295
Reloadhttps://github.com/python/typeshed/issues/13295
pythonhttps://github.com/python
typeshedhttps://github.com/python/typeshed
Codehttps://github.com/python/typeshed
Issues196 (196)https://github.com/python/typeshed/issues
Pull requests249 (249)https://github.com/python/typeshed/pulls
Actionshttps://github.com/python/typeshed/actions
Security and qualityhttps://github.com/python/typeshed/security
Insightshttps://github.com/python/typeshed/insights
https://github.com/python/typeshed
New issuehttps://github.com/login?return_to=https://github.com/python/typeshed/issues/13295
New issuehttps://github.com/login?return_to=https://github.com/python/typeshed/issues/13295
#13795https://github.com/python/typeshed/pull/13795
Applying more Ruff groups to this repositoryhttps://github.com/python/typeshed/issues/13295#top
#13795https://github.com/python/typeshed/pull/13795
project: infrastructuretypeshed build, test, or distribution relatedhttps://github.com/python/typeshed/issues?q=state%3Aopen%20label%3A%22project%3A%20infrastructure%22
https://github.com/Avasam
Avasamhttps://github.com/Avasam
on Dec 24, 2024https://github.com/python/typeshed/issues/13295#issue-2758273712
Avasam#39https://github.com/Avasam/typeshed/pull/39
Replace Flake8 checks with Ruff (except for flake8-pyi) #11496https://github.com/python/typeshed/pull/11496
Replace Flake8 checks with Ruff (except for flake8-pyi) #11496https://github.com/python/typeshed/pull/11496
Replace Flake8 checks with Ruff (except for flake8-pyi) #11496https://github.com/python/typeshed/pull/11496
Replacing isort with Ruff #10912https://github.com/python/typeshed/pull/10912
Enable Ruff N (pep8-naming) on non-stubs #13327https://github.com/python/typeshed/pull/13327
Enable Ruff D (pydocstyle) with pep257 convention #13326https://github.com/python/typeshed/pull/13326
Enable nearly all pyupgrade rules (except on test cases) #11499https://github.com/python/typeshed/pull/11499
Enable Ruff YTT #13314https://github.com/python/typeshed/pull/13314
Enable Ruff ANN2 (flake8-annotations, autofixes only) #13331https://github.com/python/typeshed/pull/13331
Older stubs still explicitly using Any rather than Incomplete #9550https://github.com/python/typeshed/issues/9550
Enable Ruff flake8-async (ASYNC) #13727https://github.com/python/typeshed/pull/13727
https://github.com/Avasam/typeshed/tree/Ruff-S-flake8-bandithttps://github.com/Avasam/typeshed/tree/Ruff-S-flake8-bandit
Enable Ruff flake8-blind-except (BLE) #13728https://github.com/python/typeshed/pull/13728
Enable Ruff groups we already pass #13751https://github.com/python/typeshed/pull/13751
Replace flake8-bugbear with Ruff #11500https://github.com/python/typeshed/pull/11500
Remove redundant Bugbear disabling in stubs #13308https://github.com/python/typeshed/pull/13308
Enable Ruff flake8-builtins (A) #13729https://github.com/python/typeshed/pull/13729
Enable Ruff groups we already pass #13751https://github.com/python/typeshed/pull/13751
Enable Ruff groups we already pass #13751https://github.com/python/typeshed/pull/13751
Enable Ruff groups we already pass #13751https://github.com/python/typeshed/pull/13751
Enable Ruff flake8-errmsg (EM) #13730https://github.com/python/typeshed/pull/13730
Enable Ruff EXE (flake8-executable) #13346https://github.com/python/typeshed/pull/13346
Use Ruff for from __future__ import annotations checks #10910https://github.com/python/typeshed/pull/10910
Enable Ruff flake8-import-conventions (ICN) #13731https://github.com/python/typeshed/pull/13731
PEP 420https://peps.python.org/pep-0420/
Enable Ruff flake8-pie (PIE) #13747https://github.com/python/typeshed/pull/13747
Add some ruff autofixes to CI #10458https://github.com/python/typeshed/pull/10458
Enable Ruff groups we already pass #13751https://github.com/python/typeshed/pull/13751
Enable Ruff RET (flake8-return) #13323https://github.com/python/typeshed/pull/13323
pyright's reportprivateusagehttps://github.com/microsoft/pyright/blob/main/docs/configuration.md#reportprivateusage
Enable Ruff groups we already pass #13751https://github.com/python/typeshed/pull/13751
Enable Ruff SIM #13309https://github.com/python/typeshed/pull/13309
Enable some Ruff TC rules (flake8-type-checking) #13333https://github.com/python/typeshed/pull/13333
Enable Ruff ARG (flake8-unsued-arguments) and remove unused arguments #13334https://github.com/python/typeshed/pull/13334
Enable Ruff flake8-use-pathlib (PTH) (autofix only) #13750https://github.com/python/typeshed/pull/13750
Enable Ruff flake8-todos (TD) #13748https://github.com/python/typeshed/pull/13748
Feature request: Support a "warning" level for linting astral-sh/ruff#1256https://github.com/astral-sh/ruff/issues/1256
Enable Ruff PGH rules #13304https://github.com/python/typeshed/pull/13304
Enable Ruff PLC (Pylint Convention) #13306https://github.com/python/typeshed/pull/13306
Enable Ruff PLE (Pylint Error) #13305https://github.com/python/typeshed/pull/13305
Enable Ruff PLR (Pylint Refactor) #13307https://github.com/python/typeshed/pull/13307
Enable Ruff PLW (Pylint Warning) #13749https://github.com/python/typeshed/pull/13749
Enable Ruff TRY (tryceratops) #13359https://github.com/python/typeshed/pull/13359
Enable Ruff groups we already pass #13751https://github.com/python/typeshed/pull/13751
Enable Ruff PERF #13312https://github.com/python/typeshed/pull/13312
Enable Ruff FURB #13310https://github.com/python/typeshed/pull/13310
Replace Flake8 checks with Ruff (except for flake8-pyi) #11496https://github.com/python/typeshed/pull/11496
Avasamhttps://github.com/Avasam
project: infrastructuretypeshed build, test, or distribution relatedhttps://github.com/python/typeshed/issues?q=state%3Aopen%20label%3A%22project%3A%20infrastructure%22
on Dec 24, 2024https://github.com/python/typeshed/issues/13295#event-15758650442
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
on Dec 24, 2024https://github.com/python/typeshed/issues/13295#issuecomment-2561461585
Avasam#39https://github.com/Avasam/typeshed/pull/39
https://github.com/Avasam
Avasamhttps://github.com/Avasam
on Apr 20, 2025https://github.com/python/typeshed/issues/13295#issuecomment-2816954280
Avasamhttps://github.com/Avasam
completedhttps://github.com/python/typeshed/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Apr 20, 2025https://github.com/python/typeshed/issues/13295#event-17330150899
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/typeshed/issues/13295
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/typeshed/issues/13295
project: infrastructuretypeshed build, test, or distribution relatedhttps://github.com/python/typeshed/issues?q=state%3Aopen%20label%3A%22project%3A%20infrastructure%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.