René's URL Explorer Experiment


Title: `file_digest.file_digest` signature is overly strict · Issue #12414 · python/typeshed · GitHub

Open Graph Title: `file_digest.file_digest` signature is overly strict · Issue #12414 · python/typeshed

X Title: `file_digest.file_digest` signature is overly strict · Issue #12414 · python/typeshed

Description: Using hashlib.file_digest with a file object obtained via pathlib.Path.open failed to typecheck with a protocol compatibility error: src/create_bundles.py:223: error: Argument 1 to "file_digest" has incompatible type "FileIO"; expected "...

Open Graph Description: Using hashlib.file_digest with a file object obtained via pathlib.Path.open failed to typecheck with a protocol compatibility error: src/create_bundles.py:223: error: Argument 1 to "file_digest" ha...

X Description: Using hashlib.file_digest with a file object obtained via pathlib.Path.open failed to typecheck with a protocol compatibility error: src/create_bundles.py:223: error: Argument 1 to "file_diges...

Opengraph URL: https://github.com/python/typeshed/issues/12414

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`file_digest.file_digest` signature is overly strict","articleBody":"Using `hashlib.file_digest` with a file object obtained via `pathlib.Path.open` failed to typecheck with a protocol compatibility error:\r\n\r\n```\r\nsrc/create_bundles.py:223: error: Argument 1 to \"file_digest\" has incompatible type \"FileIO\"; expected \"_BytesIOLike | _FileDigestFileObj\"  [arg-type]\r\nsrc/create_bundles.py:223: note: Following member(s) of \"FileIO\" have conflicts:\r\nsrc/create_bundles.py:223: note:     Expected:\r\nsrc/create_bundles.py:223: note:         def readinto(self, bytearray, /) -> int\r\nsrc/create_bundles.py:223: note:     Got:\r\nsrc/create_bundles.py:223: note:         def readinto(self, Buffer, /) -> int | None\r\n```\r\n\r\nI'm reasonably sure this is a `typeshed` issue rather than a `mypy` issue.\r\n\r\nMy first thought was that this looks like an internal inconsistency in `typeshed`, as `_FileDigestFileObj` is declared specifically with `bytearray` rather than the more general `WriteableBuffer` (hence filing the issue here).\r\n\r\nHowever, my second thought was that this signature declaration is presumably as it is because `file_digest` will *specifically* pass a `bytearray` instance to `readinto`, and `bytearray` is compatible with `Buffer`, so `mypy` shouldn't be complaining about that. That means the conflict is presumably on the return type rather than on parameter types.\r\n\r\nThe declared type signature nominally indicates that `file_digest` can't cope with `readinto` returning `None`, and `mypy` is correctly flagging that as inconsistent with the way `typeshed` declares the file and socket IO types (allowing them to return `None` here).\r\n\r\nSearching the typeshed code suggests this particular inconsistency exists across several different IO consumer type declarations: https://github.com/search?q=repo%3Apython%2Ftypeshed%20readinto&type=code","author":{"url":"https://github.com/ncoghlan","@type":"Person","name":"ncoghlan"},"datePublished":"2024-07-23T08:31:15Z","url":"https://github.com/python/typeshed/issues/12414"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:fb773c24-aa12-df82-952e-6735e9f80f1a
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idA022:302FC:D7FF37:120D90C:6B0052FC
html-safe-nonce0fa000745ecc1e801827b37dcfa23a58f8f6d4b894a979744ff8d10ea5d83845
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMDIyOjMwMkZDOkQ3RkYzNzoxMjBEOTBDOjZCMDA1MkZDIiwidmlzaXRvcl9pZCI6Ijg1MTc3NTk0ODA4NjIxMDIyNjgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac423744f50a7a58360be53031c71a962cff1a46965caaba912954b0f80eb6c21a
hovercard-subject-tagissue:2424594252
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/typeshed/12414/issue_layout
twitter:imagehttps://opengraph.githubassets.com/f2bbb949840869b8c81c34591176c778cf234b2c96e5c9ec6743c39c55eef375/python/typeshed/issues/12414
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f2bbb949840869b8c81c34591176c778cf234b2c96e5c9ec6743c39c55eef375/python/typeshed/issues/12414
og:image:altUsing hashlib.file_digest with a file object obtained via pathlib.Path.open failed to typecheck with a protocol compatibility error: src/create_bundles.py:223: error: Argument 1 to "file_digest" ha...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamencoghlan
hostnamegithub.com
expected-hostnamegithub.com
Nonef420f4996e6b1ff1ccd6d7683f8134f4b5f0f8a50124c210dbfe7490e5644abb
turbo-cache-controlno-preview
go-importgithub.com/python/typeshed git https://github.com/python/typeshed.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id31696383
octolytics-dimension-repository_nwopython/typeshed
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id31696383
octolytics-dimension-repository_network_root_nwopython/typeshed
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26e00df917aba0f128135dc073ea0c5e33a70d40
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/typeshed/issues/12414#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fissues%2F12414
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fissues%2F12414
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Ftypeshed
Reloadhttps://github.com/python/typeshed/issues/12414
Reloadhttps://github.com/python/typeshed/issues/12414
Reloadhttps://github.com/python/typeshed/issues/12414
pythonhttps://github.com/python
typeshedhttps://github.com/python/typeshed
Codehttps://github.com/python/typeshed
Issues196 (196)https://github.com/python/typeshed/issues
Pull requests252 (252)https://github.com/python/typeshed/pulls
Actionshttps://github.com/python/typeshed/actions
Security and qualityhttps://github.com/python/typeshed/security
Insightshttps://github.com/python/typeshed/insights
https://github.com/python/typeshed
New issuehttps://github.com/login?return_to=https://github.com/python/typeshed/issues/12414
New issuehttps://github.com/login?return_to=https://github.com/python/typeshed/issues/12414
#12686https://github.com/python/typeshed/pull/12686
file_digest.file_digest signature is overly stricthttps://github.com/python/typeshed/issues/12414#top
#12686https://github.com/python/typeshed/pull/12686
stubs: false positiveType checkers report false errorshttps://github.com/python/typeshed/issues?q=state%3Aopen%20label%3A%22stubs%3A%20false%20positive%22
topic: ioI/O related issueshttps://github.com/python/typeshed/issues?q=state%3Aopen%20label%3A%22topic%3A%20io%22
https://github.com/ncoghlan
ncoghlanhttps://github.com/ncoghlan
on Jul 23, 2024https://github.com/python/typeshed/issues/12414#issue-2424594252
https://github.com/search?q=repo%3Apython%2Ftypeshed%20readinto&type=codehttps://github.com/search?q=repo%3Apython%2Ftypeshed%20readinto&type=code
srittauhttps://github.com/srittau
stubs: false positiveType checkers report false errorshttps://github.com/python/typeshed/issues?q=state%3Aopen%20label%3A%22stubs%3A%20false%20positive%22
topic: ioI/O related issueshttps://github.com/python/typeshed/issues?q=state%3Aopen%20label%3A%22topic%3A%20io%22
on Jul 23, 2024https://github.com/python/typeshed/issues/12414#event-13612864404
https://github.com/srittau
srittauhttps://github.com/srittau
on Jul 23, 2024https://github.com/python/typeshed/issues/12414#issuecomment-2244734872
https://github.com/python/cpython/blob/2a5d1eb7073179a13159bce937afdbe240432e7d/Lib/hashlib.py#L232-L236https://github.com/python/cpython/blob/2a5d1eb7073179a13159bce937afdbe240432e7d/Lib/hashlib.py#L232-L236
https://github.com/python/cpython/blob/2a5d1eb7073179a13159bce937afdbe240432e7d/Modules/_io/fileio.c#L657-L684https://github.com/python/cpython/blob/2a5d1eb7073179a13159bce937afdbe240432e7d/Modules/_io/fileio.c#L657-L684
srittauhttps://github.com/srittau
on Jul 23, 2024https://github.com/python/typeshed/issues/12414#event-13615341332
Add `FileIO.readinto()`https://github.com/srittau/typeshed/commit/79d2b16bc593303e5aefd9590d98c510b76a0cf6
https://docs.github.com/articles/closing-issues-via-commit-messages
79d2b16https://github.com/srittau/typeshed/commit/79d2b16bc593303e5aefd9590d98c510b76a0cf6
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
on Jul 23, 2024https://github.com/python/typeshed/issues/12414#issuecomment-2245211275
https://github.com/python/cpython/blob/2a5d1eb7073179a13159bce937afdbe240432e7d/Modules/_io/fileio.c#L678https://github.com/python/cpython/blob/2a5d1eb7073179a13159bce937afdbe240432e7d/Modules/_io/fileio.c#L678
https://github.com/srittau
srittauhttps://github.com/srittau
on Jul 23, 2024https://github.com/python/typeshed/issues/12414#issuecomment-2245382901
https://github.com/python/cpython/blob/2c1b1e7a07eba0138b9858c6f2bea3cae9af0808/Python/fileutils.c#L1887https://github.com/python/cpython/blob/2c1b1e7a07eba0138b9858c6f2bea3cae9af0808/Python/fileutils.c#L1887
https://github.com/srittau
srittauhttps://github.com/srittau
on Jul 23, 2024https://github.com/python/typeshed/issues/12414#issuecomment-2245399031
explicitly documentedhttps://docs.python.org/3/library/hashlib.html#hashlib.file_digest
https://github.com/python/cpython/blob/2a5d1eb7073179a13159bce937afdbe240432e7d/Lib/socket.py#L713https://github.com/python/cpython/blob/2a5d1eb7073179a13159bce937afdbe240432e7d/Lib/socket.py#L713
JelleZijlstrahttps://github.com/JelleZijlstra
completedhttps://github.com/python/typeshed/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#12686https://github.com/python/typeshed/pull/12686
on Oct 2, 2024https://github.com/python/typeshed/issues/12414#event-14489453710
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/typeshed/issues/12414
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/typeshed/issues/12414
stubs: false positiveType checkers report false errorshttps://github.com/python/typeshed/issues?q=state%3Aopen%20label%3A%22stubs%3A%20false%20positive%22
topic: ioI/O related issueshttps://github.com/python/typeshed/issues?q=state%3Aopen%20label%3A%22topic%3A%20io%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.