René's URL Explorer Experiment


Title: incorrect annotations for `builtins.reversed` · Issue #11645 · python/typeshed · GitHub

Open Graph Title: incorrect annotations for `builtins.reversed` · Issue #11645 · python/typeshed

X Title: incorrect annotations for `builtins.reversed` · Issue #11645 · python/typeshed

Description: The builtins.reversed.__new__ signature is currently annotated like (Reversible[T] | SupportsLenAndGetItem[T]) -> Iterator[T]: typeshed/stdlib/builtins.pyi Lines 1639 to 1646 in 3d26992 class reversed(Iterator[_T]): @overload def __new__...

Open Graph Description: The builtins.reversed.__new__ signature is currently annotated like (Reversible[T] | SupportsLenAndGetItem[T]) -> Iterator[T]: typeshed/stdlib/builtins.pyi Lines 1639 to 1646 in 3d26992 class rever...

X Description: The builtins.reversed.__new__ signature is currently annotated like (Reversible[T] | SupportsLenAndGetItem[T]) -> Iterator[T]: typeshed/stdlib/builtins.pyi Lines 1639 to 1646 in 3d26992 class re...

Opengraph URL: https://github.com/python/typeshed/issues/11645

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"incorrect annotations for `builtins.reversed`","articleBody":"The `builtins.reversed.__new__` signature is currently annotated like `(Reversible[T] | SupportsLenAndGetItem[T]) -> Iterator[T]`:\r\nhttps://github.com/python/typeshed/blob/3d26992d1562a5175fb8fd91ca63817e55feee56/stdlib/builtins.pyi#L1639-L1646\r\n\r\nIt has two problems:\r\n\r\n## argument of type `SupportsLenAndGetItem[T]` \r\n\r\nThis should return a `reversed[T]` instance (i.e. `Self`), instead of \"just\" an `Iterable[T]`, which is unnecessarily loose.\r\n\r\n## argument with type that implement `__reversed__`\r\n\r\nThis is only handled if the argument's `__reversed__` returns an `Iterator[T]`, i.e. arguments that are `Reversible[T]`. But in reality, `reversed(x)` is equivalent to `x.__reversed__()` (if `__reversed__` exists). To illustrate:\r\n\r\n```pycon\r\n>>> class Revver[X]:\r\n...     x: X\r\n...     def __init__(self, x: X):\r\n...         self.x = x\r\n...     def __reversed__(self) -> X:\r\n...         return self.x\r\n... \r\n>>> reversed(Revver(42))\r\n42\r\n```\r\n\r\nHowever, this case isn't handled because `Revver[X]` cannot be expressed as a `Reversible[?]`.\r\n\r\n---\r\n\r\nSo instead, it should look something like this:\r\n\r\n```python\r\nclass SupportsReversed[T]:\r\n    def __reversed__(self) -> T: ...\r\n\r\nclass reversed[T](Iterator[T]):\r\n    @overload\r\n    def __new__[R](cls, sequence: SupportsReversed[R], /) -> R: ...\r\n    @overload\r\n    def __new__(cls, sequence: SupportsLenAndGetItem[T], /) -> Self: ...\r\n    def __length_hint__(self) -> int: ...\r\n    # btw, this is why protocols shouldn't be mixed with abstract classes:\r\n    def __iter__(self) -> Self: ...\r\n    def __next__(self) -> T: ...\r\n```\r\n\r\n---\r\n\r\nLet me know if I should make this into PR :)","author":{"url":"https://github.com/jorenham","@type":"Person","name":"jorenham"},"datePublished":"2024-03-21T16:30:51Z","url":"https://github.com/python/typeshed/issues/11645"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:8b6d5392-c4b4-9fd3-e448-e40eda14075a
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id92BC:33DDEF:1EE8699:2A42017:6B0021F0
html-safe-nonce1371989afe4d59798354462628b2ad0eb804bca632c768c9a93fff5ab270fc84
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MkJDOjMzRERFRjoxRUU4Njk5OjJBNDIwMTc6NkIwMDIxRjAiLCJ2aXNpdG9yX2lkIjoiMjMzODY2OTY1MjIxMDYyMjk2MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb3c61dcdbc4eb1f6ed18426234e9152ece6aef4f0d661a9282a5438fb36a49cb
hovercard-subject-tagissue:2200643493
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/typeshed/11645/issue_layout
twitter:imagehttps://opengraph.githubassets.com/fe631ae87c2db961d03440c0c7f4fe2b20a16152f043eab32d520ff5aec30cf9/python/typeshed/issues/11645
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/fe631ae87c2db961d03440c0c7f4fe2b20a16152f043eab32d520ff5aec30cf9/python/typeshed/issues/11645
og:image:altThe builtins.reversed.__new__ signature is currently annotated like (Reversible[T] | SupportsLenAndGetItem[T]) -> Iterator[T]: typeshed/stdlib/builtins.pyi Lines 1639 to 1646 in 3d26992 class rever...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejorenham
hostnamegithub.com
expected-hostnamegithub.com
None4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0
turbo-cache-controlno-preview
go-importgithub.com/python/typeshed git https://github.com/python/typeshed.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id31696383
octolytics-dimension-repository_nwopython/typeshed
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id31696383
octolytics-dimension-repository_network_root_nwopython/typeshed
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release44c658b24abf00491fb7ae5f56d42c9f38cbeab2
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/typeshed/issues/11645#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fissues%2F11645
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fissues%2F11645
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Ftypeshed
Reloadhttps://github.com/python/typeshed/issues/11645
Reloadhttps://github.com/python/typeshed/issues/11645
Reloadhttps://github.com/python/typeshed/issues/11645
pythonhttps://github.com/python
typeshedhttps://github.com/python/typeshed
Codehttps://github.com/python/typeshed
Issues196 (196)https://github.com/python/typeshed/issues
Pull requests251 (251)https://github.com/python/typeshed/pulls
Actionshttps://github.com/python/typeshed/actions
Security and qualityhttps://github.com/python/typeshed/security
Insightshttps://github.com/python/typeshed/insights
https://github.com/python/typeshed
New issuehttps://github.com/login?return_to=https://github.com/python/typeshed/issues/11645
New issuehttps://github.com/login?return_to=https://github.com/python/typeshed/issues/11645
#11646https://github.com/python/typeshed/pull/11646
incorrect annotations for builtins.reversedhttps://github.com/python/typeshed/issues/11645#top
#11646https://github.com/python/typeshed/pull/11646
https://github.com/jorenham
jorenhamhttps://github.com/jorenham
on Mar 21, 2024https://github.com/python/typeshed/issues/11645#issue-2200643493
typeshed/stdlib/builtins.pyihttps://github.com/python/typeshed/blob/3d26992d1562a5175fb8fd91ca63817e55feee56/stdlib/builtins.pyi#L1639-L1646
3d26992https://github.com/python/typeshed/commit/3d26992d1562a5175fb8fd91ca63817e55feee56
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
on Mar 21, 2024https://github.com/python/typeshed/issues/11645#issuecomment-2013209592
#10655https://github.com/python/typeshed/pull/10655
https://github.com/Akuli
Akulihttps://github.com/Akuli
on Mar 25, 2024https://github.com/python/typeshed/issues/11645#issuecomment-2018776928
https://github.com/jorenham
jorenhamhttps://github.com/jorenham
on Mar 25, 2024https://github.com/python/typeshed/issues/11645#issuecomment-2019012441
@Akulihttps://github.com/Akuli
https://github.com/jorenham
jorenhamhttps://github.com/jorenham
on Mar 25, 2024https://github.com/python/typeshed/issues/11645#issuecomment-2019037800
@Akulihttps://github.com/Akuli
optypehttps://github.com/jorenham/optype
https://github.com/jorenham
jorenhamhttps://github.com/jorenham
on Mar 25, 2024https://github.com/python/typeshed/issues/11645#issuecomment-2019061147
@Akulihttps://github.com/Akuli
https://github.com/Akuli
Akulihttps://github.com/Akuli
on Mar 26, 2024https://github.com/python/typeshed/issues/11645#issuecomment-2019133426
srittauhttps://github.com/srittau
completedhttps://github.com/python/typeshed/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#11646https://github.com/python/typeshed/pull/11646
on Jul 23, 2026https://github.com/python/typeshed/issues/11645#event-28372947924
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/typeshed/issues/11645
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/typeshed/issues/11645
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.