René's URL Explorer Experiment


Title: Incorrect definition of collection builtins causes type checking error related to false MRO · Issue #11543 · python/typeshed · GitHub

Open Graph Title: Incorrect definition of collection builtins causes type checking error related to false MRO · Issue #11543 · python/typeshed

X Title: Incorrect definition of collection builtins causes type checking error related to false MRO · Issue #11543 · python/typeshed

Description: The way some collection builtins (e.g. list, dict, ...) are defined in typeshed causes false positive with type checking, due to the incorrect MRO exposed by typeshed. For example, typeshed/stdlib/builtins.pyi Line 971 in af84d2f class l...

Open Graph Description: The way some collection builtins (e.g. list, dict, ...) are defined in typeshed causes false positive with type checking, due to the incorrect MRO exposed by typeshed. For example, typeshed/stdlib/...

X Description: The way some collection builtins (e.g. list, dict, ...) are defined in typeshed causes false positive with type checking, due to the incorrect MRO exposed by typeshed. For example, typeshed/stdlib/...

Opengraph URL: https://github.com/python/typeshed/issues/11543

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Incorrect definition of collection builtins causes type checking error related to false MRO","articleBody":"The way some collection builtins (e.g. `list`, `dict`, ...) are defined in typeshed causes false positive with type checking, due to the incorrect MRO exposed by typeshed.\r\n\r\nFor example, https://github.com/python/typeshed/blob/af84d2fbfe8640c9f5049bfd0e74ea3270c8ea2c/stdlib/builtins.pyi#L971 defines list as \"inheriting from `MutableSequence`\", however that is not true and causes the following false negative error:\r\n\r\n```python\r\nfrom typing import Optional\r\nfrom collections.abc import MutableSequence\r\n\r\n\r\nclass Item:\r\n    def __init__(self, comment: Optional[str] = None):\r\n        self._comment = comment\r\n\r\n\r\nclass Array(Item, MutableSequence, list):\r\n    def __init__(self, values: list, comment: Optional[str] = None):\r\n        Item.__init__(self, comment)\r\n        list.__init__(self, values)\r\n\r\n\r\nif __name__ == '__main__':\r\n    a = Array([0, 1, 2])\r\n    print([p.__name__ for p in a.__class__.__mro__])\r\n```\r\n\r\n```console\r\nmain.py:10: error: Cannot determine consistent method resolution order (MRO) for \"Array\"  [misc]\r\nmain.py:12: error: Argument 1 to \"__init__\" of \"Item\" has incompatible type \"Array\"; expected \"Item\"  [arg-type]\r\nmain.py:13: error: No overload variant of \"__init__\" of \"list\" matches argument types \"Array\", \"list[Any]\"  [call-overload]\r\nmain.py:13: note: Possible overload variants:\r\nmain.py:13: note:     def [_T] __init__(self: list[_T]) -> None\r\nmain.py:13: note:     def [_T] __init__(self: list[_T], Iterable[_T], /) -> None\r\nFound 3 errors in 1 file (checked 1 source file)\r\n```\r\n\r\nhttps://mypy-play.net/?mypy=latest&python=3.12&gist=dc0042ce469e49dc22de0c91384d4588\r\n\r\nNote that this does not correspond to the real implementation. When I run the script above, no runtime error is found. Instead, this is the output:\r\n\r\n```console\r\n$ python3.12 main.py\r\n['Array', 'Item', 'MutableSequence', 'Sequence', 'Reversible', 'Collection', 'Sized', 'Iterable', 'Container', 'list', 'object']\r\n```\r\n\r\nSo my guess is that `typeshed` should not tell `mypy` that \"`list` and co\" are subclasses of \"`MutableSequence` and co\".\r\n\r\n---\r\n\r\nNote:\r\n\r\nwhile this particular choice of inheritance is debatable, it is fundamental for the way some libraries work, e.g. `tomlkit` work. It uses `MutableSequence` as a mixin, so that I gets `MutableSequence` methods for free, but it also want the custom objects to be considered lists themselves, so the users can use the API transparently as if they were dealing with built-in objects (this is an important aspect of the design).\r\n\r\n---\r\n\r\nRelated: https://github.com/python/mypy/issues/11427","author":{"url":"https://github.com/abravalheri","@type":"Person","name":"abravalheri"},"datePublished":"2024-03-08T15:00:57Z","url":"https://github.com/python/typeshed/issues/11543"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:dca1a4f9-210a-257c-4e0a-8410331e5200
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idB58A:13A091:2E742F:3DBCB2:6B00C252
html-safe-noncecc18bcfeed5d48bac57e764f9703afcd48e2509f0a4a0b41a360534d85d54f19
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNThBOjEzQTA5MToyRTc0MkY6M0RCQ0IyOjZCMDBDMjUyIiwidmlzaXRvcl9pZCI6Ijk3NDY2MjAyODQwMjY3MjIxMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac2109b5e6578476c6f8917f1095b0abe832291c71c2d67feb9c5850dcd44a58e5
hovercard-subject-tagissue:2176211114
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/typeshed/11543/issue_layout
twitter:imagehttps://opengraph.githubassets.com/ca270fc9a183e82bd02416a18af9fd50a420237c7041385f0be980f1390e0e0d/python/typeshed/issues/11543
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ca270fc9a183e82bd02416a18af9fd50a420237c7041385f0be980f1390e0e0d/python/typeshed/issues/11543
og:image:altThe way some collection builtins (e.g. list, dict, ...) are defined in typeshed causes false positive with type checking, due to the incorrect MRO exposed by typeshed. For example, typeshed/stdlib/...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameabravalheri
hostnamegithub.com
expected-hostnamegithub.com
None93edd3bebc4afb7ce711ee74cb5d2a95927850b082a4d43e212222389cb1c415
turbo-cache-controlno-preview
go-importgithub.com/python/typeshed git https://github.com/python/typeshed.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id31696383
octolytics-dimension-repository_nwopython/typeshed
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id31696383
octolytics-dimension-repository_network_root_nwopython/typeshed
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release1fee81a280ea86312b69448e261b418189bfd5b5
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/typeshed/issues/11543#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fissues%2F11543
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fissues%2F11543
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Ftypeshed
Reloadhttps://github.com/python/typeshed/issues/11543
Reloadhttps://github.com/python/typeshed/issues/11543
Reloadhttps://github.com/python/typeshed/issues/11543
pythonhttps://github.com/python
typeshedhttps://github.com/python/typeshed
Codehttps://github.com/python/typeshed
Issues196 (196)https://github.com/python/typeshed/issues
Pull requests257 (257)https://github.com/python/typeshed/pulls
Actionshttps://github.com/python/typeshed/actions
Security and qualityhttps://github.com/python/typeshed/security
Insightshttps://github.com/python/typeshed/insights
https://github.com/python/typeshed
New issuehttps://github.com/login?return_to=https://github.com/python/typeshed/issues/11543
New issuehttps://github.com/login?return_to=https://github.com/python/typeshed/issues/11543
Incorrect definition of collection builtins causes type checking error related to false MROhttps://github.com/python/typeshed/issues/11543#top
https://github.com/abravalheri
abravalherihttps://github.com/abravalheri
on Mar 8, 2024https://github.com/python/typeshed/issues/11543#issue-2176211114
typeshed/stdlib/builtins.pyihttps://github.com/python/typeshed/blob/af84d2fbfe8640c9f5049bfd0e74ea3270c8ea2c/stdlib/builtins.pyi#L971
af84d2fhttps://github.com/python/typeshed/commit/af84d2fbfe8640c9f5049bfd0e74ea3270c8ea2c
https://mypy-play.net/?mypy=latest&python=3.12&gist=dc0042ce469e49dc22de0c91384d4588https://mypy-play.net/?mypy=latest&python=3.12&gist=dc0042ce469e49dc22de0c91384d4588
python/mypy#11427https://github.com/python/mypy/issues/11427
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
on Mar 8, 2024https://github.com/python/typeshed/issues/11543#issuecomment-1985861656
#1595https://github.com/python/typeshed/issues/1595
AlexWaygoodhttps://github.com/AlexWaygood
Deriving builtins from ABCs implies incorrect and problematic metaclass structure #1595https://github.com/python/typeshed/issues/1595
on Mar 8, 2024https://github.com/python/typeshed/issues/11543#event-12056893957
AlexWaygoodhttps://github.com/AlexWaygood
not plannedhttps://github.com/python/typeshed/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Anot-planned
on Mar 8, 2024https://github.com/python/typeshed/issues/11543#event-12056893969
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/typeshed/issues/11543
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/typeshed/issues/11543
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.