René's URL Explorer Experiment


Title: APIs related to `importlib.abc.PathEntryFinder` should use protocol instead · Issue #11541 · python/typeshed · GitHub

Open Graph Title: APIs related to `importlib.abc.PathEntryFinder` should use protocol instead · Issue #11541 · python/typeshed

X Title: APIs related to `importlib.abc.PathEntryFinder` should use protocol instead · Issue #11541 · python/typeshed

Description: Although importlib.abc.PathEntryFinder is defined as an abstract class in the standard library, path entry finders are intentionally loosely defined in the Python docs (and originated PEPs), so that the only thing that needs to be implem...

Open Graph Description: Although importlib.abc.PathEntryFinder is defined as an abstract class in the standard library, path entry finders are intentionally loosely defined in the Python docs (and originated PEPs), so tha...

X Description: Although importlib.abc.PathEntryFinder is defined as an abstract class in the standard library, path entry finders are intentionally loosely defined in the Python docs (and originated PEPs), so tha...

Opengraph URL: https://github.com/python/typeshed/issues/11541

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"APIs related to `importlib.abc.PathEntryFinder` should use protocol instead","articleBody":"Although `importlib.abc.PathEntryFinder` is defined as an abstract class in the standard library, `path entry finders` are intentionally loosely defined in the [Python docs](https://docs.python.org/3/reference/import.html#path-entry-finder-protocol) (and originated PEPs), so that the only thing that needs to be implemented is one method (`find_spec`). This matches the functioning of a protocol.\r\n\r\nThe reason why the abstract class is defined is probably informational (for documentation purposes) + extra code re-use internally in the stdlib. This situation is similar to `importlib.abc.MetaPathFinder`, and other `importlib.abc` classes (like loaders).\r\n\r\nThis affects https://github.com/python/typeshed/blob/af84d2fbfe8640c9f5049bfd0e74ea3270c8ea2c/stdlib/sys/__init__.pyi#L54 and probably other places.\r\n\r\n\r\nFor example, I would expect the following snippet to type check with no problems:\r\n```python\r\nimport sys\r\nfrom types import ModuleType\r\nfrom importlib.machinery import ModuleSpec\r\nfrom typing_extensions import Self\r\n\r\n\r\nclass Finder:\r\n    @classmethod\r\n    def path_hook(cls, path_entry: str) -> type[Self]:\r\n        return cls  # simplified mock for demonstration purposes only\r\n\r\n    @classmethod\r\n    def find_spec(cls, fullname: str, target: ModuleType | None = None)  -> ModuleSpec | None:\r\n        return None  # simplified mock for demonstration purposes only\r\n    \r\n        \r\nsys.path_hooks.append(Finder.path_hook)\r\n```\r\n\r\n\r\nBut instead I am having an error:\r\n```console\r\nmain.py:9: error: Missing return statement  [empty-body]\r\nmain.py:17: error: Argument 1 to \"append\" of \"list\" has incompatible type \"Callable[[str], type[Finder]]\"; expected \"Callable[[str], PathEntryFinder]\"  [arg-type]\r\nFound 2 errors in 1 file (checked 1 source file)\r\n```\r\n\r\nhttps://mypy-play.net/?mypy=latest&python=3.12&gist=dfd3a0dcf277afc43cf59c8eb07afc5b\r\n","author":{"url":"https://github.com/abravalheri","@type":"Person","name":"abravalheri"},"datePublished":"2024-03-08T14:43:02Z","url":"https://github.com/python/typeshed/issues/11541"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:1674879f-08ff-3c62-c1df-1f53e5e6650a
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id9948:363D8E:29B902:36E69E:6B00C0F5
html-safe-nonceb6a3d116358f86fdc782efa3819b6e686fe0cc64f94220d9fdf58b1640c8efa2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OTQ4OjM2M0Q4RToyOUI5MDI6MzZFNjlFOjZCMDBDMEY1IiwidmlzaXRvcl9pZCI6IjUwNzU3ODQxNDQ1MjU1MDg4NTMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac6c40bcda282ff8eb2a5613735b29fbd95eba7a43f697fe6aad5186d350a1d2a9
hovercard-subject-tagissue:2176174767
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/typeshed/11541/issue_layout
twitter:imagehttps://opengraph.githubassets.com/f19ac8ee8bd2d159a5bd4aae2d12f4709c72168f0053a5f522a7a95685459c94/python/typeshed/issues/11541
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f19ac8ee8bd2d159a5bd4aae2d12f4709c72168f0053a5f522a7a95685459c94/python/typeshed/issues/11541
og:image:altAlthough importlib.abc.PathEntryFinder is defined as an abstract class in the standard library, path entry finders are intentionally loosely defined in the Python docs (and originated PEPs), so tha...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameabravalheri
hostnamegithub.com
expected-hostnamegithub.com
None93edd3bebc4afb7ce711ee74cb5d2a95927850b082a4d43e212222389cb1c415
turbo-cache-controlno-preview
go-importgithub.com/python/typeshed git https://github.com/python/typeshed.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id31696383
octolytics-dimension-repository_nwopython/typeshed
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id31696383
octolytics-dimension-repository_network_root_nwopython/typeshed
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release1fee81a280ea86312b69448e261b418189bfd5b5
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/typeshed/issues/11541#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fissues%2F11541
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fissues%2F11541
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Ftypeshed
Reloadhttps://github.com/python/typeshed/issues/11541
Reloadhttps://github.com/python/typeshed/issues/11541
Reloadhttps://github.com/python/typeshed/issues/11541
pythonhttps://github.com/python
typeshedhttps://github.com/python/typeshed
Codehttps://github.com/python/typeshed
Issues196 (196)https://github.com/python/typeshed/issues
Pull requests257 (257)https://github.com/python/typeshed/pulls
Actionshttps://github.com/python/typeshed/actions
Security and qualityhttps://github.com/python/typeshed/security
Insightshttps://github.com/python/typeshed/insights
https://github.com/python/typeshed
New issuehttps://github.com/login?return_to=https://github.com/python/typeshed/issues/11541
New issuehttps://github.com/login?return_to=https://github.com/python/typeshed/issues/11541
#11890https://github.com/python/typeshed/pull/11890
APIs related to importlib.abc.PathEntryFinder should use protocol insteadhttps://github.com/python/typeshed/issues/11541#top
#11890https://github.com/python/typeshed/pull/11890
stubs: improvementImprove/refactor existing annotations, other stubs issueshttps://github.com/python/typeshed/issues?q=state%3Aopen%20label%3A%22stubs%3A%20improvement%22
https://github.com/abravalheri
abravalherihttps://github.com/abravalheri
on Mar 8, 2024https://github.com/python/typeshed/issues/11541#issue-2176174767
Python docshttps://docs.python.org/3/reference/import.html#path-entry-finder-protocol
typeshed/stdlib/sys/__init__.pyihttps://github.com/python/typeshed/blob/af84d2fbfe8640c9f5049bfd0e74ea3270c8ea2c/stdlib/sys/__init__.pyi#L54
af84d2fhttps://github.com/python/typeshed/commit/af84d2fbfe8640c9f5049bfd0e74ea3270c8ea2c
https://mypy-play.net/?mypy=latest&python=3.12&gist=dfd3a0dcf277afc43cf59c8eb07afc5bhttps://mypy-play.net/?mypy=latest&python=3.12&gist=dfd3a0dcf277afc43cf59c8eb07afc5b
srittauhttps://github.com/srittau
stubs: improvementImprove/refactor existing annotations, other stubs issueshttps://github.com/python/typeshed/issues?q=state%3Aopen%20label%3A%22stubs%3A%20improvement%22
on Mar 8, 2024https://github.com/python/typeshed/issues/11541#event-12056674883
srittauhttps://github.com/srittau
completedhttps://github.com/python/typeshed/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#11890https://github.com/python/typeshed/pull/11890
on May 12, 2024https://github.com/python/typeshed/issues/11541#event-12778268716
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/typeshed/issues/11541
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/typeshed/issues/11541
stubs: improvementImprove/refactor existing annotations, other stubs issueshttps://github.com/python/typeshed/issues?q=state%3Aopen%20label%3A%22stubs%3A%20improvement%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.