René's URL Explorer Experiment


Title: classmethod typing is weird · Issue #10396 · python/typeshed · GitHub

Open Graph Title: classmethod typing is weird · Issue #10396 · python/typeshed

X Title: classmethod typing is weird · Issue #10396 · python/typeshed

Description: It feels like the classmethod typing is slightly wrong. Typeshed defines it as: class classmethod(Generic[_T, _P, _R_co]): @property def __isabstractmethod__(self) -> bool: ... def __init__(self, __f: Callable[Concatenate[_T, _P], _R_co]...

Open Graph Description: It feels like the classmethod typing is slightly wrong. Typeshed defines it as: class classmethod(Generic[_T, _P, _R_co]): @property def __isabstractmethod__(self) -> bool: ... def __init__(self, _...

X Description: It feels like the classmethod typing is slightly wrong. Typeshed defines it as: class classmethod(Generic[_T, _P, _R_co]): @property def __isabstractmethod__(self) -> bool: ... def __init__(self...

Opengraph URL: https://github.com/python/typeshed/issues/10396

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"classmethod typing is weird","articleBody":"It feels like the classmethod typing is slightly wrong.\r\n\r\nTypeshed defines it as:\r\n\r\n```py\r\nclass classmethod(Generic[_T, _P, _R_co]):                                         \r\n    @property                                                                   \r\n    def __isabstractmethod__(self) -> bool: ...                                 \r\n    def __init__(self, __f: Callable[Concatenate[_T, _P], _R_co]) -> None: ...                    \r\n    def __get__(self, __instance: _T, __owner: type[_T] | None = None) -> Callable[_P, _R_co]: ...\r\n    ...\r\n```\r\n\r\nWith mypy the following program fails:\r\n\r\n```py\r\nfrom typing import *                                                               \r\n                                                                                               \r\n                                                                                   \r\ndef foo(cls: Type['G'], x: int) -> str: return \"\"                                  \r\ndef bar(cls: 'G' | None, x: int) -> str: return \"\"                                 \r\n                                                                                   \r\nclass G:                                                                           \r\n    x = classmethod(foo)                                                           \r\n    y = classmethod(bar)                                                           \r\n                                                                                   \r\nG.x(1)  # Fails                                                                           \r\nG.y(1)  # Works \r\n```\r\n\r\n```\r\nnew.py:11: error: Argument 1 to \"__get__\" of \"classmethod\" has incompatible type \"None\"; expected \"type[G]\"  [arg-type]\r\nnew.py:11: error: Argument 2 to \"__get__\" of \"classmethod\" has incompatible type \"type[G]\"; expected \"type[type[G]] | None\"  [arg-type]\r\n```\r\n\r\nThe proper solution would probably be to type `__init__` as:\r\n\r\n```py\r\ndef __init__(self, __f: Callable[Concatenate[Type[_T], _P], _R_co]) -> None: ...   \r\n```\r\n\r\nWould such a pull request be accepted? If I change this in Mypy it fails with `error: Need type annotation for \"x\"`, which I think is much better (and Mypy could probably still infer the type variable `_T` properly in the future). What do you think?","author":{"url":"https://github.com/davidhalter","@type":"Person","name":"davidhalter"},"datePublished":"2023-07-02T16:58:21Z","url":"https://github.com/python/typeshed/issues/10396"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:0556ea2b-3941-5aca-ff3e-8f77c46d61c9
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8ACA:5875E:20C9EEB:2C874F3:6B001EFB
html-safe-nonced49ad5fdf8f514efadf31c2380a6b7a522dc6452b7e19ea0352a40e8ab97529e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QUNBOjU4NzVFOjIwQzlFRUI6MkM4NzRGMzo2QjAwMUVGQiIsInZpc2l0b3JfaWQiOiIzMjQxNzM4NTk0MDgzMTUxNjExIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac314a700206198184bca7041ed6c9425c86714bfd77a872e04ab96df243d4f580
hovercard-subject-tagissue:1784725022
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/typeshed/10396/issue_layout
twitter:imagehttps://opengraph.githubassets.com/de79127a0fb18af4fdc2b1d106e77ada7585724a2c4de44d4777042578d97065/python/typeshed/issues/10396
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/de79127a0fb18af4fdc2b1d106e77ada7585724a2c4de44d4777042578d97065/python/typeshed/issues/10396
og:image:altIt feels like the classmethod typing is slightly wrong. Typeshed defines it as: class classmethod(Generic[_T, _P, _R_co]): @property def __isabstractmethod__(self) -> bool: ... def __init__(self, _...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedavidhalter
hostnamegithub.com
expected-hostnamegithub.com
None4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0
turbo-cache-controlno-preview
go-importgithub.com/python/typeshed git https://github.com/python/typeshed.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id31696383
octolytics-dimension-repository_nwopython/typeshed
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id31696383
octolytics-dimension-repository_network_root_nwopython/typeshed
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release44c658b24abf00491fb7ae5f56d42c9f38cbeab2
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/typeshed/issues/10396#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fissues%2F10396
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fissues%2F10396
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Ftypeshed
Reloadhttps://github.com/python/typeshed/issues/10396
Reloadhttps://github.com/python/typeshed/issues/10396
Reloadhttps://github.com/python/typeshed/issues/10396
pythonhttps://github.com/python
typeshedhttps://github.com/python/typeshed
Codehttps://github.com/python/typeshed
Issues196 (196)https://github.com/python/typeshed/issues
Pull requests251 (251)https://github.com/python/typeshed/pulls
Actionshttps://github.com/python/typeshed/actions
Security and qualityhttps://github.com/python/typeshed/security
Insightshttps://github.com/python/typeshed/insights
https://github.com/python/typeshed
New issuehttps://github.com/login?return_to=https://github.com/python/typeshed/issues/10396
New issuehttps://github.com/login?return_to=https://github.com/python/typeshed/issues/10396
#10421https://github.com/python/typeshed/pull/10421
classmethod typing is weirdhttps://github.com/python/typeshed/issues/10396#top
#10421https://github.com/python/typeshed/pull/10421
https://github.com/davidhalter
davidhalterhttps://github.com/davidhalter
on Jul 2, 2023https://github.com/python/typeshed/issues/10396#issue-1784725022
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
on Jul 2, 2023https://github.com/python/typeshed/issues/10396#issuecomment-1616748649
https://github.com/davidhalter
davidhalterhttps://github.com/davidhalter
on Jul 2, 2023https://github.com/python/typeshed/issues/10396#issuecomment-1616758803
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
on Jul 2, 2023https://github.com/python/typeshed/issues/10396#issuecomment-1616869328
https://github.com/davidhalter
davidhalterhttps://github.com/davidhalter
on Jul 3, 2023https://github.com/python/typeshed/issues/10396#issuecomment-1617735390
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
on Jul 3, 2023https://github.com/python/typeshed/issues/10396#issuecomment-1617743685
srittauhttps://github.com/srittau
completedhttps://github.com/python/typeshed/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#10421https://github.com/python/typeshed/pull/10421
on Jul 19, 2023https://github.com/python/typeshed/issues/10396#event-9861403475
https://github.com/davidhalter
davidhalterhttps://github.com/davidhalter
on Jul 20, 2023https://github.com/python/typeshed/issues/10396#issuecomment-1644065446
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/typeshed/issues/10396
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/typeshed/issues/10396
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.