Title: classmethod typing is weird · Issue #10396 · python/typeshed · GitHub
Open Graph Title: classmethod typing is weird · Issue #10396 · python/typeshed
X Title: classmethod typing is weird · Issue #10396 · python/typeshed
Description: It feels like the classmethod typing is slightly wrong. Typeshed defines it as: class classmethod(Generic[_T, _P, _R_co]): @property def __isabstractmethod__(self) -> bool: ... def __init__(self, __f: Callable[Concatenate[_T, _P], _R_co]...
Open Graph Description: It feels like the classmethod typing is slightly wrong. Typeshed defines it as: class classmethod(Generic[_T, _P, _R_co]): @property def __isabstractmethod__(self) -> bool: ... def __init__(self, _...
X Description: It feels like the classmethod typing is slightly wrong. Typeshed defines it as: class classmethod(Generic[_T, _P, _R_co]): @property def __isabstractmethod__(self) -> bool: ... def __init__(self...
Opengraph URL: https://github.com/python/typeshed/issues/10396
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"classmethod typing is weird","articleBody":"It feels like the classmethod typing is slightly wrong.\r\n\r\nTypeshed defines it as:\r\n\r\n```py\r\nclass classmethod(Generic[_T, _P, _R_co]): \r\n @property \r\n def __isabstractmethod__(self) -> bool: ... \r\n def __init__(self, __f: Callable[Concatenate[_T, _P], _R_co]) -> None: ... \r\n def __get__(self, __instance: _T, __owner: type[_T] | None = None) -> Callable[_P, _R_co]: ...\r\n ...\r\n```\r\n\r\nWith mypy the following program fails:\r\n\r\n```py\r\nfrom typing import * \r\n \r\n \r\ndef foo(cls: Type['G'], x: int) -> str: return \"\" \r\ndef bar(cls: 'G' | None, x: int) -> str: return \"\" \r\n \r\nclass G: \r\n x = classmethod(foo) \r\n y = classmethod(bar) \r\n \r\nG.x(1) # Fails \r\nG.y(1) # Works \r\n```\r\n\r\n```\r\nnew.py:11: error: Argument 1 to \"__get__\" of \"classmethod\" has incompatible type \"None\"; expected \"type[G]\" [arg-type]\r\nnew.py:11: error: Argument 2 to \"__get__\" of \"classmethod\" has incompatible type \"type[G]\"; expected \"type[type[G]] | None\" [arg-type]\r\n```\r\n\r\nThe proper solution would probably be to type `__init__` as:\r\n\r\n```py\r\ndef __init__(self, __f: Callable[Concatenate[Type[_T], _P], _R_co]) -> None: ... \r\n```\r\n\r\nWould such a pull request be accepted? If I change this in Mypy it fails with `error: Need type annotation for \"x\"`, which I think is much better (and Mypy could probably still infer the type variable `_T` properly in the future). What do you think?","author":{"url":"https://github.com/davidhalter","@type":"Person","name":"davidhalter"},"datePublished":"2023-07-02T16:58:21Z","url":"https://github.com/python/typeshed/issues/10396"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:0556ea2b-3941-5aca-ff3e-8f77c46d61c9 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 8ACA:5875E:20C9EEB:2C874F3:6B001EFB |
| html-safe-nonce | d49ad5fdf8f514efadf31c2380a6b7a522dc6452b7e19ea0352a40e8ab97529e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QUNBOjU4NzVFOjIwQzlFRUI6MkM4NzRGMzo2QjAwMUVGQiIsInZpc2l0b3JfaWQiOiIzMjQxNzM4NTk0MDgzMTUxNjExIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 314a700206198184bca7041ed6c9425c86714bfd77a872e04ab96df243d4f580 |
| hovercard-subject-tag | issue:1784725022 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/typeshed/10396/issue_layout |
| twitter:image | https://opengraph.githubassets.com/de79127a0fb18af4fdc2b1d106e77ada7585724a2c4de44d4777042578d97065/python/typeshed/issues/10396 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/de79127a0fb18af4fdc2b1d106e77ada7585724a2c4de44d4777042578d97065/python/typeshed/issues/10396 |
| og:image:alt | It feels like the classmethod typing is slightly wrong. Typeshed defines it as: class classmethod(Generic[_T, _P, _R_co]): @property def __isabstractmethod__(self) -> bool: ... def __init__(self, _... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | davidhalter |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/typeshed git https://github.com/python/typeshed.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 31696383 |
| octolytics-dimension-repository_nwo | python/typeshed |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 31696383 |
| octolytics-dimension-repository_network_root_nwo | python/typeshed |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 44c658b24abf00491fb7ae5f56d42c9f38cbeab2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width