René's URL Explorer Experiment


Title: Incorrect return types for xml.dom.minidom.Node.{toxml,toprettyxml} · Issue #10060 · python/typeshed · GitHub

Open Graph Title: Incorrect return types for xml.dom.minidom.Node.{toxml,toprettyxml} · Issue #10060 · python/typeshed

X Title: Incorrect return types for xml.dom.minidom.Node.{toxml,toprettyxml} · Issue #10060 · python/typeshed

Description: It looks like #9917 added the -> str return type to these functions, but the documentation indicates that may return bytes: Return a string or byte string containing the XML represented by the DOM node. With an explicit encoding 1 argume...

Open Graph Description: It looks like #9917 added the -> str return type to these functions, but the documentation indicates that may return bytes: Return a string or byte string containing the XML represented by the DOM ...

X Description: It looks like #9917 added the -> str return type to these functions, but the documentation indicates that may return bytes: Return a string or byte string containing the XML represented by the D...

Opengraph URL: https://github.com/python/typeshed/issues/10060

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Incorrect return types for xml.dom.minidom.Node.{toxml,toprettyxml}","articleBody":"It looks like #9917 added the `-> str` return type to these functions, but the [documentation](https://docs.python.org/3/library/xml.dom.minidom.html#xml.dom.minidom.Node.toxml) indicates that _may_ return `bytes`:\r\n\r\n>  Return a string or byte string containing the XML represented by the DOM node.\r\n>\r\n> With an explicit encoding 1 argument, the result is a byte string in the specified encoding. With no encoding argument, the result is a Unicode string, and the XML declaration in the resulting string does not specify an encoding. Encoding this string in an encoding other than UTF-8 is likely incorrect, since UTF-8 is the default encoding of XML.\r\n\r\nThis small example seems to confirm that it can return `bytes`:\r\n\r\n```py\r\nfrom xml.dom.minidom import Document\r\n\r\ndoc = Document()\r\ndoc.appendChild(doc.createElement(\"foo\"))\r\nprint(doc.toprettyxml(indent=\"\\t\", encoding=\"UTF-8\"))\r\n# output: b'\u003c?xml version=\"1.0\" encoding=\"UTF-8\"?>\\n\u003cfoo/>\\n'\r\n```\r\n","author":{"url":"https://github.com/wesleywright","@type":"Person","name":"wesleywright"},"datePublished":"2023-04-18T20:35:48Z","url":"https://github.com/python/typeshed/issues/10060"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:ef1ac4c1-c4d3-40a3-35a8-6d8a5b785135
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idED78:34D7A7:A9BB44:E45844:6B004C06
html-safe-nonce2631b16d401b3b31372f091233cb7af0870b49adac56e7c6340aeb6e014b8693
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRDc4OjM0RDdBNzpBOUJCNDQ6RTQ1ODQ0OjZCMDA0QzA2IiwidmlzaXRvcl9pZCI6IjQ0Njc3MDUzNTgwODkxMjM5MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacade283dd3ff0dda117edd986cc9f65c0777c3b49489a8b630dcc3785bd830f6d
hovercard-subject-tagissue:1673798297
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/typeshed/10060/issue_layout
twitter:imagehttps://opengraph.githubassets.com/d2187e1b2999b0973504704b4fccc7ff751d8bae92f6cef05d6897628e3f92a9/python/typeshed/issues/10060
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d2187e1b2999b0973504704b4fccc7ff751d8bae92f6cef05d6897628e3f92a9/python/typeshed/issues/10060
og:image:altIt looks like #9917 added the -> str return type to these functions, but the documentation indicates that may return bytes: Return a string or byte string containing the XML represented by the DOM ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamewesleywright
hostnamegithub.com
expected-hostnamegithub.com
Nonef9517bf360d46638a1e5e7daee7158842fe5ef43c9000afa0e127564a7c2f39b
turbo-cache-controlno-preview
go-importgithub.com/python/typeshed git https://github.com/python/typeshed.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id31696383
octolytics-dimension-repository_nwopython/typeshed
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id31696383
octolytics-dimension-repository_network_root_nwopython/typeshed
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb27c5dde30676028abd5c5fc53ce5c9b625f8281
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/typeshed/issues/10060#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fissues%2F10060
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftypeshed%2Fissues%2F10060
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Ftypeshed
Reloadhttps://github.com/python/typeshed/issues/10060
Reloadhttps://github.com/python/typeshed/issues/10060
Reloadhttps://github.com/python/typeshed/issues/10060
pythonhttps://github.com/python
typeshedhttps://github.com/python/typeshed
Codehttps://github.com/python/typeshed
Issues196 (196)https://github.com/python/typeshed/issues
Pull requests252 (252)https://github.com/python/typeshed/pulls
Actionshttps://github.com/python/typeshed/actions
Security and qualityhttps://github.com/python/typeshed/security
Insightshttps://github.com/python/typeshed/insights
https://github.com/python/typeshed
New issuehttps://github.com/login?return_to=https://github.com/python/typeshed/issues/10060
New issuehttps://github.com/login?return_to=https://github.com/python/typeshed/issues/10060
#10061https://github.com/python/typeshed/pull/10061
Incorrect return types for xml.dom.minidom.Node.{toxml,toprettyxml}https://github.com/python/typeshed/issues/10060#top
#10061https://github.com/python/typeshed/pull/10061
stubs: false positiveType checkers report false errorshttps://github.com/python/typeshed/issues?q=state%3Aopen%20label%3A%22stubs%3A%20false%20positive%22
https://github.com/wesleywright
wesleywrighthttps://github.com/wesleywright
on Apr 18, 2023https://github.com/python/typeshed/issues/10060#issue-1673798297
#9917https://github.com/python/typeshed/pull/9917
documentationhttps://docs.python.org/3/library/xml.dom.minidom.html#xml.dom.minidom.Node.toxml
srittauhttps://github.com/srittau
stubs: false positiveType checkers report false errorshttps://github.com/python/typeshed/issues?q=state%3Aopen%20label%3A%22stubs%3A%20false%20positive%22
on Apr 19, 2023https://github.com/python/typeshed/issues/10060#event-9042880910
AlexWaygoodhttps://github.com/AlexWaygood
completedhttps://github.com/python/typeshed/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#10061https://github.com/python/typeshed/pull/10061
on Apr 22, 2023https://github.com/python/typeshed/issues/10060#event-9073787618
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/typeshed/issues/10060
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/typeshed/issues/10060
stubs: false positiveType checkers report false errorshttps://github.com/python/typeshed/issues?q=state%3Aopen%20label%3A%22stubs%3A%20false%20positive%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.