René's URL Explorer Experiment


Title: Check NEW_TYPE_COMMENT calls for failure by msullivan · Pull Request #93 · python/typed_ast · GitHub

Open Graph Title: Check NEW_TYPE_COMMENT calls for failure by msullivan · Pull Request #93 · python/typed_ast

X Title: Check NEW_TYPE_COMMENT calls for failure by msullivan · Pull Request #93 · python/typed_ast

Description: Modified fork of CPython's ast module that parses `# type:` comments - Check NEW_TYPE_COMMENT calls for failure by msullivan · Pull Request #93 · python/typed_ast

Open Graph Description: This is mostly cribbed from python/cpython#11645, though it also adds a new error check to new_type_comment itself.

X Description: This is mostly cribbed from python/cpython#11645, though it also adds a new error check to new_type_comment itself.

Opengraph URL: https://github.com/python/typed_ast/pull/93

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:942edc7e-0924-3051-c2c6-f577c8074f0e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD076:39D6FF:1B3C3C3:2515B6D:6A536D91
html-safe-nonce94798e4af1408e56abe5e814123c1691b28c27ecce50624bbab8c8884506e9a0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMDc2OjM5RDZGRjoxQjNDM0MzOjI1MTVCNkQ6NkE1MzZEOTEiLCJ2aXNpdG9yX2lkIjoiMjU1MTQzMzc0NjQwMzUxOTg4OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacfd9221715eb07bf137aa98ac20dec1d88405005511dc27d933a1690cfe44bb22
hovercard-subject-tagpull_request:250599243
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/typed_ast/93/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/1c27455305246ce130be7b05a9bca026a1ac4d1cb92133f31b723638545a8992/python/typed_ast/pull/93
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1c27455305246ce130be7b05a9bca026a1ac4d1cb92133f31b723638545a8992/python/typed_ast/pull/93
og:image:altThis is mostly cribbed from python/cpython#11645, though it also adds a new error check to new_type_comment itself.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemsullivan
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/python/typed_ast git https://github.com/python/typed_ast.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id51875828
octolytics-dimension-repository_nwopython/typed_ast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id51875828
octolytics-dimension-repository_network_root_nwopython/typed_ast
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/typed_ast/pull/93#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftyped_ast%2Fpull%2F93
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftyped_ast%2Fpull%2F93
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Ftyped_ast
Reloadhttps://github.com/python/typed_ast/pull/93
Reloadhttps://github.com/python/typed_ast/pull/93
Reloadhttps://github.com/python/typed_ast/pull/93
Please reload this pagehttps://github.com/python/typed_ast/pull/93
python https://github.com/python
typed_asthttps://github.com/python/typed_ast
Please reload this pagehttps://github.com/python/typed_ast/pull/93
Notifications https://github.com/login?return_to=%2Fpython%2Ftyped_ast
Fork 53 https://github.com/login?return_to=%2Fpython%2Ftyped_ast
Star 233 https://github.com/login?return_to=%2Fpython%2Ftyped_ast
Code https://github.com/python/typed_ast
Issues 1 https://github.com/python/typed_ast/issues
Pull requests 0 https://github.com/python/typed_ast/pulls
Actions https://github.com/python/typed_ast/actions
Projects https://github.com/python/typed_ast/projects
Security and quality 0 https://github.com/python/typed_ast/security
Insights https://github.com/python/typed_ast/pulse
Code https://github.com/python/typed_ast
Issues https://github.com/python/typed_ast/issues
Pull requests https://github.com/python/typed_ast/pulls
Actions https://github.com/python/typed_ast/actions
Projects https://github.com/python/typed_ast/projects
Security and quality https://github.com/python/typed_ast/security
Insights https://github.com/python/typed_ast/pulse
gvanrossumhttps://github.com/gvanrossum
masterhttps://github.com/python/typed_ast/tree/master
check-errorshttps://github.com/python/typed_ast/tree/check-errors
Conversationhttps://github.com/python/typed_ast/pull/93
Commits1 (1)https://github.com/python/typed_ast/pull/93/commits
Checkshttps://github.com/python/typed_ast/pull/93/checks
Files changedhttps://github.com/python/typed_ast/pull/93/files
Check NEW_TYPE_COMMENT calls for failurehttps://github.com/python/typed_ast/pull/93#top
gvanrossumhttps://github.com/gvanrossum
masterhttps://github.com/python/typed_ast/tree/master
check-errorshttps://github.com/python/typed_ast/tree/check-errors
https://github.com/msullivan
msullivanhttps://github.com/msullivan
Feb 6, 2019https://github.com/python/typed_ast/pull/93#issue-407033715
python/cpython#11645https://github.com/python/cpython/pull/11645
Please reload this pagehttps://github.com/python/typed_ast/pull/93
https://github.com/msullivan
Check NEW_TYPE_COMMENT calls for failurehttps://github.com/python/typed_ast/pull/93/commits/76511c026d9d0c4df1cf43f4ab391e42668a9964
76511c0https://github.com/python/typed_ast/pull/93/commits/76511c026d9d0c4df1cf43f4ab391e42668a9964
python/cpython#11645https://github.com/python/cpython/pull/11645
https://github.com/msullivan
msullivanhttps://github.com/msullivan
gvanrossumhttps://github.com/gvanrossum
February 6, 2019 00:27https://github.com/python/typed_ast/pull/93#event-2120029056
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/typed_ast/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Feb 6, 2019https://github.com/python/typed_ast/pull/93#event-2120029086
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Feb 6, 2019 https://github.com/python/typed_ast/pull/93#pullrequestreview-200370505
View reviewed changes https://github.com/python/typed_ast/pull/93/files/76511c026d9d0c4df1cf43f4ab391e42668a9964
gvanrossumhttps://github.com/gvanrossum
https://github.com/python/typed_ast/pull/93#pullrequestreview-200370505
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/typed_ast/pull/93
gvanrossumhttps://github.com/gvanrossum
Feb 6, 2019 https://github.com/python/typed_ast/pull/93#ref-commit-5bea912
https://github.com/gvanrossum
bpo-35766https://bugs.python.org/issue?@action=redirect&bpo=35766
follow-up: Add an error check to new_type_comment()https://github.com/python/cpython/commit/5bea912c64a5db1cb301ad146d55bf3e5070c39d
5bea912https://github.com/python/cpython/commit/5bea912c64a5db1cb301ad146d55bf3e5070c39d
@msullivanhttps://github.com/msullivan
python/typed_ast#93https://github.com/python/typed_ast/pull/93
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Feb 6, 2019 https://github.com/python/typed_ast/pull/93#ref-pullrequest-407035633
bpo-35766 follow-up: Add an error check to new_type_comment() python/cpython#11766 https://github.com/python/cpython/pull/11766
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
f2acb2bhttps://github.com/python/typed_ast/commit/f2acb2b3de00322e3df2310edeabee01a0f1319d
Feb 6, 2019https://github.com/python/typed_ast/pull/93#event-2120042846
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
February 6, 2019 00:38https://github.com/python/typed_ast/pull/93#event-2120043444
gvanrossumhttps://github.com/gvanrossum
Feb 11, 2019 https://github.com/python/typed_ast/pull/93#ref-commit-4b250fc
https://github.com/gvanrossum
bpo-35766https://bugs.python.org/issue?@action=redirect&bpo=35766
follow-up: Add an error check to new_type_comment() (https://github.com/python/cpython/commit/4b250fc1da9c893803cf724a4974450b5e10bd8a
#11766https://github.com/python/cpython/pull/11766
)https://github.com/python/cpython/commit/4b250fc1da9c893803cf724a4974450b5e10bd8a
4b250fchttps://github.com/python/cpython/commit/4b250fc1da9c893803cf724a4974450b5e10bd8a
@msullivanhttps://github.com/msullivan
python/typed_ast#93https://github.com/python/typed_ast/pull/93
https://github.co/hiddenchars
https://github.com/python/typed_ast/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Ftyped_ast%2Fpull%2F93
https://github.com/gvanrossum
gvanrossum https://github.com/gvanrossum
https://github.com/python/typed_ast/pull/93/files/76511c026d9d0c4df1cf43f4ab391e42668a9964
CLA signed https://github.com/python/typed_ast/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Please reload this pagehttps://github.com/python/typed_ast/pull/93
https://github.com/msullivan
https://github.com/gvanrossum
https://github.com/the-knights-who-say-ni
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.