Title: Use consistent line-height for light & dark theme by tomasr8 · Pull Request #227 · python/python-docs-theme · GitHub
Open Graph Title: Use consistent line-height for light & dark theme by tomasr8 · Pull Request #227 · python/python-docs-theme
X Title: Use consistent line-height for light & dark theme by tomasr8 · Pull Request #227 · python/python-docs-theme
Description: While working on the copy button, I noticed the line height of the pre element differs for the light and dark theme. It is set to 120% for the light theme 125% for the dark theme, which is not a huge difference but it's better to be consistent. The reason for the discrepancy is the order in which the css is included in the . For the light theme, classic.css takes precedence: Whereas for the dark theme, it is pygments_dark.css which is the last stylesheet in the : This seems to be related to how sphinx inserts the css for pygments: https://github.com/sphinx-doc/sphinx/blob/a6d7ae16739bf92a032a7c4df0297db7cf120ec9/sphinx/builders/html/__init__.py#L258-L262 In any case, we can fix this by simply setting the line height in pydoctheme.css. 📚 Documentation preview 📚: https://python-docs-theme-previews--227.org.readthedocs.build/
Open Graph Description: While working on the copy button, I noticed the line height of the pre element differs for the light and dark theme. It is set to 120% for the light theme 125% for the dark theme, which is not a hu...
X Description: While working on the copy button, I noticed the line height of the pre element differs for the light and dark theme. It is set to 120% for the light theme 125% for the dark theme, which is not a hu...
Opengraph URL: https://github.com/python/python-docs-theme/pull/227
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:4aaf948d-7220-4ed6-74a7-c2e0ce875d3f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CB1E:E4115:778B56:A1BF77:69700D4D |
| html-safe-nonce | 19d12842f40578738b921e7b43d3cb513366f6374dd87a974201c72924f6fa16 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQjFFOkU0MTE1Ojc3OEI1NjpBMUJGNzc6Njk3MDBENEQiLCJ2aXNpdG9yX2lkIjoiMjIyNDI4NDAwNDM5MzE2MDAxMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | baf9b1db79074c44be90f56a50474acdf0e13aa45ca3e95d54528136758c1470 |
| hovercard-subject-tag | pull_request:2446948622 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/python-docs-theme/pull/227/files |
| twitter:image | https://avatars.githubusercontent.com/u/8739637?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/8739637?s=400&v=4 |
| og:image:alt | While working on the copy button, I noticed the line height of the pre element differs for the light and dark theme. It is set to 120% for the light theme 125% for the dark theme, which is not a hu... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 6e3493a220046ce21668e7217b5ac322bdc4edd2736ee04362e5462968204bd5 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/python-docs-theme git https://github.com/python/python-docs-theme.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 93341818 |
| octolytics-dimension-repository_nwo | python/python-docs-theme |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 93341818 |
| octolytics-dimension-repository_network_root_nwo | python/python-docs-theme |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9f627dfc82200bff3d2b49e4fb4b0a99594a9a9a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width