Title: Use consistent line-height for light & dark theme by tomasr8 · Pull Request #227 · python/python-docs-theme · GitHub
Open Graph Title: Use consistent line-height for light & dark theme by tomasr8 · Pull Request #227 · python/python-docs-theme
X Title: Use consistent line-height for light & dark theme by tomasr8 · Pull Request #227 · python/python-docs-theme
Description: While working on the copy button, I noticed the line height of the pre element differs for the light and dark theme. It is set to 120% for the light theme 125% for the dark theme, which is not a huge difference but it's better to be consistent. The reason for the discrepancy is the order in which the css is included in the . For the light theme, classic.css takes precedence: Whereas for the dark theme, it is pygments_dark.css which is the last stylesheet in the : This seems to be related to how sphinx inserts the css for pygments: https://github.com/sphinx-doc/sphinx/blob/a6d7ae16739bf92a032a7c4df0297db7cf120ec9/sphinx/builders/html/__init__.py#L258-L262 In any case, we can fix this by simply setting the line height in pydoctheme.css. 📚 Documentation preview 📚: https://python-docs-theme-previews--227.org.readthedocs.build/
Open Graph Description: While working on the copy button, I noticed the line height of the pre element differs for the light and dark theme. It is set to 120% for the light theme 125% for the dark theme, which is not a hu...
X Description: While working on the copy button, I noticed the line height of the pre element differs for the light and dark theme. It is set to 120% for the light theme 125% for the dark theme, which is not a hu...
Opengraph URL: https://github.com/python/python-docs-theme/pull/227
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:7e2a8b99-020d-a7cb-147e-02877fb3a984 |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | 9794:376227:C89693:1113FA9:696FF4BD |
| html-safe-nonce | 9956db5766d5fe87d343bfbff6d34cacdccd39f823bcc291230ad987146035ae |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Nzk0OjM3NjIyNzpDODk2OTM6MTExM0ZBOTo2OTZGRjRCRCIsInZpc2l0b3JfaWQiOiI5MTg1NjQ4MzE4NjYwNzM2MTg5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 159ede08cdf34622bf1cbac0e2aab942d9e7a185085464deeb3e5d902567d44a |
| hovercard-subject-tag | pull_request:2446948622 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/python-docs-theme/pull/227/checks |
| twitter:image | https://avatars.githubusercontent.com/u/8739637?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/8739637?s=400&v=4 |
| og:image:alt | While working on the copy button, I noticed the line height of the pre element differs for the light and dark theme. It is set to 120% for the light theme 125% for the dark theme, which is not a hu... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 61db99bbb6a7517db80567029869280bdefa9fa883092d6c2aa07ec4ea15f359 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/python-docs-theme git https://github.com/python/python-docs-theme.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 93341818 |
| octolytics-dimension-repository_nwo | python/python-docs-theme |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 93341818 |
| octolytics-dimension-repository_network_root_nwo | python/python-docs-theme |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 91ceb31fcdebd150222e05551caf4a28f9532341 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width