Title: Dark mode: fix contrast for C++ specific styling by hugovk · Pull Request #133 · python/python-docs-theme · GitHub
Open Graph Title: Dark mode: fix contrast for C++ specific styling by hugovk · Pull Request #133 · python/python-docs-theme
X Title: Dark mode: fix contrast for C++ specific styling by hugovk · Pull Request #133 · python/python-docs-theme
Description: Before Visit https://docs.python.org/3.12/c-api/arg.html#numbers Look at the C keywords such as unsigned char Dark mode: the dark blue text on dark background is very hard to read Check the contrast ratio in devtools, it's below the WCAG AA guidelines of 4.5: (Light mode is fine, ratio is 9.88, above the AAA ratio of 7.0.) After That is defined by Sphinx: https://github.com/sphinx-doc/sphinx/blob/d3c91f951255c6729a53e38c895ddc0af036b5b9/sphinx/themes/basic/static/basic.css_t#L547-L550 Copy that CSS to our dark mode file and use #5283ff as suggested by devtools, and the dark mode is improved, with no change to light mode: Preview https://python-docs-theme-previews--133.org.readthedocs.build/en/133/c-api/arg.html#numbers
Open Graph Description: Before Visit https://docs.python.org/3.12/c-api/arg.html#numbers Look at the C keywords such as unsigned char Dark mode: the dark blue text on dark background is very hard to read Check t...
X Description: Before Visit https://docs.python.org/3.12/c-api/arg.html#numbers Look at the C keywords such as unsigned char Dark mode: the dark blue text on dark background is very hard to read Check t...
Opengraph URL: https://github.com/python/python-docs-theme/pull/133
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:04f683fa-a253-68d5-e921-bea4e30e0205 |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | B846:43C7D:18693F7:20885A5:697812F3 |
| html-safe-nonce | a40d624f59ef581463ae14b098656c2e7103ce7a79ece0bc0f657330db75357e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCODQ2OjQzQzdEOjE4NjkzRjc6MjA4ODVBNTo2OTc4MTJGMyIsInZpc2l0b3JfaWQiOiIzODk1NjEyODMzMzM2Mzk4NTc5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 26d9dbc82532df6c11fd99129762f6adac8a89193869e9f1c263593006725667 |
| hovercard-subject-tag | pull_request:1424811690 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/python-docs-theme/pull/133/checks |
| twitter:image | https://avatars.githubusercontent.com/u/1324225?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1324225?s=400&v=4 |
| og:image:alt | Before Visit https://docs.python.org/3.12/c-api/arg.html#numbers Look at the C keywords such as unsigned char Dark mode: the dark blue text on dark background is very hard to read Check t... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | e71ed39771d00f42ce2fc9320895c8c608c164191e118eae487fc3bd0af6886d |
| turbo-cache-control | no-preview |
| go-import | github.com/python/python-docs-theme git https://github.com/python/python-docs-theme.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 93341818 |
| octolytics-dimension-repository_nwo | python/python-docs-theme |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 93341818 |
| octolytics-dimension-repository_network_root_nwo | python/python-docs-theme |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4919f24054c1e9bf76d7b543cb2ac018075b18ce |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width