Title: Dark mode: fix contrast for C++ specific styling by hugovk · Pull Request #133 · python/python-docs-theme · GitHub
Open Graph Title: Dark mode: fix contrast for C++ specific styling by hugovk · Pull Request #133 · python/python-docs-theme
X Title: Dark mode: fix contrast for C++ specific styling by hugovk · Pull Request #133 · python/python-docs-theme
Description: Before Visit https://docs.python.org/3.12/c-api/arg.html#numbers Look at the C keywords such as unsigned char Dark mode: the dark blue text on dark background is very hard to read Check the contrast ratio in devtools, it's below the WCAG AA guidelines of 4.5: (Light mode is fine, ratio is 9.88, above the AAA ratio of 7.0.) After That is defined by Sphinx: https://github.com/sphinx-doc/sphinx/blob/d3c91f951255c6729a53e38c895ddc0af036b5b9/sphinx/themes/basic/static/basic.css_t#L547-L550 Copy that CSS to our dark mode file and use #5283ff as suggested by devtools, and the dark mode is improved, with no change to light mode: Preview https://python-docs-theme-previews--133.org.readthedocs.build/en/133/c-api/arg.html#numbers
Open Graph Description: Before Visit https://docs.python.org/3.12/c-api/arg.html#numbers Look at the C keywords such as unsigned char Dark mode: the dark blue text on dark background is very hard to read Check t...
X Description: Before Visit https://docs.python.org/3.12/c-api/arg.html#numbers Look at the C keywords such as unsigned char Dark mode: the dark blue text on dark background is very hard to read Check t...
Opengraph URL: https://github.com/python/python-docs-theme/pull/133
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:8a13d93e-7eb6-ceb4-a3cf-57712ee1526b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B28A:333BB5:2BE59:3D8AC:69787D64 |
| html-safe-nonce | 54243c5b9ae25c686f6182a10f52deea2b5c813b36327a696e42467dcd6d5238 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMjhBOjMzM0JCNToyQkU1OTozRDhBQzo2OTc4N0Q2NCIsInZpc2l0b3JfaWQiOiIyNzU2MTQ3NjExNTkxODAyMjEyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 52472a0e9d3b71d9a83c9e81b66f2d580dbb0ac428f9564137456e6dc5d25fda |
| hovercard-subject-tag | pull_request:1424811690 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/python-docs-theme/pull/133/files |
| twitter:image | https://avatars.githubusercontent.com/u/1324225?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1324225?s=400&v=4 |
| og:image:alt | Before Visit https://docs.python.org/3.12/c-api/arg.html#numbers Look at the C keywords such as unsigned char Dark mode: the dark blue text on dark background is very hard to read Check t... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 2981c597c945c1d90ac6fa355ce7929b2f413dfe7872ca5c435ee53a24a1de50 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/python-docs-theme git https://github.com/python/python-docs-theme.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 93341818 |
| octolytics-dimension-repository_nwo | python/python-docs-theme |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 93341818 |
| octolytics-dimension-repository_network_root_nwo | python/python-docs-theme |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 520b65a872113b919c1bbdb03834a50af15859fd |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width