Title: Use an ephemeral port in bm_asyncio_websockets by sendaoYan · Pull Request #517 · python/pyperformance · GitHub
Open Graph Title: Use an ephemeral port in bm_asyncio_websockets by sendaoYan · Pull Request #517 · python/pyperformance
X Title: Use an ephemeral port in bm_asyncio_websockets by sendaoYan · Pull Request #517 · python/pyperformance
Description: Use an ephemeral port in bm_asyncio_websockets instead of the fixed port 8001 Fixes #516 Summary bm_asyncio_websockets/run_benchmark.py hard-codes port 8001 for both the server and the client: async with websockets.server.serve(handler, "", 8001): async with websockets.client.connect("ws://localhost:8001") as ws: The default suite runs this benchmark only once, so the problem is not visible in a normal sequential run. But it prevents two instances from running at the same time (CI sharding, a custom parallel runner, or simply running the benchmark twice), and it also fails if an unrelated process already owns port 8001: OSError: [Errno 98] error while attempting to bind on address ('::', 8001, 0, 0): [errno 98] address already in use Change Bind port 0 (let the kernel pick a free ephemeral port), read the assigned port back from the listening socket, and use it for the client connection: - async with websockets.server.serve(handler, "", 8001): - async with websockets.client.connect("ws://localhost:8001") as ws: + async with websockets.server.serve(handler, "127.0.0.1", 0) as server: + port = server.sockets[0].getsockname()[1] + async with websockets.client.connect(f"ws://127.0.0.1:{port}") as ws: await asyncio.gather(*[send(ws) for _ in range(100)]) Why bind 127.0.0.1 instead of keeping the empty host? Simply replacing 8001 with 0 while keeping host="" is not enough with websockets==11.0.3. For an empty host it creates two sockets (AF_INET and AF_INET6), and with port 0 they receive different ephemeral ports — for example 39103 and 45903 in my testing. sockets[0] is then order-dependent and the client can connect to the wrong address family/port. Binding 127.0.0.1 produces a single AF_INET socket and keeps the benchmark server on loopback, which is all this benchmark needs. Testing Tested on Linux x86_64 with CPython 3.16.0a2+dev, pyperformance 1.14.0, and websockets==11.0.3 (the version pinned by the benchmark). The change is not version-specific. Two instances concurrently — the case that used to fail: python -m pyperformance run -b asyncio_websockets -f -o /tmp/ws1.json & python -m pyperformance run -b asyncio_websockets -f -o /tmp/ws2.json & wait Result: both complete successfully, no EADDRINUSE, and no listening socket is left behind on port 8001: asyncio_websockets: Mean +- std dev: 1.03 sec +- 0.01 sec asyncio_websockets: Mean +- std dev: 1.03 sec +- 0.02 sec Standalone runs still work and produce the same kind of result as before. The workload, transferred data size, and benchmark measurement are unchanged; only the port selection changes.
Open Graph Description: Use an ephemeral port in bm_asyncio_websockets instead of the fixed port 8001 Fixes #516 Summary bm_asyncio_websockets/run_benchmark.py hard-codes port 8001 for both the server and the client: asyn...
X Description: Use an ephemeral port in bm_asyncio_websockets instead of the fixed port 8001 Fixes #516 Summary bm_asyncio_websockets/run_benchmark.py hard-codes port 8001 for both the server and the client: asyn...
Opengraph URL: https://github.com/python/pyperformance/pull/517
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:8e836e1a-3c17-7f7f-a90d-f29f5814e0ee |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D18C:B1B84:2C47DF7:385B11B:6B01EC71 |
| html-safe-nonce | 73ee379fcd8424f8be7ffca32550b366a07a1291a33d63de9dca7cc102143b66 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMThDOkIxQjg0OjJDNDdERjc6Mzg1QjExQjo2QjAxRUM3MSIsInZpc2l0b3JfaWQiOiIzMTg2OTYwNzUyOTg4Nzc3NTg1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | d2651140efd7af4d77bb61356b630f03ab6398140fe6b7bca2bcab57c3dba37c |
| hovercard-subject-tag | pull_request:5388139072 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/pyperformance/pull/517/files |
| twitter:image | https://avatars.githubusercontent.com/u/24123821?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/24123821?s=400&v=4 |
| og:image:alt | Use an ephemeral port in bm_asyncio_websockets instead of the fixed port 8001 Fixes #516 Summary bm_asyncio_websockets/run_benchmark.py hard-codes port 8001 for both the server and the client: asyn... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/pyperformance git https://github.com/python/pyperformance.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 65949828 |
| octolytics-dimension-repository_nwo | python/pyperformance |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 65949828 |
| octolytics-dimension-repository_network_root_nwo | python/pyperformance |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width