Title: Use an ephemeral port in bm_asyncio_tcp by sendaoYan · Pull Request #515 · python/pyperformance · GitHub
Open Graph Title: Use an ephemeral port in bm_asyncio_tcp by sendaoYan · Pull Request #515 · python/pyperformance
X Title: Use an ephemeral port in bm_asyncio_tcp by sendaoYan · Pull Request #515 · python/pyperformance
Description: Use an ephemeral port in bm_asyncio_tcp instead of the fixed port 8882 Fixes #514 Summary asyncio_tcp and asyncio_tcp_ssl both run pyperformance/data-files/benchmarks/bm_asyncio_tcp/run_benchmark.py, which hard-codes 127.0.0.1:8882. Because bm_asyncio_tcp_ssl.toml selects the SSL variant with extra_opts = ["--ssl"], the two benchmarks use the same server script and the same port, so one of them dies with EADDRINUSE when they run concurrently: OSError: [Errno 98] error while attempting to bind on address ('127.0.0.1', 8882): [errno 98] address already in use This also makes the benchmark fail whenever an unrelated process is listening on port 8882. Change Bind port 0 (let the kernel pick a free ephemeral port) and read the assigned port back from the listening socket. The client then connects to that port. - server = await asyncio.start_server(handle_echo, '127.0.0.1', 8882, ssl=server_context) + # Bind to an ephemeral port (port 0) and read back the port the kernel + # assigned. This keeps concurrent runs (e.g. asyncio_tcp and + # asyncio_tcp_ssl running in parallel) from colliding on a fixed port. + server = await asyncio.start_server(handle_echo, '127.0.0.1', 0, ssl=server_context) + host, port = server.sockets[0].getsockname()[:2] async with server: asyncio.create_task(server.start_serving()) - reader, writer = await asyncio.open_connection('127.0.0.1', 8882, ssl=client_context) + reader, writer = await asyncio.open_connection(host, port, ssl=client_context) The change covers both the plain and the SSL code path because both are handled by the same main() function. Why not probe for a free port first? A common alternative is to create a temporary socket, bind it to port 0, read the port, close it, and then bind the real server to that port. That has a TOCTOU race: another process can take the port between the close and the second bind. Binding port 0 on the real server socket avoids the race entirely — the listening socket owns the port, and getsockname() reports what the kernel assigned. bm_tornado_http already uses the same idea (bind_sockets(0, ...) plus getsockname()). Testing Tested on Linux x86_64 with CPython 3.16.0a2+dev and pyperformance 1.14.0. The change is not version-specific. Concurrent run of the two variants (the case that used to fail): python -m pyperformance run -b asyncio_tcp -f -o /tmp/asyncio_tcp.json & python -m pyperformance run -b asyncio_tcp_ssl -f -o /tmp/asyncio_tcp_ssl.json & wait Result: both complete successfully, no EADDRINUSE, and no listening socket is left behind on 8882 after the run: asyncio_tcp: Mean +- std dev: 700 ms +- 39 ms asyncio_tcp_ssl: Mean +- std dev: 2.15 sec +- 0.06 sec Standalone runs still work: python -m pyperformance run -b asyncio_tcp_ssl -f -o /tmp/asyncio_tcp_ssl.json # asyncio_tcp_ssl: Mean +- std dev: 2.21 sec +- 0.07 sec Whole suite in parallel: I ran all 100 default sub-items concurrently, one pyperformance run process per benchmark, each pinned to one CPU core. 99 passed; the only failure was dask, which is unrelated to this change (cloudpickle 3.1.2 looks up the removed DELETE_GLOBAL opcode on Python 3.16). No port-conflict errors appeared in any log, and ports 8001/8882 were free after the run. The workload, transferred data size, and benchmark measurement are unchanged; only the port selection changes.
Open Graph Description: Use an ephemeral port in bm_asyncio_tcp instead of the fixed port 8882 Fixes #514 Summary asyncio_tcp and asyncio_tcp_ssl both run pyperformance/data-files/benchmarks/bm_asyncio_tcp/run_benchmark.p...
X Description: Use an ephemeral port in bm_asyncio_tcp instead of the fixed port 8882 Fixes #514 Summary asyncio_tcp and asyncio_tcp_ssl both run pyperformance/data-files/benchmarks/bm_asyncio_tcp/run_benchmark.p...
Opengraph URL: https://github.com/python/pyperformance/pull/515
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:a5882ab5-5426-6265-417a-207d1161e228 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8370:154D88:2AA1E44:368ABDA:6B01EC57 |
| html-safe-nonce | de244bf504266205a51aedc5782a0266d13a3db7b4ca21cc8f9152dcf7c26161 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MzcwOjE1NEQ4ODoyQUExRTQ0OjM2OEFCREE6NkIwMUVDNTciLCJ2aXNpdG9yX2lkIjoiNzk3NzY0NzExNDA5NDI0MjkwMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 8978532dc18d8e8266059903c85f08648f10ed745438086cdc5d2e275afb4faf |
| hovercard-subject-tag | pull_request:5377421749 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/pyperformance/pull/515/files |
| twitter:image | https://avatars.githubusercontent.com/u/24123821?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/24123821?s=400&v=4 |
| og:image:alt | Use an ephemeral port in bm_asyncio_tcp instead of the fixed port 8882 Fixes #514 Summary asyncio_tcp and asyncio_tcp_ssl both run pyperformance/data-files/benchmarks/bm_asyncio_tcp/run_benchmark.p... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/pyperformance git https://github.com/python/pyperformance.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 65949828 |
| octolytics-dimension-repository_nwo | python/pyperformance |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 65949828 |
| octolytics-dimension-repository_network_root_nwo | python/pyperformance |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width